AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[build] Use shared libraries by default for debug builds

Browse Source 
BUG=chromium:648864

Review-Url: https://codereview.chromium.org/2373743002
Cr-Commit-Position: refs/heads/master@{#39754}
This commit is contained in:
machenbach 2016-09-27 02:46:20 -07:00 committed by Commit bot
parent 245e5b323c
commit f72b4a084a
3 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
infra/mb/mb_config.pyl
View File

@ -259,9 +259,7 @@
# GN debug configs for arm. # GN debug configs for arm.
'gn_debug_arm': [ 'gn_debug_arm': [
'gn', 'debug', 'arm', 'gn', 'debug_bot', 'arm', 'crosscompile', 'hard_float', 'swarming'],
'shared', 'goma', 'v8_enable_slow_dchecks', 'v8_optimized_debug',
'crosscompile', 'hard_float', 'swarming'],
# GN release configs for arm. # GN release configs for arm.
'gn_release_arm': [ 'gn_release_arm': [
@ -457,7 +455,7 @@
'debug_bot': { 'debug_bot': {
'mixins': [ 'mixins': [
'debug', 'static', 'goma', 'v8_enable_slow_dchecks', 'debug', 'shared', 'goma', 'v8_enable_slow_dchecks',
'v8_optimized_debug'], 'v8_optimized_debug'],
}, },

5
src/checks.h
View File

@ -7,6 +7,7 @@
#include "include/v8.h" #include "include/v8.h"
#include "src/base/logging.h" #include "src/base/logging.h"
#include "src/globals.h"
namespace v8 { namespace v8 {
@ -17,10 +18,10 @@ namespace internal {
#ifdef ENABLE_SLOW_DCHECKS #ifdef ENABLE_SLOW_DCHECKS
#define SLOW_DCHECK(condition) \ #define SLOW_DCHECK(condition) \
CHECK(!v8::internal::FLAG_enable_slow_asserts || (condition)) CHECK(!v8::internal::FLAG_enable_slow_asserts || (condition))
extern bool FLAG_enable_slow_asserts; V8_EXPORT_PRIVATE extern bool FLAG_enable_slow_asserts;
#else #else
#define SLOW_DCHECK(condition) ((void) 0) #define SLOW_DCHECK(condition) ((void) 0)
const bool FLAG_enable_slow_asserts = false; static const bool FLAG_enable_slow_asserts = false;
#endif #endif
} // namespace internal } // namespace internal

6
src/handles.h
View File

@ -63,10 +63,12 @@ class HandleBase {
enum DereferenceCheckMode { INCLUDE_DEFERRED_CHECK, NO_DEFERRED_CHECK }; enum DereferenceCheckMode { INCLUDE_DEFERRED_CHECK, NO_DEFERRED_CHECK };
#ifdef DEBUG #ifdef DEBUG
bool IsDereferenceAllowed(DereferenceCheckMode mode) const; bool V8_EXPORT_PRIVATE IsDereferenceAllowed(DereferenceCheckMode mode) const;
#else #else
V8_INLINE V8_INLINE
bool IsDereferenceAllowed(DereferenceCheckMode mode) const { return true; } bool V8_EXPORT_PRIVATE IsDereferenceAllowed(DereferenceCheckMode mode) const {
return true;
}
#endif // DEBUG #endif // DEBUG
Object** location_; Object** location_;