From f810ccc86759f204f8f149ba4b40f6166d5bae2b Mon Sep 17 00:00:00 2001 From: "daniel.bevenius" Date: Wed, 13 Jul 2016 23:32:14 -0700 Subject: [PATCH] Updating the code example in FunctionTemplate class documentation Currently the code example in the FunctionTemplate class documentation is out of date. This commit updates the examples so they compile and run without error. BUG= Review-Url: https://codereview.chromium.org/2127523003 Cr-Commit-Position: refs/heads/master@{#37741} --- AUTHORS | 1 + include/v8.h | 18 +++++++++++------- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/AUTHORS b/AUTHORS index 56f2dfdd0d..28873901a9 100644 --- a/AUTHORS +++ b/AUTHORS @@ -51,6 +51,7 @@ Craig Schlenter Chris Nardi Christopher A. Taylor Daniel Andersson +Daniel Bevenius Daniel James Deon Dior Douglas Crosher diff --git a/include/v8.h b/include/v8.h index b4deb77c55..bbe65221f5 100644 --- a/include/v8.h +++ b/include/v8.h @@ -4418,17 +4418,21 @@ typedef bool (*AccessCheckCallback)(Local accessing_context, * The following example shows how to use a FunctionTemplate: * * \code - * v8::Local t = v8::FunctionTemplate::New(); - * t->Set("func_property", v8::Number::New(1)); + * v8::Local t = v8::FunctionTemplate::New(isolate); + * t->Set(isolate, "func_property", v8::Number::New(isolate, 1)); * * v8::Local proto_t = t->PrototypeTemplate(); - * proto_t->Set("proto_method", v8::FunctionTemplate::New(InvokeCallback)); - * proto_t->Set("proto_const", v8::Number::New(2)); + * proto_t->Set(isolate, + * "proto_method", + * v8::FunctionTemplate::New(isolate, InvokeCallback)); + * proto_t->Set(isolate, "proto_const", v8::Number::New(isolate, 2)); * * v8::Local instance_t = t->InstanceTemplate(); - * instance_t->SetAccessor("instance_accessor", InstanceAccessorCallback); - * instance_t->SetNamedPropertyHandler(PropertyHandlerCallback, ...); - * instance_t->Set("instance_property", Number::New(3)); + * instance_t->SetAccessor(String::NewFromUtf8(isolate, "instance_accessor"), + * InstanceAccessorCallback); + * instance_t->SetNamedPropertyHandler(PropertyHandlerCallback); + * instance_t->Set(String::NewFromUtf8(isolate, "instance_property"), + * Number::New(isolate, 3)); * * v8::Local function = t->GetFunction(); * v8::Local instance = function->NewInstance();