AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[turbofan] Remove out-of-line defn of constexpr vars"

Browse Source 
This reverts commit 05da670871.

Reason for revert: Guess I was wrong: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Clusterfuzz%20Linux64%20ASAN%20no%20inline%20-%20release%20builder/25729/overview

Original change's description:
> [turbofan] Remove out-of-line defn of constexpr vars
>
> It's deprecated in C++17 and not needed (it was needed for
> static const, but not for constexpr)
>
> Bug: chromium:1274247
> Change-Id: If92d7b6300493cb186ff2ade8f6b6a4820d5a264
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306429
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Auto-Submit: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#78149}

Bug: chromium:1274247
Change-Id: I26f8377b331895363fec5329a08261ebec3696ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306431
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Owners-Override: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#78152}
This commit is contained in:
Leszek Swirski 2021-11-30 11:36:57 +00:00 committed by V8 LUCI CQ
parent dc7425b6aa
commit f83320fde0
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/compiler/js-heap-broker.cc
View File

@ -30,6 +30,11 @@ namespace compiler {
#define TRACE(broker, x) TRACE_BROKER(broker, x)
// These definitions are here in order to please the linker, which in debug mode
// sometimes requires static constants to be defined in .cc files.
const uint32_t JSHeapBroker::kMinimalRefsBucketCount;
const uint32_t JSHeapBroker::kInitialRefsBucketCount;
void JSHeapBroker::IncrementTracingIndentation() { ++trace_indentation_; }
void JSHeapBroker::DecrementTracingIndentation() { --trace_indentation_; }