Move remaining files in src/

TBR=mvstanton@chromium.org,neis@chromium.org,ahaas@chromium.org

Bug: v8:9247
Change-Id: I5433c863a54f3412d73df0d38aba3fdbcfac7ebe
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627973
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61830}

BUILD.gn

@@ -1698,7 +1698,7 @@ v8_header_set("v8_shared_internal_headers") {
   configs = [ ":internal_config" ]
 
   sources = [
-    "src/globals.h",
+    "src/common/globals.h",
   ]
 
   deps = [
@@ -1922,6 +1922,8 @@ v8_compiler_sources = [
   "src/compiler/types.h",
   "src/compiler/value-numbering-reducer.cc",
   "src/compiler/value-numbering-reducer.h",
+  "src/compiler/vector-slot-pair.cc",
+  "src/compiler/vector-slot-pair.h",
   "src/compiler/verifier.cc",
   "src/compiler/verifier.h",
   "src/compiler/wasm-compiler.cc",
@@ -2003,8 +2005,6 @@ v8_source_set("v8_base_without_compiler") {
     "include/v8-wasm-trap-handler-posix.h",
     "include/v8.h",
     "include/v8config.h",
-    "src/allocation-site-scopes-inl.h",
-    "src/allocation-site-scopes.h",
     "src/api/api-arguments-inl.h",
     "src/api/api-arguments.cc",
     "src/api/api-arguments.h",
@@ -2021,8 +2021,6 @@ v8_source_set("v8_base_without_compiler") {
     "src/asmjs/asm-scanner.h",
     "src/asmjs/asm-types.cc",
     "src/asmjs/asm-types.h",
-    "src/assert-scope.cc",
-    "src/assert-scope.h",
     "src/ast/ast-function-literal-id-reindexer.cc",
     "src/ast/ast-function-literal-id-reindexer.h",
     "src/ast/ast-source-ranges.h",
@@ -2082,9 +2080,6 @@ v8_source_set("v8_base_without_compiler") {
     "src/builtins/builtins.h",
     "src/builtins/constants-table-builder.cc",
     "src/builtins/constants-table-builder.h",
-    "src/cancelable-task.cc",
-    "src/cancelable-task.h",
-    "src/checks.h",
     "src/codegen/assembler-arch.h",
     "src/codegen/assembler-inl.h",
     "src/codegen/assembler.cc",
@@ -2108,6 +2103,10 @@ v8_source_set("v8_base_without_compiler") {
     "src/codegen/constant-pool.h",
     "src/codegen/constants-arch.h",
     "src/codegen/cpu-features.h",
+    "src/codegen/external-reference-table.cc",
+    "src/codegen/external-reference-table.h",
+    "src/codegen/external-reference.cc",
+    "src/codegen/external-reference.h",
     "src/codegen/flush-instruction-cache.cc",
     "src/codegen/flush-instruction-cache.h",
     "src/codegen/handler-table.cc",
@@ -2141,8 +2140,12 @@ v8_source_set("v8_base_without_compiler") {
     "src/codegen/turbo-assembler.h",
     "src/codegen/unoptimized-compilation-info.cc",
     "src/codegen/unoptimized-compilation-info.h",
-    "src/compilation-statistics.cc",
+    "src/common/assert-scope.cc",
-    "src/compilation-statistics.h",
+    "src/common/assert-scope.h",
+    "src/common/checks.h",
+    "src/common/ptr-compr-inl.h",
+    "src/common/ptr-compr.h",
+    "src/common/v8memory.h",
     "src/compiler-dispatcher/compiler-dispatcher.cc",
     "src/compiler-dispatcher/compiler-dispatcher.h",
     "src/compiler-dispatcher/optimizing-compile-dispatcher.cc",
@@ -2181,6 +2184,8 @@ v8_source_set("v8_base_without_compiler") {
     "src/diagnostics/basic-block-profiler.cc",
     "src/diagnostics/basic-block-profiler.h",
     "src/diagnostics/code-tracer.h",
+    "src/diagnostics/compilation-statistics.cc",
+    "src/diagnostics/compilation-statistics.h",
     "src/diagnostics/disasm.h",
     "src/diagnostics/disassembler.cc",
     "src/diagnostics/disassembler.h",
@@ -2222,6 +2227,8 @@ v8_source_set("v8_base_without_compiler") {
     "src/execution/thread-id.h",
     "src/execution/thread-local-top.cc",
     "src/execution/thread-local-top.h",
+    "src/execution/v8threads.cc",
+    "src/execution/v8threads.h",
     "src/execution/vm-state-inl.h",
     "src/execution/vm-state.h",
     "src/extensions/externalize-string-extension.cc",
@@ -2236,13 +2243,9 @@ v8_source_set("v8_base_without_compiler") {
     "src/extensions/statistics-extension.h",
     "src/extensions/trigger-failure-extension.cc",
     "src/extensions/trigger-failure-extension.h",
-    "src/external-reference-table.cc",
+    "src/flags/flag-definitions.h",
-    "src/external-reference-table.h",
+    "src/flags/flags.cc",
-    "src/external-reference.cc",
+    "src/flags/flags.h",
-    "src/external-reference.h",
-    "src/flag-definitions.h",
-    "src/flags.cc",
-    "src/flags.h",
     "src/handles/global-handles.cc",
     "src/handles/global-handles.h",
     "src/handles/handles-inl.h",
@@ -2250,8 +2253,6 @@ v8_source_set("v8_base_without_compiler") {
     "src/handles/handles.h",
     "src/handles/maybe-handles-inl.h",
     "src/handles/maybe-handles.h",
-    "src/hash-seed-inl.h",
-    "src/heap-symbols.h",
     "src/heap/array-buffer-collector.cc",
     "src/heap/array-buffer-collector.h",
     "src/heap/array-buffer-tracker-inl.h",
@@ -2341,6 +2342,7 @@ v8_source_set("v8_base_without_compiler") {
     "src/ic/stub-cache.h",
     "src/init/bootstrapper.cc",
     "src/init/bootstrapper.h",
+    "src/init/heap-symbols.h",
     "src/init/icu_util.cc",
     "src/init/icu_util.h",
     "src/init/isolate-allocator.cc",
@@ -2348,6 +2350,8 @@ v8_source_set("v8_base_without_compiler") {
     "src/init/setup-isolate.h",
     "src/init/startup-data-util.cc",
     "src/init/startup-data-util.h",
+    "src/init/v8.cc",
+    "src/init/v8.h",
     "src/interpreter/block-coverage-builder.h",
     "src/interpreter/bytecode-array-accessor.cc",
     "src/interpreter/bytecode-array-accessor.h",
@@ -2425,13 +2429,14 @@ v8_source_set("v8_base_without_compiler") {
     "src/numbers/fast-dtoa.h",
     "src/numbers/fixed-dtoa.cc",
     "src/numbers/fixed-dtoa.h",
+    "src/numbers/hash-seed-inl.h",
     "src/numbers/math-random.cc",
     "src/numbers/math-random.h",
     "src/numbers/strtod.cc",
     "src/numbers/strtod.h",
-    "src/objects-body-descriptors-inl.h",
-    "src/objects-body-descriptors.h",
     "src/objects/allocation-site-inl.h",
+    "src/objects/allocation-site-scopes-inl.h",
+    "src/objects/allocation-site-scopes.h",
     "src/objects/allocation-site.h",
     "src/objects/api-callbacks-inl.h",
     "src/objects/api-callbacks.h",
@@ -2579,6 +2584,8 @@ v8_source_set("v8_base_without_compiler") {
     "src/objects/object-list-macros.h",
     "src/objects/object-macros-undef.h",
     "src/objects/object-macros.h",
+    "src/objects/objects-body-descriptors-inl.h",
+    "src/objects/objects-body-descriptors.h",
     "src/objects/objects-inl.h",
     "src/objects/objects.cc",
     "src/objects/objects.h",
@@ -2638,6 +2645,12 @@ v8_source_set("v8_base_without_compiler") {
     "src/objects/transitions-inl.h",
     "src/objects/transitions.cc",
     "src/objects/transitions.h",
+    "src/objects/type-hints.cc",
+    "src/objects/type-hints.h",
+    "src/objects/value-serializer.cc",
+    "src/objects/value-serializer.h",
+    "src/objects/visitors.cc",
+    "src/objects/visitors.h",
     "src/parsing/expression-scope-reparenter.cc",
     "src/parsing/expression-scope-reparenter.h",
     "src/parsing/expression-scope.h",
@@ -2652,6 +2665,8 @@ v8_source_set("v8_base_without_compiler") {
     "src/parsing/parser.h",
     "src/parsing/parsing.cc",
     "src/parsing/parsing.h",
+    "src/parsing/pending-compilation-error-handler.cc",
+    "src/parsing/pending-compilation-error-handler.h",
     "src/parsing/preparse-data-impl.h",
     "src/parsing/preparse-data.cc",
     "src/parsing/preparse-data.h",
@@ -2666,8 +2681,6 @@ v8_source_set("v8_base_without_compiler") {
     "src/parsing/scanner.h",
     "src/parsing/token.cc",
     "src/parsing/token.h",
-    "src/pending-compilation-error-handler.cc",
-    "src/pending-compilation-error-handler.h",
     "src/profiler/allocation-tracker.cc",
     "src/profiler/allocation-tracker.h",
     "src/profiler/circular-queue-inl.h",
@@ -2693,8 +2706,6 @@ v8_source_set("v8_base_without_compiler") {
     "src/profiler/tick-sample.h",
     "src/profiler/tracing-cpu-profiler.cc",
     "src/profiler/tracing-cpu-profiler.h",
-    "src/ptr-compr-inl.h",
-    "src/ptr-compr.h",
     "src/regexp/bytecodes-irregexp.h",
     "src/regexp/interpreter-irregexp.cc",
     "src/regexp/interpreter-irregexp.h",
@@ -2718,9 +2729,9 @@ v8_source_set("v8_base_without_compiler") {
     "src/regexp/regexp-stack.h",
     "src/regexp/regexp-utils.cc",
     "src/regexp/regexp-utils.h",
-    "src/roots-inl.h",
+    "src/roots/roots-inl.h",
-    "src/roots.cc",
+    "src/roots/roots.cc",
-    "src/roots.h",
+    "src/roots/roots.h",
     "src/runtime/runtime-array.cc",
     "src/runtime/runtime-atomics.cc",
     "src/runtime/runtime-bigint.cc",
@@ -2815,8 +2826,10 @@ v8_source_set("v8_base_without_compiler") {
     "src/strings/unicode.h",
     "src/strings/uri.cc",
     "src/strings/uri.h",
-    "src/task-utils.cc",
+    "src/tasks/cancelable-task.cc",
-    "src/task-utils.h",
+    "src/tasks/cancelable-task.h",
+    "src/tasks/task-utils.cc",
+    "src/tasks/task-utils.h",
     "src/third_party/siphash/halfsiphash.cc",
     "src/third_party/siphash/halfsiphash.h",
     "src/third_party/utf8-decoder/utf8-decoder.h",
@@ -2831,8 +2844,6 @@ v8_source_set("v8_base_without_compiler") {
     "src/trap-handler/handler-shared.cc",
     "src/trap-handler/trap-handler-internal.h",
     "src/trap-handler/trap-handler.h",
-    "src/type-hints.cc",
-    "src/type-hints.h",
     "src/utils/address-map.cc",
     "src/utils/address-map.h",
     "src/utils/allocation.cc",
@@ -2859,17 +2870,6 @@ v8_source_set("v8_base_without_compiler") {
     "src/utils/vector.h",
     "src/utils/version.cc",
     "src/utils/version.h",
-    "src/v8.cc",
-    "src/v8.h",
-    "src/v8memory.h",
-    "src/v8threads.cc",
-    "src/v8threads.h",
-    "src/value-serializer.cc",
-    "src/value-serializer.h",
-    "src/vector-slot-pair.cc",
-    "src/vector-slot-pair.h",
-    "src/visitors.cc",
-    "src/visitors.h",
     "src/wasm/baseline/liftoff-assembler-defs.h",
     "src/wasm/baseline/liftoff-assembler.cc",
     "src/wasm/baseline/liftoff-assembler.h",
@@ -3986,7 +3986,7 @@ group("v8_fuzzers") {
 if (is_component_build) {
   v8_component("v8") {
     sources = [
-      "src/v8dll-main.cc",
+      "src/utils/v8dll-main.cc",
     ]
 
     public_deps = [
@@ -4003,7 +4003,7 @@ if (is_component_build) {
     testonly = true
 
     sources = [
-      "src/v8dll-main.cc",
+      "src/utils/v8dll-main.cc",
     ]
 
     public_deps = [

WATCHLISTS

@@ -50,7 +50,7 @@
                   '|test/unittests/interpreter/',
     },
     'feature_shipping_status': {
-      'filepath': 'src/flag-definitions.h',
+      'filepath': 'src/flags/flag-definitions.h',
     },
     'gc_changes': {
       'filepath': 'src/heap/',

src/api/api-arguments.h

@@ -9,7 +9,7 @@
 #include "src/debug/debug.h"
 #include "src/execution/isolate.h"
 #include "src/objects/slots.h"
-#include "src/visitors.h"
+#include "src/objects/visitors.h"
 
 namespace v8 {
 namespace internal {

src/api/api.cc

@@ -15,7 +15,6 @@
 #include "include/v8-testing.h"
 #include "include/v8-util.h"
 #include "src/api/api-natives.h"
-#include "src/assert-scope.h"
 #include "src/base/functional.h"
 #include "src/base/logging.h"
 #include "src/base/platform/platform.h"
@@ -26,6 +25,8 @@
 #include "src/builtins/builtins-utils.h"
 #include "src/codegen/compiler.h"
 #include "src/codegen/cpu-features.h"
+#include "src/common/assert-scope.h"
+#include "src/common/globals.h"
 #include "src/compiler-dispatcher/compiler-dispatcher.h"
 #include "src/date/date.h"
 #include "src/debug/debug-coverage.h"
@@ -42,14 +43,15 @@
 #include "src/execution/microtask-queue.h"
 #include "src/execution/runtime-profiler.h"
 #include "src/execution/simulator.h"
+#include "src/execution/v8threads.h"
 #include "src/execution/vm-state-inl.h"
-#include "src/globals.h"
 #include "src/handles/global-handles.h"
 #include "src/heap/embedder-tracing.h"
 #include "src/heap/heap-inl.h"
 #include "src/init/bootstrapper.h"
 #include "src/init/icu_util.h"
 #include "src/init/startup-data-util.h"
+#include "src/init/v8.h"
 #include "src/json/json-parser.h"
 #include "src/json/json-stringifier.h"
 #include "src/logging/counters.h"
@@ -78,10 +80,11 @@
 #include "src/objects/smi.h"
 #include "src/objects/stack-frame-info-inl.h"
 #include "src/objects/templates.h"
+#include "src/objects/value-serializer.h"
 #include "src/parsing/parse-info.h"
 #include "src/parsing/parser.h"
+#include "src/parsing/pending-compilation-error-handler.h"
 #include "src/parsing/scanner-character-streams.h"
-#include "src/pending-compilation-error-handler.h"
 #include "src/profiler/cpu-profiler.h"
 #include "src/profiler/heap-profiler.h"
 #include "src/profiler/heap-snapshot-generator-inl.h"
@@ -101,9 +104,6 @@
 #include "src/trap-handler/trap-handler.h"
 #include "src/utils/detachable-vector.h"
 #include "src/utils/version.h"
-#include "src/v8.h"
-#include "src/v8threads.h"
-#include "src/value-serializer.h"
 #include "src/wasm/streaming-decoder.h"
 #include "src/wasm/wasm-engine.h"
 #include "src/wasm/wasm-objects-inl.h"

src/arm/constants-arm.h

@@ -9,7 +9,7 @@
 
 #include "src/base/logging.h"
 #include "src/base/macros.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/utils/boxed-float.h"
 #include "src/utils/utils.h"
 

src/arm/macro-assembler-arm.cc

@@ -12,11 +12,11 @@
 #include "src/codegen/assembler-inl.h"
 #include "src/codegen/callable.h"
 #include "src/codegen/code-factory.h"
+#include "src/codegen/external-reference-table.h"
 #include "src/codegen/macro-assembler.h"
 #include "src/codegen/register-configuration.h"
 #include "src/debug/debug.h"
 #include "src/execution/frames-inl.h"
-#include "src/external-reference-table.h"
 #include "src/heap/heap-inl.h"  // For MemoryChunk.
 #include "src/init/bootstrapper.h"
 #include "src/logging/counters.h"

src/arm/macro-assembler-arm.h

@@ -11,7 +11,7 @@
 
 #include "src/arm/assembler-arm.h"
 #include "src/codegen/bailout-reason.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/objects/contexts.h"
 
 namespace v8 {

src/arm/simulator-arm.h

@@ -13,7 +13,7 @@
 #define V8_ARM_SIMULATOR_ARM_H_
 
 // globals.h defines USE_SIMULATOR.
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 #if defined(USE_SIMULATOR)
 // Running with a simulator.

src/arm64/assembler-arm64.h

@@ -16,7 +16,7 @@
 #include "src/base/optional.h"
 #include "src/codegen/assembler.h"
 #include "src/codegen/constant-pool.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/utils/utils.h"
 
 // Windows arm64 SDK defines mvn to NEON intrinsic neon_not which will not

src/arm64/constants-arm64.h

@@ -6,7 +6,7 @@
 #define V8_ARM64_CONSTANTS_ARM64_H_
 
 #include "src/base/macros.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 // Assert that this is an LP64 system, or LLP64 on Windows.
 STATIC_ASSERT(sizeof(int) == sizeof(int32_t));

src/arm64/decoder-arm64-inl.h

@@ -6,7 +6,7 @@
 #define V8_ARM64_DECODER_ARM64_INL_H_
 
 #include "src/arm64/decoder-arm64.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/utils/utils.h"
 
 namespace v8 {

src/arm64/decoder-arm64.cc

@@ -5,7 +5,7 @@
 #if V8_TARGET_ARCH_ARM64
 
 #include "src/arm64/decoder-arm64.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/utils/utils.h"
 
 namespace v8 {

src/arm64/decoder-arm64.h

@@ -8,7 +8,7 @@
 #include <list>
 
 #include "src/arm64/instructions-arm64.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 namespace v8 {
 namespace internal {

src/arm64/disasm-arm64.h

@@ -8,7 +8,7 @@
 #include "src/arm64/assembler-arm64.h"
 #include "src/arm64/decoder-arm64.h"
 #include "src/arm64/instructions-arm64.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/utils/utils.h"
 
 namespace v8 {

src/arm64/frame-constants-arm64.h

@@ -6,8 +6,8 @@
 #define V8_ARM64_FRAME_CONSTANTS_ARM64_H_
 
 #include "src/base/macros.h"
+#include "src/common/globals.h"
 #include "src/execution/frame-constants.h"
-#include "src/globals.h"
 
 namespace v8 {
 namespace internal {

src/arm64/instructions-arm64.h

@@ -8,7 +8,7 @@
 #include "src/arm64/constants-arm64.h"
 #include "src/arm64/register-arm64.h"
 #include "src/arm64/utils-arm64.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/utils/utils.h"
 
 namespace v8 {

src/arm64/instrument-arm64.h

@@ -5,7 +5,7 @@
 #ifndef V8_ARM64_INSTRUMENT_ARM64_H_
 #define V8_ARM64_INSTRUMENT_ARM64_H_
 
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/utils/utils.h"
 
 #include "src/arm64/constants-arm64.h"

src/arm64/macro-assembler-arm64-inl.h

@@ -7,7 +7,7 @@
 
 #include <ctype.h>
 
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 #include "src/arm64/assembler-arm64-inl.h"
 #include "src/arm64/assembler-arm64.h"

src/arm64/macro-assembler-arm64.cc

@@ -9,12 +9,12 @@
 #include "src/codegen/assembler.h"
 #include "src/codegen/callable.h"
 #include "src/codegen/code-factory.h"
+#include "src/codegen/external-reference-table.h"
 #include "src/codegen/macro-assembler-inl.h"
 #include "src/codegen/register-configuration.h"
 #include "src/debug/debug.h"
 #include "src/execution/frame-constants.h"
 #include "src/execution/frames-inl.h"
-#include "src/external-reference-table.h"
 #include "src/heap/heap-inl.h"  // For MemoryChunk.
 #include "src/init/bootstrapper.h"
 #include "src/logging/counters.h"

src/arm64/macro-assembler-arm64.h

@@ -14,7 +14,7 @@
 #include "src/arm64/assembler-arm64.h"
 #include "src/base/bits.h"
 #include "src/codegen/bailout-reason.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 // Simulator specific helpers.
 #if USE_SIMULATOR

src/arm64/register-arm64.h

@@ -8,7 +8,7 @@
 #include "src/arm64/utils-arm64.h"
 #include "src/codegen/register.h"
 #include "src/codegen/reglist.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 namespace v8 {
 namespace internal {

src/arm64/simulator-arm64.h

@@ -6,7 +6,7 @@
 #define V8_ARM64_SIMULATOR_ARM64_H_
 
 // globals.h defines USE_SIMULATOR.
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 #if defined(USE_SIMULATOR)
 

src/asmjs/asm-js.cc

@@ -6,12 +6,12 @@
 
 #include "src/asmjs/asm-names.h"
 #include "src/asmjs/asm-parser.h"
-#include "src/assert-scope.h"
 #include "src/ast/ast.h"
 #include "src/base/optional.h"
 #include "src/base/platform/elapsed-timer.h"
 #include "src/codegen/compiler.h"
 #include "src/codegen/unoptimized-compilation-info.h"
+#include "src/common/assert-scope.h"
 #include "src/execution/execution.h"
 #include "src/execution/isolate.h"
 #include "src/execution/message-template.h"

src/asmjs/asm-js.h

@@ -7,7 +7,7 @@
 
 // Clients of this interface shouldn't depend on lots of asmjs internals.
 // Do not include anything from src/asmjs here!
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 namespace v8 {
 namespace internal {

src/asmjs/asm-parser.cc

@@ -13,7 +13,7 @@
 #include "src/asmjs/asm-types.h"
 #include "src/base/optional.h"
 #include "src/base/overflowing-math.h"
-#include "src/flags.h"
+#include "src/flags/flags.h"
 #include "src/numbers/conversions-inl.h"
 #include "src/parsing/scanner.h"
 #include "src/wasm/wasm-limits.h"

src/asmjs/asm-scanner.cc

@@ -6,7 +6,7 @@
 
 #include <cinttypes>
 
-#include "src/flags.h"
+#include "src/flags/flags.h"
 #include "src/numbers/conversions.h"
 #include "src/parsing/scanner.h"
 #include "src/strings/char-predicates-inl.h"

src/asmjs/asm-scanner.h

@@ -11,7 +11,7 @@
 
 #include "src/asmjs/asm-names.h"
 #include "src/base/logging.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 namespace v8 {
 namespace internal {

src/asmjs/asm-types.cc

@@ -6,8 +6,8 @@
 
 #include <cinttypes>
 
+#include "src/init/v8.h"
 #include "src/utils/utils.h"
-#include "src/v8.h"
 
 namespace v8 {
 namespace internal {

src/asmjs/asm-types.h

@@ -9,7 +9,7 @@
 
 #include "src/base/compiler-specific.h"
 #include "src/base/macros.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/zone/zone-containers.h"
 #include "src/zone/zone.h"
 

src/ast/ast-value-factory.h

@@ -31,8 +31,8 @@
 #include <forward_list>
 
 #include "src/base/hashmap.h"
+#include "src/common/globals.h"
 #include "src/execution/isolate.h"
-#include "src/globals.h"
 #include "src/heap/factory.h"
 #include "src/numbers/conversions.h"
 

src/ast/ast.h

@@ -13,8 +13,8 @@
 #include "src/base/threaded-list.h"
 #include "src/codegen/bailout-reason.h"
 #include "src/codegen/label.h"
+#include "src/common/globals.h"
 #include "src/execution/isolate.h"
-#include "src/globals.h"
 #include "src/heap/factory.h"
 #include "src/objects/literal-objects.h"
 #include "src/objects/smi.h"

src/ast/modules.cc

@@ -7,7 +7,7 @@
 #include "src/ast/scopes.h"
 #include "src/objects/module-inl.h"
 #include "src/objects/objects-inl.h"
-#include "src/pending-compilation-error-handler.h"
+#include "src/parsing/pending-compilation-error-handler.h"
 
 namespace v8 {
 namespace internal {

src/ast/prettyprinter.cc

@@ -9,7 +9,7 @@
 #include "src/ast/ast-value-factory.h"
 #include "src/ast/scopes.h"
 #include "src/base/platform/platform.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/objects/objects-inl.h"
 #include "src/strings/string-builder-inl.h"
 #include "src/utils/vector.h"

src/ast/scopes.h

@@ -9,10 +9,10 @@
 #include "src/base/compiler-specific.h"
 #include "src/base/hashmap.h"
 #include "src/base/threaded-list.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
-#include "src/utils/pointer-with-payload.h"
 #include "src/objects/function-kind.h"
 #include "src/objects/objects.h"
+#include "src/utils/pointer-with-payload.h"
 #include "src/zone/zone.h"
 
 namespace v8 {

src/ast/variables.cc

@@ -5,7 +5,7 @@
 #include "src/ast/variables.h"
 
 #include "src/ast/scopes.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/objects/objects-inl.h"
 
 namespace v8 {

src/ast/variables.h

@@ -7,7 +7,7 @@
 
 #include "src/ast/ast-value-factory.h"
 #include "src/base/threaded-list.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/zone/zone.h"
 
 namespace v8 {

src/builtins/accessors.h

@@ -6,7 +6,7 @@
 #define V8_BUILTINS_ACCESSORS_H_
 
 #include "include/v8.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/objects/property-details.h"
 #include "src/utils/allocation.h"
 

src/builtins/builtins-api.cc

@@ -11,7 +11,7 @@
 #include "src/objects/objects-inl.h"
 #include "src/objects/prototype.h"
 #include "src/objects/templates.h"
-#include "src/visitors.h"
+#include "src/objects/visitors.h"
 
 namespace v8 {
 namespace internal {

src/builtins/builtins-call-gen.cc

@@ -7,8 +7,8 @@
 #include "src/builtins/builtins-utils-gen.h"
 #include "src/builtins/builtins.h"
 #include "src/codegen/macro-assembler.h"
+#include "src/common/globals.h"
 #include "src/execution/isolate.h"
-#include "src/globals.h"
 #include "src/objects/api-callbacks.h"
 #include "src/objects/arguments.h"
 #include "src/objects/property-cell.h"

src/builtins/builtins-interpreter-gen.cc

@@ -4,7 +4,7 @@
 
 #include "src/builtins/builtins.h"
 #include "src/codegen/macro-assembler.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 namespace v8 {
 namespace internal {

src/builtins/builtins-lazy-gen.cc

@@ -6,7 +6,7 @@
 
 #include "src/builtins/builtins-utils-gen.h"
 #include "src/builtins/builtins.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/objects/feedback-vector.h"
 #include "src/objects/shared-function-info.h"
 

src/builtins/builtins-sharedarraybuffer.cc

@@ -8,8 +8,8 @@
 #include "src/builtins/builtins-utils-inl.h"
 #include "src/builtins/builtins.h"
 #include "src/codegen/code-factory.h"
+#include "src/common/globals.h"
 #include "src/execution/futex-emulation.h"
-#include "src/globals.h"
 #include "src/heap/factory.h"
 #include "src/logging/counters.h"
 #include "src/numbers/conversions-inl.h"

src/builtins/builtins.cc

@@ -16,9 +16,9 @@
 #include "src/logging/log.h"          // For Logger.
 #include "src/objects/fixed-array.h"
 #include "src/objects/objects-inl.h"
+#include "src/objects/visitors.h"
 #include "src/snapshot/embedded-data.h"
 #include "src/utils/ostreams.h"
-#include "src/visitors.h"
 
 namespace v8 {
 namespace internal {

src/builtins/builtins.h

@@ -7,7 +7,7 @@
 
 #include "src/base/flags.h"
 #include "src/builtins/builtins-definitions.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 namespace v8 {
 namespace internal {

src/builtins/constants-table-builder.cc

@@ -7,7 +7,7 @@
 #include "src/execution/isolate.h"
 #include "src/heap/heap-inl.h"
 #include "src/objects/oddball-inl.h"
-#include "src/roots-inl.h"
+#include "src/roots/roots-inl.h"
 
 namespace v8 {
 namespace internal {

src/codegen/assembler.h

@@ -39,12 +39,12 @@
 
 #include "src/codegen/code-comments.h"
 #include "src/codegen/cpu-features.h"
+#include "src/codegen/external-reference.h"
 #include "src/codegen/reglist.h"
 #include "src/codegen/reloc-info.h"
+#include "src/common/globals.h"
 #include "src/deoptimizer/deoptimize-reason.h"
-#include "src/external-reference.h"
+#include "src/flags/flags.h"
-#include "src/flags.h"
-#include "src/globals.h"
 #include "src/handles/handles.h"
 #include "src/objects/objects.h"
 

src/codegen/code-desc.h

@@ -5,7 +5,7 @@
 #ifndef V8_CODEGEN_CODE_DESC_H_
 #define V8_CODEGEN_CODE_DESC_H_
 
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 namespace v8 {
 namespace internal {

src/codegen/code-factory.h

@@ -7,8 +7,8 @@
 
 #include "src/codegen/callable.h"
 #include "src/codegen/interface-descriptors.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
-#include "src/type-hints.h"
+#include "src/objects/type-hints.h"
 #include "src/utils/allocation.h"
 
 namespace v8 {

src/codegen/code-reference.cc

@@ -5,7 +5,7 @@
 #include "src/codegen/code-reference.h"
 
 #include "src/codegen/code-desc.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/handles/handles-inl.h"
 #include "src/objects/objects-inl.h"
 #include "src/wasm/wasm-code-manager.h"

src/codegen/code-stub-assembler.h

@@ -9,16 +9,16 @@
 
 #include "src/base/macros.h"
 #include "src/codegen/bailout-reason.h"
+#include "src/common/globals.h"
 #include "src/compiler/code-assembler.h"
 #include "src/execution/frames.h"
 #include "src/execution/message-template.h"
-#include "src/globals.h"
 #include "src/objects/arguments.h"
 #include "src/objects/bigint.h"
 #include "src/objects/objects.h"
 #include "src/objects/shared-function-info.h"
 #include "src/objects/smi.h"
-#include "src/roots.h"
+#include "src/roots/roots.h"
 
 #include "torque-generated/builtins-base-gen-tq.h"
 

src/codegen/compilation-cache.cc

@@ -4,14 +4,14 @@
 
 #include "src/codegen/compilation-cache.h"
 
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/heap/factory.h"
 #include "src/logging/counters.h"
 #include "src/logging/log.h"
 #include "src/objects/compilation-cache-inl.h"
 #include "src/objects/objects-inl.h"
 #include "src/objects/slots.h"
-#include "src/visitors.h"
+#include "src/objects/visitors.h"
 
 namespace v8 {
 namespace internal {

src/codegen/compiler.cc

@@ -16,6 +16,7 @@
 #include "src/codegen/compilation-cache.h"
 #include "src/codegen/optimized-compilation-info.h"
 #include "src/codegen/unoptimized-compilation-info.h"
+#include "src/common/globals.h"
 #include "src/compiler-dispatcher/compiler-dispatcher.h"
 #include "src/compiler-dispatcher/optimizing-compile-dispatcher.h"
 #include "src/compiler/pipeline.h"
@@ -26,7 +27,6 @@
 #include "src/execution/message-template.h"
 #include "src/execution/runtime-profiler.h"
 #include "src/execution/vm-state-inl.h"
-#include "src/globals.h"
 #include "src/heap/heap-inl.h"
 #include "src/init/bootstrapper.h"
 #include "src/interpreter/interpreter.h"

src/codegen/constant-pool.h

@@ -9,7 +9,7 @@
 
 #include "src/codegen/label.h"
 #include "src/codegen/reloc-info.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/numbers/double.h"
 
 namespace v8 {

src/codegen/cpu-features.h

@@ -5,7 +5,7 @@
 #ifndef V8_CODEGEN_CPU_FEATURES_H_
 #define V8_CODEGEN_CPU_FEATURES_H_
 
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 namespace v8 {
 

src/codegen/external-reference-table.cc

@@ -2,10 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "src/external-reference-table.h"
+#include "src/codegen/external-reference-table.h"
 
 #include "src/builtins/accessors.h"
-#include "src/external-reference.h"
+#include "src/codegen/external-reference.h"
 #include "src/ic/stub-cache.h"
 #include "src/logging/counters.h"
 

src/codegen/external-reference-table.h

@@ -2,14 +2,14 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef V8_EXTERNAL_REFERENCE_TABLE_H_
+#ifndef V8_CODEGEN_EXTERNAL_REFERENCE_TABLE_H_
-#define V8_EXTERNAL_REFERENCE_TABLE_H_
+#define V8_CODEGEN_EXTERNAL_REFERENCE_TABLE_H_
 
 #include <vector>
 
 #include "src/builtins/accessors.h"
 #include "src/builtins/builtins.h"
-#include "src/external-reference.h"
+#include "src/codegen/external-reference.h"
 #include "src/logging/counters-definitions.h"
 
 namespace v8 {
@@ -108,4 +108,4 @@ STATIC_ASSERT(ExternalReferenceTable::kSizeInBytes ==
 
 }  // namespace internal
 }  // namespace v8
-#endif  // V8_EXTERNAL_REFERENCE_TABLE_H_
+#endif  // V8_CODEGEN_EXTERNAL_REFERENCE_TABLE_H_

src/codegen/external-reference.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "src/external-reference.h"
+#include "src/codegen/external-reference.h"
 
 #include "src/api/api.h"
 #include "src/base/ieee754.h"
@@ -11,9 +11,9 @@
 #include "src/date/date.h"
 #include "src/debug/debug.h"
 #include "src/deoptimizer/deoptimizer.h"
-#include "src/hash-seed-inl.h"
 #include "src/heap/heap.h"
 #include "src/logging/counters.h"
+#include "src/numbers/hash-seed-inl.h"
 #include "src/objects/elements.h"
 #include "src/objects/ordered-hash-table.h"
 // For IncrementalMarking::RecordWriteFromCode. TODO(jkummerow): Drop.
@@ -497,7 +497,7 @@ ExternalReference ExternalReference::invoke_accessor_getter_callback() {
 #elif V8_TARGET_ARCH_S390
 #define re_stack_check_func RegExpMacroAssemblerS390::CheckStackGuardState
 #else
-  UNREACHABLE();
+UNREACHABLE();
 #endif
 
 FUNCTION_REFERENCE_WITH_ISOLATE(re_check_stack_guard_state, re_stack_check_func)

src/codegen/external-reference.h

@@ -2,10 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef V8_EXTERNAL_REFERENCE_H_
+#ifndef V8_CODEGEN_EXTERNAL_REFERENCE_H_
-#define V8_EXTERNAL_REFERENCE_H_
+#define V8_CODEGEN_EXTERNAL_REFERENCE_H_
 
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/runtime/runtime.h"
 
 namespace v8 {
@@ -328,4 +328,4 @@ void abort_with_reason(int reason);
 }  // namespace internal
 }  // namespace v8
 
-#endif  // V8_EXTERNAL_REFERENCE_H_
+#endif  // V8_CODEGEN_EXTERNAL_REFERENCE_H_

src/codegen/handler-table.h

@@ -5,8 +5,8 @@
 #ifndef V8_CODEGEN_HANDLER_TABLE_H_
 #define V8_CODEGEN_HANDLER_TABLE_H_
 
-#include "src/assert-scope.h"
+#include "src/common/assert-scope.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/utils/utils.h"
 
 namespace v8 {

src/codegen/interface-descriptors.h

@@ -9,8 +9,8 @@
 
 #include "src/codegen/machine-type.h"
 #include "src/codegen/register-arch.h"
+#include "src/common/globals.h"
 #include "src/execution/isolate.h"
-#include "src/globals.h"
 
 namespace v8 {
 namespace internal {

src/codegen/machine-type.h

@@ -8,7 +8,7 @@
 #include <iosfwd>
 
 #include "src/base/bits.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 namespace v8 {
 namespace internal {

src/codegen/optimized-compilation-info.h

@@ -9,12 +9,12 @@
 
 #include "src/codegen/bailout-reason.h"
 #include "src/codegen/source-position-table.h"
+#include "src/common/globals.h"
 #include "src/execution/frames.h"
-#include "src/globals.h"
-#include "src/utils/utils.h"
-#include "src/utils/vector.h"
 #include "src/handles/handles.h"
 #include "src/objects/objects.h"
+#include "src/utils/utils.h"
+#include "src/utils/vector.h"
 
 namespace v8 {
 

src/codegen/register-configuration.cc

@@ -6,7 +6,7 @@
 #include "src/base/lazy-instance.h"
 #include "src/codegen/cpu-features.h"
 #include "src/codegen/register-arch.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 namespace v8 {
 namespace internal {

src/codegen/register-configuration.h

@@ -8,7 +8,7 @@
 #include "src/base/macros.h"
 #include "src/codegen/machine-type.h"
 #include "src/codegen/reglist.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/utils/utils.h"
 
 namespace v8 {

src/codegen/reloc-info.h

@@ -6,7 +6,7 @@
 #define V8_CODEGEN_RELOC_INFO_H_
 
 #include "src/codegen/flush-instruction-cache.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/objects/code.h"
 
 namespace v8 {

src/codegen/safepoint-table.h

@@ -5,10 +5,10 @@
 #ifndef V8_CODEGEN_SAFEPOINT_TABLE_H_
 #define V8_CODEGEN_SAFEPOINT_TABLE_H_
 
-#include "src/assert-scope.h"
+#include "src/common/assert-scope.h"
+#include "src/common/v8memory.h"
 #include "src/utils/allocation.h"
 #include "src/utils/utils.h"
-#include "src/v8memory.h"
 #include "src/zone/zone-chunk-list.h"
 #include "src/zone/zone.h"
 

src/codegen/source-position-table.h

@@ -5,10 +5,10 @@
 #ifndef V8_CODEGEN_SOURCE_POSITION_TABLE_H_
 #define V8_CODEGEN_SOURCE_POSITION_TABLE_H_
 
-#include "src/assert-scope.h"
-#include "src/checks.h"
 #include "src/codegen/source-position.h"
-#include "src/globals.h"
+#include "src/common/assert-scope.h"
+#include "src/common/checks.h"
+#include "src/common/globals.h"
 #include "src/zone/zone-containers.h"
 
 namespace v8 {

src/codegen/source-position.h

@@ -7,10 +7,10 @@
 
 #include <ostream>
 
-#include "src/flags.h"
+#include "src/common/globals.h"
-#include "src/globals.h"
+#include "src/flags/flags.h"
-#include "src/utils/utils.h"
 #include "src/handles/handles.h"
+#include "src/utils/utils.h"
 
 namespace v8 {
 namespace internal {

src/codegen/turbo-assembler.h

@@ -8,7 +8,7 @@
 #include "src/base/template-utils.h"
 #include "src/builtins/builtins.h"
 #include "src/codegen/assembler-arch.h"
-#include "src/roots.h"
+#include "src/roots/roots.h"
 
 namespace v8 {
 namespace internal {

src/codegen/unoptimized-compilation-info.h

@@ -8,11 +8,11 @@
 #include <memory>
 
 #include "src/codegen/source-position-table.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
-#include "src/utils/utils.h"
 #include "src/handles/handles.h"
 #include "src/objects/feedback-vector.h"
 #include "src/objects/objects.h"
+#include "src/utils/utils.h"
 
 namespace v8 {
 namespace internal {

src/common/assert-scope.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "src/assert-scope.h"
+#include "src/common/assert-scope.h"
 
 #include "src/base/lazy-instance.h"
 #include "src/base/platform/platform.h"
@@ -20,7 +20,6 @@ DEFINE_LAZY_LEAKY_OBJECT_GETTER(base::Thread::LocalStorageKey,
 
 }  // namespace
 
-
 class PerThreadAssertData final {
  public:
   PerThreadAssertData() : nesting_level_(0) {
@@ -97,7 +96,6 @@ template <PerIsolateAssertType kType, bool kAllow>
 class PerIsolateAssertScope<kType, kAllow>::DataBit
     : public BitField<bool, kType, 1> {};
 
-
 template <PerIsolateAssertType kType, bool kAllow>
 PerIsolateAssertScope<kType, kAllow>::PerIsolateAssertScope(Isolate* isolate)
     : isolate_(isolate), old_data_(isolate->per_isolate_assert_data()) {
@@ -106,20 +104,17 @@ PerIsolateAssertScope<kType, kAllow>::PerIsolateAssertScope(Isolate* isolate)
   isolate_->set_per_isolate_assert_data(DataBit::update(old_data_, kAllow));
 }
 
-
 template <PerIsolateAssertType kType, bool kAllow>
 PerIsolateAssertScope<kType, kAllow>::~PerIsolateAssertScope() {
   isolate_->set_per_isolate_assert_data(old_data_);
 }
 
-
 // static
 template <PerIsolateAssertType kType, bool kAllow>
 bool PerIsolateAssertScope<kType, kAllow>::IsAllowed(Isolate* isolate) {
   return DataBit::decode(isolate->per_isolate_assert_data());
 }
 
-
 // -----------------------------------------------------------------------------
 // Instantiations.
 

src/common/assert-scope.h

@@ -2,14 +2,14 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef V8_ASSERT_SCOPE_H_
+#ifndef V8_COMMON_ASSERT_SCOPE_H_
-#define V8_ASSERT_SCOPE_H_
+#define V8_COMMON_ASSERT_SCOPE_H_
 
 #include <stdint.h>
 
 #include "src/base/macros.h"
 #include "src/base/optional.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 #include "src/utils/pointer-with-payload.h"
 
 namespace v8 {
@@ -72,7 +72,6 @@ class PerThreadAssertScope {
   DISALLOW_COPY_AND_ASSIGN(PerThreadAssertScope);
 };
 
-
 template <PerIsolateAssertType type, bool allow>
 class PerIsolateAssertScope {
  public:
@@ -90,11 +89,9 @@ class PerIsolateAssertScope {
   DISALLOW_COPY_AND_ASSIGN(PerIsolateAssertScope);
 };
 
-
 template <PerThreadAssertType type, bool allow>
 #ifdef DEBUG
-class PerThreadAssertScopeDebugOnly : public
+class PerThreadAssertScopeDebugOnly : public PerThreadAssertScope<type, allow> {
-    PerThreadAssertScope<type, allow> {
 #else
 class PerThreadAssertScopeDebugOnly {
  public:
@@ -105,18 +102,17 @@ class PerThreadAssertScopeDebugOnly {
 #endif
 };
 
-
 template <PerIsolateAssertType type, bool allow>
 #ifdef DEBUG
-class PerIsolateAssertScopeDebugOnly : public
+class PerIsolateAssertScopeDebugOnly
-    PerIsolateAssertScope<type, allow> {
+    : public PerIsolateAssertScope<type, allow> {
  public:
   explicit PerIsolateAssertScopeDebugOnly(Isolate* isolate)
-      : PerIsolateAssertScope<type, allow>(isolate) { }
+      : PerIsolateAssertScope<type, allow>(isolate) {}
 #else
 class PerIsolateAssertScopeDebugOnly {
  public:
-  explicit PerIsolateAssertScopeDebugOnly(Isolate* isolate) { }
+  explicit PerIsolateAssertScopeDebugOnly(Isolate* isolate) {}
 #endif
 };
 
@@ -273,4 +269,4 @@ extern template class PerIsolateAssertScope<NO_EXCEPTION_ASSERT, true>;
 }  // namespace internal
 }  // namespace v8
 
-#endif  // V8_ASSERT_SCOPE_H_
+#endif  // V8_COMMON_ASSERT_SCOPE_H_

src/common/checks.h

@@ -2,12 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef V8_CHECKS_H_
+#ifndef V8_COMMON_CHECKS_H_
-#define V8_CHECKS_H_
+#define V8_COMMON_CHECKS_H_
 
 #include "include/v8-internal.h"
 #include "src/base/logging.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 namespace v8 {
 
@@ -20,7 +20,7 @@ namespace internal {
   CHECK(!v8::internal::FLAG_enable_slow_asserts || (condition))
 V8_EXPORT_PRIVATE extern bool FLAG_enable_slow_asserts;
 #else
-#define SLOW_DCHECK(condition) ((void) 0)
+#define SLOW_DCHECK(condition) ((void)0)
 static const bool FLAG_enable_slow_asserts = false;
 #endif
 
@@ -33,4 +33,4 @@ static const bool FLAG_enable_slow_asserts = false;
 #define DCHECK_SIZE_TAG_ALIGNED(size) \
   DCHECK((size & ::v8::internal::kHeapObjectTagMask) == 0)
 
-#endif  // V8_CHECKS_H_
+#endif  // V8_COMMON_CHECKS_H_

src/common/globals.h

@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef V8_GLOBALS_H_
+#ifndef V8_COMMON_GLOBALS_H_
-#define V8_GLOBALS_H_
+#define V8_COMMON_GLOBALS_H_
 
 #include <stddef.h>
 #include <stdint.h>
@@ -25,7 +25,7 @@ namespace v8 {
 namespace base {
 class Mutex;
 class RecursiveMutex;
-}
+}  // namespace base
 
 namespace internal {
 
@@ -339,13 +339,12 @@ F FUNCTION_CAST(Address addr) {
   return reinterpret_cast<F>(addr);
 }
 
-
 // Determine whether the architecture uses function descriptors
 // which provide a level of indirection between the function pointer
 // and the function entrypoint.
-#if V8_HOST_ARCH_PPC && \
+#if V8_HOST_ARCH_PPC &&                                            \
     (V8_OS_AIX || (V8_TARGET_ARCH_PPC64 && V8_TARGET_BIG_ENDIAN && \
-    (!defined(_CALL_ELF) || _CALL_ELF == 1)))
+                   (!defined(_CALL_ELF) || _CALL_ELF == 1)))
 #define USES_FUNCTION_DESCRIPTORS 1
 #define FUNCTION_ENTRYPOINT_ADDRESS(f)       \
   (reinterpret_cast<v8::internal::Address*>( \
@@ -354,7 +353,6 @@ F FUNCTION_CAST(Address addr) {
 #define USES_FUNCTION_DESCRIPTORS 0
 #endif
 
-
 // -----------------------------------------------------------------------------
 // Declarations for use in both the preparser and the rest of V8.
 
@@ -602,7 +600,8 @@ class Foreign;
 class FreeStoreAllocationPolicy;
 class FunctionTemplateInfo;
 class GlobalDictionary;
-template <typename T> class Handle;
+template <typename T>
+class Handle;
 class Heap;
 class HeapObject;
 class HeapObjectReference;
@@ -798,11 +797,7 @@ enum class BytecodeFlushMode {
 };
 
 // Flag indicating whether code is built into the VM (one of the natives files).
-enum NativesFlag {
+enum NativesFlag { NOT_NATIVES_CODE, EXTENSION_CODE, INSPECTOR_CODE };
-  NOT_NATIVES_CODE,
-  EXTENSION_CODE,
-  INSPECTOR_CODE
-};
 
 // ParseRestriction is used to restrict the set of valid statements in a
 // unit of compilation.  Restriction violations cause a syntax error.
@@ -870,9 +865,7 @@ typedef enum {
   kStoreBufferScanningPageEvent
 } StoreBufferEvent;
 
-
+typedef void (*StoreBufferCallback)(Heap* heap, MemoryChunk* page,
-typedef void (*StoreBufferCallback)(Heap* heap,
-                                    MemoryChunk* page,
                                     StoreBufferEvent event);
 
 // Union used for customized checking of the IEEE double types
@@ -881,21 +874,20 @@ typedef void (*StoreBufferCallback)(Heap* heap,
 union IeeeDoubleLittleEndianArchType {
   double d;
   struct {
-    unsigned int man_low  :32;
+    unsigned int man_low : 32;
-    unsigned int man_high :20;
+    unsigned int man_high : 20;
-    unsigned int exp      :11;
+    unsigned int exp : 11;
-    unsigned int sign     :1;
+    unsigned int sign : 1;
   } bits;
 };
 
-
 union IeeeDoubleBigEndianArchType {
   double d;
   struct {
-    unsigned int sign     :1;
+    unsigned int sign : 1;
-    unsigned int exp      :11;
+    unsigned int exp : 11;
-    unsigned int man_high :20;
+    unsigned int man_high : 20;
-    unsigned int man_low  :32;
+    unsigned int man_low : 32;
   } bits;
 };
 
@@ -1203,7 +1195,6 @@ enum MaybeAssignedFlag : uint8_t { kNotAssigned, kMaybeAssigned };
 
 enum ParseErrorType { kSyntaxError = 0, kReferenceError = 1 };
 
-
 enum class InterpreterPushArgsMode : unsigned {
   kArrayFunction,
   kWithFinalSpread,
@@ -1568,4 +1559,4 @@ constexpr int kSmallOrderedHashMapMinCapacity = 4;
 
 namespace i = v8::internal;
 
-#endif  // V8_GLOBALS_H_
+#endif  // V8_COMMON_GLOBALS_H_

src/common/ptr-compr-inl.h

@@ -2,12 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef V8_PTR_COMPR_INL_H_
+#ifndef V8_COMMON_PTR_COMPR_INL_H_
-#define V8_PTR_COMPR_INL_H_
+#define V8_COMMON_PTR_COMPR_INL_H_
 
 #include "include/v8-internal.h"
+#include "src/common/ptr-compr.h"
 #include "src/execution/isolate.h"
-#include "src/ptr-compr.h"
 
 namespace v8 {
 namespace internal {
@@ -110,4 +110,4 @@ V8_INLINE Address DecompressTaggedAny(TOnHeapAddress on_heap_addr,
 }  // namespace internal
 }  // namespace v8
 
-#endif  // V8_PTR_COMPR_INL_H_
+#endif  // V8_COMMON_PTR_COMPR_INL_H_

src/common/ptr-compr.h

@@ -2,10 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef V8_PTR_COMPR_H_
+#ifndef V8_COMMON_PTR_COMPR_H_
-#define V8_PTR_COMPR_H_
+#define V8_COMMON_PTR_COMPR_H_
 
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 #if V8_TARGET_ARCH_64_BIT
 
@@ -22,4 +22,4 @@ constexpr size_t kPtrComprIsolateRootAlignment = size_t{4} * GB;
 
 #endif  // V8_TARGET_ARCH_64_BIT
 
-#endif  // V8_PTR_COMPR_H_
+#endif  // V8_COMMON_PTR_COMPR_H_

src/common/v8memory.h

@@ -2,11 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef V8_V8MEMORY_H_
+#ifndef V8_COMMON_V8MEMORY_H_
-#define V8_V8MEMORY_H_
+#define V8_COMMON_V8MEMORY_H_
 
 #include "src/base/macros.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
 
 namespace v8 {
 namespace internal {
@@ -96,4 +96,4 @@ static inline void WriteLittleEndianValue(V* p, V value) {
 }  // namespace internal
 }  // namespace v8
 
-#endif  // V8_V8MEMORY_H_
+#endif  // V8_COMMON_V8MEMORY_H_

src/compiler-dispatcher/compiler-dispatcher.cc

@@ -7,14 +7,14 @@
 #include "src/ast/ast.h"
 #include "src/base/platform/time.h"
 #include "src/base/template-utils.h"
-#include "src/cancelable-task.h"
 #include "src/codegen/compiler.h"
-#include "src/flags.h"
+#include "src/flags/flags.h"
 #include "src/handles/global-handles.h"
 #include "src/objects/objects-inl.h"
 #include "src/parsing/parse-info.h"
 #include "src/parsing/parser.h"
-#include "src/task-utils.h"
+#include "src/tasks/cancelable-task.h"
+#include "src/tasks/task-utils.h"
 #include "src/zone/zone-list-inl.h"  // crbug.com/v8/8816
 
 namespace v8 {

src/compiler-dispatcher/compiler-dispatcher.h

@@ -17,9 +17,9 @@
 #include "src/base/platform/condition-variable.h"
 #include "src/base/platform/mutex.h"
 #include "src/base/platform/semaphore.h"
-#include "src/globals.h"
+#include "src/common/globals.h"
-#include "src/utils/identity-map.h"
 #include "src/handles/maybe-handles.h"
+#include "src/utils/identity-map.h"
 #include "testing/gtest/include/gtest/gtest_prod.h"  // nogncheck
 
 namespace v8 {

src/compiler-dispatcher/optimizing-compile-dispatcher.cc

@@ -6,15 +6,15 @@
 
 #include "src/base/atomicops.h"
 #include "src/base/template-utils.h"
-#include "src/cancelable-task.h"
 #include "src/codegen/compiler.h"
 #include "src/codegen/optimized-compilation-info.h"
 #include "src/execution/isolate.h"
+#include "src/init/v8.h"
 #include "src/logging/counters.h"
 #include "src/logging/log.h"
 #include "src/objects/objects-inl.h"
+#include "src/tasks/cancelable-task.h"
 #include "src/tracing/trace-event.h"
-#include "src/v8.h"
 
 namespace v8 {
 namespace internal {

src/compiler-dispatcher/optimizing-compile-dispatcher.h

@@ -11,8 +11,8 @@
 #include "src/base/platform/condition-variable.h"
 #include "src/base/platform/mutex.h"
 #include "src/base/platform/platform.h"
-#include "src/flags.h"
+#include "src/common/globals.h"
-#include "src/globals.h"
+#include "src/flags/flags.h"
 #include "src/utils/allocation.h"
 
 namespace v8 {

src/compiler/backend/arm/unwinding-info-writer-arm.h

@@ -6,7 +6,7 @@
 #define V8_COMPILER_BACKEND_ARM_UNWINDING_INFO_WRITER_ARM_H_
 
 #include "src/diagnostics/eh-frame.h"
-#include "src/flags.h"
+#include "src/flags/flags.h"
 
 namespace v8 {
 namespace internal {

src/compiler/backend/arm64/unwinding-info-writer-arm64.h

@@ -6,7 +6,7 @@
 #define V8_COMPILER_BACKEND_ARM64_UNWINDING_INFO_WRITER_ARM64_H_
 
 #include "src/diagnostics/eh-frame.h"
-#include "src/flags.h"
+#include "src/flags/flags.h"
 
 namespace v8 {
 namespace internal {

src/compiler/backend/instruction-selector.h

@@ -8,13 +8,13 @@
 #include <map>
 
 #include "src/codegen/cpu-features.h"
+#include "src/common/globals.h"
 #include "src/compiler/backend/instruction-scheduler.h"
 #include "src/compiler/backend/instruction.h"
 #include "src/compiler/common-operator.h"
 #include "src/compiler/linkage.h"
 #include "src/compiler/machine-operator.h"
 #include "src/compiler/node.h"
-#include "src/globals.h"
 #include "src/zone/zone-containers.h"
 
 namespace v8 {

src/compiler/backend/instruction.h

@@ -11,14 +11,14 @@
 #include <set>
 
 #include "src/base/compiler-specific.h"
+#include "src/codegen/external-reference.h"
 #include "src/codegen/register-arch.h"
 #include "src/codegen/source-position.h"
+#include "src/common/globals.h"
 #include "src/compiler/backend/instruction-codes.h"
 #include "src/compiler/common-operator.h"
 #include "src/compiler/frame.h"
 #include "src/compiler/opcodes.h"
-#include "src/external-reference.h"
-#include "src/globals.h"
 #include "src/numbers/double.h"
 #include "src/zone/zone-allocator.h"
 

src/compiler/backend/move-optimizer.h

@@ -5,8 +5,8 @@
 #ifndef V8_COMPILER_BACKEND_MOVE_OPTIMIZER_H_
 #define V8_COMPILER_BACKEND_MOVE_OPTIMIZER_H_
 
+#include "src/common/globals.h"
 #include "src/compiler/backend/instruction.h"
-#include "src/globals.h"
 #include "src/zone/zone-containers.h"
 
 namespace v8 {

src/compiler/backend/register-allocator.h

@@ -8,9 +8,9 @@
 #include "src/base/bits.h"
 #include "src/base/compiler-specific.h"
 #include "src/codegen/register-configuration.h"
+#include "src/common/globals.h"
 #include "src/compiler/backend/instruction.h"
-#include "src/flags.h"
+#include "src/flags/flags.h"
-#include "src/globals.h"
 #include "src/utils/ostreams.h"
 #include "src/zone/zone-containers.h"
 

src/compiler/backend/unwinding-info-writer.h

@@ -5,7 +5,7 @@
 #ifndef V8_COMPILER_BACKEND_UNWINDING_INFO_WRITER_H_
 #define V8_COMPILER_BACKEND_UNWINDING_INFO_WRITER_H_
 
-#include "src/flags.h"
+#include "src/flags/flags.h"
 
 #if V8_TARGET_ARCH_ARM
 #include "src/compiler/backend/arm/unwinding-info-writer-arm.h"

src/compiler/backend/x64/instruction-selector-x64.cc

@@ -9,7 +9,7 @@
 #include "src/compiler/backend/instruction-selector-impl.h"
 #include "src/compiler/node-matchers.h"
 #include "src/compiler/node-properties.h"
-#include "src/roots-inl.h"
+#include "src/roots/roots-inl.h"
 
 namespace v8 {
 namespace internal {

src/compiler/backend/x64/unwinding-info-writer-x64.h

@@ -6,7 +6,7 @@
 #define V8_COMPILER_BACKEND_X64_UNWINDING_INFO_WRITER_X64_H_
 
 #include "src/diagnostics/eh-frame.h"
-#include "src/flags.h"
+#include "src/flags/flags.h"
 
 namespace v8 {
 namespace internal {

src/compiler/branch-elimination.h

@@ -6,10 +6,10 @@
 #define V8_COMPILER_BRANCH_ELIMINATION_H_
 
 #include "src/base/compiler-specific.h"
+#include "src/common/globals.h"
 #include "src/compiler/functional-list.h"
 #include "src/compiler/graph-reducer.h"
 #include "src/compiler/node-aux-data.h"
-#include "src/globals.h"
 
 namespace v8 {
 namespace internal {

src/compiler/bytecode-graph-builder.cc

@@ -14,6 +14,7 @@
 #include "src/compiler/operator-properties.h"
 #include "src/compiler/simplified-operator.h"
 #include "src/compiler/state-values-utils.h"
+#include "src/compiler/vector-slot-pair.h"
 #include "src/interpreter/bytecode-array-iterator.h"
 #include "src/interpreter/bytecode-flags.h"
 #include "src/interpreter/bytecodes.h"
@@ -23,7 +24,6 @@
 #include "src/objects/objects-inl.h"
 #include "src/objects/smi.h"
 #include "src/objects/template-objects-inl.h"
-#include "src/vector-slot-pair.h"
 
 namespace v8 {
 namespace internal {

src/compiler/checkpoint-elimination.h

@@ -6,8 +6,8 @@
 #define V8_COMPILER_CHECKPOINT_ELIMINATION_H_
 
 #include "src/base/compiler-specific.h"
+#include "src/common/globals.h"
 #include "src/compiler/graph-reducer.h"
-#include "src/globals.h"
 
 namespace v8 {
 namespace internal {

src/compiler/common-node-cache.cc

@@ -4,8 +4,8 @@
 
 #include "src/compiler/common-node-cache.h"
 
+#include "src/codegen/external-reference.h"
 #include "src/compiler/node.h"
-#include "src/external-reference.h"
 
 namespace v8 {
 namespace internal {

src/compiler/common-operator-reducer.h

@@ -6,8 +6,8 @@
 #define V8_COMPILER_COMMON_OPERATOR_REDUCER_H_
 
 #include "src/base/compiler-specific.h"
+#include "src/common/globals.h"
 #include "src/compiler/graph-reducer.h"
-#include "src/globals.h"
 
 namespace v8 {
 namespace internal {

src/compiler/common-operator.h

@@ -9,10 +9,10 @@
 #include "src/codegen/machine-type.h"
 #include "src/codegen/reloc-info.h"
 #include "src/codegen/string-constants.h"
+#include "src/common/globals.h"
 #include "src/compiler/frame-states.h"
+#include "src/compiler/vector-slot-pair.h"
 #include "src/deoptimizer/deoptimize-reason.h"
-#include "src/globals.h"
-#include "src/vector-slot-pair.h"
 #include "src/zone/zone-containers.h"
 #include "src/zone/zone-handle-set.h"
 

src/compiler/compiler-source-position-table.h

@@ -7,8 +7,8 @@
 
 #include "src/base/compiler-specific.h"
 #include "src/codegen/source-position.h"
+#include "src/common/globals.h"
 #include "src/compiler/node-aux-data.h"
-#include "src/globals.h"
 
 namespace v8 {
 namespace internal {

src/compiler/control-equivalence.h

@@ -6,9 +6,9 @@
 #define V8_COMPILER_CONTROL_EQUIVALENCE_H_
 
 #include "src/base/compiler-specific.h"
+#include "src/common/globals.h"
 #include "src/compiler/graph.h"
 #include "src/compiler/node.h"
-#include "src/globals.h"
 #include "src/zone/zone-containers.h"
 
 namespace v8 {

src/compiler/control-flow-optimizer.h

@@ -5,8 +5,8 @@
 #ifndef V8_COMPILER_CONTROL_FLOW_OPTIMIZER_H_
 #define V8_COMPILER_CONTROL_FLOW_OPTIMIZER_H_
 
+#include "src/common/globals.h"
 #include "src/compiler/node-marker.h"
-#include "src/globals.h"
 #include "src/zone/zone-containers.h"
 
 namespace v8 {

src/compiler/dead-code-elimination.h

@@ -7,8 +7,8 @@
 
 #include "src/base/compiler-specific.h"
 #include "src/codegen/machine-type.h"
+#include "src/common/globals.h"
 #include "src/compiler/graph-reducer.h"
-#include "src/globals.h"
 
 namespace v8 {
 namespace internal {