From fa73edeb1ef41c9f9430d16bb20991614c5405b5 Mon Sep 17 00:00:00 2001 From: Ilya Rezvov Date: Mon, 6 Feb 2023 21:23:28 +0000 Subject: [PATCH] Revert "[gc][static-roots] Fix one remaining access to r/o markbits" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 229f91a339431ee118b0eb4b1ec469aa0a5b85f8. Reason for revert: Initial CL(https://chromium-review.googlesource.com/c/v8/v8/+/4212397) with InReadOnlySpace() was reverted. Original change's description: > [gc][static-roots] Fix one remaining access to r/o markbits > > Yet another access to the markbits on the r/o pages that was overlooked > in https://chromium-review.googlesource.com/c/v8/v8/+/4212397. > > No-Tree-Checks: true > No-Try: true > Bug: v8:13717 > Change-Id: I682a2604512dfda00b3f69d0e1f60edd66391687 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4221702 > Commit-Queue: Olivier Flückiger > Reviewed-by: Dominik Inführ > Auto-Submit: Olivier Flückiger > Cr-Commit-Position: refs/heads/main@{#85672} Bug: v8:13717 Change-Id: I72a629d335c1ec90d080dbc4a3e79ab54da7a8b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4226003 Bot-Commit: Rubber Stamper Auto-Submit: Ilya Rezvov Owners-Override: Ilya Rezvov Commit-Queue: Ilya Rezvov Cr-Commit-Position: refs/heads/main@{#85697} --- src/heap/mark-compact.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc index a69409f478..25d6513523 100644 --- a/src/heap/mark-compact.cc +++ b/src/heap/mark-compact.cc @@ -2082,7 +2082,6 @@ bool MarkCompactCollector::IsUnmarkedHeapObject(Heap* heap, FullObjectSlot p) { Object o = *p; if (!o.IsHeapObject()) return false; HeapObject heap_object = HeapObject::cast(o); - if (heap_object.InReadOnlySpace()) return false; MarkCompactCollector* collector = heap->mark_compact_collector(); if (V8_UNLIKELY(collector->uses_shared_heap_) && !collector->is_shared_heap_isolate_) {