AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Fix more header includes to allow individual compilation

Browse Source 
Fixes:
  src/objects/arguments.h
  src/objects/arguments-inl.h
  src/objects/compilation-cache-inl.h
  src/objects/data-handler-inl.h
  src/objects/hash-table-inl.h

Bug: v8:7754,v8:7490
Change-Id: Ic17d4c3477c7d2003b325497cb9082899a0bf3fc
Reviewed-on: https://chromium-review.googlesource.com/1151312
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54736}
This commit is contained in:
Peter Marshall 2018-07-26 16:49:18 +02:00 committed by Commit Bot
parent 31b6faed38
commit fbedc72a6c
13 changed files with 27 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/feedback-vector.cc
View File

@ -7,6 +7,7 @@
#include "src/feedback-vector-inl.h"
#include "src/ic/ic-inl.h"
#include "src/objects.h"
#include "src/objects/data-handler-inl.h"
#include "src/objects/hash-table-inl.h"
#include "src/objects/object-macros.h"

1
src/heap/objects-visiting-inl.h
View File

@ -12,6 +12,7 @@
#include "src/heap/mark-compact.h"
#include "src/macro-assembler.h"
#include "src/objects-body-descriptors-inl.h"
#include "src/objects-inl.h"
namespace v8 {
namespace internal {

1
src/ic/handler-configuration-inl.h
View File

@ -10,7 +10,6 @@
#include "src/field-index-inl.h"
#include "src/handles-inl.h"
#include "src/objects-inl.h"
#include "src/objects/data-handler-inl.h"
// Has to be the last include (doesn't have include guards):
#include "src/objects/object-macros.h"

1
src/ic/handler-configuration.cc
View File

@ -6,6 +6,7 @@
#include "src/code-stubs.h"
#include "src/ic/handler-configuration-inl.h"
#include "src/objects/data-handler-inl.h"
#include "src/objects/maybe-object.h"
#include "src/transitions.h"

1
src/ic/ic.cc
View File

@ -23,6 +23,7 @@
#include "src/isolate-inl.h"
#include "src/macro-assembler.h"
#include "src/objects/api-callbacks.h"
#include "src/objects/data-handler-inl.h"
#include "src/objects/hash-table-inl.h"
#include "src/objects/js-array-inl.h"
#include "src/objects/module-inl.h"

5
src/objects-inl.h
View File

@ -205,6 +205,10 @@ bool HeapObject::IsJSGeneratorObject() const {
IsJSAsyncGeneratorObject();
}
bool HeapObject::IsDataHandler() const {
return IsLoadHandler() || IsStoreHandler();
}
bool HeapObject::IsClassBoilerplate() const { return IsFixedArrayExact(); }
bool HeapObject::IsExternal(Isolate* isolate) const {
@ -612,6 +616,7 @@ CAST_ACCESSOR(BigInt)
CAST_ACCESSOR(ObjectBoilerplateDescription)
CAST_ACCESSOR(Cell)
CAST_ACCESSOR(ArrayBoilerplateDescription)
CAST_ACCESSOR(DataHandler)
CAST_ACCESSOR(DescriptorArray)
CAST_ACCESSOR(EphemeronHashTable)
CAST_ACCESSOR(EnumCache)

1
src/objects-printer.cc
View File

@ -14,6 +14,7 @@
#include "src/interpreter/bytecodes.h"
#include "src/objects-inl.h"
#include "src/objects/arguments-inl.h"
#include "src/objects/data-handler-inl.h"
#include "src/objects/debug-objects-inl.h"
#include "src/objects/hash-table-inl.h"
#include "src/objects/js-collection-inl.h"

5
src/objects/arguments-inl.h
View File

@ -7,6 +7,11 @@
#include "src/objects/arguments.h"
#include "src/contexts-inl.h"
#include "src/isolate-inl.h"
#include "src/objects-inl.h"
#include "src/objects/fixed-array-inl.h"
// Has to be the last include (doesn't have include guards):
#include "src/objects/object-macros.h"

1
src/objects/arguments.h
View File

@ -6,6 +6,7 @@
#define V8_OBJECTS_ARGUMENTS_H_
#include "src/objects.h"
#include "src/objects/fixed-array.h"
// Has to be the last include (doesn't have include guards):
#include "src/objects/object-macros.h"

5
src/objects/compilation-cache-inl.h
View File

@ -7,6 +7,11 @@
#include "src/objects/compilation-cache.h"
#include "src/objects/name-inl.h"
#include "src/objects/script-inl.h"
#include "src/objects/shared-function-info.h"
#include "src/objects/string.h"
// Has to be the last include (doesn't have include guards):
#include "src/objects/object-macros.h"

7
src/objects/data-handler-inl.h
View File

@ -5,6 +5,7 @@
#ifndef V8_OBJECTS_DATA_HANDLER_INL_H_
#define V8_OBJECTS_DATA_HANDLER_INL_H_
#include "src/objects-inl.h" // Needed for write barriers
#include "src/objects/data-handler.h"
// Has to be the last include (doesn't have include guards):
@ -13,12 +14,6 @@
namespace v8 {
namespace internal {
bool HeapObject::IsDataHandler() const {
return IsLoadHandler() || IsStoreHandler();
}
CAST_ACCESSOR(DataHandler)
ACCESSORS(DataHandler, smi_handler, Object, kSmiHandlerOffset)
ACCESSORS(DataHandler, validity_cell, Object, kValidityCellOffset)

6
src/objects/hash-table-inl.h
View File

@ -5,9 +5,13 @@
#ifndef V8_OBJECTS_HASH_TABLE_INL_H_
#define V8_OBJECTS_HASH_TABLE_INL_H_
#include "src/heap/heap.h"
#include "src/objects/hash-table.h"
#include "src/heap/heap.h"
#include "src/objects-inl.h"
#include "src/objects/fixed-array-inl.h"
#include "src/roots-inl.h"
namespace v8 {
namespace internal {

5
tools/generate-header-include-checks.py
View File

@ -61,11 +61,6 @@ AUTO_EXCLUDE = [
'src/lookup.h',
'src/lookup-inl.h',
'src/map-updater.h',
'src/objects/arguments.h',
'src/objects/arguments-inl.h',
'src/objects/compilation-cache-inl.h',
'src/objects/data-handler-inl.h',
'src/objects/hash-table-inl.h',
'src/objects/intl-objects-inl.h',
'src/objects/js-collection.h',
'src/objects/js-collection-inl.h',