From fc04f8ce43c76b90586fa4983af9b9c3b32c95b6 Mon Sep 17 00:00:00 2001 From: Michael Starzinger Date: Mon, 12 Feb 2018 16:36:21 +0100 Subject: [PATCH] [assembler] Remove dead {kNoCodeAgeSequenceLength} constant. R=clemensh@chromium.org Change-Id: Ife4b31e5484314e3e9d51344c446fae4952bbbbf Reviewed-on: https://chromium-review.googlesource.com/913616 Reviewed-by: Clemens Hammacher Commit-Queue: Michael Starzinger Cr-Commit-Position: refs/heads/master@{#51266} --- src/arm/assembler-arm.h | 2 -- src/arm64/assembler-arm64.h | 1 - src/ia32/assembler-ia32-inl.h | 3 --- src/x64/assembler-x64-inl.h | 3 --- src/x64/assembler-x64.h | 3 --- 5 files changed, 12 deletions(-) diff --git a/src/arm/assembler-arm.h b/src/arm/assembler-arm.h index 089e58e0c7..18b9ed57cb 100644 --- a/src/arm/assembler-arm.h +++ b/src/arm/assembler-arm.h @@ -1774,8 +1774,6 @@ class Assembler : public AssemblerBase { std::forward_list heap_object_requests_; }; -constexpr int kNoCodeAgeSequenceLength = 3 * Assembler::kInstrSize; - class EnsureSpace BASE_EMBEDDED { public: INLINE(explicit EnsureSpace(Assembler* assembler)); diff --git a/src/arm64/assembler-arm64.h b/src/arm64/assembler-arm64.h index e0b1ac09c2..069dd1913b 100644 --- a/src/arm64/assembler-arm64.h +++ b/src/arm64/assembler-arm64.h @@ -68,7 +68,6 @@ namespace internal { // clang-format on constexpr int kRegListSizeInBits = sizeof(RegList) * kBitsPerByte; -static const int kNoCodeAgeSequenceLength = 5 * kInstructionSize; const int kNumRegs = kNumberOfRegisters; // Registers x0-x17 are caller-saved. diff --git a/src/ia32/assembler-ia32-inl.h b/src/ia32/assembler-ia32-inl.h index d8b078d17a..a9bdd18846 100644 --- a/src/ia32/assembler-ia32-inl.h +++ b/src/ia32/assembler-ia32-inl.h @@ -50,9 +50,6 @@ bool CpuFeatures::SupportsOptimizer() { return true; } bool CpuFeatures::SupportsWasmSimd128() { return IsSupported(SSE4_1); } -static const byte kCallOpcode = 0xE8; -static const int kNoCodeAgeSequenceLength = 5; - // The modes possibly affected by apply must be in kApplyMask. void RelocInfo::apply(intptr_t delta) { diff --git a/src/x64/assembler-x64-inl.h b/src/x64/assembler-x64-inl.h index b8eec9b59c..7b11c35d25 100644 --- a/src/x64/assembler-x64-inl.h +++ b/src/x64/assembler-x64-inl.h @@ -23,9 +23,6 @@ bool CpuFeatures::SupportsWasmSimd128() { return IsSupported(SSE4_1); } // Implementation of Assembler -static const byte kCallOpcode = 0xE8; - - void Assembler::emitl(uint32_t x) { Memory::uint32_at(pc_) = x; pc_ += sizeof(uint32_t); diff --git a/src/x64/assembler-x64.h b/src/x64/assembler-x64.h index 4224f28e0c..5836376fb2 100644 --- a/src/x64/assembler-x64.h +++ b/src/x64/assembler-x64.h @@ -81,9 +81,6 @@ namespace internal { V(r14) \ V(r15) -// The length of pushq(rbp), movp(rbp, rsp), Push(rsi) and Push(rdi). -constexpr int kNoCodeAgeSequenceLength = kPointerSize == kInt64Size ? 6 : 17; - enum RegisterCode { #define REGISTER_CODE(R) kRegCode_##R, GENERAL_REGISTERS(REGISTER_CODE)