AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

X64 Crankshaft: Fix error in computation of sine and cosine.

Browse Source 
Review URL: http://codereview.chromium.org/6646047

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
whesse@chromium.org 2011-03-10 13:34:23 +00:00
parent 48832819b7
commit fc8f77e398
2 changed files with 17 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/x64/lithium-codegen-x64.cc
View File

@ -2613,7 +2613,7 @@ void LCodeGen::DoMathLog(LUnaryMathOperation* instr) {
void LCodeGen::DoMathCos(LUnaryMathOperation* instr) { void LCodeGen::DoMathCos(LUnaryMathOperation* instr) {
ASSERT(ToDoubleRegister(instr->result()).is(xmm1)); ASSERT(ToDoubleRegister(instr->result()).is(xmm1));
TranscendentalCacheStub stub(TranscendentalCache::LOG, TranscendentalCacheStub stub(TranscendentalCache::COS,
TranscendentalCacheStub::UNTAGGED); TranscendentalCacheStub::UNTAGGED);
CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr); CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr);
} }
@ -2621,7 +2621,7 @@ void LCodeGen::DoMathCos(LUnaryMathOperation* instr) {
void LCodeGen::DoMathSin(LUnaryMathOperation* instr) { void LCodeGen::DoMathSin(LUnaryMathOperation* instr) {
ASSERT(ToDoubleRegister(instr->result()).is(xmm1)); ASSERT(ToDoubleRegister(instr->result()).is(xmm1));
TranscendentalCacheStub stub(TranscendentalCache::LOG, TranscendentalCacheStub stub(TranscendentalCache::SIN,
TranscendentalCacheStub::UNTAGGED); TranscendentalCacheStub::UNTAGGED);
CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr); CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr);
} }

25
test/mjsunit/sin-cos.js
View File

@ -1,4 +1,4 @@
// Copyright 2009 the V8 project authors. All rights reserved. // Copyright 2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without // Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are // modification, are permitted provided that the following conditions are
// met: // met:
@ -27,19 +27,24 @@
// Test Math.sin and Math.cos. // Test Math.sin and Math.cos.
var input_sin = [0, Math.PI / 2]; function sinTest() {
var input_cos = [0, Math.PI]; assertEquals(0, Math.sin(0));
assertEquals(1, Math.sin(Math.PI / 2));
}
var output_sin = input_sin.map(Math.sin); function cosTest() {
var output_cos = input_cos.map(Math.cos); assertEquals(0, Math.cos(1));
assertEquals(-1, Math.cos(Math.PI));
}
var expected_sin = [0, 1]; sinTest();
var expected_cos = [1, -1]; cosTest();
assertArrayEquals(expected_sin, output_sin, "sine");
assertArrayEquals(expected_cos, output_cos, "cosine");
// By accident, the slow case for sine and cosine were both sine at // By accident, the slow case for sine and cosine were both sine at
// some point. This is a regression test for that issue. // some point. This is a regression test for that issue.
var x = Math.pow(2, 70); var x = Math.pow(2, 70);
assertTrue(Math.sin(x) != Math.cos(x)); assertTrue(Math.sin(x) != Math.cos(x));
// Ensure that sine and log are not the same.
x = 0.5;
assertTrue(Math.sin(x) != Math.log(x));