AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[build] Split out v8_flags target

Browse Source 
Moves flags/flags.h and flags/flag-definitions.h out of
v8_internal_headers into a new v8_flags target that can be included by
torque_base to resolve a gn check error.

Bug: v8:7330
Change-Id: I08e3a4475cc4f455077995ddff8683266ed51cd9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727819
Commit-Queue: Dan Elphick <delphick@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73110}
This commit is contained in:
Dan Elphick 2021-03-01 19:02:11 +00:00 committed by Commit Bot
parent c687bee8f3
commit fcf29e4815
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
BUILD.gn
View File

@ -2178,6 +2178,19 @@ v8_header_set("v8_shared_internal_headers") {
]
}
v8_header_set("v8_flags") {
visibility = [ ":*" ]
configs = [ ":internal_config" ]
sources = [
"src/flags/flag-definitions.h",
"src/flags/flags.h",
]
deps = [ ":v8_shared_internal_headers" ]
}
v8_header_set("v8_internal_headers") {
configs = [ ":internal_config" ]
@ -2465,8 +2478,6 @@ v8_header_set("v8_internal_headers") {
"src/extensions/ignition-statistics-extension.h",
"src/extensions/statistics-extension.h",
"src/extensions/trigger-failure-extension.h",
"src/flags/flag-definitions.h",
"src/flags/flags.h",
"src/handles/global-handles.h",
"src/handles/handles-inl.h",
"src/handles/handles.h",
@ -3238,6 +3249,7 @@ v8_header_set("v8_internal_headers") {
public_deps = [
":torque_runtime_support",
":v8_flags",
":v8_headers",
":v8_maybe_icu",
":v8_shared_internal_headers",
@ -4314,7 +4326,10 @@ v8_source_set("torque_base") {
"src/torque/utils.h",
]
deps = [ ":v8_shared_internal_headers" ]
deps = [
":v8_flags",
":v8_shared_internal_headers",
]
public_deps = [ ":v8_libbase" ]