AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Enable embedded builtins on two bots

Browse Source 
Since embedded builtins will be disabled by default until after the
M67 branch point, let's enable them on two specific bots to at least
have some continued coverage.

release_x64_internal is a release build (with an internal snapshot).
release_x64_verify_csa is a pseudo-debug build with DEBUG set.

Bug: v8:6666
Change-Id: I7e81c24e3cefc6eeba5d6e5823d47ab52f3e5941
Reviewed-on: https://chromium-review.googlesource.com/983597
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52274}
This commit is contained in:
jgruber 2018-03-28 14:20:45 +02:00 committed by Commit Bot
parent b27ee43a0f
commit fd059bc440
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
infra/mb/mb_config.pyl
View File

@ -415,7 +415,8 @@
'release_x64_gcc_coverage': [
'release_bot', 'x64', 'coverage', 'gcc'],
'release_x64_internal': [
'release_bot', 'x64', 'v8_snapshot_internal'],
'release_bot', 'x64', 'v8_enable_embedded_builtins',
'v8_snapshot_internal'],
'release_x64_jumbo': [
'release_bot', 'x64', 'jumbo'],
'release_x64_jumbo_trybot': [
@ -445,7 +446,7 @@
'release_bot', 'x64', 'ubsan_vptr', 'minimal_symbols'],
'release_x64_verify_csa': [
'release_bot', 'x64', 'dcheck_always_on',
'v8_enable_slow_dchecks', 'v8_verify_csa'],
'v8_enable_slow_dchecks', 'v8_enable_embedded_builtins', 'v8_verify_csa'],
# Debug configs for x64.
'debug_x64': [
@ -752,6 +753,10 @@
'gn_args': 'v8_enable_disassembler=true',
},
'v8_enable_embedded_builtins': {
'gn_args': 'v8_enable_embedded_builtins=true',
},
'v8_enable_slow_dchecks': {
'gn_args': 'v8_enable_slow_dchecks=true',
},