Disable ParserSync test for now, it takes waaaaay too long.
Running this in x64.release mode on a powerful HP620 takes 4 seconds, this is at least 2 orders of magnitude too slow and leads to tons of false positives on our build bots due to timeouts. As it is, the cost-benefit ratio is far too low. The whole approach needs to be changed: Instead of trying to exhaust some search space in unit tests, this should be turned into a fuzzing test where only a small but random number of things are tested. The exhaustive approach can be done separately, but definitely not in the unit tests. BUG=v8:3707 Review URL: https://codereview.chromium.org/762743002 Cr-Commit-Position: refs/heads/master@{#25510}
This commit is contained in:
parent
83a635e0d7
commit
fd13969ef0
@ -1509,7 +1509,9 @@ void TestParserSync(const char* source,
|
||||
}
|
||||
|
||||
|
||||
TEST(ParserSync) {
|
||||
// TODO(marja) This needs to be turned into a fuzzing test, trying all those
|
||||
// combinations below takes at least 2 orders of magnitude too long.
|
||||
DISABLED_TEST(ParserSync) {
|
||||
const char* context_data[][2] = {
|
||||
{ "", "" },
|
||||
{ "{", "}" },
|
||||
|
Loading…
Reference in New Issue
Block a user