AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "Add debug output to presubmit script for investigating tree check behavior." and "Add more temporary debugging output to PRESUBMIT.py".

Browse Source 
This reverts commits r18538 and r18528, since the investigated problem was found.

BUG=
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/133993002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
machenbach@chromium.org 2014-01-10 15:17:49 +00:00
parent d849dfa5d4
commit fe69172e4b
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
PRESUBMIT.py
View File

@ -61,15 +61,11 @@ def _CommonChecks(input_api, output_api):
def _SkipTreeCheck(input_api, output_api):
"""Check the env var whether we want to skip tree check.
Only skip if src/version.cc has been updated."""
print "skip tree check?", input_api.environ.get('PRESUBMIT_TREE_CHECK')
src_version = 'src/version.cc'
def FilterFile(file):
print "Changed file:", file.LocalPath()
return file.LocalPath() == src_version
if not input_api.AffectedSourceFiles(FilterFile):
FilterFile = lambda file: file.LocalPath() == src_version
if not input_api.AffectedSourceFiles(
lambda file: file.LocalPath() == src_version):
return False
if input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip':
print "Skip tree check requested via environment variable."
return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip'
@ -98,7 +94,6 @@ def CheckChangeOnCommit(input_api, output_api):
results.extend(input_api.canned_checks.CheckChangeHasDescription(
input_api, output_api))
if not _SkipTreeCheck(input_api, output_api):
print "Checking if tree is open."
results.extend(input_api.canned_checks.CheckTreeIsOpen(
input_api, output_api,
json_url='http://v8-status.appspot.com/current?format=json'))