From fe728e52b46290be7a5ee0c32dabfb5d0a56f7fb Mon Sep 17 00:00:00 2001 From: bgeron Date: Mon, 25 Jul 2016 02:49:52 -0700 Subject: [PATCH] [turbolizer] Fix a latent bug when dragging a node under another node. BUG= R=danno Review-Url: https://codereview.chromium.org/2169023002 Cr-Commit-Position: refs/heads/master@{#38004} --- tools/turbolizer/graph-view.js | 34 +++++++++------------------------- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/tools/turbolizer/graph-view.js b/tools/turbolizer/graph-view.js index 2baad783c1..a53a0e0b4f 100644 --- a/tools/turbolizer/graph-view.js +++ b/tools/turbolizer/graph-view.js @@ -469,33 +469,17 @@ class GraphView extends View { if (!mouseDownNode) return; - if (mouseDownNode !== d){ - // we're in a different node: create new edge for mousedown edge and add to graph - var newEdge = {source: mouseDownNode, target: d}; - var filtRes = graph.visibleEdges.filter(function(d){ - if (d.source === newEdge.target && d.target === newEdge.source){ - graph.edges.splice(graph.edges.indexOf(d), 1); - } - return d.source === newEdge.source && d.target === newEdge.target; - }); - if (!filtRes[0].length){ - graph.edges.push(newEdge); - graph.updateGraphVisibility(); - } + if (state.justDragged) { + // dragged, not clicked + state.justDragged = false; } else{ - // we're in the same node - if (state.justDragged) { - // dragged, not clicked - state.justDragged = false; - } else{ - // clicked, not dragged - var extend = d3.event.shiftKey; - var selection = graph.state.selection; - if (!extend) { - selection.clear(); - } - selection.select(d3node[0][0], true); + // clicked, not dragged + var extend = d3.event.shiftKey; + var selection = graph.state.selection; + if (!extend) { + selection.clear(); } + selection.select(d3node[0][0], true); } }