AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[api] Advance deprecations in EmbedderHeapTracer

Browse Source 
Change-Id: I0751c1761a2d07dd89d831ca6370ae01bc569b6a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1841351
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64116}
This commit is contained in:
Michael Lippautz 2019-10-04 20:00:38 +02:00 committed by Commit Bot
parent a1e73fd6af
commit fe78dd71a7
3 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/v8.h
View File

@ -7508,8 +7508,7 @@ class V8_EXPORT EmbedderHeapTracer {
/**
* Called at the beginning of a GC cycle.
*/
V8_DEPRECATED("Use version with flags.", virtual void TracePrologue()) {}
virtual void TracePrologue(TraceFlags flags);
virtual void TracePrologue(TraceFlags flags) {}
/**
* Called to advance tracing in the embedder.
@ -7536,8 +7535,7 @@ class V8_EXPORT EmbedderHeapTracer {
* overriden to fill a |TraceSummary| that is used by V8 to schedule future
* garbage collections.
*/
V8_DEPRECATE_SOON("Use version with parameter.",
virtual void TraceEpilogue()) {}
V8_DEPRECATED("Use version with parameter.", virtual void TraceEpilogue()) {}
virtual void TraceEpilogue(TraceSummary* trace_summary);
/**

11
src/api/api.cc
View File

@ -10534,17 +10534,6 @@ void Testing::DeoptimizeAll(Isolate* isolate) {
i::Deoptimizer::DeoptimizeAll(i_isolate);
}
void EmbedderHeapTracer::TracePrologue(TraceFlags flags) {
#if __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated"
#endif
TracePrologue();
#if __clang__
#pragma clang diagnostic pop
#endif
}
void EmbedderHeapTracer::TraceEpilogue(TraceSummary* trace_summary) {
#if __clang__
#pragma clang diagnostic push

2
test/cctest/test-global-handles.cc
View File

@ -49,7 +49,7 @@ class NonRootingEmbedderHeapTracer final : public v8::EmbedderHeapTracer {
const std::vector<std::pair<void*, void*>>& embedder_fields) final {}
bool AdvanceTracing(double deadline_in_ms) final { return true; }
bool IsTracingDone() final { return true; }
void TracePrologue() final {}
void TracePrologue(TraceFlags) final {}
void TraceEpilogue() final {}
void EnterFinalPause(EmbedderStackState) final {}