AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Reset inlining limits due to overly long compilation times in Speedometer, Dart2JS

Browse Source 
BUG=454625
LOG=y

Review URL: https://codereview.chromium.org/900553003

Cr-Commit-Position: refs/heads/master@{#26405}
This commit is contained in:
verwaest 2015-02-03 07:02:43 -08:00 committed by Commit bot
parent d8cfbc633d
commit fea7ddb640
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/flag-definitions.h
View File

@ -286,11 +286,11 @@ DEFINE_BOOL(use_local_allocation_folding, false, "only fold in basic blocks")
DEFINE_BOOL(use_write_barrier_elimination, true,
"eliminate write barriers targeting allocations in optimized code")
DEFINE_INT(max_inlining_levels, 5, "maximum number of inlining levels")
DEFINE_INT(max_inlined_source_size, 1150,
DEFINE_INT(max_inlined_source_size, 600,
"maximum source size in bytes considered for a single inlining")
DEFINE_INT(max_inlined_nodes, 200,
DEFINE_INT(max_inlined_nodes, 196,
"maximum number of AST nodes considered for a single inlining")
DEFINE_INT(max_inlined_nodes_cumulative, 3000,
DEFINE_INT(max_inlined_nodes_cumulative, 400,
"maximum cumulative number of AST nodes considered for inlining")
DEFINE_BOOL(loop_invariant_code_motion, true, "loop invariant code motion")
DEFINE_BOOL(fast_math, true, "faster (but maybe less accurate) math functions")

4
src/hydrogen.cc
View File

@ -7885,7 +7885,9 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,
}
// We don't want to add more than a certain number of nodes from inlining.
if (inlined_count_ > Min(FLAG_max_inlined_nodes_cumulative,
// Always inline small methods (<= 10 nodes).
if (nodes_added > 10 &&
inlined_count_ > Min(FLAG_max_inlined_nodes_cumulative,
kUnlimitedMaxInlinedNodesCumulative)) {
TraceInline(target, caller, "cumulative AST node limit reached");
return false;