Commit Graph

44 Commits

Author SHA1 Message Date
Omer Katz
301baa5584 cppgc: Report cppgc changes to oilpan-reviews@chromium.org
Bug: chromium:1056170
Change-Id: Ie639dd00fa146fa1ea166c282cbdead329604922
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3129423
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76579}
2021-08-30 14:28:32 +00:00
Ross McIlroy
13f6c055c7 Remove rmcilroy from OWNERS.
Change-Id: I32fc41124c6c16efe1150d60e72dc2bba90782c7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3106745
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76396}
2021-08-19 16:30:27 +00:00
Camillo Bruni
0fe0ee21ad Reland "[watchlist] Add cbruni@ to api watchlist"
This is a reland of 9287befeea

- Add missing commas for api group
- Add trailing commas for existing lists

Original change's description:
> [watchlist] Add cbruni@ to api watchlist
>
> - Remove unused ia32 watchlist group
> - Add api watchlist group
>
> Change-Id: Ia64d2368de54a846ce548a66eef7e96ee5579a3a
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3084365
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#76189}

Change-Id: Idb2a09e1b55bb3ad9aed0d8f0c37f48dfef28ec0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3085263
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#76200}
2021-08-10 13:51:49 +00:00
Jakob Gruber
f06ef2c3dd Revert "[watchlist] Add cbruni@ to api watchlist"
This reverts commit 9287befeea.

Reason for revert: Invalid syntax at line 39

Original change's description:
> [watchlist] Add cbruni@ to api watchlist
>
> - Remove unused ia32 watchlist group
> - Add api watchlist group
>
> Change-Id: Ia64d2368de54a846ce548a66eef7e96ee5579a3a
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3084365
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#76189}

Change-Id: Ib53139c5b72d5715348f61397cd4e8427397fdef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3085261
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#76193}
2021-08-10 10:33:20 +00:00
Camillo Bruni
9287befeea [watchlist] Add cbruni@ to api watchlist
- Remove unused ia32 watchlist group
- Add api watchlist group

Change-Id: Ia64d2368de54a846ce548a66eef7e96ee5579a3a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3084365
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#76189}
2021-08-10 09:37:59 +00:00
Victor Gomes
a6cc119c92 [bazel] Add bazel files to watchlist
Bug: v8:11234
Change-Id: I6b3d3a72ad272b8b98e58c0de02b6a9b3dcfb5a8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2967466
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75205}
2021-06-17 09:26:11 +00:00
Marja Hölttä
663eec3a12 [WATCHLISTS] Add a watchlist for regexp
Drive-by fix: The file name for WATCHLISTS in the OWNERS file rule was
wrong, so fixing that too so that it's possible to modify WATCHLISTS
without eng reviewers approval in the future.

Change-Id: I0e24c5d459aab2bb346aca64125eabe0ceac8274
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2903154
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Patrick Thier <pthier@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74644}
2021-05-18 19:00:57 +00:00
Leszek Swirski
cc6228c43a [watchlist] Add leszeks to src/baseline watchlist
Change-Id: I983d3c0a14238aeaa017f083b5df30668f6670e1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848472
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74207}
2021-04-27 08:40:24 +00:00
Caleb Raitto
9cc240fecd Add a watchlist for ieee754.(cc|h) changes.
We're making a copy of ieee754.(cc|h) in Chromium in
crrev.com/c/2582607. To ensure this copy stays in sync, we're adding a
watchlist for changes on the original ieee754.(cc|h).

Also, watch for changes in dependency of ieee754.(cc|h)
overflowing-math.h, and for changes in the licenses (LICENSE.fdlibm).

Bug: chromium:1145192
Change-Id: I5a967266c8b5c5c973afc48d9b453915f228a268
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2593649
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72015}
2021-01-11 18:10:19 +00:00
Yang Guo
b09c18295b Stop watching for API changes in WATCHLISTS
TBR=verwaest@chromium.org

Change-Id: If18d402f9b0b9c500307fd454eafe93de701599c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141731
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67048}
2020-04-08 07:06:45 +00:00
Adam Klein
14b5b2ad82 Remove myself from WATCHLISTS
I'm not actively reviewing parser or API changes these days, so these
watchlists aren't really helping anyone.

Change-Id: I7babfeabf0f2bff914e7ab03d1f875e57a10ce47
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2008399
Auto-Submit: Adam Klein <adamk@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65855}
2020-01-18 00:34:32 +00:00
Yang Guo
71526bb021 Remove 'profiler' category from WATCHLISTS
R=bmeurer@chromium.org

Change-Id: Ia76369623c767fbbc249d1d77643d63062f99487
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870231
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64405}
2019-10-21 08:23:59 +00:00
Yang Guo
b603c65585 Set up WATCHLIST for DevTools related changes
Change-Id: I66699c48eaa9a2cae8290a0240fb359f6367e325
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1861855
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64370}
2019-10-18 07:02:23 +00:00
Yang Guo
f9a88acbc9 Move remaining files in src/
TBR=mvstanton@chromium.org,neis@chromium.org,ahaas@chromium.org

Bug: v8:9247
Change-Id: I5433c863a54f3412d73df0d38aba3fdbcfac7ebe
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627973
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61830}
2019-05-24 18:24:36 +00:00
Yang Guo
a6eeea35cb Move code generation related files to src/codegen
Bug: v8:9247

TBR=bmeurer@chromium.org,neis@chromium.org
NOPRESUBMIT=true

Change-Id: Ia1e49d1aac09c4ff9e05d58fab9d08dd71198878
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621931
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61682}
2019-05-21 10:33:39 +00:00
Yang Guo
5fc7356c50 Update WATCHLIST wrt yangguo
R=jgruber@chromium.org

Change-Id: I49c08217d0c8e452afe84ad76ae6d60367802e82
Reviewed-on: https://chromium-review.googlesource.com/c/1348075
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57762}
2018-11-23 08:29:12 +00:00
Jakob Gruber
ea39a98109 [watchlist] Add csa and torque watchlists and add myself
Change-Id: Ia30702060cdcd63a3b429e05e700928a32824604
Reviewed-on: https://chromium-review.googlesource.com/c/1328944
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57526}
2018-11-15 10:01:08 +00:00
Alexei Filippov
4b2282b316 Add myself to the watch list.
Change-Id: Iefd58de58d5aaa9ac30f87dba249f7a123ede0bd
Reviewed-on: https://chromium-review.googlesource.com/c/1292685
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56867}
2018-10-22 16:20:40 +00:00
Adam Klein
272a9944fd Make my watchlists easier to filter
Tbr: gsathya@chromium.org
Change-Id: I293e5eb686e2ba92386efb908d3437b2afdd152d
Reviewed-on: https://chromium-review.googlesource.com/1196683
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55533}
2018-08-30 15:28:02 +00:00
Adam Klein
3669c00e7e Remove v8-x87-ports@ from WATCHLIST
The x87 port itself has been gone for awhile.

Bug: v8:7310
Change-Id: I1c938ba93720af361733f2c09dc5f128173b5675
Reviewed-on: https://chromium-review.googlesource.com/935198
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51581}
2018-02-26 19:56:21 +00:00
Yang Guo
2c8663aa1a [gyp] remove gyp files.
R=machenbach@chromium.org

Bug: v8:7335
Change-Id: Ied1101295fc9ee37fcc038b9aeb557229722df0b
Reviewed-on: https://chromium-review.googlesource.com/897566
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51185}
2018-02-08 20:04:06 +00:00
Adam Klein
fbb008a6c9 Add adamk to a few WATCHLISTS
And add a watchlist for the C++ API.

Change-Id: Id82d7191153afe701fc11958ba36ce7a8b29bef2
Reviewed-on: https://chromium-review.googlesource.com/764548
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49309}
2017-11-10 21:38:29 +00:00
lpy
66d242dea5 [V8Tracing] Add lpy@ and fmeawad@ into watchlist for tracing/.
TBR=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2898043002
Cr-Commit-Position: refs/heads/master@{#45469}
2017-05-22 19:40:17 +00:00
Marja Hölttä
cedc6ccf61 [watchlists] Added parser watchlist.
Bug: 
Change-Id: I335a793d28697092c89e588c456f2689e689c841
Reviewed-on: https://chromium-review.googlesource.com/494054
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45060}
2017-05-03 12:30:13 +00:00
ulan
3737501075 Remove ulan@ from heap watchlist.
NOTRY=true

Review-Url: https://codereview.chromium.org/2843393002
Cr-Commit-Position: refs/heads/master@{#44920}
2017-04-27 09:36:43 +00:00
jbroman
1b0bd5fde2 Add jbroman to WATCHLISTS for src/value-serializer.*.
NOTRY=true

Review-Url: https://codereview.chromium.org/2782463002
Cr-Commit-Position: refs/heads/master@{#44190}
2017-03-28 12:51:29 +00:00
mtrofin
25f86ffea5 [wasm] wasm WATCHLISTS
Improve visibility within the distributed wasm team.
Created wasm watchlist, and added wasm-team - the union of
MUC and MTV wasm teams.

BUG=

Review-Url: https://codereview.chromium.org/2759053002
Cr-Commit-Position: refs/heads/master@{#43959}
2017-03-21 02:49:39 +00:00
kozyatinskiy
497af7fca5 [inspector] added devtools-reviews@chromium.org in WATCHLISTS for inspector
BUG=chromium:635948
R=dgozman@chromium.org,jochen@chromium.org

Review-Url: https://codereview.chromium.org/2373983003
Cr-Commit-Position: refs/heads/master@{#39877}
2016-09-29 15:16:54 +00:00
oth
fc6a0c940c Remove oth from v8 WATCHLISTS file.
TBR=rmcilroy@chromium.org
BUG=NONE

Review-Url: https://codereview.chromium.org/2290633004
Cr-Commit-Position: refs/heads/master@{#38997}
2016-08-30 08:32:33 +00:00
phajdan.jr
c13c62695b Remove myself from v8 WATCHLISTS
TBR=jochen

BUG=none

Review-Url: https://codereview.chromium.org/2124483002
Cr-Commit-Position: refs/heads/master@{#37503}
2016-07-04 14:45:04 +00:00
machenbach
ef3304ba1d [GN] Watchlist upadate to track gyp changes.
BUG=chromium:474921
LOG=n
NOTRY=true
TBR=vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/1980313002
Cr-Commit-Position: refs/heads/master@{#36271}
2016-05-17 08:14:26 +00:00
machenbach
cb855fe728 [build] Prepare moving v8.gyp to src/
This will allow to pull in gyp as a deps to the same location
as chromium (tools/gyp not build/gyp), needed for gn switch.

This is the first step of a 3-way move.
1) Copy v8.gyp in v8
2) Update references in embedders (follow up)
3) Remove old v8.gyp (follow up)

BUG=chromium:474921
LOG=n
NOTRY=true

Review URL: https://codereview.chromium.org/1920793002

Cr-Commit-Position: refs/heads/master@{#35760}
2016-04-25 12:20:24 +00:00
rmcilroy
d1c28849c7 [Interpreter] Make InterpreterAssembler a subclass of CodeStubAssembler.
Moves InterpreterAssembler out of the compiler directory and into the
interpreter directory. Makes InterpreterAssembler as subclass of
CodeStubAssembler.

As part of this change, the special bytecode dispatch linkage type
is removed and instead we use a InterfaceDispatchDescriptor and
a normal CodeStub linkage type.

Removes a bunch of duplicated logic in InterpreterAssembler and
instead uses the CodeStubAssembler logic. Refactors Interpreter
with these changes.

Modifies CodeStubAssembler to add the extra operations required
by the Interpreter (extra call types, raw memory access and some extra
binary ops). Also adds the ability for subclasses to add extra
prologue and epilogue operations around calls, which is required
for the Interpreter.

BUG=v8:4280
LOG=N

Review URL: https://codereview.chromium.org/1673333004

Cr-Commit-Position: refs/heads/master@{#33873}
2016-02-10 16:39:32 +00:00
hablich
ccf47c4d30 [Release] Automatically notify mailing list on a pending merge
With the combination of the WATCHLISTS feature and
create_release.py it is possible to notify the
mailing list v8-merges@googlegroups.com on pending
merges.

On master this notification is deactivated.

R=machenbach@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1663003003

Cr-Commit-Position: refs/heads/master@{#33719}
2016-02-04 09:03:13 +00:00
rmcilroy
df1964a08e [WATCHLIST] Add BytecodeGraphBuilder and InterpreterAssembler to interpreter watchlist.
Review URL: https://codereview.chromium.org/1657683002

Cr-Commit-Position: refs/heads/master@{#33663}
2016-02-02 09:40:34 +00:00
jkummerow
009b351427 [WATCHLISTS] CC v8-$arch-ports automatically on platform-specific CLs
Automate ALL the repetitive workflows!

Drive-by: fix 'interpreter' watchlist definition.

NOTRY=true

Review URL: https://codereview.chromium.org/1589633007

Cr-Commit-Position: refs/heads/master@{#33383}
2016-01-19 09:18:41 +00:00
hablich
424b246bce [Release] CC hpayer@ and ulan@ to every heap change
NOTRY=true
TBR=hpayer@chromium.org, ulan@chromium.org

Review URL: https://codereview.chromium.org/1490263002

Cr-Commit-Position: refs/heads/master@{#32510}
2015-12-02 12:49:50 +00:00
rmcilroy
83bb51e5ad Add an interpreter watchlist
Review URL: https://codereview.chromium.org/1413663007

Cr-Commit-Position: refs/heads/master@{#31528}
2015-10-23 15:43:37 +00:00
hablich
6ead2bd8a1 [Release] Add hablich to autocc for staging/shipping features
LOG=N
R=machenbach@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1415533004

Cr-Commit-Position: refs/heads/master@{#31368}
2015-10-19 11:35:03 +00:00
yangguo
1667c15e37 Debugger: move implementation to a separate folder.
R=cbruni@chromium.org

Review URL: https://codereview.chromium.org/1265923002

Cr-Commit-Position: refs/heads/master@{#29951}
2015-07-31 11:08:15 +00:00
hablich
0bb460150d Removing hablich from auto CC of x87
R=machenbach@chromium.org
BUG=v8:4135
NOTRY=true
LOG=N

Review URL: https://codereview.chromium.org/1217993002

Cr-Commit-Position: refs/heads/master@{#29375}
2015-06-30 11:29:57 +00:00
hablich
daaedddf7b Temporary auto-CC'ing hablich to x87 changes
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/1157993003

Cr-Commit-Position: refs/heads/master@{#28627}
2015-05-26 13:05:32 +00:00
yangguo
3068b5ff83 Add yangguo@chromium.org to src/snapshot/OWNERS and WATCHLISTS
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/1060683003

Cr-Commit-Position: refs/heads/master@{#27629}
2015-04-07 13:38:29 +00:00
jkummerow@chromium.org
cf1257d2be Add myself to a watchlist for the public API.
See https://groups.google.com/d/msg/v8-users/jq8k9s4xEu8/N-es0or3uz4J

BUG=none
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/26574009

Patch from Paweł Hajdan Jr. <phajdan.jr@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17134 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-10 11:37:48 +00:00