rossberg@chromium.org
19d716989e
Unify handling of position info in AST, part 1
...
* AstNode now has a position info.
* Removed various ad-hoc position infos from subclasses (most of which had it).
* Position is always set with the constructor, instead of later.
* Take care to use kNoPosition in the right spots, to not crash the debugger.
Still to do:
* Eliminate Conditional::then/else_position and WhileStatement::condition_position.
* Make CaseClause a proper AstNode and eliminate its custom position.
* If possible, eliminate all uses of kNoPosition.
R=yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24076007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-14 09:24:58 +00:00
cira@chromium.org
c0ff0b284d
Original review https://codereview.chromium.org/25855005 .
...
Reverting reverted r17148 and fixing build (test) breakage by side stepping the Windows vs. Linux issue of different Date object for the same millisecond time stamp.
We do that by using UTC Date methods (they eliminate DST problems).
Windows:
new Date(129193200000);
Sun Feb 03 1974 23:00:00 GMT-0800 (Pacific Standard Time)
Linux:
new Date(129193200000);
Mon Feb 04 1974 00:00:00 GMT-0700 (PST)
BUG=2919
R=dslomov@chromium.org , mnita@google.com
Review URL: https://codereview.chromium.org/26918002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-11 17:54:31 +00:00
danno@chromium.org
f55fc759dc
Revert 17167: "Ensure lower <= upper bound"
...
Due to crashes in nosnap ia32
TBR=rossberg@chromium.org
Review URL: https://codereview.chromium.org/27046002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17170 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-11 16:41:34 +00:00
danno@chromium.org
4d67b70ea4
Adding Cira & Mihai to OWNERS for internationalization (i18n)
...
Keeping the names together so that I can put one comment for both.
Might also sort alphabetically, with the comment after each email.
Not sure what option was best, I have seen it done both ways.
R=cira@chromium.org , danno@chromium.org
Review URL: https://codereview.chromium.org/26534002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17168 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-11 15:24:45 +00:00
rossberg@chromium.org
68cc8da20c
Ensure lower <= upper bound
...
R=jkummerow@chromium.org
BUG=
Review URL: https://codereview.chromium.org/26959004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17167 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-11 15:17:58 +00:00
olivf@chromium.org
93d4fbd2ee
Truncate booleans to 0/1 in truncating t-to-i.
...
Thanks to weiliang.lin2@gmail.com for discovering the issue.
BUG=
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/26824002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17166 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-11 15:13:12 +00:00
mstarzinger@chromium.org
f878c1c359
Fix pre-parsing of 'use strict' directive after string literals.
...
R=ulan@chromium.org
TEST=mjsunit/regress/regress-parse-use-strict
Review URL: https://codereview.chromium.org/27025002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17164 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-11 14:03:54 +00:00
rossberg@chromium.org
b9d639cd9d
Minor tweaks to types cctest
...
R=verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/26223006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17163 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-11 13:59:01 +00:00
bmeurer@chromium.org
2c631933d5
Load/Store cannot handle double representation.
...
Assert that the representation for Load/Store in the X64 MacroAssembler
is never Double. Also add missing test case for the Load/Store macros.
TEST=cctest/test-macro-assembler-x64
R=mvstanton@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=17135
Review URL: https://codereview.chromium.org/25990002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17151 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-11 07:12:06 +00:00
dslomov@chromium.org
0610773db7
Revert "Fixing timezone issues with date-time/parse-* tests."
...
This reverts commit r17148 for breaking tests on Windows.
TBR=cira@google.com ,titzer@chromium.org
Review URL: https://codereview.chromium.org/26467005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17149 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-10 19:43:05 +00:00
cira@chromium.org
2986f94c14
Fixing timezone issues with date-time/parse-* tests.
...
BUG=2919
TEST=All tests passing when local timezone was set to EST.
R=mnita@google.com , titzer@chromium.org
Review URL: https://codereview.chromium.org/25855005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-10 17:54:33 +00:00
olivf@chromium.org
4b6d0e33f2
Only set binary operation side effects flags, when observable.
...
BUG=
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/26712002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17147 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-10 16:49:25 +00:00
yurys@chromium.org
344d836d0f
Add column getter to CpuProfileNode
...
CpuProfileNode currently exposes only line number which is not enough for the cases when there is more than one function on the same line. This change exposes column number on CpuProfileNode.
BUG=302537
R=jkummerow@chromium.org , loislo@chromium.org
Review URL: https://codereview.chromium.org/25541003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17142 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-10 13:15:47 +00:00
yurys@chromium.org
3228e953f9
Unflake cctest/test-cpu-profiler/JsNativeJsRuntimeJsSample on Win32 Debug
...
Profiler is now started from JavaScript. Since we always capture stack trace when starting profiler there should always be at least one expected sample in the profile.
Also changed ProfilerEventsProcessor::AddCurrentStack to make sure it call TickSample::Init to instead of custom initialization code.
BUG=v8:2920
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/25686011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17140 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-10 13:03:41 +00:00
rossberg@chromium.org
3c01f30e3f
Revert "Load/Store cannot handle double representation."
...
This reverts r17135 -- test crashes on x64.
TBR=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/26653004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17138 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-10 12:28:52 +00:00
mstarzinger@chromium.org
63d8abb6c6
Unify and fix checkers for duplicate object literal properties.
...
R=ulan@chromium.org
TEST=preparser/duplicate-property,mjsunit/regress/regress-parse-object-literal
Review URL: https://codereview.chromium.org/26375004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17136 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-10 11:58:16 +00:00
bmeurer@chromium.org
ef8dc50e55
Load/Store cannot handle double representation.
...
Assert that the representation for Load/Store in the X64 MacroAssembler
is never Double. Also add missing test case for the Load/Store macros.
TEST=cctest/test-macro-assembler-x64
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/25990002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17135 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-10 11:42:00 +00:00
mvstanton@chromium.org
59c8d36c00
Revert "Debug: Allow stepping into on a given call frame."
...
This reverts commit r17095.
There were test failures (flaky).
BUG=chromium:296963
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/26703009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17125 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-10 09:05:28 +00:00
mvstanton@chromium.org
fc95207750
Revert "Unify and fix checkers for duplicate object literal properties."
...
This reverts commit 12c68518bd2c74dc4e44d928c84c17f98ca63359.
(r17114)
R=mstarzinger@chromium.org
TBR=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/26732006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17122 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-10 08:45:19 +00:00
dslomov@chromium.org
380d0ca582
Implement ArrayBuffer.isView.
...
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/25700010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17121 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-10 08:36:44 +00:00
mstarzinger@chromium.org
067a266426
Unify and fix checkers for duplicate object literal properties.
...
R=ulan@chromium.org
TEST=preparser/duplicate-property
Review URL: https://codereview.chromium.org/25755002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17114 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-04 16:58:01 +00:00
mstarzinger@chromium.org
3c8e87d840
Remove obsolete preparser binary.
...
R=danno@chromium.org
Review URL: https://codereview.chromium.org/25277003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17113 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-04 16:21:23 +00:00
bmeurer@chromium.org
a9d8970bf6
Fix SmiMove unit test.
...
TEST=cctest/test-macro-assembler-x64.cc
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/25426006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17101 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-04 07:21:31 +00:00
yurys@chromium.org
ce61a704e3
Debug: Allow stepping into on a given call frame.
...
BUG=chromium:296963
R=yangguo@chromium.org , yurys
Review URL: https://codereview.chromium.org/25605005
Patch from Andrey Adaikin <aandrey@chromium.org>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17095 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-03 07:42:44 +00:00
olivf@chromium.org
24c2336d75
Inline some more compare operations.
...
BUG=
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/25009003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17091 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-02 18:15:57 +00:00
adamk@chromium.org
e5f2d0f7bd
Avoid allocations in Object.observe access check tests
...
BUG=v8:2907
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/24999007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17090 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-02 18:06:20 +00:00
bmeurer@chromium.org
81e4550796
Always use timeGetTime() for TimeTicks::Now() on Windows.
...
This way, we also ensure that timeGetTime() is used for Time::Now(),
and thereby Date.now() even if GetTickCount64() is available.
Also add test coverage for Time::Now(), TimeTicks::Now() and
TimeTicks::HighResNow().
BUG=chromium:288924
TEST=cctest/test-timer
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/25468003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17080 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-02 13:30:31 +00:00
verwaest@chromium.org
7e0ea6ab46
Only fold polymorphic into monomorphic load if all load from either receiver or same prototype.
...
R=jkummerow@chromium.org
Review URL: https://chromiumcodereview.appspot.com/25718002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17078 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-02 13:24:08 +00:00
haitao.feng@intel.com
7fc8679c4e
Tweak SmiAdd for X64
...
R=danno@chromium.org
Review URL: https://codereview.chromium.org/24754002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17074 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-02 11:46:01 +00:00
yurys@chromium.org
b3c440f8da
Fix threading problems in test-api when running on simulator
...
Sampler can retrieve current simulator for profiled isolate from its ThreadLocalTop without calls to Isolate::FindPerThreadDataForThread which sometimes leads to acquring same mutex second time.
BUG=v8:2874
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/25053002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17047 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-01 13:54:53 +00:00
dcarney@chromium.org
7fae9959e9
remove Isolate::Current from ScriptData and Script
...
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/25037002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17041 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-01 09:56:04 +00:00
mstarzinger@chromium.org
191bcf20cc
Limit entry points into the parser API.
...
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/24104006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17033 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-01 09:27:03 +00:00
dcarney@chromium.org
6dd72b6416
change of V8_DEPRECATED to be enabled behind a gyp flag
...
also add a deprecation message for newer gcc versions
R=danno@chromium.org
BUG=
Review URL: https://codereview.chromium.org/25226002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17006 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-30 13:28:23 +00:00
mstarzinger@chromium.org
f03dbcff94
Function::Call and Object::CallAsFunction APIs should allow v8::Value as a receiver
...
Since the primitive values can be a receiver of strict mode functions in
ECMA262 5.1th, v8::Function::Call and Object::CallAsFunction should take
v8::Value as a receiver instead of v8::Object.
BUG=v8:2915
TEST=cctest/test-api
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/24920003
Patch from Yusuke Suzuki <yusukesuzuki@chromium.org>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17003 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-30 11:47:36 +00:00
mvstanton@chromium.org
81557f21fc
Use a walking visitor to traverse JSObject structure. The purpose is to prepare for more complex context-dependent walks of the structure, needed for allocation site and pretenuring work. Different visitors can be created that annotate the object in various ways.
...
BUG=
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/25025002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17001 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-30 11:36:50 +00:00
dcarney@chromium.org
b81c581b38
make v8::Locker not use Isolate::GetCurrent()
...
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/25002004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16988 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-27 11:32:13 +00:00
hpayer@chromium.org
8f60f65bdf
Disable gc stress mode for mjsunit timer test.
...
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/24979002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16984 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-27 11:04:16 +00:00
dcarney@chromium.org
7fcd0f395e
remove Local::New with no isolate parameter
...
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24550006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16972 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-27 07:04:02 +00:00
titzer@chromium.org
d441160cab
Implement local check elimination on basic blocks.
...
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/23866016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16970 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-26 16:25:57 +00:00
mstarzinger@chromium.org
9c3ffc4f58
Fix replaying of HCapturedObject for nested objects.
...
R=titzer@chromium.org
TEST=mjsunit/compiler/property-refs,mjsunit/compiler/escape-analysis
Review URL: https://codereview.chromium.org/24561002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16969 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-26 15:28:46 +00:00
dcarney@chromium.org
47e32d0339
Add EscapableHandleScope to api to fix problems with HandleScope::Close
...
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24245005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16965 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-26 13:46:37 +00:00
dcarney@chromium.org
6245d34b95
build fix for 16957
...
TBR=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24726002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16958 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-26 08:47:59 +00:00
dcarney@chromium.org
7bad4ba648
remove uses of static oddball accessors using GetCurrent in advance of removal from api
...
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24508006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16957 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-26 08:21:48 +00:00
dcarney@chromium.org
2efd6aa179
add isolate parameter to ThrowException
...
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24538002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-26 07:37:59 +00:00
machenbach@chromium.org
7c0c861e7a
Fix comment in test case.
...
TBR=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/24643002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16949 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-25 18:53:33 +00:00
machenbach@chromium.org
9fd455872c
Let timer test retry for 20ms to reduce flakiness.
...
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/24484003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16948 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-25 16:47:56 +00:00
verwaest@chromium.org
3ee82ddc3f
Special handle for mul/div minus one when kAllUsesTruncatingToInt32
...
BUG=
R=verwaest@chromium.org
Review URL: https://chromiumcodereview.appspot.com/24521002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16943 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-25 15:10:48 +00:00
hpayer@chromium.org
77000f2d59
Disable timer mjsunit test on Windows.
...
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/24485004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16942 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-25 12:46:45 +00:00
hpayer@chromium.org
f59bcf2f3b
Revert OS::TimeCurrentMillis on Windows introduced in r16413.
...
BUG=chromium:288924
R=danno@chromium.org , jkummerow@chromium.org
Review URL: https://codereview.chromium.org/24529002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16938 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-25 09:50:48 +00:00
verwaest@chromium.org
d0e12549ed
Reset IC to premonomorphic rather than uninitialized.
...
R=mstarzinger@chromium.org
Review URL: https://chromiumcodereview.appspot.com/24512003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16936 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-09-25 09:25:39 +00:00