Commit Graph

35 Commits

Author SHA1 Message Date
jkummerow
53a74a6446 Fix gen-postmortem-metadata.py after r43075
DescriptorArray::kDescriptorFoo was renamed to
DescriptorArray::kEntryFooIndex in https://codereview.chromium.org/2688573003

TBR=ishell@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2687083003
Cr-Commit-Position: refs/heads/master@{#43076}
2017-02-09 23:42:21 +00:00
julien.gilli
cd96c7ccd5 add post-mortem metadata for frames type
Previously (and still currently for some of them), post-mortem debugging
tools were using StandardFrameConstants::kContextOffset as the offset to
get the value that represents a frame's type.

However since https://codereview.chromium.org/1696043002, a new, more
general offset was introduced:
CommonFrameConstants::kContextOrFrameTypeOffset.

In order for post-mortem debugging tools to use this constant, it is
included in the generated post-mortem metadata.

R=danno@chromium.org,bmeurer@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2655553006
Cr-Commit-Position: refs/heads/master@{#42746}
2017-01-27 18:19:08 +00:00
ishell
ac45f88acb [runtime] Fix postmortem metadata generator.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2636893002
Cr-Commit-Position: refs/heads/master@{#42376}
2017-01-16 14:24:50 +00:00
franzih
9f0f50c2ad [Runtime] Remove obsolete constants.
Remove now obsolete constants (see 8f0bf07b50)
from postmortem metadata generator.

BUG=

Review-Url: https://codereview.chromium.org/2636863004
Cr-Commit-Position: refs/heads/master@{#42374}
2017-01-16 13:38:40 +00:00
fedor
66611810e1 [post-mortem] JS_API_OBJECT_TYPE and friends
Export JS_API_OBJECT_TYPE, JS_SPECIAL_API_OBJECT_TYPE.

Exports JSObject::kHeaderSize to ease the inspection of internal fields
in llnode.

BUG=
R=machenbach

Review-Url: https://codereview.chromium.org/2514063002
Cr-Commit-Position: refs/heads/master@{#41157}
2016-11-21 19:33:48 +00:00
verwaest
1493bc8c8b Replace CollectVariables with locals(), update callsites to walk locals instead
This additionally gets rid of old approach to global shortcuts.

BUG=v8:5209

Review-Url: https://codereview.chromium.org/2287173002
Cr-Commit-Position: refs/heads/master@{#38980}
2016-08-29 12:49:35 +00:00
ishell
c9b6e81697 Update tools/gen-postmortem-metadata.py after recent modifications.
This CL changed layout of UnseededNumberDictionary: https://codereview.chromium.org/2102073002.

Review-Url: https://codereview.chromium.org/2105553006
Cr-Commit-Position: refs/heads/master@{#37398}
2016-06-29 14:28:19 +00:00
julien.gilli
2619ccd1a0 Move post-mortem constants from accessors table to constants table
Some post-mortem metadata constants that are not offsets to objects'
properties were incorrectly defined in the accessors table. This change
fixes it by moving them from the accessors table to the constants table.

More background is available at
https://github.com/nodejs/post-mortem/issues/27.

R=danno@chromium.org,bmeurer@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2051563003
Cr-Commit-Position: refs/heads/master@{#36878}
2016-06-10 04:09:09 +00:00
fedor
8eda85d54e Postmortem: export DATA_CONSTANT
Useful for inspecting constant fields in objects.

BUG=
R=machenbach

Review-Url: https://codereview.chromium.org/1922903003
Cr-Commit-Position: refs/heads/master@{#35826}
2016-04-27 15:51:11 +00:00
ofrobots
cbd91c5208 Fix post-mortem data after frame-marking changes
Post-mortem metadata generation broke as a result of
https://codereview.chromium.org/1696043002

BUG=

Review URL: https://codereview.chromium.org/1780933004

Cr-Commit-Position: refs/heads/master@{#34725}
2016-03-11 15:12:01 +00:00
ben
344d99c4bb Fix gen-postmortem-metadata.py script.
BUG=

Review URL: https://codereview.chromium.org/1718953002

Cr-Commit-Position: refs/heads/master@{#34186}
2016-02-22 08:16:35 +00:00
ofrobots
638e20da7e postmortem: Remove Context::GLOBAL_OBJECT_INDEX
Context::GLOBAL_OBJECT_INDEX has been replaced by NATIVE_CONTEXT_INDEX in
https://codereview.chromium.org/1480003002. Update the postmortem data generator
to reflect this change.

R=bmeurer@chromium.org,yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1542753002

Cr-Commit-Position: refs/heads/master@{#32993}
2015-12-22 00:18:46 +00:00
thechargingvolcano
c0ec16e559 [tools] gen-postmortem-metadata: use strip instead of lstrip + rstrip
In Python, `strip` can be used directly instead of stripping the ends
one by one.

R=machenbach@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1443963004

Cr-Commit-Position: refs/heads/master@{#32413}
2015-11-30 17:07:56 +00:00
evan.lucas
bc2e393b4c [tools] Make gen-postmortem-metadata.py more reliable
Instead of basing matches off of whitespace, walk the inheritance chain and include any classes that inherit from Object.

R=machenbach@chromium.org,jkummerow@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1435643002

Cr-Commit-Position: refs/heads/master@{#31964}
2015-11-12 14:48:04 +00:00
fedor
2b6d07abb2 tools: fix typo in postmortem generator
BUG=
R=machenbach

Review URL: https://codereview.chromium.org/1439763002

Cr-Commit-Position: refs/heads/master@{#31961}
2015-11-12 14:11:32 +00:00
fedor
68e89fbb0a This commit adds some postmortem data that is otherwise unavailable.
I have discovered need in those values when writing:

https://github.com/indutny/llnode

BUG=

Review URL: https://codereview.chromium.org/1436473002

Cr-Commit-Position: refs/heads/master@{#31947}
2015-11-11 19:13:52 +00:00
julien.gilli
56a0a797f2 Update post-mortem metadata generation
mdb_v8, a post-mortem debugger for Node.js, now uses JSArrayBuffer's
backing_store property and JSArrayBufferView's byte_offset property to
get access to the content of Buffer instances in node (which are
Uint8Array instances). This change adds post-mortem metadata for these
two properties.

This change also fixes a typo in
inobject_properties_of_constructor_function_index_offset that was added
to gen-postmortem-metadata in a previous change. It should be named
inobject_properties_or_constructor_function_index instead.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/1363403003

Cr-Commit-Position: refs/heads/master@{#30926}
2015-09-25 04:59:40 +00:00
julien.gilli
c281c15d6d Add JSTypedArray's length in post-mortem metadata.
BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/1363683002

Cr-Commit-Position: refs/heads/master@{#30873}
2015-09-23 05:37:47 +00:00
julien.gilli
357e6b99ee Add ScopeInfo constants to post-mortem metadata
mdb_v8, a post-mortem debugging tool for Node.js, allows users to
inspect ScopeInfo structures in order to get more information about
closures.

Currently, it hardcodes the metadata it uses to find this information.
This change allows it to get this metadata from the node binary itself,
and thus to adapt to future changes made to the layout of the ScopeInfo
data structure.

BUG=

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/1350843003

Cr-Commit-Position: refs/heads/master@{#30843}
2015-09-21 05:45:38 +00:00
julien.gilli
ff7d70bf41 Update BitField3 type in gen-postmortem-metadata.py
Since https://codereview.chromium.org/272163002, BitField3 is a raw
uint32 field, and not a SMI anymore.

Update tools/gen-postmortem-metadata.py so that post-mortem tools can
work with versions of V8 that shipped after that change.

This change was merged in github.com/joyent/node right before node
v0.12.0 was released.

R=danno@chromium.org

TEST=mdb_v8, a post-mortem debugging tool running on SmartOS,  has been
using this change since Node.js v0.12.0 was released

BUG=

Review URL: https://codereview.chromium.org/1296743003

Cr-Commit-Position: refs/heads/master@{#30839}
2015-09-18 22:41:22 +00:00
ofrobots
5434d052f1 fix gen-postmortem-metadata.py for kInObjectPropertiesOffset
This is causing build breaks for Node.js w/ V8 4.6.

Map::kInObjectPropertiesOffset was been replaced by
kInObjectPropertiesOrConstructorFunctionIndexOffset in
https://codereview.chromium.org/1276533003. This is causing the post-mortem
debug information generation to fail.

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1308113007

Cr-Commit-Position: refs/heads/master@{#30536}
2015-09-02 07:45:40 +00:00
fedor
93a290d0ff postmortem: fixup after 33994b4
This commit has changed the enum names:

33994b4a22

`FIELD` is now called `DATA`.

BUG=
R=danno

Review URL: https://codereview.chromium.org/1033733003

Cr-Commit-Position: refs/heads/master@{#27434}
2015-03-25 10:10:06 +00:00
fedor
a0d0c4333d tools: fix postmortem generator
BUG=
R=danno

Review URL: https://codereview.chromium.org/892223002

Cr-Commit-Position: refs/heads/master@{#26389}
2015-02-02 21:21:54 +00:00
yangguo@chromium.org
c71976d55a Also rename ascii to one-byte in tool scripts.
TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/561743002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-09-10 12:56:19 +00:00
danno@chromium.org
51ff0b5e97 tools: more post-mortem constants
Expose more info about post-mortem constants

Useful for node.js and/or other tools.

BUG=
R=danno@chromium.org

Review URL: https://codereview.chromium.org/404173002

Patch from Fedor Indutny <fedor.indutny@gmail.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22549 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-07-23 10:48:16 +00:00
jkummerow@chromium.org
6b1f05bf35 tools: strip whitespace in gen-postmortem-metadata.py
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/221513002

Patch from Ben Noordhuis <ben@strongloop.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20436 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-02 13:04:08 +00:00
rmcilroy@chromium.org
78ab4379d3 Out-of-line constant pool on Arm: Stage 3 - Set Constant Pool Pointer on Function Entry
Third stage of implementing an out-of-line constant pool for Arm.  This CL adds
a ConstantPool field to Code objects and initializes the pp register on
function entry, and saves the pp register on the stack frame. The ConstantPool
object is always empty and is unused currently.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/88043002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18425 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-12-30 11:23:59 +00:00
jkummerow@chromium.org
2e3057c69f Add additional postmortem debugging metadata to support decoding two-byte
strings, sliced strings, and changes to some object property representations.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/26034002

Patch from David Pacheco <dap@joyent.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-14 13:08:52 +00:00
svenpanne@chromium.org
b74f1b8b4a Synched postmortem script with not-so-recent changes.
Review URL: https://codereview.chromium.org/11744019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13303 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-01-03 13:11:47 +00:00
danno@chromium.org
2e6a7c733b postmortem: export kSmiShiftSize
Right now it's impossible to figure out from headers that smis are left shifted
by 31 bit on x64, and only then tagged.

R=erik.corry@gmail.com

Review URL: https://codereview.chromium.org/11676005
Patch from Fedor Indutny <fedor@indutny.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13285 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-12-28 13:06:08 +00:00
yangguo@chromium.org
3699616609 Rename SeqAsciiString
This is a straight rename:

NewRawAsciiString -> NewRawOneByteString
SeqAscii -> SeqOneByte

SeqOneByteString cannot yet take non-ascii data.

R=yangguo@chromium.org,
BUG=

Review URL: https://chromiumcodereview.appspot.com/11411005
Patch from Dan Carney <dcarney@google.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12972 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-11-15 13:31:27 +00:00
yangguo@chromium.org
943c10bb87 Rename kAsciiStringTag to kOneByteStringTag
This is just a rename. After commit, I'll begin with the semantic changes.
Until those are complete, kOneByteStringTag will have the same meaning as
kAsciiStringTag.

BUG=

Review URL: https://chromiumcodereview.appspot.com/11293168
Patch from Dan Carney <dcarney@google.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12897 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-11-08 12:14:29 +00:00
erik.corry@gmail.com
e817800f14 postmortem: fix postmortem build
This is a commit of https://chromiumcodereview.appspot.com/10539132/ for Fedor Indutny.


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11801 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-06-13 13:48:18 +00:00
vegorov@chromium.org
9ad61f635e Add Code-related fields to postmortem metadata
Review URL: https://chromiumcodereview.appspot.com/9361008
Patch from David Pacheco <dap@joyent.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10986 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-03-09 12:34:42 +00:00
vegorov@chromium.org
a297d3f9af Optionally export metadata with libv8 to enable debuggers to inspect V8 state.
Review URL: https://chromiumcodereview.appspot.com/8803024
Patch from David Pacheco <dap@joyent.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10596 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-02-02 20:18:19 +00:00