Commit Graph

45 Commits

Author SHA1 Message Date
Daniel Clifford
b51053d89e Reland: [builtins] Implement Array.prototype.slice in Torque
In the process:

- add volatile types for FastJSArray and remove the length_fast accessor
  from JSArray with the application of more rigorous typing.
- add micro benchmarks for testing all the interesting slice cases

Also update a few assorted places in .tq code to make them more
idiomatic.

The original version of this patch had an overly agressive assert that has
been loosened.

TBR=jgruber@chromium.org

Change-Id: I56870862f4b124d1b38372daa326182a526c874c
Reviewed-on: https://chromium-review.googlesource.com/c/1291375
Reviewed-by: Daniel Clifford <danno@chromium.org>
Commit-Queue: Daniel Clifford <danno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56829}
2018-10-19 21:27:19 +00:00
Sigurd Schneider
5bc96c9191 Revert "[builtins] Implement Array.prototype.slice in Torque"
This reverts commit 41ba3d3eb0.

Reason for revert: Speculative revert:
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Fuzzer/27370
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20predictable/19895

Original change's description:
> [builtins] Implement Array.prototype.slice in Torque
> 
> In the process:
> 
> - add volatile types for FastJSArray and remove the length_fast accessor
>   from JSArray with the application of more rigorous typing.
> - add micro benchmarks for testing all the interesting slice cases
> 
> Also update a few assorted places in .tq code to make them more
> idiomatic.
> 
> Change-Id: I76ec2bb25b65a869180af1f7288419dc1f0a9c37
> Reviewed-on: https://chromium-review.googlesource.com/c/1281603
> Commit-Queue: Daniel Clifford <danno@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56806}

TBR=danno@chromium.org,jgruber@chromium.org,tebbi@chromium.org

Change-Id: I1f2c82b4c3ab0848857f620facacf9604d4fcd11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1290973
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56815}
2018-10-19 11:24:34 +00:00
Daniel Clifford
41ba3d3eb0 [builtins] Implement Array.prototype.slice in Torque
In the process:

- add volatile types for FastJSArray and remove the length_fast accessor
  from JSArray with the application of more rigorous typing.
- add micro benchmarks for testing all the interesting slice cases

Also update a few assorted places in .tq code to make them more
idiomatic.

Change-Id: I76ec2bb25b65a869180af1f7288419dc1f0a9c37
Reviewed-on: https://chromium-review.googlesource.com/c/1281603
Commit-Queue: Daniel Clifford <danno@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56806}
2018-10-19 09:12:21 +00:00
Julien Brianceau
b41f857b9e Fix common misspellings
Bug: chromium:750830
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng
Change-Id: Icab7b5a1c469d5e77d04df8bfca8319784e92af4
Reviewed-on: https://chromium-review.googlesource.com/595655
Commit-Queue: Julien Brianceau <jbriance@cisco.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47072}
2017-08-02 09:35:28 +00:00
machenbach@chromium.org
b77cb4a793 Revert "Refactoring: Make gtest testsuite the default."
This reverts commit cb8f08658767e7e3182e5deab0473f264f6ce92f.

TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/532673002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-09-02 09:17:26 +00:00
machenbach@chromium.org
a050734c35 Refactoring: Make gtest testsuite the default.
BUG=v8:3489
R=bmeurer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/526133003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23583 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-09-02 09:11:13 +00:00
machenbach@chromium.org
68ec08240c Add test driver with the notion of perf tests.
BUG=374740
LOG=n
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/526953005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23569 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-09-01 14:27:44 +00:00
machenbach@chromium.org
509c15c799 Add new benchmark suite runner.
TEST=./tools/run_benchmarks.py benchmarks/v8.json
TEST=cd tools/unittests; python -m unittest run_benchmarks_test

Does not support custom results processors yet. Will implement that in a future CL.

BUG=374740
LOG=n
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/293023006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21570 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-05-28 13:05:17 +00:00
fschneider@chromium.org
77b3da380d Fix bug in nextWeaker function of deltablue benchmark.
It does not seem to affect the correctness of the particular
workload it is currently running.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/13994003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17399 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-10-25 13:21:46 +00:00
ulan@chromium.org
863d5fdf49 More fixes for V8 benchmark version 7.
R=rossberg@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9701067

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11064 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-03-15 17:13:50 +00:00
ulan@chromium.org
4898f5bd0d Update revision.html for V8 benchmark version 7.
R=rossberg@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9702078

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11061 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-03-15 16:57:10 +00:00
ulan@chromium.org
579ca7430c Add Navier-Stokes benchmark.
R=danno@chromium.org,kasperl@chromium.com,stefanoc@chromium.org,sandholm@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9359033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10705 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-02-14 15:07:15 +00:00
vegorov@chromium.org
95ecaeb996 Fix presubmit errors introduced by r10002.
TBR=erik.corry@gmail.com
Review URL: http://codereview.chromium.org/8520031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10004 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-11-16 01:44:17 +00:00
vegorov@chromium.org
237401a5dd Introduce non auto-scaling mode in spinning balls benchmark.
Review URL: http://codereview.chromium.org/8570017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10002 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-11-15 22:52:38 +00:00
ulan@chromium.org
da49e4d83d Convert array index to integer when computing pause distribution for spinning-balls.
BUG=
TEST=

Review URL: http://codereview.chromium.org/8430006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9852 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-10-31 17:26:59 +00:00
ulan@chromium.org
e67096aded Allow to set a time limit for spinning-balls and output the pause distribution at the end.
BUG=
TEST=

Review URL: http://codereview.chromium.org/8428002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9851 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-10-31 17:05:37 +00:00
erik.corry@gmail.com
95efb334ac Revert inadvertent changes to the spinning balls tool.
Review URL: http://codereview.chromium.org/8230010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9581 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-10-11 11:43:48 +00:00
erik.corry@gmail.com
f900fc9d80 Remove some unused and unneeded flags.
Review URL: http://codereview.chromium.org/8228004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9576 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-10-11 09:28:06 +00:00
vegorov@chromium.org
01419ed750 GC pauses visualization tool.
R=erik.corry@gmail.com

Review URL: http://codereview.chromium.org/8139001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9532 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-10-05 13:40:49 +00:00
yangguo@chromium.org
86a62d0da3 Added check for trailing whitespaces and corrected existing violations.
Review URL: http://codereview.chromium.org/7826007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9094 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-09-01 11:28:10 +00:00
kasperl@chromium.org
fdde212fec Promote the current V8 benchmark suite candidate to version 6.
Review URL: http://codereview.chromium.org/3571021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5596 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-10-07 07:25:22 +00:00
sandholm@chromium.org
5a6b098527 Changed the RegExp benchmark to exercise the regexp engine on different
inputs by scrambling the input strings.
Review URL: http://codereview.chromium.org/3435012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5493 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-20 10:36:21 +00:00
sandholm@chromium.org
2edf58e973 Recalibrate benchmarks.
Review URL: http://codereview.chromium.org/3300031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5449 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-09-13 13:55:26 +00:00
kasperl@chromium.org
7e69e170fd Update the V8 benchmark suite with the following fixes:
*) Fix a couple of typos in DeltaBlue.
*) Make sure Splay doesn't always remove the node just added.
*) Run all benchmarks for at least 32 times (and warm up).
Review URL: http://codereview.chromium.org/2836031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4966 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-06-28 12:28:37 +00:00
kasperl@chromium.org
c590fb94d6 Incorporate feedback from issue 679 and issue 690 into the
benchmark suite thus forming a new candidate benchmark revision:

  * Remove dead code from RayTrace benchmark.
  * Avoid repeated number-to-string conversion in Splay.

Review URL: http://codereview.chromium.org/2086005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4658 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-05-17 05:59:20 +00:00
kasperl@chromium.org
ce37937df1 Remove svn:executable flag from run.html and style.css and change the mime-type of style.css to text/css.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2474 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-07-15 10:37:10 +00:00
sandholm@chromium.org
92acc9f82e Adding a missing 'the' in the warning message on bleeding edge.
Review URL: http://codereview.chromium.org/155561

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2467 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-07-15 09:35:04 +00:00
sandholm@chromium.org
5143ce8ff3 Third and hopefully last of thrre CLs to issue a warning when an older
version of the benchmark suite is run. This last change updates
bleeding_edge. 
Review URL: http://codereview.chromium.org/155496

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2465 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-07-15 08:47:51 +00:00
kasperl@chromium.org
94a9ebb0a7 Change the name of the Object.prototype.inherits function in
the DeltaBlue benchmark to inheritsFrom to avoid name clashes
when running in Chromium with extensions enabled.

See http://crbug.com/11797. 
Review URL: http://codereview.chromium.org/155205

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2386 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-07-08 07:35:14 +00:00
lrn@chromium.org
54e4562e7d Changed benchmark html and css files to be almost validating HTML 4.01 and CSS.
Review URL: http://codereview.chromium.org/146076


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2259 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-06-24 10:10:49 +00:00
christian.plesner.hansen@gmail.com
7f14958fd4 fixrev
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2251 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-06-23 08:07:22 +00:00
christian.plesner.hansen@gmail.com
9806a3ee67 fixlink
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2250 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-06-23 08:07:12 +00:00
sandholm@chromium.org
46eb69656d Remove duplicate line in benchmarks/base.js
This resolves issue 356 (http://code.google.com/p/v8/issues/detail?id=356) thanks to bitRAKE. Changed benchmark version number from 4 to 5 resulting in updates to base.js, README.txt and revisions.html. 

Review URL: http://codereview.chromium.org/113839

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2058 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-05-26 13:28:51 +00:00
kasperl@chromium.org
1a54dd0197 Add new Splay benchmark to the V8 benchmark suite and remove
the unused parts (most) of the Prototype library from raytrace.js.
Review URL: http://codereview.chromium.org/115227

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1910 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-05-12 08:23:11 +00:00
christian.plesner.hansen@gmail.com
e633dcb6b0 Fixed issue where \x.. and \u.... were rot13-ed in strings (but not in
regexps).  IE saved the day by rejecting them.


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-01-30 13:19:29 +00:00
christian.plesner.hansen@gmail.com
9083e7e239 Added regexp benchmark
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1190 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-01-30 11:35:15 +00:00
ager@chromium.org
7c56f0dd9a Fix benchmarks to not format scores that are really errors.
Uploading for Kasper.
Review URL: http://codereview.chromium.org/17641

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1061 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-01-13 09:27:47 +00:00
christian.plesner.hansen@gmail.com
de5dc43671 Changed benchmark runners to always display at least three significant
digits in the results.


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-12-02 13:02:11 +00:00
christian.plesner.hansen@gmail.com
7fd6409109 Added revisions page and moved change log there.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@889 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-12-02 10:08:39 +00:00
kasperl@chromium.org
949729c06e Improve error reporting in benchmarks.
Review URL: http://codereview.chromium.org/8053

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@553 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-10-22 11:55:08 +00:00
kasperl@chromium.org
15e7cd6e18 Let the current state of the benchmarks be known to the
world as version 2.
Review URL: http://codereview.chromium.org/6487

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@437 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-10-06 07:55:10 +00:00
kasperl@chromium.org
8d617a7b6b Removed the use of Math.random() and new Date() for building
the RNG pool in the crypto benchmark.
Review URL: http://codereview.chromium.org/6071

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@404 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-10-02 07:43:46 +00:00
erik.corry@gmail.com
806c4d63c3 Introduce some checks to indicate that the benchmarks have run correctly.
This change affects the results by around 2% so the version number has been
bumped to 2 to avoid confusion.
Review URL: http://codereview.chromium.org/4401

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@379 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-09-25 13:48:27 +00:00
christian.plesner.hansen@gmail.com
9bed566bdb Changed copyright header from google inc. to v8 project authors.
Added presubmit step to check copyright.



git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-09-09 20:08:45 +00:00
v8.team.kasperl@gmail.com
f472c46a08 Added version 1 of the V8 benchmark suite to the repository.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@91 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-09-02 11:06:49 +00:00