Michael Achenbach
59c55842b8
Revert "Whitespace CL to test poller."
...
This reverts commit f27de256c1
.
Cr-Commit-Position: refs/heads/master@{#26552}
2015-02-10 17:01:14 +00:00
Michael Achenbach
f27de256c1
Whitespace CL to test poller.
...
Cr-Commit-Position: refs/heads/master@{#26548}
2015-02-10 16:03:58 +00:00
michael_dawson
f1ba8d8f86
Contribution of PowerPC port (continuation of 422063005) - AIX Common1
...
Contribution of PowerPC port (continuation of 422063005 and 817143002). This patch covers
the key changes needed to the common files needed to support AIX. Subsequent
patches will cover:
- changes to update the ppc directories so they are current with the changes
in the rest of the project.
- remaining AIX changes not resolved by 4.8 compiler
- individual optimizations for PPC
This is based off of the GitHub repository
https://github.com/andrewlow/v8ppc
R=danno@chromium.org , svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/866843003
Cr-Commit-Position: refs/heads/master@{#26343}
2015-01-30 08:02:08 +00:00
bmeurer
2620f7604a
Fix ninja build with clang=1.
...
Review URL: https://codereview.chromium.org/862313002
Cr-Commit-Position: refs/heads/master@{#26211}
2015-01-22 07:21:52 +00:00
machenbach
4cc852685f
Reland Make clang the default on linux.
...
TBR=jochen@chromium.org ,jkummerow@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/862173002
Cr-Commit-Position: refs/heads/master@{#26206}
2015-01-21 22:25:05 +00:00
machenbach
b0ea0810c6
Revert of Reland Make clang the default on linux. (patchset #3 id:40001 of https://codereview.chromium.org/861223002/ )
...
Reason for revert:
Still missing these builders:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20full%20debug
Original issue's description:
> Reland Make clang the default on linux.
>
> BUG=
>
> Committed: https://crrev.com/72ef6843b0aff68e519a8f26e7d2f7dd87b4712c
> Cr-Commit-Position: refs/heads/master@{#26204}
TBR=jochen@chromium.org ,jkummerow@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/864093004
Cr-Commit-Position: refs/heads/master@{#26205}
2015-01-21 20:38:32 +00:00
machenbach
72ef6843b0
Reland Make clang the default on linux.
...
BUG=
Review URL: https://codereview.chromium.org/861223002
Cr-Commit-Position: refs/heads/master@{#26204}
2015-01-21 19:32:12 +00:00
machenbach
6024d24866
Properly configure goma.
...
Everything is c/p from common.gypi.
Review URL: https://codereview.chromium.org/862973002
Cr-Commit-Position: refs/heads/master@{#26198}
2015-01-21 15:30:28 +00:00
machenbach
e26627e8da
Don't use -O3 with sanitizers.
...
BUG=chromium:430614
LOG=n
Review URL: https://codereview.chromium.org/798653006
Cr-Commit-Position: refs/heads/master@{#26169}
2015-01-20 16:07:22 +00:00
jochen
3fd5b96f3b
Revert of Make clang the default on linux. (patchset #2 id:20001 of https://codereview.chromium.org/781983002/ )
...
Reason for revert:
breaks arm and mips compilation on main waterfall
Original issue's description:
> Make clang the default on linux.
>
> TBR=jochen@chromium.org
>
> Committed: https://crrev.com/006b5c5cfd8517563601f331bc7a57e13bfeb202
> Cr-Commit-Position: refs/heads/master@{#26164}
TBR=machenbach@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/861553004
Cr-Commit-Position: refs/heads/master@{#26166}
2015-01-20 15:15:28 +00:00
machenbach
006b5c5cfd
Make clang the default on linux.
...
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/781983002
Cr-Commit-Position: refs/heads/master@{#26164}
2015-01-20 15:01:09 +00:00
jochen
aeb09e6dcf
Merge v8_optimized_debug 1 and 2
...
All builders that used level 1 should meanwhile define
v8_enable_slow_dchecks, and so they can use level 2 without losing
coverage. Level 2, however, is considerably faster, so we want to use it
on those builders as well. The make optdebug setting is not affected by
this change.
BUG=none
R=machenbach@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/847753002
Cr-Commit-Position: refs/heads/master@{#26019}
2015-01-12 09:58:42 +00:00
jochen
8216f1bc7c
Add ASAN and TSAN support for Mac
...
BUG=none
LOG=n
R=machenbach@chromium.org ,glider@chromium.org
Review URL: https://codereview.chromium.org/838383005
Cr-Commit-Position: refs/heads/master@{#26013}
2015-01-09 13:38:25 +00:00
jochen
333a92bd5e
Define SDKROOT for Mac
...
otherwise, the clang we ship doesn't work
BUG=none
R=adamk@chromium.org ,thakis@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/792783006
Cr-Commit-Position: refs/heads/master@{#25893}
2014-12-18 20:42:46 +00:00
svenpanne
71bb00e261
Consistently use only one of virtual/OVERRIDE/FINAL.
...
FINAL implies OVERRIDE, which in turn implies virtual, so there's no need to use
more than one of these. The Google C++ style guide even requires this, see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Inheritance .
While we're here, port r24662 to x87.
The net result is that v8 compiles again with a current clang.
BUG=v8:3753
LOG=y
Review URL: https://codereview.chromium.org/797943002
Cr-Commit-Position: refs/heads/master@{#25792}
2014-12-12 10:44:25 +00:00
jochen
b0f9ac831d
Temporarily remove warning about inconsistent overrides
...
Otherwise, V8 won't compile with the latest clang anymore
BUG=v8:3753
R=machenbach@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/797583004
Cr-Commit-Position: refs/heads/master@{#25788}
2014-12-11 19:10:45 +00:00
mostynb
68870ab6ee
move v8_use_external_startup_data to standalone.gypi
...
This allows the setting to be overridable by embedders,
at the cost of forcing embedders that don't build v8
using standalone.gypi to add this setting to their build
config.
BUG=chromium:421063
LOG=Y
Review URL: https://codereview.chromium.org/794583002
Cr-Commit-Position: refs/heads/master@{#25781}
2014-12-11 15:27:44 +00:00
machenbach
01be1b0084
Set clang directory in gyp.
...
BUG=
Review URL: https://codereview.chromium.org/764803002
Cr-Commit-Position: refs/heads/master@{#25553}
2014-11-27 17:18:12 +00:00
dusan.milosavljevic@imgtec.com
61c0aa96e3
MIPS: Resolve chromium and android webview build conflicts.
...
The mips related gyp variables and compiler flags for webview
and chromium builds are set externally. The CL ensures this
behaviour and prevents conflicts in configuration with standalone builds.
TEST=
BUG=
R=jkummerow@chromium.org , paul.lind@imgtec.com
Review URL: https://codereview.chromium.org/707883002
Cr-Commit-Position: refs/heads/master@{#25243}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25243 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-11-10 11:48:17 +00:00
bmeurer@chromium.org
08e20d1291
Disable libstdc++ debug mode on x64 for now.
...
TBR=mstarzinger@chromium.org
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24798 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-10-22 09:37:42 +00:00
bmeurer@chromium.org
ded822a5de
Enable libstdc++ debug mode in debug builds.
...
For now it's only enabled on Linux/Intel.
R=mstarzinger@chromium.org
BUG=v8:3638
LOG=y
Review URL: https://codereview.chromium.org/650013006
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24794 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-10-22 08:12:17 +00:00
bmeurer@chromium.org
a58000d11e
Revert "Enable libstdc++ debug mode in debug builds.".
...
This reverts commit r24676 to see if it was the cause for the mysterious
crashes on some bots. If not, we'll reland it.
TBR=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/663013002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24715 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-10-20 04:16:06 +00:00
bmeurer@chromium.org
6353ff20ed
Fix Mac build after r24676.
...
BUG=v8:3638
LOG=n
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/659253002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24679 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-10-17 07:12:30 +00:00
bmeurer@chromium.org
c987974dcc
Enable libstdc++ debug mode in debug builds.
...
See https://gcc.gnu.org/onlinedocs/libstdc++/manual/debug_mode.html for
details about the debug mode.
BUG=v8:3638
LOG=y
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/648293007
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-10-17 06:58:20 +00:00
jochen@chromium.org
3d7bd81ea3
Don't enable WPO on Win64 and require Server 2003 / x64 for win64
...
WPO was only enabled to work around an issue with the Isolate's static
initializer which no longer exists.
Requiring XP on Win64 doesn't make sense.
BUG=421363
R=machenbach@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/637303002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24457 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-10-08 09:09:57 +00:00
bmeurer@chromium.org
dd34bc2cab
Add missing -Wno-missing-field-initializer flag to standalone.gypi.
...
Chrome uses -Wno-missing-field-initializers when building V8, so we
should better use that as well. It silences warnings generated for the
GTest port files.
BUG=v8:3518
LOG=n
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/535283006
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-09-04 09:23:50 +00:00
svenpanne@chromium.org
c6f044b397
Tweaks to generate XP-compatible .exes
...
BUG=407517
LOG=y
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/504793004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23436 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-27 08:45:39 +00:00
bmeurer@chromium.org
11fb976bf4
Revert "Unbreak build with clang."
...
This reverts commit r22878 and fixes the actual bug instead.
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/446573002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22880 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-05 14:19:22 +00:00
svenpanne@chromium.org
99bfb3d974
Unbreak build with clang.
...
It's unclear whether it's a clang bug or our code is wrong, to be
verified later...
TBR=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/438323002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22878 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-05 13:58:11 +00:00
svenpanne@chromium.org
337015e5dd
Enable C++11. Synch toolchains with Chrome.
...
* Consistently enable C++11 features on all platforms.
* Use the same ARM toolchain version as Chrome.
* Make clang the default on Mac OS X, just like Chrome.
* Use C99 on Mac OS X, again following Chrome.
* Small build fixes.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/440663002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22875 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-08-05 13:23:55 +00:00
machenbach@chromium.org
f5a4b26061
Add tsan support to v8's gyp and test driver.
...
Tests only the default variant for now.
BUG=
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/412853002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22561 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-07-23 13:14:26 +00:00
dusan.milosavljevic@rt-rk.com
a0f6878a06
Add mips64 port.
...
Summary:
- Changes in common code are mainly boilerplate changes,
gyp and test status files updates.
- On mips64 simulator all tests pass from all test units.
- Current issues: mjsunit JS debugger tests fail randomly on HW in release mode.
Corresponding tests are skipped on HW.
- Skipped tests on mips64: test-heap/ReleaseOverReservedPages, mjsunit/debug-*
TEST=
BUG=
R=danno@chromium.org , plind44@gmail.com , ulan@chromium.org
Review URL: https://codereview.chromium.org/371923006
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22297 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-07-09 11:08:26 +00:00
yangguo@chromium.org
12d0d1b74f
Revert "Add msan build option." (r22109)
...
Building d8 with msan requires instrumented libc++. Currently the
advised way to do this is from a chromium checkout with d8 as target.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/361963003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22124 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-07-01 13:51:27 +00:00
yangguo@chromium.org
e711d193c3
Add msan build option.
...
Currently works only in combination with i18nsupport=off.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/367623002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22109 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-07-01 09:04:48 +00:00
svenpanne@chromium.org
e25f833496
Added slim versions of output streams.
...
R=bmeurer@chromium.org , mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/352823003
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22049 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-27 08:42:17 +00:00
jochen@chromium.org
bab70ca936
Set host_arch to ia32 on machines with a 32bit userland but a 64bit kernel.
...
I don't know if there are any v8 bots with that configuration, but it seems
like a good idea to have v8 be consistent with chromium and nacl here, so that
this works fine if such a bot is ever set up.
This is similar to https://codereview.chromium.org/342493002/ , but with a
detect_v8_host_arch.py script that handles the additional machine types that
standalone.gypi used to handle.
Originally reviewed at https://codereview.chromium.org/346643002/
BUG=368384
LOG=Y
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/349333006
Patch from Nico Weber <thakis@chromium.org>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21956 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-24 07:12:48 +00:00
marja@chromium.org
2c8eef08ca
Revert "Set host_arch to ia32 on machines with a 32bit userland but a 64bit kernel."
...
This reverts r21909.
Reason: breaks NaCL build.
BUG=
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/346223004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21914 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-23 08:47:07 +00:00
jochen@chromium.org
1ef52275d5
Set host_arch to ia32 on machines with a 32bit userland but a 64bit kernel.
...
I don't know if there are any v8 bots with that configuration, but it seems
like a good idea to have v8 be consistent with chromium and nacl here, so that
this works fine if such a bot is ever set up.
This is similar to https://codereview.chromium.org/342493002/ , but with a
detect_v8_host_arch.py script that handles the additional machine types that
standalone.gypi used to handle.
BUG=368384 possibly?
LOG=Y
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/346643002
Patch from Nico Weber <thakis@chromium.org>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21909 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-06-23 08:19:54 +00:00
danno@chromium.org
9c485e182b
Introduce x87 port
...
Support x87-only platform (ia32 without SSE)
R=danno@chromium.org
Review URL: https://codereview.chromium.org/293743005
Patch from Weiliang Lin <weiliang.lin@intel.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21469 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-05-23 16:37:27 +00:00
m.m.capewell@googlemail.com
2bdd088cde
ARM: update defaults for flags
...
R=bmeurer@chromium.org , ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/264593002
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21258 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-05-12 09:25:32 +00:00
m.m.capewell@googlemail.com
10bbd65525
ARM64: Fix native builds
...
Rearrange sed lines to enable native builds for ARM64.
BUG=
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/238543009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20806 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-16 13:25:15 +00:00
jochen@chromium.org
d426cd1012
Use abstract configurations to switch between opt debug settings
...
The problem is that conditions are evaluated before configuration inheritance is resolved, so we can't just define a configuration like this:
'Optdebug': {
'inherits_from': ['Debug'],
'variables': {
'v8_optimized_debug': 2,
}
}
Instead, we have to put the different settings depending on the optimization level into separate configurations, and use conditions inside the concrete configurations to inherit from the correct base class.
Common settings go in the base configuration DebugBaseCommon, and v8_optimized_debug dependent settings go into DebugBase{0,1,2}
The new Debug configuration inherits from DebugBaseCommon and DebugBase<(v8_optimized_debug), while the new configuration Optdebug inherits from DebugBaseCommon and DebugBase2.
BUG=v8:3252
R=machenbach@chromium.org , jkummerow@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/224443003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20605 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-09 09:54:49 +00:00
jkummerow@chromium.org
8e5f6d98fc
Remove Apple-only GCC_WARN_ABOUT_MISSING_NEWLINE
...
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/199843003
Patch from Ben Noordhuis <ben@strongloop.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20435 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-02 12:55:22 +00:00
jkummerow@chromium.org
985c98a1eb
Don't try to use ASan on Windows
...
Let ASan support depend on __has_feature(address_sanitizer) instead of defined(ADDRESS_SANITIZER)
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/213133002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20287 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-26 16:18:28 +00:00
jkummerow@chromium.org
c6bff48f09
ASan support for the Zone
...
R=jarin@chromium.org , kcc@google.com
Review URL: https://codereview.chromium.org/208743004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20266 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-26 10:01:53 +00:00
jochen@chromium.org
2ce0bebba1
Rename A64 port to ARM64 port
...
BUG=354405
R=ulan@chromium.org , rodolph.perfetta@arm.com
LOG=y
Review URL: https://codereview.chromium.org/207823003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-21 09:28:26 +00:00
jochen@chromium.org
9fccfc37c8
Prepare switch from a64 to arm64
...
BUG=354405
R=machenbach@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/207793002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20147 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-21 08:47:03 +00:00
jochen@chromium.org
a992481b9e
Allow for compiling with xcode 5.1 (which doesn't have gcc anymore)
...
BUG=none
R=jkummerow@chromium.org , machenbach@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/196983006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19917 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-14 07:47:08 +00:00
machenbach@chromium.org
717c4d3bb5
Add ASAN option to stand-alone gyp config.
...
BUG=
R=jkummerow@chromium.org , jochen@chromium.org
Review URL: https://codereview.chromium.org/196943004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19888 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-13 10:36:55 +00:00
ulan@chromium.org
e95bc7eec8
Merge experimental/a64 to bleeding_edge.
...
BUG=v8:3113
LOG=Y
R=jochen@chromium.org , rmcilroy@chromium.org , rodolph.perfetta@arm.com
Review URL: https://codereview.chromium.org/148293020
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19311 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-12 09:19:30 +00:00