yangguo@chromium.org
0cfa70852a
Fix presubmit check for the case when cpplint fails.
...
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10124006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11384 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-04-19 10:28:26 +00:00
yangguo@chromium.org
11e779185b
Parallelize cpplint in presubmit and fix usage of DISALLOW_* macros.
...
BUG=v8:1653
Review URL: https://chromiumcodereview.appspot.com/9192010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10465 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2012-01-20 16:17:08 +00:00
jkummerow@chromium.org
11d79c5233
Add presubmit=no and werror=no flags to Makefile
...
Review URL: http://codereview.chromium.org/8159015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9539 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-10-06 11:08:41 +00:00
yangguo@chromium.org
6336eb7c20
Presubmit output to distinguish check phases.
...
Review URL: http://codereview.chromium.org/7795050
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-09-07 15:17:18 +00:00
yangguo@chromium.org
0409c8d6ec
Only presubmit check files in git repo for copyright note etc. (if using git).
...
Review URL: http://codereview.chromium.org/7792068
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9113 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-09-02 08:04:51 +00:00
yangguo@chromium.org
86a62d0da3
Added check for trailing whitespaces and corrected existing violations.
...
Review URL: http://codereview.chromium.org/7826007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9094 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-09-01 11:28:10 +00:00
vitalyr@chromium.org
c02bc26a5a
Make presubmit check happier with GYP.
...
R=jkummerow@chromium.org
Review URL: http://codereview.chromium.org/7598034
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8867 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2011-08-09 13:45:54 +00:00
lrn@chromium.org
0c60c88c2c
Working stand-alone preparser.
...
BUG=
TEST=
Review URL: http://codereview.chromium.org/5302003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5885 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-11-24 09:57:06 +00:00
lrn@chromium.org
455cfe5932
Make presubmit lint the "include" dir.
...
Make include dir content pass lint.
Review URL: http://codereview.chromium.org/4421002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5767 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-11-04 10:27:39 +00:00
antonm@chromium.org
bc01445830
Use hashlib module instead of md5 if it is present.
...
md5 module is deprecated since Python 2.5 and we'd better off using hashlib instead.
Review URL: http://codereview.chromium.org/3026030
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5143 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-07-28 12:35:46 +00:00
ricow@chromium.org
33079fb851
Added ES5 15.2.3.2 Object.getPrototypeOf.
...
Review URL: http://codereview.chromium.org/523124
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3555 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2010-01-07 10:01:24 +00:00
mikhail.naganov@gmail.com
f2f00d0d09
A cache of MD5 sums of source file contents is now maintained. Cpplint is only invoked for new, changed, and files containing errors from the past lint check run.
...
As a result, repetitive presubmit checks now run in a blink of an eye, so we can include it as an obligatory pre-submit check to avoid frequent CB breakages on lint errors.
Review URL: http://codereview.chromium.org/440026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3368 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-26 10:17:03 +00:00
lrn@chromium.org
931396e689
Ignore "sputniktests" subdirectory from presubmit checks.
...
Review URL: http://codereview.chromium.org/385067
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3290 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-11-12 12:11:40 +00:00
sgjesse@chromium.org
f5864d08af
Use local cpplint.py if it exists.
...
If there is a local cpplint.py in the tools directory use this instead of any cpplint in the path. This makes it possible to run presubmit checks on Windows by downloading cpplint.py from http://code.google.com/p/google-styleguide/ .
Review URL: http://codereview.chromium.org/194039
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2874 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-09-11 12:21:48 +00:00
iposva@chromium.org
f7473610c8
- Exclude "build/include_what_you_use" from cpplint.py filters.
...
Review URL: http://codereview.chromium.org/65017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1688 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-04-09 20:07:30 +00:00
erik.corry@gmail.com
18d6c23971
Tell presubmit.py that regexp-pcre.js doesn't need a standard copyright
...
message since it has a special one.
Review URL: http://codereview.chromium.org/19752
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1209 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-02-02 16:27:08 +00:00
ager@chromium.org
06d96bade5
jsmin does not have our copyright header and shouldn't have. Exclude
...
it from the presubmit check.
Review URL: http://codereview.chromium.org/19424
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-01-28 11:49:44 +00:00
ager@chromium.org
e639876dbe
Allow 2009 as a valid year in the copyright header.
...
Review URL: http://codereview.chromium.org/16568
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1038 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-01-07 11:51:03 +00:00
iposva@chromium.org
45847bd125
- Rename flags.defs to flag-definitions.h.
...
- Add better support for ignoring files in the presubmit tool.
Review URL: http://codereview.chromium.org/3082
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@322 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-09-17 08:47:50 +00:00
christian.plesner.hansen@gmail.com
9bed566bdb
Changed copyright header from google inc. to v8 project authors.
...
Added presubmit step to check copyright.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-09-09 20:08:45 +00:00
erik.corry@gmail.com
9a216515ac
When the Mozilla tests are checked out of cvs in the recommended place the
...
linter attempts to check them for style issues. This is not helpful. This
chance makes the presubmit linter skip the data directory where they are
located.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@182 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-09-06 06:22:59 +00:00
v8.team.kasperl@gmail.com
ce7210ece0
Ignore missing copyright notices for EarleyBoyer and RayTrace
...
benchmarks.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@93 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-09-02 11:40:18 +00:00
christian.plesner.hansen@gmail.com
132a2cd1c3
Added presubmit step that runs cpplint and checks for missing
...
copyrights. Fixed some lint issues in the samples. Added better
error handling for crashing tests on windows.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@49 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-08-29 12:52:21 +00:00