marja@chromium.org
5788b34a16
Unify function name validation in Parser and PreParser.
...
BUG=3126
LOG=N
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/140183005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19193 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-07 10:47:01 +00:00
marja@chromium.org
7a53841cd1
Add regression tests for PrePreparser.
...
These tests ensure that PreParser doesn't start producing less data when it's
getting refactored.
BUG=3126
LOG=N
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/157373002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19192 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-07 10:28:00 +00:00
hpayer@chromium.org
3f86546bb4
The allocation sites scratchpad becomes a heap data structure.
...
BUG=
R=mstarzinger@chromium.org , mvstanton@chromium.org
Review URL: https://codereview.chromium.org/143153008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19189 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-07 09:54:52 +00:00
bmeurer@chromium.org
4bab63d79d
Prepare push to trunk. Now working on version 3.24.35.
...
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/157343002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-07 09:10:56 +00:00
bmeurer@chromium.org
eee40ea690
Fix printing of GVN flags.
...
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/142253003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19185 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-07 08:59:20 +00:00
marja@chromium.org
5b890419f5
Unify PreParser::ParseIdentifierName and Parser::ParseIdentifierName.
...
No special handling for keywords is needed, since the literal ascii strings for
them work too (see how Parser did it).
BUG=3126
LOG=N
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/152853006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19184 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-07 08:45:28 +00:00
svenpanne@chromium.org
cb6e1b4536
Win64 fixes.
...
TBR=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/157243004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-07 07:44:19 +00:00
bmeurer@chromium.org
2b60325def
[Sheriff] Revert "Check elimination temporarily disabled.", "Fix for buildbot failure after r19102." and "Check elimination improvement: propagation of state through phis is supported, CheckMap narrowing implemented."
...
This reverts commit r19102, r19105 and r19170 for breaking the
Chrome browser_tests. Will reland once fixed.
R=ishell@chromium.org
Review URL: https://codereview.chromium.org/130053007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-07 07:36:30 +00:00
svenpanne@chromium.org
bda84eaf23
Make LeakSanitizer happy, part 2. Fixed register usage on the way.
...
Note that according to the System V ABI for AMD64, rbx must be
preserved across calls. We actually crash with clang in the x64
assembler tests without that fix, we were lucky with GCC.
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/144313017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19178 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-07 07:06:13 +00:00
haitao.feng@intel.com
c3ba22ade9
Use StackArgumentsAccessor to access receiver on stack, use kPCOnStackSize to
...
access stack argument and use movq instead of movp to operate return address
on stack for x64
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/156663002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19177 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-07 02:21:18 +00:00
rafaelw@chromium.org
41039c4f13
Revert "Implement Microtask Delivery Queue"
...
TBR=adamk,rossberg
BUG=
Review URL: https://codereview.chromium.org/150103012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19176 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-07 01:08:50 +00:00
plind44@gmail.com
8b40e37380
MIPS: Avoid embedding x86 NaN constant in MacroAssembler code when snapshot is created.
...
BUG=
TEST=test262/15.4.4.15-8-b-ii-4
R=plind44@gmail.com
Review URL: https://codereview.chromium.org/156803003
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19175 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-07 00:55:04 +00:00
ishell@chromium.org
4a0d4109e4
Check elimination temporarily disabled.
...
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/149523004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19170 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 17:31:00 +00:00
plind44@gmail.com
f74501c627
MIPS: swap in global proxy on accessors.
...
Port r19142 (087bc3e)
BUG=
R=plind44@gmail.com
Review URL: https://codereview.chromium.org/140893011
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19168 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 16:45:50 +00:00
rossberg@chromium.org
01f5601129
ES6: Remove __proto__ setter poison pill
...
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-set-object.prototype.__proto__
The __proto__ setter should be reusable on other objects.
BUG=v8:2804
LOG=y
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/103343005
Patch from Erik Arvidsson <arv@chromium.org>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19165 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 16:09:45 +00:00
palfia@homejinni.com
fca3f16b46
Add support to automatically search for corresponding architecture ports in merge-to-branch.sh.
...
BUG=
R=jkummerow@chromium.org , plind44@gmail.com
Review URL: https://codereview.chromium.org/152343011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19163 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 15:34:46 +00:00
marja@chromium.org
032999da4c
Merge Parser::ReportUnexpectedToken and PreParser::ReportUnexpectedToken.
...
(I.e., move ReportUnexpectedToken to ParserBase.)
Because of the recent unifications, they now do the same thing.
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/153743006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19161 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 15:10:21 +00:00
ishell@chromium.org
a26bd05be3
Optimized stores of smis on x64 temporarily disabled.
...
BUG=338425
LOG=N
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/132753008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19155 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 13:16:44 +00:00
marja@chromium.org
42ea494cd6
Redo r19140 with better efficiency.
...
Still relevant parts of the original commit message:
Unify paren handling in Parser and PreParser.
It is only needed in (Pre)Parser::ParseExpressionOrLabelledStatement for not
recognizing parenthesized identifiers as labels and in
(Pre)Parser::ParseSourceElements for not recognizing a parenthesized string as
directive prologue.
Parser Expressions don't keep track of whether they're parenthesized, so
PreParser Expressions shouldn't either.
BUG=3126
LOG=N
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/148323011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19153 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 13:12:10 +00:00
verwaest@chromium.org
43c0a419ed
Remove special ArrayLength handling already covered by JSObjectFieldAccessors
...
R=dslomov@chromium.org
Review URL: https://codereview.chromium.org/153743005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19152 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 13:01:38 +00:00
jarin@chromium.org
476881ce5b
Test and fix for _CallFunction intrinsic deoptimization.
...
I have also cleaned up HOptimizedGraphBuilder::GenerateCallFunction
to use IfBuilder.
R=jkummerow@chromium.org
BUG=
Review URL: https://codereview.chromium.org/131343013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19151 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 12:42:26 +00:00
bmeurer@chromium.org
e14463e07e
Cosmetic cleanup for GVN.
...
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/153563006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19150 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 12:35:17 +00:00
svenpanne@chromium.org
4ab3270dd5
Fixed space leak in DebuggerAgentSession.
...
Ownership in this part is still very convoluted and should probably be
cleaned up, this is only the minimal CL needed to fix the leak.
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/153623009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 12:09:08 +00:00
marja@chromium.org
e6bc60c98d
Revert "Unify paren handling in Parser and PreParser."
...
This reverts r19140.
Reason: Octane regression.
BUG=
TBR=verwaest@chromium.org
Review URL: https://codereview.chromium.org/156673002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19147 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 11:59:16 +00:00
hpayer@chromium.org
88b45eef17
Just calculate pretenuring ratio when needed.
...
BUG=
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/153863005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19144 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 11:27:08 +00:00
dcarney@chromium.org
12039c97c6
swap in global proxy on accessors
...
R=verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/156623002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19142 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 10:50:07 +00:00
hpayer@chromium.org
9b61008f27
Cleanup allocation site pretenuring tracing, added new flag --trace-pretenuring-statistics.
...
BUG=
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/153273003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19141 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 10:30:13 +00:00
marja@chromium.org
76646e88ed
Unify paren handling in Parser and PreParser.
...
It is only needed in (Pre)Parser::ParseExpressionOrLabelledStatement for not
recognizing parenthesized identifiers as labels and in
(Pre)Parser::ParseSourceElements for not recognizing a parenthesized string as
directive prologue.
Parser Expressions don't keep track of whether they're parenthesized, so
PreParser Expressions shouldn't either.
In addition, add helper funcs for checking if an Expression is identifier or a
given identifier. (PreParser Expressions can do this.)
BUG=3126
LOG=N
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/150103004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19140 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 10:30:02 +00:00
svenpanne@chromium.org
8472a55b0c
Fixed space leak in Interface class.
...
The exports_ hash map itself should live in the zone, too, not only
its entries.
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/156643002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19138 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 10:23:22 +00:00
marja@chromium.org
931fae7d1c
Follow-up to r19112.
...
There's only one error message for "eval" and "arguments", so no need to pass it
to PreParser::StrictModeIdentifierViolation.
BUG=3126
LOG=N
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/139713005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19137 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 10:16:25 +00:00
bmeurer@chromium.org
e02a9d5361
Reduce memory usage due to fixpoint iteration of GVN.
...
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/153533003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19135 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 09:54:59 +00:00
jarin@chromium.org
eb502fe599
Binary operation deoptimization fix.
...
R=jkummerow@chromium.org
BUG=
Review URL: https://codereview.chromium.org/132453009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19132 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 09:36:55 +00:00
dcarney@chromium.org
6df537d631
inline api setters in crankshaft
...
R=verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/155913002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 07:31:08 +00:00
svenpanne@chromium.org
f0bf110448
Make LeakSanitizer happy, part 1.
...
Bumped an assembler buffer on the way, it is necessary for some combinations of debugging flags.
Note that the allocation profiler still leaks, this is handled in a separate CL.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/152643006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19128 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 07:16:41 +00:00
svenpanne@chromium.org
25df21cca1
Fix allocation tracker leaks.
...
R=yangguo@chromium.org , yurys@chromium.org
Review URL: https://codereview.chromium.org/155513004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19127 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 07:10:59 +00:00
plind44@gmail.com
79e354163f
MIPS: Fixes for patch sites if long branches are emitted.
...
This resolves many mjsunit failures if long branches are forced to be emitted.
TEST=
BUG=
R=plind44@gmail.com
Review URL: https://codereview.chromium.org/153983002
Patch from Dusan Milosavljevic <Dusan.Milosavljevic@rt-rk.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19126 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 01:10:06 +00:00
machenbach@chromium.org
bae7a2d886
Prepare push to trunk. Now working on version 3.24.34.
...
R=jkummerow@chromium.org
TBR=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/152483005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19123 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-06 01:05:58 +00:00
palfia@homejinni.com
62034d91fd
MIPS: Move failing ASSERT to a more sane place.
...
Port r19095 (caf48ad)
Original commit message:
Objects can actually be stored into themselves. This fails when no write
barrier is needed (eg, the object was just allocated).
BUG=
R=plind44@gmail.com
Review URL: https://codereview.chromium.org/149343003
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19122 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 22:31:24 +00:00
plind44@gmail.com
ec0c4b453f
MIPS: Fix crashes after profile entry hook calls.
...
The call to C++ function has to be done through t9 register for
the position independent code.
The crashes occur only for shared library build.
TEST=cctest/test-api/SetFunctionEntryHook
BUG=
R=plind44@gmail.com
Review URL: https://codereview.chromium.org/132113009
Patch from Dusan Milosavljevic <Dusan.Milosavljevic@rt-rk.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19121 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 22:28:46 +00:00
plind44@gmail.com
a540e31471
MIPS: Avoid embedding x86 NaN constant in code when snapshot is created.
...
Due to a different NaN representation on MIPS, the canonical nan
constant embedded in generated code that comes from snapshot will differ from
the one used on MIPS hardware.
TEST=mozilla/ecma/Array/15.4.4.2.js
BUG=
R=plind44@gmail.com
Review URL: https://codereview.chromium.org/150663009
Patch from Dusan Milosavljevic <Dusan.Milosavljevic@rt-rk.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19118 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 18:58:16 +00:00
hpayer@chromium.org
d2a2f83574
Perform a fix point iteration for GVN.
...
BUG=
R=danno@chromium.org
Review URL: https://codereview.chromium.org/149573014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19115 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 17:21:34 +00:00
marja@chromium.org
8150464209
Make strict more error messages about "eval" and "arguments" less specific.
...
We used to have error messages which provide context, like "Variable name may
not be eval or arguments in strict mode", but for other illegal words we only
have non-context specific error messages like "Unexpected reserved word".
Providing the context makes the code unnecessarily complex, since every
individual place must remember to check for eval or arguments. This CL produces
a unified error message ("Unexpected eval or arguments in strict mode"), and puts
the error reporting to (Pre)Parser::ParseIdentifier.
Notes:
- The module feature is so experimental, that I decided to not allow "eval" or
"arguments" as module-related identifiers in the strict mode (even though this
check wasn't there before).
- Unfortunately, there were some inconsistencies, since it was the
responsibility of the caller of ParseIdentifier to check "eval" and "arguments"
and some places didn't have the check for no good reason. This CL is supposed to
keep backward compatibility and *not* introduce any new errors.
- ECMA allows "eval" and "arguments" as labels even in strict mode. (Syntax:
"LabelledStatement: Identifier : Statement", and no strict mode restrictions on
Identifier are listed.)
- Tests which compare error message strings will fail, and need to be updated.
BUG=3126
LOG=N
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/152813005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19112 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 16:26:48 +00:00
dcarney@chromium.org
5028ebaa8b
inline api getters in crankshaft
...
R=verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/146023004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 15:52:31 +00:00
verwaest@chromium.org
5949fe1679
Merge named part of BuildLoad and BuildStore
...
BUG=
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/149803007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19109 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 15:44:20 +00:00
verwaest@chromium.org
d985948c7a
Merge BuildLoad/StoreMonomorphic
...
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/137263021
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19108 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 15:43:33 +00:00
marja@chromium.org
14a90fcc57
Better tests for the Parser / Preparser unification.
...
We need a way to assert that for a given source code snippet, an error *is*
produced or *is not* produced. Otherwise we might accidentally create new
errors or start accepting code which was previously not accepted. Just checking
that Parser and PreParser produce the same result doesn't cut it.
BUG=3126
LOG=N
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/154243005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19107 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 15:30:01 +00:00
verwaest@chromium.org
cb044fa2d8
Merge polymorphic load/store handling
...
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/150573010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19106 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 15:28:57 +00:00
ishell@chromium.org
9743d254f3
Fix for buildbot failure after r19102.
...
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/149093011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19105 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 15:22:54 +00:00
ishell@chromium.org
a11899ff4e
Check elimination improvement: propagation of state through phis is supported, CheckMap narrowing implemented.
...
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/141653009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19102 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 13:39:55 +00:00
yangguo@chromium.org
5fadbd9e2f
Fix %OptimizeFunctionOnNextCall wrt concurrent compilation.
...
If a function is marked or queued for concurrent compilation,
%OptimizeFunctionOnNextCall becomes a no-op. That can be wrong
if concurrent recompilation does not complete at the time we
expect the function to have been optimized.
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/151343006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19100 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-05 12:19:29 +00:00