AuroraMiddleware/v8

Fork 0

Commit Graph

Author	SHA1	Message	Date
svenpanne@chromium.org	d0fe04447e	Fixed evaluation order issue in defineProperties. This is not covered by test262 yet, but it really makes sense and matches Firefox's behaviour. TEST=mjsunit/define-properties.js Review URL: http://codereview.chromium.org/8349031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00	2011-10-19 09:52:08 +00:00
yangguo@chromium.org	86a62d0da3	Added check for trailing whitespaces and corrected existing violations. Review URL: http://codereview.chromium.org/7826007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9094 ce2b1a6d-e550-0410-aec6-3dcde31c8c00	2011-09-01 11:28:10 +00:00
ricow@chromium.org	4f179b09ba	Added IsProperty() check to result in DefineOrRedefineAccessor - if no check this causes the debug check to fails since type() asserts that the lookup_type != NOT_FOUND. This does not change any functionality since we explicitly checked if it was one of the three types that we need to delete. Also changed defineProperties in v8natives to actually return the object being defined (as specified by spec) Review URL: http://codereview.chromium.org/572003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3794 ce2b1a6d-e550-0410-aec6-3dcde31c8c00	2010-02-04 11:28:03 +00:00

Author

SHA1

Message

Date

svenpanne@chromium.org

d0fe04447e

Fixed evaluation order issue in defineProperties.

This is not covered by test262 yet, but it really makes sense and matches Firefox's behaviour.

TEST=mjsunit/define-properties.js
Review URL: http://codereview.chromium.org/8349031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2011-10-19 09:52:08 +00:00

yangguo@chromium.org

86a62d0da3

Added check for trailing whitespaces and corrected existing violations.

Review URL: http://codereview.chromium.org/7826007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9094 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2011-09-01 11:28:10 +00:00

ricow@chromium.org

4f179b09ba

Added IsProperty() check to result in DefineOrRedefineAccessor - if no check

this causes the debug check to fails since type() asserts that the 
lookup_type != NOT_FOUND. This does not change any functionality since we 
explicitly checked if it was one of the three types that we need to delete.
Also changed defineProperties in v8natives to actually return the object
being defined (as specified by spec)

Review URL: http://codereview.chromium.org/572003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3794 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2010-02-04 11:28:03 +00:00

3 Commits