AuroraMiddleware/v8

Fork 0

Commit Graph

Author	SHA1	Message	Date
yangguo@chromium.org	aa3518a0f3	Make sure files end with exactly one new line and police this in presubmit. The changes are (excluding presubmit.py) mechanical. I added the following lines after the check and iterated the presubmit script until all errors went away: f = open(name, "w"); if contents.endswith('\n\n'): f.write(contents[0:-1]) else: f.write(contents + '\n') R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/82803005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18017 ce2b1a6d-e550-0410-aec6-3dcde31c8c00	2013-11-22 13:50:39 +00:00
yangguo@chromium.org	7c2a1346d6	Fix edge case in stack trace formatting. Bug description: in strict mode, null as receiver is not implicitly converted to the global object, so that when formatting the stack trace, the receiver of the stack frame is null. The IS_OBJECT check returns true for null, but %GetDataProperty expected a JSObject, which results in a failed RUNTIME_ASSERT. R=mvstanton@chromium.org BUG=237617 Review URL: https://chromiumcodereview.appspot.com/15670003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14797 ce2b1a6d-e550-0410-aec6-3dcde31c8c00	2013-05-24 11:33:46 +00:00

Author

SHA1

Message

Date

yangguo@chromium.org

aa3518a0f3

Make sure files end with exactly one new line and police this in presubmit.

The changes are (excluding presubmit.py) mechanical. I added the following
lines after the check and iterated the presubmit script until all errors
went away:

f = open(name, "w");
if contents.endswith('\n\n'):
  f.write(contents[0:-1])
else:
  f.write(contents + '\n')

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/82803005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18017 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2013-11-22 13:50:39 +00:00

yangguo@chromium.org

7c2a1346d6

Fix edge case in stack trace formatting.

Bug description: in strict mode, null as receiver is not implicitly converted
to the global object, so that when formatting the stack trace, the receiver of
the stack frame is null. The IS_OBJECT check returns true for null, but
%GetDataProperty expected a JSObject, which results in a failed RUNTIME_ASSERT.

R=mvstanton@chromium.org
BUG=237617

Review URL: https://chromiumcodereview.appspot.com/15670003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14797 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2013-05-24 11:33:46 +00:00

2 Commits