4 Commits

Author	SHA1	Message	Date
Erik Luo	d9806cec94	DevTools: also use default label for console.count ... Aligns console.count() behavior with spec, which says the default label should be "default" when the label provided is not defined. Bug: chromium:700624 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie58af210d300ef3151082b23187dd18e356f5de8 Reviewed-on: https://chromium-review.googlesource.com/780620 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49804}	2017-12-01 20:17:20 +00:00
Alexey Kozyatinskiy	292e96709c	[inspector] catch exception during object.toString() call for console ... Console methods should never throw an exception. R=jgruber@chromium.org Bug: chromium:736302 Change-Id: I05791b366d46a43b2a78825cbb8a82bb049110e6 Reviewed-on: https://chromium-review.googlesource.com/567434 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#46573}	2017-07-12 06:01:42 +00:00
Michael Achenbach	c917ecfe4e	Revert "[inspector] doesn't run user code to stringify console method arg" ... This reverts commit 82451d45a7. Reason for revert: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/16923 Original change's description: > [inspector] doesn't run user code to stringify console method arg > > Otherwise user code can produce an exception and we will crash. > > R=​jakob@chromium.org > > Bug: chromium:736302 > Change-Id: I078150909b0348a63e8c375b508e34fc4751b4ab > Reviewed-on: https://chromium-review.googlesource.com/565628 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46566} TBR=kozyatinskiy@chromium.org,jgruber@chromium.org,jakob@chromium.org Change-Id: I6d7e06fad2ab6c1c894c199fe7b3b6afb2930734 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:736302 Reviewed-on: https://chromium-review.googlesource.com/567060 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#46567}	2017-07-11 19:27:49 +00:00
Alexey Kozyatinskiy	82451d45a7	[inspector] doesn't run user code to stringify console method arg ... Otherwise user code can produce an exception and we will crash. R=jakob@chromium.org Bug: chromium:736302 Change-Id: I078150909b0348a63e8c375b508e34fc4751b4ab Reviewed-on: https://chromium-review.googlesource.com/565628 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46566}	2017-07-11 17:18:42 +00:00