Clemens Hammacher
f29cae45ce
[wasm] Fix emitting element section in wasm-module-builder.js
...
We were emitting the table index once in the element section instead of
once per element segment. This did not cause failures because we never
had more than one element segment.
This CL fixes this, and adds a test for more than one segment.
R=rossberg@chromium.org
Change-Id: I13923baf3dae383c72760286e24242d0ad55c4db
Reviewed-on: https://chromium-review.googlesource.com/527155
Reviewed-by: Andreas Rossberg <rossberg@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45857}
2017-06-12 12:45:36 +00:00
gdeepti
930142e877
[wasm] Update table bounds when module is instantiated with a table import
...
When WebAssembly.Table initial size is greater than the declared initial size, table size references should be updated on instantiate for functions to be called at indices greater than the declared initial size.
R=bradnelson@chromium.org , titzer@chromium.org
Review-Url: https://codereview.chromium.org/2661773002
Cr-Commit-Position: refs/heads/master@{#42781}
2017-01-30 18:10:32 +00:00
rossberg
d62914f6e9
[wasm] check that there is at most 1 table
...
R=titzer@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2643783002
Cr-Commit-Position: refs/heads/master@{#42465}
2017-01-18 15:36:22 +00:00
titzer
8d76f0e346
[wasm] Enforce memory and table limits during instantiation.
...
R=rossberg@chromium.org
BUG=chromium:575167
Review-Url: https://codereview.chromium.org/2636173002
Cr-Commit-Position: refs/heads/master@{#42426}
2017-01-17 19:15:59 +00:00
titzer
7d42244a7e
[wasm] Enforce that function bodies end with the \"end\" opcode.
...
R=rossberg@chromium.org
BUG=chromium:575167
Review-Url: https://codereview.chromium.org/2630553002
Cr-Original-Original-Commit-Position: refs/heads/master@{#42286}
Committed: fcc6e85ec6https://codereview.chromium.org/2630553002
Cr-Original-Commit-Position: refs/heads/master@{#42315}
Committed: 74a2f9b7d3https://codereview.chromium.org/2630553002
Cr-Commit-Position: refs/heads/master@{#42350}
2017-01-15 21:18:53 +00:00
gdeepti
ccf0998d63
[wasm] Table.Grow should grow dispatch tables
...
- Table.Grow updates function, signature table sizes
- Updates generated code with new base addresses for function, signature tables
- Relocates size references for correct bounds check
R=bradnelson@chromium.org , titzer@chromium.org
Review-Url: https://codereview.chromium.org/2637643002
Cr-Commit-Position: refs/heads/master@{#42349}
2017-01-15 07:46:08 +00:00
titzer
55fc5c0c32
[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm*
...
This is more renaming work to comply with the naming in the public
design repository. E.g. types are called "value types" and we no longer
refer to ASTs.
R=clemensh@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2594993002
Cr-Commit-Position: refs/heads/master@{#41891}
2016-12-21 13:43:00 +00:00
titzer
6e8338865a
[wasm] Implement correct 2-level namespace for imports.
...
R=clemensh@chromium.org
CC=rossberg@chromium.org
BUG=chromium:575167
Review-Url: https://codereview.chromium.org/2591753002
Cr-Commit-Position: refs/heads/master@{#41866}
2016-12-20 15:32:56 +00:00
titzer
f897e36c8c
[wasm] Names of exported functions should be the stringified function index.
...
R=bradnelson@chromium.org ,rossberg@chromium.org
BUG=v8:5705
Review-Url: https://codereview.chromium.org/2551323003
Cr-Commit-Position: refs/heads/master@{#41530}
2016-12-06 15:33:42 +00:00
titzer
b7aff1ff64
[wasm] Support for restricted table imports.
...
This CL implements basic table import functionality.
Missing: growing of tables (WebAssembly.Grow) doesn't change dispatch tables
Missing: allowing larger table imports than minimum size
R=rossberg@chromium.org ,bradnelson@chromium.org
BUG=v8:5507
Review-Url: https://codereview.chromium.org/2454503005
Cr-Commit-Position: refs/heads/master@{#40661}
2016-10-29 21:07:38 +00:00
machenbach
bc0ee727df
Revert of [wasm] Support for restricted table imports. (patchset #7 id:120001 of https://codereview.chromium.org/2454503005/ )
...
Reason for revert:
GC stress failures:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/8857
Original issue's description:
> [wasm] Support for restricted table imports.
>
> This CL implements basic table import functionality.
>
> Missing: growing of tables (WebAssembly.Grow) doesn't change dispatch tables
> Missing: allowing larger table imports than minimum size
>
> R=rossberg@chromium.org ,bradnelson@chromium.org
> BUG=v8:5507
TBR=bradnelson@chromium.org ,rossberg@chromium.org,titzer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5507
Review-Url: https://codereview.chromium.org/2456193006
Cr-Commit-Position: refs/heads/master@{#40656}
2016-10-28 18:58:54 +00:00
titzer
404e215458
[wasm] Support for restricted table imports.
...
This CL implements basic table import functionality.
Missing: growing of tables (WebAssembly.Grow) doesn't change dispatch tables
Missing: allowing larger table imports than minimum size
R=rossberg@chromium.org ,bradnelson@chromium.org
BUG=v8:5507
Review-Url: https://codereview.chromium.org/2454503005
Cr-Commit-Position: refs/heads/master@{#40652}
2016-10-28 18:03:50 +00:00
titzer
3f207617d7
[wasm] Binary 0xD: update encoding of opcodes, types, and add immediates.
...
R=ahaas@chromium.org ,rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org
BUG=chromium:575167, chromium:659591
Review-Url: https://codereview.chromium.org/2440953002
Cr-Commit-Position: refs/heads/master@{#40600}
2016-10-26 16:56:49 +00:00
titzer
ad9cf53473
[wasm] Add support for exporting WebAssembly.Table instances.
...
R=bradnelson@chromium.org , rossberg@chromium.org
BUG=v8:5507
Review-Url: https://codereview.chromium.org/2443353002
Cr-Commit-Position: refs/heads/master@{#40554}
2016-10-25 09:44:51 +00:00
