Commit Graph

350 Commits

Author SHA1 Message Date
machenbach
7f3954c57b [build] Move gyp folder
Uses now the same location chromium uses and which some tools
expect.

BUG=chromium:474921
LOG=n

Review URL: https://codereview.chromium.org/1929473002

Cr-Commit-Position: refs/heads/master@{#35817}
2016-04-27 12:37:35 +00:00
v8-autoroll
c9d9016d4b Update V8 DEPS.
Rolling v8/build/gyp to 4cf07e8d616739f6484e46c9359b2a35196b2585

Rolling v8/buildtools to 2a9a29fbdc2170c25e5cc0f642213eb7b3e7bc98

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1917073004

Cr-Commit-Position: refs/heads/master@{#35783}
2016-04-26 08:38:59 +00:00
machenbach
4377c2f583 [build] Update V8 DEPS
Rolling v8/tools/clang to
b6f620b311665e2d96d0921833f54295b9bbf925

Porting parts of https://codereview.chromium.org/1917853002

BUG=604993
LOG=n
TBR=thakis@chromium.org, jochen@chromium.org

Review URL: https://codereview.chromium.org/1923473002

Cr-Commit-Position: refs/heads/master@{#35782}
2016-04-26 07:51:34 +00:00
v8-autoroll
fed8f3a55b Update V8 DEPS.
Rolling v8/tools/clang to db76f9f1d1ed7f4c4db1bf10f530506614375db3

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1912413002

Cr-Commit-Position: refs/heads/master@{#35746}
2016-04-25 03:16:22 +00:00
v8-autoroll
af1866f462 Update V8 DEPS.
Rolling v8/buildtools to e84114dbe2b65428951c876349b6a3ff1afbfccd

Rolling v8/tools/clang to 2956eca572ff0e1b181df65f71a045f061a2eb34

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1909483004

Cr-Commit-Position: refs/heads/master@{#35690}
2016-04-21 09:12:12 +00:00
v8-autoroll
dfb945d543 Update V8 DEPS.
Rolling v8/tools/clang to d9ee849b2aa65cef903af3044e03205d92343093

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1883413002

Cr-Commit-Position: refs/heads/master@{#35524}
2016-04-15 12:35:35 +00:00
v8-autoroll
88556b709b Update V8 DEPS.
Rolling v8/buildtools to 5378d73123b64907773cc5c1bb027b2f765ff00a

Rolling v8/tools/clang to 41bff4c5ba97022c0fe69a59d8892a6c45fb0867

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1889043002

Cr-Commit-Position: refs/heads/master@{#35505}
2016-04-15 06:24:28 +00:00
v8-autoroll
2469be9e09 Update V8 DEPS.
Rolling v8/build/gyp to 6ea68631cdabab9b7c5257657567a785a261692e

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1886223002

Cr-Commit-Position: refs/heads/master@{#35463}
2016-04-14 03:19:48 +00:00
v8-autoroll
57884362e4 Update V8 DEPS.
Rolling v8/buildtools to de013cf87971d0ab40596f2275a633432c908052

Rolling v8/tools/clang to 05a5cb33164e3c656a3375a1614ab350ca799215

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1883703003

Cr-Commit-Position: refs/heads/master@{#35428}
2016-04-13 03:18:55 +00:00
v8-autoroll
a62104dfbe Update V8 DEPS.
Rolling v8/buildtools to a2082cafead67b75c9c8edbdca47a2def6dbab21

Rolling v8/tools/clang to 9dc1904d214a77f081362c1b848b5f28d2192748

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1876583002

Cr-Commit-Position: refs/heads/master@{#35367}
2016-04-09 03:29:50 +00:00
v8-autoroll
84ed760915 Update V8 DEPS.
Rolling v8/tools/clang to 88d00d95febafac2dbe501850d0f53e95e4db291

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1867573005

Cr-Commit-Position: refs/heads/master@{#35343}
2016-04-08 03:25:59 +00:00
v8-autoroll
ea61d86f0d Update V8 DEPS.
Rolling v8/tools/clang to f9d7a272792022ffdfc9bd2cd0c901b824baf029

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1868873003

Cr-Commit-Position: refs/heads/master@{#35317}
2016-04-07 03:20:19 +00:00
v8-autoroll
10027372bf Update V8 DEPS.
Rolling v8/third_party/icu to c291cde264469b20ca969ce8832088acb21e0c48

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1863963002

Cr-Commit-Position: refs/heads/master@{#35280}
2016-04-06 03:26:43 +00:00
v8-autoroll
0e8b7542a1 Update V8 DEPS.
Rolling v8/base/trace_event/common to c8c8665c2deaf1cc749d9f8e153256d4f67bf1b8

Rolling v8/build/gyp to 4ec6c4e3a94bd04a6da2858163d40b2429b8aad1

Rolling v8/tools/clang to faee82e064e04e5cbf60cc7327e7a81d2a4557ad

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1856133003

Cr-Commit-Position: refs/heads/master@{#35248}
2016-04-05 06:19:13 +00:00
v8-autoroll
f5a95d2b59 Update V8 DEPS.
Rolling v8/base/trace_event/common to ffb39885a2418caa7a6a6652471fe097732675bd

Rolling v8/tools/clang to 8f7a85a108698ce7ed4fe1aa842efa61f195364e

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1859433002

Cr-Commit-Position: refs/heads/master@{#35223}
2016-04-03 03:24:21 +00:00
v8-autoroll
edc8acffda Update V8 DEPS.
Rolling v8/base/trace_event/common to 0fc98828a66ee4d69b9524e4967b9287b7b8eea0

Rolling v8/build/gyp to 697933c2e3b3ffdd6949df3c2fa3613489e01175

Rolling v8/tools/clang to 87058e09f9c547eb5d00cb8ca666c6aec203a117

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1853783004

Cr-Commit-Position: refs/heads/master@{#35219}
2016-04-02 03:32:43 +00:00
v8-autoroll
046414169a Update V8 DEPS.
Rolling v8/third_party/android_tools to adfd31794011488cd0fc716b53558b2d8a67af8b

Rolling v8/third_party/icu to 628d39f5b088236d2021bf4388549fd92673ff1a

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1847623003

Cr-Commit-Position: refs/heads/master@{#35144}
2016-03-31 03:26:43 +00:00
v8-autoroll
d22a7ed415 Update V8 DEPS.
Rolling v8/tools/clang to 51bba1037858028f42141689ed1b3b63a20f0b52

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1838013003

Cr-Commit-Position: refs/heads/master@{#35088}
2016-03-29 03:28:28 +00:00
v8-autoroll
0af32aaf4c Update V8 DEPS.
Rolling v8/build/gyp to 28340b46df65f2c84f7793470189a0b395e1c9a4

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1839563002

Cr-Commit-Position: refs/heads/master@{#35080}
2016-03-27 03:21:38 +00:00
v8-autoroll
a4b5b77a4a Update V8 DEPS.
Rolling v8/tools/clang to 43ef5b7210286664ce0ed7581c90e7797d80ea28

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1831303005

Cr-Commit-Position: refs/heads/master@{#35077}
2016-03-26 03:35:55 +00:00
v8-autoroll
47cce544a3 Update V8 DEPS.
Rolling v8/buildtools to 80b5126f91be4eb359248d28696746ef09d5be67

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1834743004

Cr-Commit-Position: refs/heads/master@{#35070}
2016-03-25 03:21:41 +00:00
v8-autoroll
373cf6b2a2 Update V8 DEPS.
Rolling v8/build/gyp to 8e8c3178d9d2734a6223b87fbd45ab250baf77e8

Rolling v8/tools/clang to c789a99803595dfa963ba300ac79b760d1304d8c

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1834583002

Cr-Commit-Position: refs/heads/master@{#35050}
2016-03-24 03:21:06 +00:00
v8-autoroll
99ebb5bab4 Update V8 DEPS.
Rolling v8/tools/clang to f5219dd53ee7a87a07085ce03083456231ba0c27

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1825283005

Cr-Commit-Position: refs/heads/master@{#35009}
2016-03-23 03:24:00 +00:00
v8-autoroll
dcee82d61e Update V8 DEPS.
Rolling v8/third_party/android_tools to 19728471dd63a968668288488403286b68e4ae9e

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1821943002

Cr-Commit-Position: refs/heads/master@{#34970}
2016-03-22 03:38:37 +00:00
machenbach
741ec01107 Update V8 DEPS.
Rolling v8/build/gyp to 133eaf70b3720b7413017ef3f9c42f6811ef9347

Rolling v8/third_party/icu to 0d572d65aae621e13d6863fe470c9c8cee71043d

This is the same as the auto-generated version, but with a
landmine: https://codereview.chromium.org/1824563002/

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Committed: https://crrev.com/1d6dba43c2b61900be68777297634e05d479a25a
Cr-Commit-Position: refs/heads/master@{#34914}

patch from issue 1824563002 at patchset 1 (http://crrev.com/1824563002#ps1)

BUG=

Review URL: https://codereview.chromium.org/1820823002

Cr-Commit-Position: refs/heads/master@{#34921}
2016-03-21 08:57:06 +00:00
bmeurer
27bce81995 Revert of Update V8 DEPS. (patchset #1 id:1 of https://codereview.chromium.org/1824563002/ )
Reason for revert:
ICU breakage.

Original issue's description:
> Update V8 DEPS.
>
> Rolling v8/build/gyp to 133eaf70b3720b7413017ef3f9c42f6811ef9347
>
> Rolling v8/third_party/icu to 0d572d65aae621e13d6863fe470c9c8cee71043d
>
> TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
>
> Committed: https://crrev.com/1d6dba43c2b61900be68777297634e05d479a25a
> Cr-Commit-Position: refs/heads/master@{#34914}

TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1816023002

Cr-Commit-Position: refs/heads/master@{#34915}
2016-03-21 05:34:36 +00:00
v8-autoroll
1d6dba43c2 Update V8 DEPS.
Rolling v8/build/gyp to 133eaf70b3720b7413017ef3f9c42f6811ef9347

Rolling v8/third_party/icu to 0d572d65aae621e13d6863fe470c9c8cee71043d

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1824563002

Cr-Commit-Position: refs/heads/master@{#34914}
2016-03-21 03:26:45 +00:00
v8-autoroll
b33076d114 Update V8 DEPS.
Rolling v8/tools/clang to a00149535c011c08b6e8cc583a1f10f38d3cdaf9

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1817713002

Cr-Commit-Position: refs/heads/master@{#34911}
2016-03-19 03:23:32 +00:00
v8-autoroll
00f5345c05 Update V8 DEPS.
Rolling v8/tools/clang to c642451e861b9c568967fb8e4d9d3fd081699162

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1803953002

Cr-Commit-Position: refs/heads/master@{#34765}
2016-03-15 03:26:52 +00:00
v8-autoroll
7b48773d7e Update V8 DEPS.
Rolling v8/tools/clang to 1e45fb0482b997a87bff1d5edfeac5b2c5458943

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1796443002

Cr-Commit-Position: refs/heads/master@{#34735}
2016-03-13 04:24:58 +00:00
v8-autoroll
46542b885d Update V8 DEPS.
Rolling v8/buildtools to 7274f1c726640bce4cd4c4198e1ee62a0b29bb89

Rolling v8/third_party/icu to 6d3b55dfa17d9a597c064eeef7ceac18c73184b7

Rolling v8/tools/clang to ec17c92cc70fcd8f5f39eaa17f3dbbd99e29c1f9

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1781313004

Cr-Commit-Position: refs/heads/master@{#34734}
2016-03-12 04:18:34 +00:00
v8-autoroll
457331fb56 Update V8 DEPS.
Rolling v8/tools/clang to 96f43fa6c1232981bc401c0b6f2e2697a318356b

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1781183002

Cr-Commit-Position: refs/heads/master@{#34704}
2016-03-11 08:03:40 +00:00
v8-autoroll
0f8cb27ef0 Update V8 DEPS.
Rolling v8/tools/clang to fc7b250f6ca03bcbcd2cd1a3e4102cb639a2814a

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1784643005

Cr-Commit-Position: refs/heads/master@{#34649}
2016-03-10 04:19:01 +00:00
v8-autoroll
2e7bf37593 Update V8 DEPS.
Rolling v8/tools/clang to 59675c1e00cb17f347eb6da235b3266697b4521d

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1775313002

Cr-Commit-Position: refs/heads/master@{#34604}
2016-03-09 04:40:19 +00:00
v8-autoroll
3293c4862d Update V8 DEPS.
Rolling v8/build/gyp to 61259d585ce99d9de8b35188cd0025bdbcb58411

Rolling v8/tools/clang to 7f949627a42e2b8b229522ab74de5b1b6a1ced3e

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1768263003

Cr-Commit-Position: refs/heads/master@{#34568}
2016-03-08 04:23:47 +00:00
v8-autoroll
38ce972085 Update V8 DEPS.
Rolling v8/tools/clang to 3183208ae119c48012bed71645cb2ca537120811

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1768453002

Cr-Commit-Position: refs/heads/master@{#34475}
2016-03-04 04:27:44 +00:00
v8-autoroll
a3bd39e715 Update V8 DEPS.
Rolling v8/tools/clang to a8288b3f25cdc4e3c3f4dd7ea2f7765ae8847459

Rolling v8/tools/swarming_client to df6e95e7669883c8fe9ef956c69a544154701a49

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1753133002

Cr-Commit-Position: refs/heads/master@{#34418}
2016-03-02 04:23:51 +00:00
v8-autoroll
a4462be1bb Update V8 DEPS.
Rolling v8/base/trace_event/common to e40c41030f44cbd5b6f54081436620f43c3bb08a

Rolling v8/tools/clang to d53e60b4f31f03a6f719b13ed2de7389a4d89be4

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1748313002

Cr-Commit-Position: refs/heads/master@{#34374}
2016-03-01 04:22:51 +00:00
v8-autoroll
8401e94892 Update V8 DEPS.
Rolling v8/tools/clang to e67c4fe288f02e1d208961b757ff78d5b3e51782

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1744783002

Cr-Commit-Position: refs/heads/master@{#34343}
2016-02-27 04:18:38 +00:00
littledan
abe61bdeac Reland of Test262 roll, 2016-2-23 (patchset #1 id:1 of https://codereview.chromium.org/1736223002/ )
Reason for revert:
Intl change relanded https://codereview.chromium.org/1745483002/

Original issue's description:
> Revert of Test262 roll, 2016-2-23 (patchset #2 id:20001 of https://codereview.chromium.org/1738033002/ )
>
> Reason for revert:
> An Intl change that this depends on breaks a bot
>
> Original issue's description:
> > Test262 roll, 2016-2-23
> >
> > R=adamk
> >
> > Committed: https://crrev.com/34492040fbfb04fead21416245c8696b9847e751
> > Cr-Commit-Position: refs/heads/master@{#34312}
>
> TBR=adamk@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/3b829ad80628bf521aa78255c2e5e20040a57b5f
> Cr-Commit-Position: refs/heads/master@{#34313}

TBR=adamk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1739533006

Cr-Commit-Position: refs/heads/master@{#34338}
2016-02-26 19:43:58 +00:00
littledan
3b829ad806 Revert of Test262 roll, 2016-2-23 (patchset #2 id:20001 of https://codereview.chromium.org/1738033002/ )
Reason for revert:
An Intl change that this depends on breaks a bot

Original issue's description:
> Test262 roll, 2016-2-23
>
> R=adamk
>
> Committed: https://crrev.com/34492040fbfb04fead21416245c8696b9847e751
> Cr-Commit-Position: refs/heads/master@{#34312}

TBR=adamk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1736223002

Cr-Commit-Position: refs/heads/master@{#34313}
2016-02-26 05:25:51 +00:00
littledan
34492040fb Test262 roll, 2016-2-23
R=adamk

Review URL: https://codereview.chromium.org/1738033002

Cr-Commit-Position: refs/heads/master@{#34312}
2016-02-26 05:08:16 +00:00
v8-autoroll
4461af8f79 Update V8 DEPS.
Rolling v8/base/trace_event/common to 81b7b6f531ad2375140b2a5f4d3a803e5ba2514c

Rolling v8/buildtools to 14288a03a92856fe1fc296d39e6a25c2d83cd6cf

Rolling v8/tools/swarming_client to a72f46e42dba1335e8001499b4621acad2d26728

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1737243003

Cr-Commit-Position: refs/heads/master@{#34309}
2016-02-26 04:19:17 +00:00
v8-autoroll
24e85029ca Update V8 DEPS.
Rolling v8/tools/clang to 8598a726360f2722f4db0eab732a5f6b4cb41eb9

Rolling v8/tools/swarming_client to 71c61c858bb2c2deda83781978fe65e94171f58f

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1729263004

Cr-Commit-Position: refs/heads/master@{#34265}
2016-02-24 20:38:46 +00:00
v8-autoroll
ced09a7b49 Update V8 DEPS.
Rolling v8/buildtools to 97b5c485707335dd2952c05bf11412ada3f4fb6f

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1723843002

Cr-Commit-Position: refs/heads/master@{#34203}
2016-02-23 04:22:03 +00:00
v8-autoroll
ba1521299d Update V8 DEPS.
Rolling v8/third_party/icu to e466f6ac8f60bb9697af4a91c6911c6fc4aec95f

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1715283002

Cr-Commit-Position: refs/heads/master@{#34184}
2016-02-22 04:17:58 +00:00
v8-autoroll
35e443874b Update V8 DEPS.
Rolling v8/tools/clang to a8adb78c8eda9bddb2aa9c51f3fee60296de1ad4

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1717953002

Cr-Commit-Position: refs/heads/master@{#34179}
2016-02-21 04:19:50 +00:00
v8-autoroll
5990cd6aff Update V8 DEPS.
Rolling v8/tools/clang to 50fc8b6e785aa002218d67b78db871b21b1c9d71

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1710263004

Cr-Commit-Position: refs/heads/master@{#34173}
2016-02-20 04:19:16 +00:00
v8-autoroll
a238a30d08 Update V8 DEPS.
Rolling v8/tools/clang to b194e7fa21cc99980e38ff8b29740e78134fcfce

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1712993002

Cr-Commit-Position: refs/heads/master@{#34133}
2016-02-19 04:25:24 +00:00
machenbach
7a9ebb5846 [Swarming] Bundle jsfunfuzz.
This downloads a patched version of jsfunfuzz from google
storage (google internal bucket) as a hook on demand.

Similar to the gcmole approach from
https://codereview.chromium.org/1703533002/

BUG=chromium:535160
LOG=n

Review URL: https://codereview.chromium.org/1706963005

Cr-Commit-Position: refs/heads/master@{#34106}
2016-02-18 09:47:34 +00:00