littledan
f5e924eb10
Fix user options for fractional digits in Intl.NumberFormatter
...
The patch in https://crrev.com/ddb5c2d999c5ee6e31c4a9599bb3ddb293cc3f49
moved all fractional digit settings to default values due to a coding
error. These were not even correct default values, and users observed
errors where percentages were written as "23.0%" instead of "23%".
This patch fixes the setting propagation when appropriate and it changes
the default max fractional digits of a percentage to 0, per spec.
BUG=chromium:544122
R=mnita,jochen
CC=hichris123,adamk
LOG=Y
Review URL: https://codereview.chromium.org/1420883002
Cr-Commit-Position: refs/heads/master@{#31468}
2015-10-22 11:31:13 +00:00
yangguo
d508345123
Do not expect verbatim JPY symbol in test.
...
The choice for the symbol seems to be locale-dependent.
R=jochen@chromium.org
BUG=v8:4314
LOG=N
Review URL: https://codereview.chromium.org/1238133003
Cr-Commit-Position: refs/heads/master@{#29750}
2015-07-20 10:52:51 +00:00
hichris123
ddb5c2d999
Make NumberFormat use the ICU currency data, fix bug in NumberFormat
...
NumberFormat previously just used a min of 0 digits after the decimal and a max of 3. This CL changes it so that we use the ICU currency data, and set the min and max to the number of numbers after the decimal point for each currency.
This CL also fixes a small bug where if the minimum fraction digits is above 3 but the maximum fraction digits isn't set, then it returns with only three numbers after the decimal point.
BUG=435465,473104,304722
LOG=Y
Review URL: https://codereview.chromium.org/1231613006
Cr-Commit-Position: refs/heads/master@{#29734}
2015-07-17 15:08:08 +00:00
jochen@chromium.org
08be29d8bd
Revert r22544: "Rebaseline/update the intl tests with ICU 52"
...
The intl tests still fail locally.
BUG=v8:3454
LOG=N
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/410083004
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22558 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-07-23 11:39:46 +00:00
jochen@chromium.org
3651a67156
Rebaseline/update the intl tests with ICU 52
...
Update the following 4 intl tests after ICU 52 roll.
date-format/parse-MMMdy.js
date-format/parse-mdyhms.js
number-format/parse-decimal.js
number-format/parse-percent.js
BUG=v8:3454
TEST=intl/* tests pass.
LOG=Y
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/410733003
Patch from Jungshik Shin <jshin@chromium.org>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-07-23 09:00:43 +00:00
jochen@chromium.org
f30452ba40
Store i18n meta data in hidden symbols instead of js accessible properties
...
There were some tests that are supposed to protect against js messing
with the meta data, however, they just didn't try hard enough.
BUG=354967
R=dcarney@chromium.org
LOG=y
Committed: https://code.google.com/p/v8/source/detail?r=20375
Review URL: https://codereview.chromium.org/215293005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20388 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-01 10:56:16 +00:00
machenbach@chromium.org
8806f2d815
Revert r20375.
...
Store i18n meta data in hidden symbols instead of js accessible properties
BUG=354967
LOG=N
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/220673002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20377 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-01 08:05:45 +00:00
jochen@chromium.org
0d04cba759
Store i18n meta data in hidden symbols instead of js accessible properties
...
There were some tests that are supposed to protect against js messing
with the meta data, however, they just didn't try hard enough.
BUG=354967
R=dcarney@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/215293005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20375 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-01 07:21:05 +00:00
jochen@chromium.org
777bae581a
Reenable tests that need to access the default timezone.
...
It's now available via builtins.
BUG=v8:2475
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/21512002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16016 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-08-01 19:43:06 +00:00
jochen@chromium.org
c61c74d24f
Import intl test suite from v8-i18n project
...
BUG=v8:2745
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/18687003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-07-10 10:49:04 +00:00