AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
58,534 Commits 1 Branch 0 Tags 839 MiB
95ec4803fd
Commit Graph

498 Commits

Author SHA1 Message Date
Michael Achenbach
f2ea3d6682 [CQ] Raise experiment percentage for node-integration bot to 100 
Bug: v8:6154
NOTRY=true
TBR=yangguo@chromium.org

Change-Id: I50529f820107dae701476deee285fa62a59374d1
Reviewed-on: https://chromium-review.googlesource.com/469706
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44426}
 2017-04-06 07:40:41 +00:00
machenbach
2ac17e34cd Revert of [build] Temporarily switch off goma on gyp bot (patchset #1 id:1 of https://codereview.chromium.org/2802793002/ ) 
Reason for revert:
A different sysroot config fix was required here.

Original issue's description:
> [build] Temporarily switch off goma on gyp bot
>
> BUG=chromium:708482
> NOTRY=true
> TBR=tandrii@chromium.org
>
> Review-Url: https://codereview.chromium.org/2802793002
> Cr-Commit-Position: refs/heads/master@{#44418}
> Committed: 6cf74cb61b

TBR=tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:708482

Review-Url: https://codereview.chromium.org/2799083002
Cr-Commit-Position: refs/heads/master@{#44420}
 2017-04-05 20:25:14 +00:00
machenbach
6cf74cb61b [build] Temporarily switch off goma on gyp bot 
BUG=chromium:708482
NOTRY=true
TBR=tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2802793002
Cr-Commit-Position: refs/heads/master@{#44418}
 2017-04-05 18:50:09 +00:00
Michael Achenbach
32f096667e [CQ] Raise node-integration experiment percentage to 20 
Bug: v8:6154
NOTRY=true
TBR=yangguo@chromium.org

Change-Id: I7acb31abd5571261740fd95eeb58f104c26b192e
Reviewed-on: https://chromium-review.googlesource.com/468807
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44403}
 2017-04-05 10:21:59 +00:00
Michael Achenbach
1aaafe5a4b [CQ] Add node-integration bot as 10% experiment 
Bug: v8:6154
NOTRY=true
TBR=yangguo@chromium.org

Change-Id: I29e8fd8e12c43478086a35a28249f5f66cd30b6b
Reviewed-on: https://chromium-review.googlesource.com/467429
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44397}
 2017-04-05 07:34:28 +00:00
Adam Klein
74c7dd0bad Enable inspector on noi18n trybot to improve test coverage 
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

Change-Id: Iff5ff2e73d598ecae1be30a61856c1292f2fd6da
Reviewed-on: https://chromium-review.googlesource.com/456646
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44125}
 2017-03-24 20:27:54 +00:00
Michael Achenbach
c90ce43161 [build] Switch interpreted-regexp bot to gn 
Bug: chromium:645890
TBR=yangguo@chromium.org
NOTRY=true

Change-Id: I83bf77a82317c3394d1b81133e52a8b6ecfbe360
Reviewed-on: https://chromium-review.googlesource.com/459418
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44094}
 2017-03-24 11:14:41 +00:00
Michael Achenbach
78ede2b1a3 [build] Switch predictable bot to gn 
BUG=chromium:645890
NOTRY=true
TBR=jochen@chromium.org,vogelheim@chromium.org

Change-Id: I559412b0b85af87494f6d14d0a3b6a016449fc14
Reviewed-on: https://chromium-review.googlesource.com/458657
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44087}
 2017-03-24 08:25:19 +00:00
Michael Achenbach
3cbb2a50c8 [build] Switch vtune_jit bot to gn 
BUG=chromium:645890
NOTRY=true
TBR=jochen@chromium.org,vogelheim@chromium.org

Change-Id: Id0e972bf2480dd9c48e064537090a7bd97431db1
Reviewed-on: https://chromium-review.googlesource.com/458223
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44066}
 2017-03-23 15:41:34 +00:00
bjaideep
a7d07a3d29 [build] Add v8gen support for PPC/s390 architecture 
Add PPC/s390 configs to mb_config and BUILD.gn. Also
use a script to get host byte ordering.

R=machenbach@chromium.org, dpranke@chromium.org
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2736993004
Cr-Commit-Position: refs/heads/master@{#43751}
 2017-03-13 15:05:51 +00:00
Michael Achenbach
7f2771ee95 Revert "[swarming] Dogfood exparchive feature" 
This reverts commit e1f7ae3328.

Reason for revert: Breaks on the bot:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/8773/steps/compile/logs/stdio

Original change's description:
> [swarming] Dogfood exparchive feature
> 
> The new swarming archiving method requires isolate files to be copied to the build dir.
> 
> BUG=chromium:598990
> NOTRY=true
> TBR=tandrii@chromium.org,tansell@chromium.org,vogelheim@chromium.org
> 
> Change-Id: I87633725d9ce715684f761ce0c8d2691642c5389
> Reviewed-on: https://chromium-review.googlesource.com/444644
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#43266}

TBR=machenbach@chromium.org,vogelheim@chromium.org,tandrii@chromium.org,tansell@chromium.org,v8-reviews@googlegroups.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:598990

Change-Id: Ie25205f8df69981fde223a232348534487460808
Reviewed-on: https://chromium-review.googlesource.com/444225
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43271}
 2017-02-17 10:18:41 +00:00
Michael Achenbach
e1f7ae3328 [swarming] Dogfood exparchive feature 
The new swarming archiving method requires isolate files to be copied to the build dir.

BUG=chromium:598990
NOTRY=true
TBR=tandrii@chromium.org,tansell@chromium.org,vogelheim@chromium.org

Change-Id: I87633725d9ce715684f761ce0c8d2691642c5389
Reviewed-on: https://chromium-review.googlesource.com/444644
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43266}
 2017-02-17 07:35:38 +00:00
Andrii Shyshkalov
2d0b1ddf70 CQ config: let CQ check CQ permissions. 
CQ will only allow CL authors (owners in Gerrit) and V8 committers to trigger
CQ in Gerrit codereview. Thus, CQ voting restriction to just committers
can be lifted, letting every authenticated user attempt to trigger CQ.

R=machenbach@chromium.org,agable@chromium.org
BUG=641422,685318
NOTRY=True

Change-Id: Ied310a65277d6fefa44a9945cc780cb8fe827e03
Reviewed-on: https://chromium-review.googlesource.com/442124
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43183}
 2017-02-14 11:30:43 +00:00
Michael Achenbach
c737982c90 [build] Let v8gen support mipsel architectures 
NOTRY=true
R=ishell@chromium.org

Change-Id: I99dc19f9904b24ba491334e76adb9486697e8a12
Reviewed-on: https://chromium-review.googlesource.com/438324
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#42948}
 2017-02-06 09:28:07 +00:00
machenbach
13de00c0be [foozzie] Support multi-architecture builds 
This adds optional multi-architecture builds, allowing to compile
x86 and x64 in one build. The correctness fuzzer can be configured to
compare the two executables, e.g. to compare x86 to x64 run the
launcher with: --second-d8=clang_x86/d8 in an x64 build.

Configuring the executable's architecture is now simplified and
inferred from the gn build configuration.

Building for clusterfuzz has now a new canonical target that can be
used by the infrastructure (defaults to d8).

The clusterfuzz release builder is now defined to compile
multi-arch builds, which will have an effect as soon as the
infrastructure refers to the new clusterfuzz target.

BUG=chromium:673246
NOTRY=true
TBR=mstarzinger,jarin

Review-Url: https://codereview.chromium.org/2649133010
Cr-Commit-Position: refs/heads/master@{#42884}
 2017-02-02 11:32:52 +00:00
Aaron Gable
735739bfa4 Enable gerrit-based CQ for v8 
BUG=685318

Change-Id: I6654410beaca18f5d8e0791ed18d0daa46edcae0
Reviewed-on: https://chromium-review.googlesource.com/434177
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#42792}
 2017-01-30 21:24:35 +00:00
machenbach
aaaffd3758 [CQ] Make verify-csa bots block CQ 
BUG=chromium:685561
NOTRY=true
TBR=danno@chromium.org, kjellander@chromium.org

Review-Url: https://codereview.chromium.org/2650383008
Cr-Commit-Position: refs/heads/master@{#42743}
 2017-01-27 15:34:45 +00:00
machenbach
5129880ad5 [CQ] Add verify-csa bot experimentally to CQ 
BUG=chromium:685561
NOTRY=true
TBR=danno@chromium.org, kjellander@chromium.org

Review-Url: https://codereview.chromium.org/2652653013
Cr-Commit-Position: refs/heads/master@{#42700}
 2017-01-26 14:21:12 +00:00
machenbach
169b85673f [build] Add configs for verify-csa bots 
This adds MB configs for the four verify-csa bots (gn only).

BUG=chromium:685561
NOTRY=true
NOTREECHECKS=true
TBR=danno@chromium.org, kjellander@chromium.org

Review-Url: https://codereview.chromium.org/2659583002
Cr-Commit-Position: refs/heads/master@{#42698}
 2017-01-26 14:10:55 +00:00
tandrii
0dc9afefbc Infra CQ config: remove deprecated target_ref. 
BUG=644915
R=sergiyb@chromium.org,machenbach@chromium.org
NOTRY=True

Review-Url: https://codereview.chromium.org/2641523003
Cr-Commit-Position: refs/heads/master@{#42428}
 2017-01-17 21:42:28 +00:00
machenbach
d1f347fa54 [foozzie] Add correctness-fuzzer-archive builder's mb config 
Related to:
https://chromium-review.googlesource.com/c/426618

BUG=chromium:673246
NOTRY=true
NOTREECHECKS=true
TBR=tandrii@chromium.org,jochen@chromium.org

Review-Url: https://codereview.chromium.org/2628483003
Cr-Commit-Position: refs/heads/master@{#42167}
 2017-01-10 10:54:04 +00:00
tandrii
b2b5d0ab5b CQ config: remove unused hide_ref_in_committed_msg. 
This has been superseeded by just-in-time determination based on state
of gnumbd and git-numberer validation.

BUG=chromium:644915
R=machenbach@chromium.org,sergiyb@chromium.org
NOTRY=True

Review-Url: https://codereview.chromium.org/2583703004
Cr-Commit-Position: refs/heads/master@{#41772}
 2016-12-16 16:41:36 +00:00
machenbach
d4208da3b3 [build] Make x87 bot use the snapshot. 
The bot will be renamed in a follow up, when the infra side is renamed.

TBR=zhengxing.li@intel.com, vogelheim@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2549033002
Cr-Commit-Position: refs/heads/master@{#41475}
 2016-12-05 08:18:28 +00:00
machenbach
526d955c26 [CQ] Temporarily reduce coverage bot's frequency 
NOTRY=true
NOPRESUBMIT=true
TBR=tandrii@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2437723002
Cr-Commit-Position: refs/heads/master@{#40431}
 2016-10-19 12:13:40 +00:00
machenbach
a276bc8998 [mb] Make linux64 bots aware of valgrind 
Prepared by:
https://codereview.chromium.org/2423083002/

BUG=chromium:656573
NOTRY=true
TBR=tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2427603002
Cr-Commit-Position: refs/heads/master@{#40370}
 2016-10-17 18:40:36 +00:00
machenbach
3d41efced8 Revert of [CQ] Remove experimental bot temporarily. (patchset #1 id:1 of https://codereview.chromium.org/2411283002/ ) 
Reason for revert:
Root cause fixed.

Original issue's description:
> [CQ] Remove experimental bot temporarily.
>
> BUG=chromium:655033,v8:5502
> NOTRY=true
> NOPRESUBMIT=true
> TBR=tandrii@chromium.org
>
> Committed: https://crrev.com/f994fcb10ed9ebc09a3544221db8d2fc121c6e98
> Cr-Commit-Position: refs/heads/master@{#40193}

TBR=tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:655033,v8:5502

Review-Url: https://codereview.chromium.org/2412073002
Cr-Commit-Position: refs/heads/master@{#40203}
 2016-10-12 09:08:13 +00:00
machenbach
3195f19e87 [inspector] Add swarming support to inspector tests 
BUG=chromium:635948

Review-Url: https://codereview.chromium.org/2393863002
Cr-Commit-Position: refs/heads/master@{#40194}
 2016-10-12 07:32:06 +00:00
machenbach
f994fcb10e [CQ] Remove experimental bot temporarily. 
BUG=chromium:655033,v8:5502
NOTRY=true
NOPRESUBMIT=true
TBR=tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2411283002
Cr-Commit-Position: refs/heads/master@{#40193}
 2016-10-12 07:09:52 +00:00
machenbach
af19028864 [build] Use static libraries on x87 bot. 
The bot currently doesn't work with shared libraries. This
temporarily works around the problem to get the bot green.

BUG=v8:5412
NOTRY=true
TBR=jochen, zhengxing.li, jgruber

Review-Url: https://codereview.chromium.org/2405243002
Cr-Commit-Position: refs/heads/master@{#40191}
 2016-10-12 06:49:51 +00:00
machenbach
679409e800 [build] Use same symbol level as chromium for android 
This makes our configuration similar to Chromium's for
android performance testing.

This blocks deps'ing in:
https://codereview.chromium.org/2377013002

BUG=chromium:648948
NOTRY=true

Review-Url: https://codereview.chromium.org/2383743002
Cr-Commit-Position: refs/heads/master@{#39915}
 2016-09-30 11:59:12 +00:00
machenbach
f72b4a084a [build] Use shared libraries by default for debug builds 
BUG=chromium:648864

Review-Url: https://codereview.chromium.org/2373743002
Cr-Commit-Position: refs/heads/master@{#39754}
 2016-09-27 09:46:36 +00:00
machenbach
d85a349771 [build] Enable shared libraries for arm debug 
BUG=chromium:648864,chromium:648610
NOTRY=true
TBR=jgruber@chromium.org

Review-Url: https://codereview.chromium.org/2371713002
Cr-Commit-Position: refs/heads/master@{#39712}
 2016-09-26 10:22:19 +00:00
machenbach
01cd881b87 [gn] Use clang plugins on win clang bot 
BUG=chromium:644096
TBR=thakis@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2369493002
Cr-Commit-Position: refs/heads/master@{#39665}
 2016-09-23 13:26:18 +00:00
machenbach
697738e86c Revert of [cq] Temporarily make failing chromium trybot experimental (patchset #1 id:1 of https://codereview.chromium.org/2352573002/ ) 
Reason for revert:
Real fix landed by now.

Original issue's description:
> [cq] Temporarily make failing chromium trybot experimental
>
> BUG=chromium:648153
> NOTRY=true
> NOPRESUBMIT=true
> TBR=emso@chromium.org
>
> Committed: https://crrev.com/bb6fa481b6e8e643cb86d66cfa5b8bb35d1dd320
> Cr-Commit-Position: refs/heads/master@{#39494}

TBR=emso@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:648153

Review-Url: https://codereview.chromium.org/2353713002
Cr-Commit-Position: refs/heads/master@{#39516}
 2016-09-19 21:02:26 +00:00
machenbach
bb6fa481b6 [cq] Temporarily make failing chromium trybot experimental 
BUG=chromium:648153
NOTRY=true
NOPRESUBMIT=true
TBR=emso@chromium.org

Review-Url: https://codereview.chromium.org/2352573002
Cr-Commit-Position: refs/heads/master@{#39494}
 2016-09-19 08:24:34 +00:00
machenbach
03364b6245 [gn] Switch asan builders to gn 
BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2334003005
Cr-Commit-Position: refs/heads/master@{#39416}
 2016-09-14 12:00:18 +00:00
machenbach
3999fb0788 [gn] Fix no-inline config for V8 
This restores the original gyp behavior. Blocks:
https://codereview.chromium.org/2334003005

BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2344493002
Cr-Commit-Position: refs/heads/master@{#39414}
 2016-09-14 11:18:50 +00:00
machenbach
086f566ed8 [gn] Switch mipsel and mips64el bots to gn 
BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2328233002
Cr-Commit-Position: refs/heads/master@{#39370}
 2016-09-13 07:42:09 +00:00
machenbach
a482ab5c82 [gn] Add gn configs for mips to match old behavior 
BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2322163003
Cr-Commit-Position: refs/heads/master@{#39369}
 2016-09-13 07:33:11 +00:00
machenbach
9f42d6c2c0 [gn] Switch arm cross-compile bots to gn 
BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2328293002
Cr-Commit-Position: refs/heads/master@{#39367}
 2016-09-13 06:37:36 +00:00
machenbach
4266d33e76 [gn] Switch noi18n bots to gn 
BUG=chromium:474921
NOTRY=true
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2314423005
Cr-Commit-Position: refs/heads/master@{#39303}
 2016-09-09 09:16:00 +00:00
machenbach
bcc3cb2ea4 [test] Fix the noi18n trybot 
This is a work-around as v8_enable_i18n_support=false does
currently not imply icu_use_data_file_flag=false. The
swarming isolator then tries to find the data file also
in builds without ICU.

Making the implication is non-trivial as icu_use_data_file_flag lives
in ICU and v8_enable_i18n_support lives in V8.

BUG=chromium:474921
NOTRY=true
TBR=petermarshall@chromium.org, vogelheim@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2321563007
Cr-Commit-Position: refs/heads/master@{#39301}
 2016-09-09 08:23:38 +00:00
machenbach
c90964616e [gn] Switch linux gc stress trybot to gn 
Fell through the cracks in a recent CL. Should have switched
with the CI bot, which is on GN already.

BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2328533002
Cr-Commit-Position: refs/heads/master@{#39285}
 2016-09-08 15:48:23 +00:00
machenbach
9142671847 [gn] Switch mac asan to gn 
BUG=chromium:644643
NOTRY=true

Review-Url: https://codereview.chromium.org/2319583002
Cr-Commit-Position: refs/heads/master@{#39281}
 2016-09-08 13:12:11 +00:00
machenbach
45fe9019bf [gn] Switch android bots to gn 
Also roll build and android_tools, which contains a bump of
the ndk to r12b.

BUG=chromium:629806

Review-Url: https://codereview.chromium.org/2320843003
Cr-Commit-Position: refs/heads/master@{#39269}
 2016-09-08 10:31:10 +00:00
machenbach
86f119b85d [gn] Turn off lsan on mac asan 
Chromium doesn't support lsan with mac's current toolchain.

BUG=chromium:644643
NOTRY=true

Review-Url: https://codereview.chromium.org/2322493002
Cr-Commit-Position: refs/heads/master@{#39255}
 2016-09-07 15:30:30 +00:00
machenbach
70429e7a20 Reland of [gn] Switch win clang bot to gn (patchset #1 id:1 of https://codereview.chromium.org/2311853002/ ) 
Reason for revert:
Trying reland with plugin switched off.

Original issue's description:
> Revert of [gn] Switch win clang bot to gn (patchset #1 id:1 of https://codereview.chromium.org/2310863002/ )
>
> Reason for revert:
> Fails compilation:
> https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang
>
> Original issue's description:
> > [gn] Switch win clang bot to gn
> >
> > BUG=chromium:474921
> > NOTRY=true
> >
> > Committed: https://crrev.com/1740587772bbd1ffb7b79a90deb16519e8d47588
> > Cr-Commit-Position: refs/heads/master@{#39156}
>
> TBR=jochen@chromium.org,vogelheim@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:474921
>
> Committed: https://crrev.com/49e13ea6eab4158915a75b95ccc9f01892924d9e
> Cr-Commit-Position: refs/heads/master@{#39158}

TBR=jochen@chromium.org,vogelheim@chromium.org
NOTRY=true
BUG=chromium:474921,chromium:644096

Review-Url: https://codereview.chromium.org/2312093002
Cr-Commit-Position: refs/heads/master@{#39201}
 2016-09-06 11:17:18 +00:00
machenbach
6c335b7aae [gn] Switch linux asan to gn 
Also disable four cpu-profiler tests under asan that fail
with the GN setup.

BUG=chromium:474921,v8:5243

Review-Url: https://codereview.chromium.org/2309263002
Cr-Commit-Position: refs/heads/master@{#39171}
 2016-09-05 13:16:40 +00:00
machenbach
49e13ea6ea Revert of [gn] Switch win clang bot to gn (patchset #1 id:1 of https://codereview.chromium.org/2310863002/ ) 
Reason for revert:
Fails compilation:
https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang

Original issue's description:
> [gn] Switch win clang bot to gn
>
> BUG=chromium:474921
> NOTRY=true
>
> Committed: https://crrev.com/1740587772bbd1ffb7b79a90deb16519e8d47588
> Cr-Commit-Position: refs/heads/master@{#39156}

TBR=jochen@chromium.org,vogelheim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2311853002
Cr-Commit-Position: refs/heads/master@{#39158}
 2016-09-05 11:08:18 +00:00
machenbach
1740587772 [gn] Switch win clang bot to gn 
BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2310863002
Cr-Commit-Position: refs/heads/master@{#39156}
 2016-09-05 10:54:55 +00:00
machenbach
6c51c7d3a1 [gn] Add generic subcommands and provide list command 
This prepares using mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

Also added more robust checks of user inputs, better hints
and better docu.

BUG=chromium:625791
NOTRY=true

Review-Url: https://codereview.chromium.org/2300333002
Cr-Commit-Position: refs/heads/master@{#39136}
 2016-09-02 13:07:30 +00:00
machenbach
25603e0b26 [gn] Switch windows to gn 
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2303233002
Cr-Commit-Position: refs/heads/master@{#39128}
 2016-09-02 11:02:25 +00:00
machenbach
903172e4fc [mb] Add more developer defaults to mb config. 
BUG=chromium:625791

Review-Url: https://codereview.chromium.org/2304623002
Cr-Commit-Position: refs/heads/master@{#39100}
 2016-09-01 18:06:24 +00:00
machenbach
324a9ace25 [gn] Switch linux branch builder to gn 
BUG=chromium:474921
NOTRY=true
TBR=jochen,vogelheim

Review-Url: https://codereview.chromium.org/2306573002
Cr-Commit-Position: refs/heads/master@{#39083}
 2016-09-01 12:28:07 +00:00
machenbach
bbe5c5490c [gn] Switch arm simulators to gn 
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2304533002
Cr-Commit-Position: refs/heads/master@{#39081}
 2016-09-01 12:18:57 +00:00
machenbach
e866b969bf [gn] Switch tsan to gn 
BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2209313002
Cr-Commit-Position: refs/heads/master@{#38374}
 2016-08-05 11:55:23 +00:00
machenbach
276f15d4c1 [build] Enable v8 backtrace on all standalone bots 
BUG=

Review-Url: https://codereview.chromium.org/2204593009
Cr-Commit-Position: refs/heads/master@{#38313}
 2016-08-03 19:46:16 +00:00
machenbach
4289c28fb9 [build] Conditionally print to stdout on Android 
This adds a gyp/gn variable to control printing to stdout
on Android. This is false by default and true for all
v8 stand-alone android bots.

BUG=chromium:629806

Review-Url: https://codereview.chromium.org/2183063002
Cr-Commit-Position: refs/heads/master@{#38253}
 2016-08-02 15:38:04 +00:00
machenbach
45d0c051e2 [gn] Switch msan bots to gn 
BUG=chromium:631979
NOTRY=true

Review-Url: https://codereview.chromium.org/2194823002
Cr-Commit-Position: refs/heads/master@{#38207}
 2016-08-01 12:35:44 +00:00
machenbach
5ef69e93a2 [build] Port using prebuilt instrumented libraries for msan 
BUG=chromium:631979
NOTRY=true

Review-Url: https://codereview.chromium.org/2189343002
Cr-Commit-Position: refs/heads/master@{#38197}
 2016-08-01 09:43:12 +00:00
machenbach
3dedc3e5ce [gn] Fix sanitizer configs 
This prepares for https://codereview.chromium.org/2188693002/

With the current configuration, sanitizers wouldn't be used
at all. The clang configuration is automatically derived
in GN.

BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2184683004
Cr-Commit-Position: refs/heads/master@{#38089}
 2016-07-27 09:59:37 +00:00
machenbach
0bb05780b3 [gn] Switch arm64 bots to gn 
BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2182563003
Cr-Commit-Position: refs/heads/master@{#38082}
 2016-07-27 08:21:04 +00:00
machenbach
c2d6d983de [gn] Switch mac to gn 
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2182443002
Cr-Commit-Position: refs/heads/master@{#38011}
 2016-07-25 11:38:07 +00:00
machenbach
7f07809c2c [tools] Build generator script 
Helper script to generate gn arguments based on common
developer defaults or builder configurations.

BUG=chromium:625791
NOTRY=true

Review-Url: https://codereview.chromium.org/2138693002
Cr-Commit-Position: refs/heads/master@{#37947}
 2016-07-21 13:23:44 +00:00
machenbach
3449dbc010 [cq] Make chromium win trybot experimental 
BUG=chromium:629025
NOTRY=true
NOPRESUBMIT=true
TBR=sergiyb@chromium.org

Review-Url: https://codereview.chromium.org/2165883003
Cr-Commit-Position: refs/heads/master@{#37903}
 2016-07-20 12:19:52 +00:00
machenbach
9f640c93f4 [gn] Fix remaining ia32/x86 misconfigurations 
BUG=chromium:474921
NOTRY=true
TBR=jochen@chromium.org, vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2156063003
Cr-Commit-Position: refs/heads/master@{#37839}
 2016-07-18 13:37:45 +00:00
machenbach
d0d99bee2b [cq] Make chromium win trybot blocking 
BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2148673004
Cr-Commit-Position: refs/heads/master@{#37765}
 2016-07-14 13:41:15 +00:00
machenbach
277f253ae7 [cq] Add chromium win trybot as experiment 
This will be temporarily added to the V8 CQ in a follow up
to prevent win-specific gn breakages. It will be removed
once v8 has its own full gn coverage on windows.

BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2144193002
Cr-Commit-Position: refs/heads/master@{#37747}
 2016-07-14 08:52:52 +00:00
machenbach
e6a195d4dd [cq] Reenable gcc trybot after infra fix 
BUG=chromium:626622
NOTRY=true
NOPRESUBMIT=true
TBR=sergiyb@chromium.org

Review-Url: https://codereview.chromium.org/2147023003
Cr-Commit-Position: refs/heads/master@{#37742}
 2016-07-14 07:16:05 +00:00
machenbach
168d9eaa36 Reland of [gn] Switch gcc bots to gn (patchset #1 id:1 of https://codereview.chromium.org/2130303002/ ) 
Reason for revert:
Relanding as the goma problem is due to an upgrade of the binutils version we use.

Original issue's description:
> Revert of [gn] Switch gcc bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2124263002/ )
>
> Reason for revert:
> There are a bunch of goma errors on the gcc bot now. Maybe connected to this CL.
>
> https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/19068
>
> Original issue's description:
> > [gn] Switch gcc bots to gn
> >
> > BUG=chromium:474921
> >
> > Committed: https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393
> > Cr-Commit-Position: refs/heads/master@{#37580}
>
> TBR=vogelheim@chromium.org,jochen@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:474921
>
> Committed: https://crrev.com/980d0d6e227f8de3cc0b71a0d3f492908adcf138
> Cr-Commit-Position: refs/heads/master@{#37603}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2132333002
Cr-Commit-Position: refs/heads/master@{#37624}
 2016-07-11 07:28:59 +00:00
machenbach
55b89ad7e6 [CQ] Temporarily make gcc bot experimental due to goma problems 
BUG=chromium:626622
NOTRY=true
NOPRESUBMIT=true
TBR=sergiyb@chromium.org

Review-Url: https://codereview.chromium.org/2136443004
Cr-Commit-Position: refs/heads/master@{#37606}
 2016-07-08 09:58:37 +00:00
machenbach
8545269374 [CQ] Temporarily remove gcc bot due to goma problems 
BUG=chromium:626622
NOTRY=true
TBR=sergiyb@chromium.org

Review-Url: https://codereview.chromium.org/2134643002
Cr-Commit-Position: refs/heads/master@{#37605}
 2016-07-08 09:55:23 +00:00
machenbach
980d0d6e22 Revert of [gn] Switch gcc bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2124263002/ ) 
Reason for revert:
There are a bunch of goma errors on the gcc bot now. Maybe connected to this CL.

https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/19068

Original issue's description:
> [gn] Switch gcc bots to gn
>
> BUG=chromium:474921
>
> Committed: https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393
> Cr-Commit-Position: refs/heads/master@{#37580}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2130303002
Cr-Commit-Position: refs/heads/master@{#37603}
 2016-07-08 09:36:37 +00:00
machenbach
312d0149af [CQ] Make gyp bot a blocking bot 
BUG=chromium:474921
NOTRY=true
TBR=vogelheim@chromium.org, jochen@chromium.org, tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2126793004
Cr-Commit-Position: refs/heads/master@{#37593}
 2016-07-07 17:35:12 +00:00
machenbach
73f154ba60 [gn] Switch gcc bots to gn 
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2124263002
Cr-Commit-Position: refs/heads/master@{#37580}
 2016-07-07 11:17:19 +00:00
machenbach
59f2f3d836 [gn] Switch linux bots on beta/stable to gn 
BUG=chromium:474921
NOTRY=true
TBR=vogelheim@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2130723002
Cr-Commit-Position: refs/heads/master@{#37579}
 2016-07-07 11:04:49 +00:00
machenbach
207fd4b9cd [gn] Fix sysroot usage with gcc 
BUG=chromium:474921
TBR=jochen@chromium.org, vogelheim@chromium.org,
NOTRY=true

Review-Url: https://codereview.chromium.org/2124003003
Cr-Commit-Position: refs/heads/master@{#37575}
 2016-07-07 09:27:44 +00:00
machenbach
03453d10be [gn] Fix config for using clang 
Needed for https://codereview.chromium.org/2124263002/

BUG=chromium:474921
TBR=jochen@chromium.org, vogelheim@chromium.org,
NOTRY=true

Review-Url: https://codereview.chromium.org/2125703005
Cr-Commit-Position: refs/heads/master@{#37574}
 2016-07-07 09:04:54 +00:00
machenbach
9a581f602e [cq] Add temporary gyp bot to CQ experiment 
BUG=chromium:474921
NOTRY=true
TBR=vogelheim@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2129853002
Cr-Commit-Position: refs/heads/master@{#37573}
 2016-07-07 08:52:00 +00:00
machenbach
a53bf2264d [gn] Add bots for gyp support 
Add temporary bots that continuously test with gyp until its
deprecation.

BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2123173002
Cr-Commit-Position: refs/heads/master@{#37560}
 2016-07-06 15:29:47 +00:00
machenbach
d3413fa2da Reland of [gn] Switch more linux32 bots to gn (patchset #1 id:1 of https://codereview.chromium.org/2128493002/ ) 
Reason for revert:
Should be fixed after https://codereview.chromium.org/2123223002/

Original issue's description:
> Revert of [gn] Switch more linux32 bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2122933002/ )
>
> Reason for revert:
> Breaks test isolation on shared library bot.
>
> Original issue's description:
> > [gn] Switch more linux32 bots to gn
> >
> > This switches nosnap and shared library bots to gn.
> >
> > This also unsets external startup data if no snapshot is
> > used.
> >
> > BUG=chromium:474921
> > NOTRY=true
> >
> > Committed: https://crrev.com/ab4d8fc07d9d35e6fc129098f42aa0317a02244a
> > Cr-Commit-Position: refs/heads/master@{#37546}
>
> TBR=vogelheim@chromium.org,jochen@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:474921
>
> Committed: https://crrev.com/a5fa2984257a50ee9440914c7d1a199f64a86194
> Cr-Commit-Position: refs/heads/master@{#37548}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2126843002
Cr-Commit-Position: refs/heads/master@{#37558}
 2016-07-06 15:17:09 +00:00
machenbach
00c51b99ed [mb] Fix shared-library bots. 
Because the release_bot mixin includes the 'static' config,
the shared-library bots included both 'static' and 'shared'.

This removes the wrong 'static' config.

BUG=chromium:474921
TBR=vogelheim@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2123243002
Cr-Commit-Position: refs/heads/master@{#37556}
 2016-07-06 15:07:35 +00:00
machenbach
a5fa298425 Revert of [gn] Switch more linux32 bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2122933002/ ) 
Reason for revert:
Breaks test isolation on shared library bot.

Original issue's description:
> [gn] Switch more linux32 bots to gn
>
> This switches nosnap and shared library bots to gn.
>
> This also unsets external startup data if no snapshot is
> used.
>
> BUG=chromium:474921
> NOTRY=true
>
> Committed: https://crrev.com/ab4d8fc07d9d35e6fc129098f42aa0317a02244a
> Cr-Commit-Position: refs/heads/master@{#37546}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2128493002
Cr-Commit-Position: refs/heads/master@{#37548}
 2016-07-06 10:16:26 +00:00
machenbach
ab4d8fc07d [gn] Switch more linux32 bots to gn 
This switches nosnap and shared library bots to gn.

This also unsets external startup data if no snapshot is
used.

BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2122933002
Cr-Commit-Position: refs/heads/master@{#37546}
 2016-07-06 09:57:17 +00:00
machenbach
84124ce219 [build] Switch x87 to swarming. 
BUG=chromium:625793
NOTRY=true
TBR=vogelheim@chromium.org, zhengxing.li@intel.com

Review-Url: https://codereview.chromium.org/2124763002
Cr-Commit-Position: refs/heads/master@{#37525}
 2016-07-05 12:01:02 +00:00
machenbach
27965f19a4 [gn] Switch basic linux32 bots to gn 
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2109293004
Cr-Commit-Position: refs/heads/master@{#37492}
 2016-07-04 07:54:32 +00:00
machenbach
e8d2238d24 [gn] Switch custom snapsot bot to gn 
BUG=chromium:474921
NOTRY=true

Committed: https://crrev.com/52a43518abe9143a14ded92a89bd3384a47e9193
Review-Url: https://codereview.chromium.org/2113583002
Cr-Original-Commit-Position: refs/heads/master@{#37431}
Cr-Commit-Position: refs/heads/master@{#37436}
 2016-06-30 11:26:30 +00:00
machenbach
33ceb9e5d6 Revert of [gn] Switch custom snapsot bot to gn (patchset #2 id:20001 of https://codereview.chromium.org/2113583002/ ) 
Reason for revert:
Breaks...

Original issue's description:
> [gn] Switch custom snapsot bot to gn
>
> BUG=chromium:474921
> NOTRY=true
>
> Committed: https://crrev.com/52a43518abe9143a14ded92a89bd3384a47e9193
> Cr-Commit-Position: refs/heads/master@{#37431}

TBR=yangguo@chromium.org,vogelheim@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2107423003
Cr-Commit-Position: refs/heads/master@{#37434}
 2016-06-30 11:14:18 +00:00
machenbach
52a43518ab [gn] Switch custom snapsot bot to gn 
BUG=chromium:474921
NOTRY=true

Review-Url: https://codereview.chromium.org/2113583002
Cr-Commit-Position: refs/heads/master@{#37431}
 2016-06-30 10:00:10 +00:00
machenbach
38b31043ec [gn] Switch linux64 debug and internal snapshot to gn 
BUG=chromium:474921

Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7
Review-Url: https://codereview.chromium.org/2105353002
Cr-Original-Commit-Position: refs/heads/master@{#37414}
Cr-Commit-Position: refs/heads/master@{#37425}
 2016-06-30 08:59:32 +00:00
machenbach
fbeb0e6430 Revert of [gn] Switch linux64 debug and internal snapshot to gn (patchset #1 id:1 of https://codereview.chromium.org/2105353002/ ) 
Reason for revert:
Breaks...

Original issue's description:
> [gn] Switch linux64 debug and internal snapshot to gn
>
> BUG=chromium:474921
>
> Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7
> Cr-Commit-Position: refs/heads/master@{#37414}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2109503007
Cr-Commit-Position: refs/heads/master@{#37420}
 2016-06-30 07:54:13 +00:00
machenbach
8d65a3c1ef Revert of [gn] Fix valgrind config (patchset #1 id:1 of https://codereview.chromium.org/2109403002/ ) 
Reason for revert:
Breaks...

Original issue's description:
> [gn] Fix valgrind config
>
> BUG=chromium:474921
> NOTRY=true
> NOTREECHECKS=true
> TBR=vogelheim@chromium.org, jochen@chromium.org
>
> Committed: https://crrev.com/e97c990a2b1fd0b5b90832a7f182daa25fee8291
> Cr-Commit-Position: refs/heads/master@{#37418}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2109423002
Cr-Commit-Position: refs/heads/master@{#37419}
 2016-06-30 07:51:07 +00:00
machenbach
e97c990a2b [gn] Fix valgrind config 
BUG=chromium:474921
NOTRY=true
NOTREECHECKS=true
TBR=vogelheim@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2109403002
Cr-Commit-Position: refs/heads/master@{#37418}
 2016-06-30 07:39:10 +00:00
machenbach
3cfc9f209e [gn] Switch linux64 debug and internal snapshot to gn 
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2105353002
Cr-Commit-Position: refs/heads/master@{#37414}
 2016-06-30 06:46:16 +00:00
machenbach
b4b45ff692 [gn] Switch linux64 release to gn. 
BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2109083002
Cr-Commit-Position: refs/heads/master@{#37385}
 2016-06-29 11:13:30 +00:00
tandrii
44ca872385 Make bucket names explicit in cq.cfg. 
Don't assume bucket name to start with 'master.'.

NOTRY=True
BUG=chromium:617627
R=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2093993002
Cr-Commit-Position: refs/heads/master@{#37258}
 2016-06-24 20:14:25 +00:00
machenbach
8349651e06 [mb] Switch remaining bots to mb 
BUG=chromium:616035
NOTRY=true

Review-Url: https://codereview.chromium.org/2081263003
Cr-Commit-Position: refs/heads/master@{#37249}
 2016-06-24 11:29:45 +00:00
machenbach
f86cabe674 [mb] Switch remaining ports to mb 
BUG=chromium:616035
NOTRY=true

Review-Url: https://codereview.chromium.org/2082283002
Cr-Commit-Position: refs/heads/master@{#37248}
 2016-06-24 10:20:02 +00:00
machenbach
25b511ca9b [mb] Switch mac bots to mb 
BUG=chromium:616035
NOTRY=true

Review-Url: https://codereview.chromium.org/2083153003
Cr-Commit-Position: refs/heads/master@{#37246}
 2016-06-24 10:05:03 +00:00
machenbach
046c1f24bd [mb] Switch windows bots to mb 
BUG=chromium:616035
NOTRY=true

Review-Url: https://codereview.chromium.org/2088963003
Cr-Commit-Position: refs/heads/master@{#37188}
 2016-06-22 13:53:05 +00:00
machenbach
f984051284 [mb] Remove lsan from x86 bots 
Lsan only works with x64. This broke when landing:
https://codereview.chromium.org/2085513002/

BUG=616035
TBR=jochen@chromium.org, vogelheim@chromium.org, kjellander@chromium.org
NOTRY=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2086623003
Cr-Commit-Position: refs/heads/master@{#37138}
 2016-06-21 12:07:21 +00:00
machenbach
be1c15a937 [mb] Add linux sanitizers and coverage bots to mb 
BUG=chromium:616035
NOTRY=true

Review-Url: https://codereview.chromium.org/2085513002
Cr-Commit-Position: refs/heads/master@{#37129}
 2016-06-21 07:07:55 +00:00
machenbach
2d7782399b [mb] Switch branch builders to mb 
BUG=chromium:616035
NOTRY=true

Review-Url: https://codereview.chromium.org/2082583002
Cr-Commit-Position: refs/heads/master@{#37106}
 2016-06-20 13:38:10 +00:00
machenbach
1b3d9fa33d [mb] Add configs for more linux bots 
BUG=chromium:616035
NOTRY=true
NOTREECHECKS=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2078973002
Cr-Commit-Position: refs/heads/master@{#37101}
 2016-06-20 12:11:16 +00:00
machenbach
6a39399763 [mb] Remove redundant flags 
BUG=chromium:616035
TBR=kjellander@chromium.org, vogelheim@chromium.org, jochen@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2071313002
Cr-Commit-Position: refs/heads/master@{#37067}
 2016-06-17 12:29:55 +00:00
machenbach
3249e23e5a [mb] Add presubmit checks 
Also comment out some currently unused configs the presubmit
check now complains about. They'll be used soon, once
respective bots are added.

BUG=chromium:616035
TBR=kjellander@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2076053002
Cr-Commit-Position: refs/heads/master@{#37056}
 2016-06-17 08:35:15 +00:00
machenbach
c7443874a1 [mb] Fix typo in mb config 
BUG=chromium:616035
TBR=kjellander@chromium.org
NOTRY=true
NOTREECHECKS=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2072833004
Cr-Commit-Position: refs/heads/master@{#37054}
 2016-06-17 07:50:18 +00:00
machenbach
9347cae998 Add linux64 mb configs. 
Depends on https://codereview.chromium.org/2071583003/ to
skip redundant clang=1 configs.

BUG=chromium:616035
NOTRY=true

Review-Url: https://codereview.chromium.org/2071793002
Cr-Commit-Position: refs/heads/master@{#37050}
 2016-06-17 07:33:16 +00:00
machenbach
f1ac74b253 [mb] Set correct default values for sysroot and icu 
Port https://codereview.chromium.org/2057053002/ for the
v8-side configurations.

BUG=chromium:616035
NOTRY=true
TBR=vogelheim@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2066823002
Cr-Commit-Position: refs/heads/master@{#36967}
 2016-06-14 13:42:40 +00:00
machenbach
956f28b816 Revert of [mb] Switch staging bot to gyp for testing purposes (patchset #1 id:1 of https://codereview.chromium.org/2056673002/ ) 
Reason for revert:
Looks good. Switch back to gn.

Original issue's description:
> [mb] Switch staging bot to gyp for testing purposes
>
> This is to test the migration workflow. Will be reverted
> afterwards.
>
> BUG=chromium:616035
> NOTRY=true
> TBR=vogelheim@chromium.org, jochen@chromium.org
>
> Committed: https://crrev.com/6a5d769be2b97a9ebca8ec58496cb20aed077f18
> Cr-Commit-Position: refs/heads/master@{#36848}

TBR=vogelheim@chromium.org,jochen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:616035

Review-Url: https://codereview.chromium.org/2050243002
Cr-Commit-Position: refs/heads/master@{#36861}
 2016-06-09 13:21:36 +00:00
machenbach
6a5d769be2 [mb] Switch staging bot to gyp for testing purposes 
This is to test the migration workflow. Will be reverted
afterwards.

BUG=chromium:616035
NOTRY=true
TBR=vogelheim@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2056673002
Cr-Commit-Position: refs/heads/master@{#36848}
 2016-06-09 10:06:14 +00:00
machenbach
6de74c782c [mb] Add mb config 
This adds a minimal mb config to switch the v8 staging bot
to mb. External mb documentation:
https://chromium.googlesource.com/chromium/src/tools/mb/+/HEAD/docs/user_guide.md

After this is tested on the staging bot, mb configs for the
remaining bots will be provided and all bots will be
systematically switched.

BUG=chromium:616035
NOTRY=true

Review-Url: https://codereview.chromium.org/2024893002
Cr-Commit-Position: refs/heads/master@{#36847}
 2016-06-09 09:12:54 +00:00
machenbach
8aeb1ab74e [CQ] Raise blink trybot percentage to 100 
TBR=hablich@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1930163003
Cr-Commit-Position: refs/heads/master@{#35894}
 2016-04-29 09:05:06 +00:00
machenbach
0f0d349411 [CQ] Activate remaining next-gen trybots. 
BUG=535160
TBR=sergiyb@chromium.org, kjellander@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1884473002

Cr-Commit-Position: refs/heads/master@{#35408}
 2016-04-12 09:32:11 +00:00
machenbach
1c4b80b193 [CQ] Add more next-gen bots to CQ experiment 
BUG=535160
TBR=sergiyb@chromium.org, kjellander@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1872423002

Cr-Commit-Position: refs/heads/master@{#35390}
 2016-04-11 14:33:54 +00:00
machenbach
b4f0a5d52c [CQ] Add win nosnap shared trybot to CQ. 
The builder + triggered tester replace the old compile-only
bot. Ran now as experiment for a few days.

BUG=535160
TBR=sergiyb@chromium.org, kjellander@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1872783002

Cr-Commit-Position: refs/heads/master@{#35360}
 2016-04-08 13:42:42 +00:00
machenbach
69bad719fc [CQ] Add next-gen win-nosnap-shared trybot as experiment 
BUG=535160
TBR=sergiyb@chromium.org, kjellander@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1864963003

Cr-Commit-Position: refs/heads/master@{#35304}
 2016-04-06 13:58:56 +00:00
machenbach
6280844e19 [Coverage] Make coverage a 100% experiment 
BUG=chromium:568949
LOG=n
TBR=kjellander@chromium.org, tandrii@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1830153002

Cr-Commit-Position: refs/heads/master@{#35057}
 2016-03-24 13:27:59 +00:00
machenbach
7a05ddd4bb Revert of [CQ] Make gn bot temporarily experimental. (patchset #1 id:1 of https://codereview.chromium.org/1829673002/ ) 
Reason for revert:
Bot compiles blink only now and works again.

Original issue's description:
> [CQ] Make gn bot temporarily experimental.
>
> TBR=sergiyb@chromium.org, dpranke@chromium.org
> BUG=chromium:481693
> LOG=n
> NOTRY=true
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/b072760b99f45839e6b4ebeffc46c5d4e8c3a6e3
> Cr-Commit-Position: refs/heads/master@{#35026}

TBR=sergiyb@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:481693

Review URL: https://codereview.chromium.org/1826783002

Cr-Commit-Position: refs/heads/master@{#35032}
 2016-03-23 14:30:07 +00:00
machenbach
b072760b99 [CQ] Make gn bot temporarily experimental. 
TBR=sergiyb@chromium.org, dpranke@chromium.org
BUG=chromium:481693
LOG=n
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1829673002

Cr-Commit-Position: refs/heads/master@{#35026}
 2016-03-23 12:58:51 +00:00
machenbach
7e4ce04301 Revert of [CQ] Reduce code-coverage experiment factor. (patchset #1 id:1 of https://codereview.chromium.org/1822703002/ ) 
Reason for revert:
More bots added.

Original issue's description:
> [CQ] Reduce code-coverage experiment factor.
>
> BUG=chromium:568949
> LOG=n
> TBR=kjellander@chromium.org, tandrii@chromium.org
> NOTRY=true
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/76f677fc6d0b147603ddda2d5809086b0d36d900
> Cr-Commit-Position: refs/heads/master@{#34946}

TBR=kjellander@chromium.org,tandrii@chromium.org
BUG=chromium:568949
LOG=n
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1816283004

Cr-Commit-Position: refs/heads/master@{#35021}
 2016-03-23 09:30:35 +00:00
machenbach
76f677fc6d [CQ] Reduce code-coverage experiment factor. 
BUG=chromium:568949
LOG=n
TBR=kjellander@chromium.org, tandrii@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1822703002

Cr-Commit-Position: refs/heads/master@{#34946}
 2016-03-21 14:40:51 +00:00
machenbach
10015f338a [CQ] Add coverage bot to cq experiment. 
BUG=chromium:568949
LOG=n
TBR=kjellander@chromium.org, tandrii@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1814153002

Cr-Commit-Position: refs/heads/master@{#34882}
 2016-03-18 08:57:52 +00:00
machenbach
759734af94 [cq] Update configuration. 
Authorize people with try-job access to do dry runs.
Change to faster blink trybot in 20% experiment.

NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1692943002

Cr-Commit-Position: refs/heads/master@{#33950}
 2016-02-12 14:29:27 +00:00
machenbach
1c07a0c8ab [cq] Use more next gen trybots. 
This uses the bots introduced here:
https://codereview.chromium.org/1581803003/

BUG=chromium:535160
LOG=n
NOTRY=true
NOPRESUBMIT=true
TBR=tandrii@chromium.org, kjellander@chromium.org

Review URL: https://codereview.chromium.org/1588543002

Cr-Commit-Position: refs/heads/master@{#33263}
 2016-01-13 14:05:42 +00:00
machenbach
037be14088 Revert of [CQ] Temporarily switch off pure swarming bots. (patchset #1 id:1 of https://codereview.chromium.org/1502143005/ ) 
Reason for revert:
Switched swarming back on.

Original issue's description:
> [CQ] Temporarily switch off pure swarming bots.
>
> NOTRY=true
> NOTREECHECKS=true
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/cd96d74124d9c4f4c713fd17205becf30d510edb
> Cr-Commit-Position: refs/heads/master@{#32674}

TBR=tandrii@chromium.org,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1511123002

Cr-Commit-Position: refs/heads/master@{#32691}
 2015-12-09 07:43:41 +00:00
machenbach
cd96d74124 [CQ] Temporarily switch off pure swarming bots. 
NOTRY=true
NOTREECHECKS=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1502143005

Cr-Commit-Position: refs/heads/master@{#32674}
 2015-12-08 15:55:15 +00:00
machenbach
b12db2574d [CQ] Experiment: Add blink trybots to CQ. 
NOTRY=true

Review URL: https://codereview.chromium.org/1496303002

Cr-Commit-Position: refs/heads/master@{#32609}
 2015-12-04 11:56:32 +00:00
machenbach
235eff9574 [CQ] Add new triggered win trybots to CQ. 
TBR=sergiyb@chromium.org,tandrii@chromium.org
NOTRY=true
BUG=chromium:561530
LOG=n

Review URL: https://codereview.chromium.org/1497743002

Cr-Commit-Position: refs/heads/master@{#32568}
 2015-12-03 15:01:06 +00:00
machenbach
edda955ed6 Reland of [CQ] Update proto format to fix triggered builders. 
Reason for revert:

Should be fixed after
https://chromereviews.googleplex.com/318207014/

TBR=sergiyb@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:561530

Review URL: https://codereview.chromium.org/1494893003

Cr-Commit-Position: refs/heads/master@{#32559}
 2015-12-03 12:56:20 +00:00
machenbach
5cdb107f88 Revert of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1494103002/ ) 
Reason for revert:
Still not working...

Original issue's description:
> Reland of [CQ] Update proto format to fix triggered builders.
>
> Reason for revert:
>
> Should be fixed after
> https://chromereviews.googleplex.com/317197013/
> https://codereview.chromium.org/1487413002/
> https://codereview.chromium.org/1489293003/
>
> TBR=sergiyb@chromium.org,tandrii@chromium.org
> NOPRESUBMIT=true
> NOTRY=true
> BUG=chromium:561530
>
> Committed: https://crrev.com/224c7fa72b8002348bb876ab7a4d4fabbf9438a4
> Cr-Commit-Position: refs/heads/master@{#32544}

TBR=sergiyb@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:561530

Review URL: https://codereview.chromium.org/1497583003

Cr-Commit-Position: refs/heads/master@{#32546}
 2015-12-03 09:43:21 +00:00
machenbach
224c7fa72b Reland of [CQ] Update proto format to fix triggered builders. 
Reason for revert:

Should be fixed after
https://chromereviews.googleplex.com/317197013/
https://codereview.chromium.org/1487413002/
https://codereview.chromium.org/1489293003/

TBR=sergiyb@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=chromium:561530

Review URL: https://codereview.chromium.org/1494103002

Cr-Commit-Position: refs/heads/master@{#32544}
 2015-12-03 09:18:38 +00:00
machenbach
1125f16088 Revert of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1495443003/ ) 
Reason for revert:
Still not working

Original issue's description:
> Reland of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1485813004/ )
>
> Reason for revert:
> Should be fixed after https://codereview.chromium.org/1487413002/
>
> Original issue's description:
> > Revert of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1486963002/ )
> >
> > Reason for revert:
> > Maybe causing problems
> >
> > Original issue's description:
> > > [CQ] Update proto format to fix triggered builders.
> > >
> > > Depends on https://chromereviews.googleplex.com/319777013/
> > >
> > > BUG=chromium:561530
> > > LOG=n
> > > TBR=sergiyb@chromium.org, tandrii@chromium.org
> > > NOTRY=true
> > >
> > > Committed: https://crrev.com/51d6d619330080a76c5bc7a2ebdafebc6a808aa8
> > > Cr-Commit-Position: refs/heads/master@{#32453}
> >
> > TBR=sergiyb@chromium.org,tandrii@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=chromium:561530
> >
> > Committed: https://crrev.com/79ded5acc9da6a80cbd739c24c6dfa0cf207ae93
> > Cr-Commit-Position: refs/heads/master@{#32464}
>
> TBR=sergiyb@chromium.org,tandrii@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:561530
>
> Committed: https://crrev.com/3cea13351c1af365013f51c7b67e72eeba79afe6
> Cr-Commit-Position: refs/heads/master@{#32511}

TBR=sergiyb@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:561530

Review URL: https://codereview.chromium.org/1493693003

Cr-Commit-Position: refs/heads/master@{#32512}
 2015-12-02 13:28:07 +00:00
machenbach
3cea13351c Reland of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1485813004/ ) 
Reason for revert:
Should be fixed after https://codereview.chromium.org/1487413002/

Original issue's description:
> Revert of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1486963002/ )
>
> Reason for revert:
> Maybe causing problems
>
> Original issue's description:
> > [CQ] Update proto format to fix triggered builders.
> >
> > Depends on https://chromereviews.googleplex.com/319777013/
> >
> > BUG=chromium:561530
> > LOG=n
> > TBR=sergiyb@chromium.org, tandrii@chromium.org
> > NOTRY=true
> >
> > Committed: https://crrev.com/51d6d619330080a76c5bc7a2ebdafebc6a808aa8
> > Cr-Commit-Position: refs/heads/master@{#32453}
>
> TBR=sergiyb@chromium.org,tandrii@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:561530
>
> Committed: https://crrev.com/79ded5acc9da6a80cbd739c24c6dfa0cf207ae93
> Cr-Commit-Position: refs/heads/master@{#32464}

TBR=sergiyb@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:561530

Review URL: https://codereview.chromium.org/1495443003

Cr-Commit-Position: refs/heads/master@{#32511}
 2015-12-02 12:55:34 +00:00
machenbach
79ded5acc9 Revert of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1486963002/ ) 
Reason for revert:
Maybe causing problems

Original issue's description:
> [CQ] Update proto format to fix triggered builders.
>
> Depends on https://chromereviews.googleplex.com/319777013/
>
> BUG=chromium:561530
> LOG=n
> TBR=sergiyb@chromium.org, tandrii@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/51d6d619330080a76c5bc7a2ebdafebc6a808aa8
> Cr-Commit-Position: refs/heads/master@{#32453}

TBR=sergiyb@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:561530

Review URL: https://codereview.chromium.org/1485813004

Cr-Commit-Position: refs/heads/master@{#32464}
 2015-12-01 13:55:47 +00:00
machenbach
51d6d61933 [CQ] Update proto format to fix triggered builders. 
Depends on https://chromereviews.googleplex.com/319777013/

BUG=chromium:561530
LOG=n
TBR=sergiyb@chromium.org, tandrii@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1486963002

Cr-Commit-Position: refs/heads/master@{#32453}
 2015-12-01 12:00:17 +00:00
machenbach
e68dda83f9 [CQ] Temporarily remove triggered win trybot. 
Removes the triggered builder temporarily. In a follow up,
it'll be added with the new syntax from:
https://chromereviews.googleplex.com/319777013/

BUG=chromium:561530
LOG=n
TBR=sergiyb@chromium.org, tandrii@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1483063005

Cr-Commit-Position: refs/heads/master@{#32445}
 2015-12-01 09:35:42 +00:00
machenbach
c865a49537 [CQ] Update new trybots. 
BUG=chromium:535160, chromium:561530
TBR=tandrii@chromium.org, sergiyb@chromium.org, akuegel@chromium.org
LOG=n
NOTRY=true

Review URL: https://codereview.chromium.org/1479003004

Cr-Commit-Position: refs/heads/master@{#32364}
 2015-11-27 10:55:25 +00:00
machenbach
732b575553 [CQ] Remove triggered experimental builder. 
BUG=chromium:535160, chromium:561530
TBR=tandrii@chromium.org, sergiyb@chromium.org,
LOG=n
NOTRY=true

Review URL: https://codereview.chromium.org/1481763003

Cr-Commit-Position: refs/heads/master@{#32352}
 2015-11-26 16:23:55 +00:00
machenbach
b250bec4ab [CQ] Add experimental bots. 
BUG=chromium:535160, chromium:561530
LOG=n
NOTRY=true

Review URL: https://codereview.chromium.org/1476133002

Cr-Commit-Position: refs/heads/master@{#32335}
 2015-11-26 13:21:07 +00:00
sergiyb
ab5146925e Use committer list from chrome-infra-auth group project-v8-committers 
R=machenbach@chromium.org
BUG=chromium:511311
LOG=N

Review URL: https://codereview.chromium.org/1312953002

Cr-Commit-Position: refs/heads/master@{#30421}
 2015-08-27 16:10:22 +00:00
machenbach
029c813145 Revert of [cq] Increase commit burst delay. (patchset #1 id:1 of https://codereview.chromium.org/1258193003/) 
Reason for revert:
Committing more than one CL at a time led to some odd buildbot behavior on the console (probably an independent bug).

Original issue's description:
> [cq] Increase commit burst delay.
>
> TBR=jkummerow@chromium.org, hablich@chromium.org
> NOTRY=true
> NOTREECHECKS=true
>
> Committed: https://crrev.com/1f2e914d103532df410f118c81c60fba8b6a00e0
> Cr-Commit-Position: refs/heads/master@{#29914}

TBR=jkummerow@chromium.org,hablich@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1263183002

Cr-Commit-Position: refs/heads/master@{#29944}
 2015-07-31 07:16:48 +00:00
machenbach
1f2e914d10 [cq] Increase commit burst delay. 
TBR=jkummerow@chromium.org, hablich@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1258193003

Cr-Commit-Position: refs/heads/master@{#29914}
 2015-07-30 08:38:37 +00:00
nodir
b8568ec86c Moved project configs to infra/config branch 
luci-config has been switched to read from
https://chromium.googlesource.com/v8/v8/+/infra/config

R=machenbach@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=513460

Review URL: https://codereview.chromium.org/1258763004

Cr-Commit-Position: refs/heads/master@{#29897}
 2015-07-28 15:08:22 +00:00
nodir
0337fedf52 V8 project metadata 
Added project.cfg metadata file for chrome-infra

R=machenbach@chromium.org, sergiyb@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=507723

Review URL: https://codereview.chromium.org/1230823005

Cr-Commit-Position: refs/heads/master@{#29613}
 2015-07-13 14:40:44 +00:00
sheyang
99e24fccf6 Add signcla verifier for v8. 
Currently this verifier will post an informative error if the author has not signed CLA, instead of rejecting the CL.

LOG=N

BUG=457428

Review URL: https://codereview.chromium.org/1185193009

Cr-Commit-Position: refs/heads/master@{#29096}
 2015-06-17 16:36:53 +00:00
nodir
db18b77836 /infra-config directory 
Added /infra with chrome-infra specific files.
/infra/project-config/cr-buildbucket.cfg defines v8 buckets on cr-buildbucket.appspot.com

R=tandrii@chromium.org, machenbach@chromium.org, sergiyb@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1161143002

Cr-Commit-Position: refs/heads/master@{#28736}
 2015-06-01 16:19:49 +00:00
sergiyb
9088719ee5 Converted V8 CQ config to proto-format 
This will land with https://chromereviews.googleplex.com/202967013

R=akuegel@chromium.org, machenbach@chromium.org
BUG=471767
NOTRY=true
LOG=N

Review URL: https://codereview.chromium.org/1161873004

Cr-Commit-Position: refs/heads/master@{#28684}
 2015-05-28 15:02:53 +00:00