- Lane indices are no longer required to be integers. Add index coersion for loads/stores
- Give shift operators masking shift count semantics
- Throw type/range errors instead of runtime asserts.
BUG=v8:4963
LOG=N
R=bbudge@chromium.org, bmeurer@chromium.org
Review-Url: https://codereview.chromium.org/1965443003
Cr-Commit-Position: refs/heads/master@{#36402}
Rolling v8/build to f81cc400005454453b83aad6e47e321a37d092dd
Rolling v8/third_party/android_tools to 5b5f2f60b78198eaef25d442ac60f823142a8a6e
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review-Url: https://codereview.chromium.org/1999603003
Cr-Commit-Position: refs/heads/master@{#36387}
use_icu_data_file from //third_party/icu should be used.
//third_party/icu also defines ICU_UTIL_DATA_IMPL.
BUG=chromium:610673,chromium:474921
Review-Url: https://codereview.chromium.org/1996033002
Cr-Commit-Position: refs/heads/master@{#36371}
Rolling v8/build to b2d15686436cdc17f67c3621c314f8d96b5b6fd9
Rolling v8/tools/clang to 996bab489f816e51dde704bd215fb3403919f07e
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review-Url: https://codereview.chromium.org/1992113002
Cr-Commit-Position: refs/heads/master@{#36343}
Rolling v8/build to d4fdf55ba8b19ee50d864162c343fd1939d00fe7
Rolling v8/buildtools to 06e80a0e17319868d4a9b13f9bb6a248dc8d8b20
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review-Url: https://codereview.chromium.org/1977243002
Cr-Commit-Position: refs/heads/master@{#36258}
Rolling v8/base/trace_event/common to 54b8455be9505c2cb0cf5c26bb86739c236471aa
Rolling v8/build to 93c1eb80b485df02249b83452a42b7a13b3bde28
Rolling v8/buildtools to e9fb74175ea7c3f251baad24d9ebe03c01ed5aba
Rolling v8/tools/gyp to bce1c7793010574d88d7915e2d55395213ac63d1
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review-Url: https://codereview.chromium.org/1980813002
Cr-Commit-Position: refs/heads/master@{#36256}
Rolling v8/build to 143dcc2b1b07c16858f16f25fefe04311f663279
Rolling v8/tools/clang to 18b63c680a59a7125514b1e05ca42cdfb89a19c7
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review-Url: https://codereview.chromium.org/1959293002
Cr-Commit-Position: refs/heads/master@{#36120}
Rolling v8/build to e3d87b142123f2da73c94c276ee915c099afe909
Rolling v8/tools/clang to 15dd77e3ea10e43596ec6ac07b73431135915b30
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review-Url: https://codereview.chromium.org/1961713002
Cr-Commit-Position: refs/heads/master@{#36093}
Rolling v8/build to b81f2a05b5aa7f5b6cf843380eb276897b1ef626
Rolling v8/tools/clang to afdc842603935f994788bf2388e1155528448b2a
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review-Url: https://codereview.chromium.org/1961653002
Cr-Commit-Position: refs/heads/master@{#36092}
Rolling v8/build to 119d5305247498fdd8a215b8e2b6c50223ac7d4b
Rolling v8/tools/clang to 0bb0462a91310d88ab9d124d8db54a70c9e1d1b0
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review-Url: https://codereview.chromium.org/1953813004
Cr-Commit-Position: refs/heads/master@{#36059}
Rolling v8/build to f80756f5df1d90cf1113a2ce335147482e36f65e
Rolling v8/buildtools to 731bdb2af8b5839450605ddebdcf5de749cf9d17
Rolling v8/tools/clang to ee715658a19a60fc73b02532a077d9c96f291331
Rolling v8/tools/gyp to 02b145a1a4f4e1c62e8bae06045caf852d9ef17f
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review-Url: https://codereview.chromium.org/1945103004
Cr-Commit-Position: refs/heads/master@{#36050}
Rolling v8/build to 5fbb07a2443f8095963594c2f365f99bad549180
Rolling v8/tools/clang to 0e474b23030b2723dfb3dd0c038746ec2c042469
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review-Url: https://codereview.chromium.org/1941543002
Cr-Commit-Position: refs/heads/master@{#35915}
This prepares for pulling chromium's build as dependency for
gn. After this, the files in build and gypfiles need to stay
in sync until chromium is updated.
BUG=chromium:474921
LOG=n
Review-Url: https://codereview.chromium.org/1848553003
Cr-Commit-Position: refs/heads/master@{#35898}
Rolling v8/buildtools to cdbd50759bf2289d2c9d3f1f7d02239b4b4b1209
Rolling v8/tools/clang to 4652e9c8cea11f68101411f5826eca51b4838eda
Rolling v8/tools/gyp to e24c83726b7294179f479a683eeb351568fcc4ee
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review-Url: https://codereview.chromium.org/1926883003
Cr-Commit-Position: refs/heads/master@{#35839}
Uses now the same location chromium uses and which some tools
expect.
BUG=chromium:474921
LOG=n
Review URL: https://codereview.chromium.org/1929473002
Cr-Commit-Position: refs/heads/master@{#35817}
Rolling v8/build/gyp to 4cf07e8d616739f6484e46c9359b2a35196b2585
Rolling v8/buildtools to 2a9a29fbdc2170c25e5cc0f642213eb7b3e7bc98
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1917073004
Cr-Commit-Position: refs/heads/master@{#35783}
Rolling v8/buildtools to e84114dbe2b65428951c876349b6a3ff1afbfccd
Rolling v8/tools/clang to 2956eca572ff0e1b181df65f71a045f061a2eb34
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1909483004
Cr-Commit-Position: refs/heads/master@{#35690}
Rolling v8/buildtools to 5378d73123b64907773cc5c1bb027b2f765ff00a
Rolling v8/tools/clang to 41bff4c5ba97022c0fe69a59d8892a6c45fb0867
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1889043002
Cr-Commit-Position: refs/heads/master@{#35505}
Rolling v8/buildtools to de013cf87971d0ab40596f2275a633432c908052
Rolling v8/tools/clang to 05a5cb33164e3c656a3375a1614ab350ca799215
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1883703003
Cr-Commit-Position: refs/heads/master@{#35428}
Rolling v8/buildtools to a2082cafead67b75c9c8edbdca47a2def6dbab21
Rolling v8/tools/clang to 9dc1904d214a77f081362c1b848b5f28d2192748
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1876583002
Cr-Commit-Position: refs/heads/master@{#35367}
Rolling v8/base/trace_event/common to c8c8665c2deaf1cc749d9f8e153256d4f67bf1b8
Rolling v8/build/gyp to 4ec6c4e3a94bd04a6da2858163d40b2429b8aad1
Rolling v8/tools/clang to faee82e064e04e5cbf60cc7327e7a81d2a4557ad
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1856133003
Cr-Commit-Position: refs/heads/master@{#35248}
Rolling v8/base/trace_event/common to ffb39885a2418caa7a6a6652471fe097732675bd
Rolling v8/tools/clang to 8f7a85a108698ce7ed4fe1aa842efa61f195364e
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1859433002
Cr-Commit-Position: refs/heads/master@{#35223}
Rolling v8/base/trace_event/common to 0fc98828a66ee4d69b9524e4967b9287b7b8eea0
Rolling v8/build/gyp to 697933c2e3b3ffdd6949df3c2fa3613489e01175
Rolling v8/tools/clang to 87058e09f9c547eb5d00cb8ca666c6aec203a117
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1853783004
Cr-Commit-Position: refs/heads/master@{#35219}
Rolling v8/third_party/android_tools to adfd31794011488cd0fc716b53558b2d8a67af8b
Rolling v8/third_party/icu to 628d39f5b088236d2021bf4388549fd92673ff1a
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1847623003
Cr-Commit-Position: refs/heads/master@{#35144}
Rolling v8/build/gyp to 8e8c3178d9d2734a6223b87fbd45ab250baf77e8
Rolling v8/tools/clang to c789a99803595dfa963ba300ac79b760d1304d8c
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1834583002
Cr-Commit-Position: refs/heads/master@{#35050}
Rolling v8/build/gyp to 133eaf70b3720b7413017ef3f9c42f6811ef9347
Rolling v8/third_party/icu to 0d572d65aae621e13d6863fe470c9c8cee71043d
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1824563002
Cr-Commit-Position: refs/heads/master@{#34914}
Rolling v8/buildtools to 7274f1c726640bce4cd4c4198e1ee62a0b29bb89
Rolling v8/third_party/icu to 6d3b55dfa17d9a597c064eeef7ceac18c73184b7
Rolling v8/tools/clang to ec17c92cc70fcd8f5f39eaa17f3dbbd99e29c1f9
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1781313004
Cr-Commit-Position: refs/heads/master@{#34734}
Rolling v8/build/gyp to 61259d585ce99d9de8b35188cd0025bdbcb58411
Rolling v8/tools/clang to 7f949627a42e2b8b229522ab74de5b1b6a1ced3e
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1768263003
Cr-Commit-Position: refs/heads/master@{#34568}
Rolling v8/tools/clang to a8288b3f25cdc4e3c3f4dd7ea2f7765ae8847459
Rolling v8/tools/swarming_client to df6e95e7669883c8fe9ef956c69a544154701a49
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1753133002
Cr-Commit-Position: refs/heads/master@{#34418}
Rolling v8/base/trace_event/common to e40c41030f44cbd5b6f54081436620f43c3bb08a
Rolling v8/tools/clang to d53e60b4f31f03a6f719b13ed2de7389a4d89be4
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1748313002
Cr-Commit-Position: refs/heads/master@{#34374}
Reason for revert:
An Intl change that this depends on breaks a bot
Original issue's description:
> Test262 roll, 2016-2-23
>
> R=adamk
>
> Committed: https://crrev.com/34492040fbfb04fead21416245c8696b9847e751
> Cr-Commit-Position: refs/heads/master@{#34312}
TBR=adamk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1736223002
Cr-Commit-Position: refs/heads/master@{#34313}
Rolling v8/base/trace_event/common to 81b7b6f531ad2375140b2a5f4d3a803e5ba2514c
Rolling v8/buildtools to 14288a03a92856fe1fc296d39e6a25c2d83cd6cf
Rolling v8/tools/swarming_client to a72f46e42dba1335e8001499b4621acad2d26728
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1737243003
Cr-Commit-Position: refs/heads/master@{#34309}
Rolling v8/tools/clang to 8598a726360f2722f4db0eab732a5f6b4cb41eb9
Rolling v8/tools/swarming_client to 71c61c858bb2c2deda83781978fe65e94171f58f
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1729263004
Cr-Commit-Position: refs/heads/master@{#34265}
This enables downloading all gcmole dependencies from
google storage on demand, controlled by a gyp flag
"gcmole=1". This makes the analysis portable to any linux64
host. The archive contains a prebuilt clang in the needed
version, the gcmole plugin and a lua binary.
The tool can be run through a new wrapper that sets up the
environment. This'll ease running it on swarming.
BUG=chromium:535160
LOG=n
Review URL: https://codereview.chromium.org/1703533002
Cr-Commit-Position: refs/heads/master@{#34046}
Rolling v8/buildtools to e27b1f1459452013ce59c9d5dbc93c88982cb76e
Rolling v8/tools/clang to 6449b18afaa80290fd8930c3a42c80908505f41f
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1660143007
Cr-Commit-Position: refs/heads/master@{#33714}
Rolling v8/base/trace_event/common to 4b09207e447ae5bd34643b4c6321bee7b76d35f9
Rolling v8/third_party/icu to 8f91ea3a7e0413df3312204058da856058a8099b
Rolling v8/tools/clang to 003558cb5f46e54fdbf5d14507f5c233d2ea91e6
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1665713002
Cr-Commit-Position: refs/heads/master@{#33692}
Rolling v8/third_party/icu to 2b12f8775d66568f2b2e2bd8246efcfdff40d563
Rolling v8/tools/clang to fc5dab2a77e5a2c69f0095faba5f903d520f0bb5
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1653153003
Cr-Commit-Position: refs/heads/master@{#33653}
Rolling v8/base/trace_event/common to 3b14e6554b07defdad00c17d162c6e7121f71fbf
Rolling v8/buildtools to 389b7143dbd63da3a9725e304d286b02805fc170
Rolling v8/tools/clang to 7548b22debe829cb92047725def34c50fb88ca01
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1648343004
Cr-Commit-Position: refs/heads/master@{#33624}
Rolling v8/buildtools to be55b9ad86a4a5f760895984f93f76038e08e29e
Rolling v8/tools/clang to 2b2edb2dbbc5818f98972eeefd756cdcd69aa6f3
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1650463002
Cr-Commit-Position: refs/heads/master@{#33598}
Rolling v8/buildtools to 11961c21510b90aa6057064459a1af53f3fff449
Rolling v8/tools/clang to 55e0efc650db1b2c60b50c8c32cfc8a27d8f2986
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1641473002
Cr-Commit-Position: refs/heads/master@{#33532}
Rolling v8/buildtools to 222bd42ce39d1bd8f08fe089b066f49c469e1cdf
Rolling v8/tools/clang to 3ed46b50b0b4e8c829ea6492bbe357b2b7b8e64a
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1623773002
Cr-Commit-Position: refs/heads/master@{#33479}
Rolling v8/buildtools to cf8c4332f5c9d0da4b4782d7f0122df74a16819b
Rolling v8/tools/clang to e47364ad9fb37e8255a7a5cdf7891781b3f8256e
Rolling v8/tools/swarming_client to 0b908f18767c8304dc089454bc1c91755d21f1f5
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1621563002
Cr-Commit-Position: refs/heads/master@{#33451}
Rolling v8/buildtools to 81863fe70639e85606b541d9d36e9e98c96b957e
Rolling v8/tools/clang to fe8d232767c63ce43873ffef101063a5791d171e
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1561063002
Cr-Commit-Position: refs/heads/master@{#33134}
Rolling v8/buildtools to 6d0c448437825a1af0ad2ea28128dda474403cd7
Rolling v8/tools/clang to da84f132a581202117fb45bceec8327752c81283
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1554843002
Cr-Commit-Position: refs/heads/master@{#33069}
Rolling v8/buildtools to fee7f1e849f59c3fd7bb7b2cacf876edca0572f3
Rolling v8/tools/clang to c745f4763a6af65800a40b6da508f3e943d1804e
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1540513002
Cr-Commit-Position: refs/heads/master@{#32961}
This is based on the Skia Implementation.
More on the project can be found here:
https://docs.google.com/a/chromium.org/document/d/1_4LAnInOB8tM_DLjptWiszRwa4qwiSsDzMkO4tU-Qes/edit#heading=h.p97rw6yt8o2j
The V8 Tracing platform will replace the isolate->event_logger().
But since the current embedders (namely chromium) currently use the isolate->event_logger, I made the default implementation (event-tracer) call into isolate->event_logger if an event_logger was set.
Once the embedders properly implement the interface (for example in chromium it would look like this: https://codereview.chromium.org/707273005/), the default implementation will be doing nothing.
Once the embedders side is fixed, we will change how V8 uses the tracing framework beyond the call from Logger:CallEventLogger. (which would also include a d8 implementation)
BUG=v8:4560
LOG=N
Review URL: https://codereview.chromium.org/988893003
Cr-Commit-Position: refs/heads/master@{#32959}
Rolling v8/third_party/android_tools to f4c36ad89b2696b37d9cd7ca7d984b691888b188
Rolling v8/tools/clang to 67c5521f1878f7929f8f0afc74b31627b3bbffb3
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1530413002
Cr-Commit-Position: refs/heads/master@{#32923}
While not really fitting our directory layout, the DEPS entry needs to
be at exactly the same position as it is in chromium, otherwise either
standalone or chromium build won't work :-/
BUG=none
R=machenbach@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/1526843004
Cr-Commit-Position: refs/heads/master@{#32896}
Rolling v8/third_party/icu to 8d342a405be5ae8aacb1e16f0bc31c3a4fbf26a2
Rolling v8/tools/clang to 6261565695263bd878edd055e81ecc5e989711d6
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1529973004
Cr-Commit-Position: refs/heads/master@{#32873}
Rolling v8/build/gyp to b85ad3e578da830377dbc1843aa4fbc5af17a192
Rolling v8/tools/clang to f8fd8b699f6c474577b455e55b22df23ceaa2da8
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1527613005
Cr-Commit-Position: refs/heads/master@{#32849}
Rolling v8/buildtools to 68e3c238a5ab347436762cb929316aa55ca72563
Rolling v8/tools/clang to 3a1510ccbc295798602abbbffcf61065704e8acb
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1516193002
Cr-Commit-Position: refs/heads/master@{#32776}
Rolling v8/build/gyp to 70ee80e82bacf2d7816a56f792bb33587b04c338
Rolling v8/tools/clang to 247bb6833987bc73051243230a1f3c949a9c9b92
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1509093002
Cr-Commit-Position: refs/heads/master@{#32672}
Rolling v8/buildtools to b747a9e091cb8212a62343258406eaf53a6c032e
Rolling v8/tools/clang to 58b11d197b1c5fec39a6ec374c21b3d3a5bf557b
Rolling v8/tools/swarming_client to 9cdd76171e517a430a72dcd7d66ade67e109aa00
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1493273004
Cr-Commit-Position: refs/heads/master@{#32593}
Rolling v8/build/gyp to e2313c02ad7b6d589b38fe578f5d39970a9bbc20
Rolling v8/tools/clang to 3cc3dac50b26c67176bfed187a300741f31651bf
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1491133002
Cr-Commit-Position: refs/heads/master@{#32485}
Rolling v8/build/gyp to f4d65e35719cfe02257ece126c109cfc053ca35c
Rolling v8/tools/clang to 3bd755f93254f9c21a323a5cfd28dacbe02e53e4
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1486733003
Cr-Commit-Position: refs/heads/master@{#32437}
In this new version of test262, a number of known failing tests have
been changed to match the ES2016 semantics, which V8 implements.
R=adamk
Review URL: https://codereview.chromium.org/1475793004
Cr-Commit-Position: refs/heads/master@{#32303}
Since the gn builders do not resolve the DEPS after patch, the patch cannot contain
both the DEPS change as well the usage of the newly added DEPS.
If the CL mentioned in the title does not land, this CL is to be remove/reverted as well.
BUG=v8:4560
LOG=N
Review URL: https://codereview.chromium.org/1469303004
Cr-Commit-Position: refs/heads/master@{#32296}
Rolling v8/tools/clang to aeba05c6d90e906ba60a328e9a5b68f25627dc29
Rolling v8/tools/swarming_client to df99a00d96fae932bae824dccba13156bf7eddd0
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1475893002
Cr-Commit-Position: refs/heads/master@{#32239}
Rolling v8/build/gyp to e1133480da78cd4a23a8cec604d1d6d46dab35d6
Rolling v8/buildtools to 818123dac34899ec230840936fc15b8b2b5556f9
Rolling v8/tools/clang to 650a79a0bd9b486fa688d8a71ce00674e9e2c096
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/1456323002
Cr-Commit-Position: refs/heads/master@{#32100}
