Commit Graph

20144 Commits

Author SHA1 Message Date
svenpanne
11a950fcf7 Fixed race condition in HBranch::observed_input_representation.
Non-numeric static local variables are not thread-safe, and the case
at hand was a premature optimization anyway: The generated code for
the check in question is exactly the same when unfolded.

BUG=chromium:420483

Review URL: https://codereview.chromium.org/756903003

Cr-Commit-Position: refs/heads/master@{#25502}
2014-11-25 14:47:32 +00:00
hpayer
d15d453fa5 Distinguish beween final incremental mark-compact and full mark-compact event in IdleNotification.
BUG=

Review URL: https://codereview.chromium.org/727323004

Cr-Commit-Position: refs/heads/master@{#25501}
2014-11-25 13:41:57 +00:00
yangguo
33853f73a7 Partially revert "Optimize function across closures."
BUG=chromium:434447

Review URL: https://codereview.chromium.org/755173002

Cr-Commit-Position: refs/heads/master@{#25500}
2014-11-25 13:22:04 +00:00
yangguo
7904576039 Refactor use of Isolate::use_crankshaft.
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/755883003

Cr-Commit-Position: refs/heads/master@{#25499}
2014-11-25 12:48:06 +00:00
yangguo
2ed39d936a Reset code age on the cloned code when serializing.
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/757983002

Cr-Commit-Position: refs/heads/master@{#25498}
2014-11-25 12:03:41 +00:00
balazs.kilvady
a4c9cc46dc MIPS64: Load prototype from map in PropertyHandlerCompiler::CheckPrototypes.
Port 100db75808

BUG=v8:3629
LOG=N

Review URL: https://codereview.chromium.org/755693002

Cr-Commit-Position: refs/heads/master@{#25497}
2014-11-25 11:38:10 +00:00
jarin
322bb23e82 [turbofan] Insert appropriate conversions for typed array stores.
BUG=

Review URL: https://codereview.chromium.org/758643003

Cr-Commit-Position: refs/heads/master@{#25496}
2014-11-25 08:40:29 +00:00
Benedikt Meurer
9a5ec9c57c Fix platform unittests.
Follow-up to 87db4ff1f4, which added
suppressions to unittests.status and a special case for Android to the
ThreadLocalStorageTest, both of which are unneccessary and should be
handled differently for the GTest based unittests.

BUG=v8:3706
LOG=n
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/757913002

Cr-Commit-Position: refs/heads/master@{#25495}
2014-11-25 07:22:00 +00:00
hpayer
e01e35fc2f Reduce context disposal gc overhead.
BUG=

Review URL: https://codereview.chromium.org/750963002

Cr-Commit-Position: refs/heads/master@{#25494}
2014-11-24 19:19:16 +00:00
verwaest
7cf17a9e5e Don't double smi-tag the mask used to check read-only / field mode in the dictionary-store-stub on X64
BUG=

Review URL: https://codereview.chromium.org/757673002

Cr-Commit-Position: refs/heads/master@{#25493}
2014-11-24 19:16:26 +00:00
cullinan
87db4ff1f4 Fix/suppress unittests broken on Android
cctest/test-threads/ThreadJoinSelf is suppressed for Android, but the
test has since been moved to unittests/Thread.SelfJoin. Move the
suppression to unittests.status.

unittests/ThreadLocalStorageTest.DoTest fails on older Android devices
as it assumes the availability of more TLS slots than many devices
implement. Test a smaller number of slots (32) on Android. Remove old
suppression of test-platform-tls/FastTLS (which no longer exists).

cctest/test-mark-compact/RegressJoinThreadsOnIsolateDeinit can't deal
with shared mappings. Check for 's' instead of '-'.

BUG=v8:3706
LOG=

Review URL: https://codereview.chromium.org/735863003

Cr-Commit-Position: refs/heads/master@{#25492}
2014-11-24 18:06:10 +00:00
jarin
d9cabb9b22 [turbofan] Fix matching of the lea instruction.
Resets the scaled exponent to 0 when the scaling match fails.

BUG=

Review URL: https://codereview.chromium.org/756643002

Cr-Commit-Position: refs/heads/master@{#25491}
2014-11-24 17:45:33 +00:00
ulan
100db75808 Load prototype from map in PropertyHandlerCompiler::CheckPrototypes.
BUG=v8:3629
LOG=N
TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/753223002

Cr-Commit-Position: refs/heads/master@{#25490}
2014-11-24 17:44:25 +00:00
Yang Guo
fc22bf2e8d Disable regress-3717 for gc-stress.
TBR=ulan@chromium.org
BUG=v8:3723
LOG=N

Review URL: https://codereview.chromium.org/749283002

Cr-Commit-Position: refs/heads/master@{#25489}
2014-11-24 16:29:23 +00:00
yangguo
fc52398d21 Remove lineprocessor sample.
This sample used to demonstrate the usage of the DebuggerAgent. The latter
has been removed, so this sample has no point anymore.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/754043002

Cr-Commit-Position: refs/heads/master@{#25488}
2014-11-24 16:23:00 +00:00
yangguo
1a2a18b66c Remove v8::StartupData::compressed_size.
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/739253006

Cr-Commit-Position: refs/heads/master@{#25487}
2014-11-24 16:14:34 +00:00
yangguo
270dccf6db Correctly find shared function info for debugging when compiling eagerly.
R=ulan@chromium.org
BUG=v8:3717
LOG=N

Review URL: https://codereview.chromium.org/758523004

Cr-Commit-Position: refs/heads/master@{#25486}
2014-11-24 15:43:35 +00:00
Michael Stanton
54b0109d42 Make use of post-scoping information to compute feedback vector requirements.
This avoids allocating vector ic slots that we don't use.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/758543002

Cr-Commit-Position: refs/heads/master@{#25485}
2014-11-24 15:00:07 +00:00
ishell
d8a5616809 Dictionary-mode PropertyDetails printing fixed.
BUG=chromium:435974
LOG=N

Review URL: https://codereview.chromium.org/755583003

Cr-Commit-Position: refs/heads/master@{#25484}
2014-11-24 14:55:46 +00:00
ishell
1f5f088969 Reland of "Enable inobject double fields unboxing for 64-bit archs."
Review URL: https://codereview.chromium.org/751643005

Cr-Commit-Position: refs/heads/master@{#25483}
2014-11-24 14:54:38 +00:00
ishell
25b8efffa3 Reland of "TransitionArray::Search() now returns insertion index if the entry was not found."
Review URL: https://codereview.chromium.org/739013004

Cr-Commit-Position: refs/heads/master@{#25482}
2014-11-24 14:31:36 +00:00
baixo
0e5c107c66 Ensure external snapshot is only set once.
BUG=421063

Review URL: https://codereview.chromium.org/746263002

Cr-Commit-Position: refs/heads/master@{#25481}
2014-11-24 12:44:39 +00:00
baixo
009fe698ee The file snapshot_blob_host.bin was supposed to be generated when building the host toolset. However, the file snapshot_blob.bin was being generated instead, under every set of conditions.
Because of this, every time we build the host toolset, snapshot_blob_host.bin is not found. This causes the target (v8_external_snapshot) that generates such file to be run. This target generates snapshot_blob.bin instead of snapshot_blob_host.bin. This in turn causes all the targets that depend on snapshot_blob.bin to run again.

After this, we still don't have snapshot_blob_host.bin. So the next time we build, the whole process described above happens again.

BUG=421063

Review URL: https://codereview.chromium.org/741223002

Cr-Commit-Position: refs/heads/master@{#25480}
2014-11-24 12:43:32 +00:00
Benedikt Meurer
94f5b78b96 [turbofan] Combine Word32And with Int32Add and negative power of two.
TEST=unittests
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/749233002

Cr-Commit-Position: refs/heads/master@{#25479}
2014-11-24 12:30:30 +00:00
hpayer
1d0d520e77 Don't verify evacuation when it is not completed.
BUG=

Review URL: https://codereview.chromium.org/756553002

Cr-Commit-Position: refs/heads/master@{#25478}
2014-11-24 11:58:34 +00:00
Ben L. Titzer
a56900a975 [turbofan] Dump graph in RPO order as text.
R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/754803002

Cr-Commit-Position: refs/heads/master@{#25477}
2014-11-24 11:55:17 +00:00
yangguo
14a3b9188d Fix RegExp.source for uncompiled regexp.
R=jkummerow@chromium.org
BUG=435825
LOG=N

Review URL: https://codereview.chromium.org/753983002

Cr-Commit-Position: refs/heads/master@{#25476}
2014-11-24 11:21:52 +00:00
baptiste.afsa
9b5c279b9f [turbofan] Recognize sign extension of 8-bit and 16-bit values on arm64.
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/730183005

Cr-Commit-Position: refs/heads/master@{#25475}
2014-11-24 11:00:15 +00:00
svenpanne
be0fcaa2bc Added test cases for truncating stores.
Review URL: https://codereview.chromium.org/741643003

Cr-Commit-Position: refs/heads/master@{#25474}
2014-11-24 10:42:26 +00:00
dcarney
b1667fca63 don't use to-be-deprecated Value::To* without isolate parameter
R=svenpanne@chromium.org

BUG=

Review URL: https://codereview.chromium.org/725293003

Cr-Commit-Position: refs/heads/master@{#25473}
2014-11-24 10:30:55 +00:00
andrew_low
c1bfc3485d Fix alignment of Code::kConstantPoolOffset.
This is needed for 64bit alignment sensitive platforms (PowerPC)
Exposed bugs with new GC compare and swap changes updating the
field.

Example failing test:
out/ppc64.debug/cctest  test-decls/ExistsInPrototype

BUG=

Review URL: https://codereview.chromium.org/740443002

Cr-Commit-Position: refs/heads/master@{#25472}
2014-11-24 10:22:17 +00:00
dcarney
3bfc3ae702 remove some isolate::currents from api.cc
R=svenpanne@chromium.org

BUG=

Review URL: https://codereview.chromium.org/691513005

Cr-Commit-Position: refs/heads/master@{#25471}
2014-11-24 09:45:00 +00:00
ishell
d6cd4eab84 Revert of Enable inobject double fields unboxing for 64-bit archs. (patchset #3 id:40001 of https://codereview.chromium.org/753503002/)
Reason for revert:
GCMole and gc-stress issues.

Original issue's description:
> Enable inobject double fields unboxing for 64-bit archs.

TBR=verwaest@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/751863002

Cr-Commit-Position: refs/heads/master@{#25470}
2014-11-22 20:33:03 +00:00
ishell
726eb9d51c Enable inobject double fields unboxing for 64-bit archs.
Review URL: https://codereview.chromium.org/753503002

Cr-Commit-Position: refs/heads/master@{#25469}
2014-11-22 17:30:27 +00:00
dslomov
4d4ed236d8 harmony-scoping: Disallow cross-script assignment to const
R=rossberg@chromium.org
BUG=v8:2198
LOG=N

Review URL: https://codereview.chromium.org/745963002

Cr-Commit-Position: refs/heads/master@{#25468}
2014-11-21 18:09:33 +00:00
mstarzinger
7aad1d2e42 Revert "Remove deprecated ShouldSelfOptimize machinery."
This reverts commit 9da92c1a33 because of performance regressions.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/752613002

Cr-Commit-Position: refs/heads/master@{#25467}
2014-11-21 17:28:38 +00:00
danno
4f1cc51555 [turbofan]: remove optimization of adds/subs to inc and dec
They generally cause regressions on most modern Intel chips. Replace them with
addl/subl.

Review URL: https://codereview.chromium.org/737153003

Cr-Commit-Position: refs/heads/master@{#25466}
2014-11-21 13:18:46 +00:00
dcarney
ac3c4d40f5 [turbofan] put late ssa deconstruction in register allocator behind a flag
BUG=

Review URL: https://codereview.chromium.org/751543002

Cr-Commit-Position: refs/heads/master@{#25465}
2014-11-21 13:14:00 +00:00
yangguo
9b8d40594a Rip out bzip compression for native sources.
R=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/750543002

Cr-Commit-Position: refs/heads/master@{#25464}
2014-11-21 12:45:20 +00:00
yangguo
5414c39974 Slightly improve tests that rely on lazy compilation.
R=rossberg@chromium.org
BUG=v8:3712
LOG=N

Review URL: https://codereview.chromium.org/743843003

Cr-Commit-Position: refs/heads/master@{#25463}
2014-11-21 12:41:06 +00:00
jochen
34363bf5aa Introduce a flag to change the new space growth factor
A useful value would be 4, so we get 1, 4, 16MB (instead of the default
value 2 which leads to 1, 2, 4, 8, 16)

BUG=none
R=hpayer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/753513002

Cr-Commit-Position: refs/heads/master@{#25462}
2014-11-21 12:14:29 +00:00
dcarney
dad405a258 [turbofan] put spill slot reuse behind a flag
BUG=

Review URL: https://codereview.chromium.org/748773002

Cr-Commit-Position: refs/heads/master@{#25461}
2014-11-21 11:33:05 +00:00
ulan
132871a6a8 ARM64: skip flaky mozilla/ecma/Date/15.9.5.26-1 until it is fixed.
BUG=v8:3716
LOG=N

Review URL: https://codereview.chromium.org/746983002

Cr-Commit-Position: refs/heads/master@{#25460}
2014-11-21 11:24:54 +00:00
mstarzinger
9da92c1a33 Remove deprecated ShouldSelfOptimize machinery.
R=titzer@chromium.org

Review URL: https://codereview.chromium.org/582683002

Cr-Commit-Position: refs/heads/master@{#25459}
2014-11-21 11:23:52 +00:00
Yang Guo
5d65e1374f Fix mozilla expectations after regexp change.
TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/749963002

Cr-Commit-Position: refs/heads/master@{#25458}
2014-11-21 11:23:51 +00:00
yangguo
61bee5c898 Correctly escape RegExp source.
R=ulan@chromium.org
BUG=v8:3229
LOG=N

Review URL: https://codereview.chromium.org/736003002

Cr-Commit-Position: refs/heads/master@{#25457}
2014-11-21 10:50:24 +00:00
Michael Stanton
cf572694fe Assert to protect against polymorphic string loads fires on valid stores.
BUG=435477
LOG=N
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/751513002

Cr-Commit-Position: refs/heads/master@{#25456}
2014-11-21 10:29:08 +00:00
Michael Stanton
3d58b82add Fix for 435073: CHECK failure in CHECK(p->IsSmi()) failed.
The bug was an error when copying arrays in crankshaft. If it's a holey smi
array, the copy must be done as FAST_HOLEY_ELEMENTS to prevent representation
changes from being inserted that deopt on encountering the hole.

Also, prevent inlining array pop() and shift() if the length is read-only.

BUG=435073
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/737383002

Cr-Commit-Position: refs/heads/master@{#25455}
2014-11-21 10:14:19 +00:00
Baptiste Afsa
fada2a08e5 [turbofan] Avoid useless zero-extension on arm64.
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/737733002

Cr-Commit-Position: refs/heads/master@{#25454}
2014-11-21 10:00:57 +00:00
dcarney
0ed433ce30 dump compiler stats from d8 on direct exit from js
BUG=

Review URL: https://codereview.chromium.org/753483002

Cr-Commit-Position: refs/heads/master@{#25453}
2014-11-21 09:53:12 +00:00