v8-ci-autoroll-builder
61263dc0ec
Update V8 DEPS.
...
Rolling v8/build: a2bfd53..05ea63b
Rolling v8/buildtools: da9b294..04161ec
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d115075..aa21a92
Rolling v8/third_party/depot_tools: e47ac15..d66dad7
Rolling v8/tools/clang: aa6b9c8..7fa2bdf
Rolling v8/tools/luci-go:infra/tools/luci/isolate/${platform}: https://chrome-infra-packages.appspot.com/infra/tools/luci/isolate/${platform}/+log/git_rev..git_rev
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I5c181380da2230f62677f345c6584f3fd856b75f
Reviewed-on: https://chromium-review.googlesource.com/c/1347890
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57706}
2018-11-22 03:55:43 +00:00
Michael Achenbach
28af9d7e90
Update V8 DEPS.
...
Rolling v8/build: 1f137f3..a2bfd53
Rolling v8/buildtools: 13a00f1..da9b294
Rolling v8/test/wasm-js/data: 5aaea96..e822213
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1e54003..d115075
Rolling v8/third_party/depot_tools: 7da982a..e47ac15
Rolling v8/tools/swarming_client: 7f463e6..b6e9e23
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: Icf622c3e49371ba965f08e15d0177697f04c55e5
Reviewed-on: https://chromium-review.googlesource.com/c/1344806
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57663}
2018-11-21 09:16:25 +00:00
v8-ci-autoroll-builder
7f4a04e7f3
Update V8 DEPS.
...
Rolling v8/build: 2fb6537..1f137f3
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b81a9c7..1e54003
Rolling v8/third_party/depot_tools: c6ffd7a..7da982a
Rolling v8/tools/clang: 1d879ce..aa6b9c8
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I7e874e531e589b194184067e0e5b7fd7230c371d
Reviewed-on: https://chromium-review.googlesource.com/c/1342949
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57625}
2018-11-20 03:26:47 +00:00
v8-ci-autoroll-builder
c18dc78584
Update V8 DEPS.
...
Rolling v8/build: 1caa03d..2fb6537
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I68d342787770515ebbd38b81c341202026b24a25
Reviewed-on: https://chromium-review.googlesource.com/c/1341462
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57591}
2018-11-19 03:29:23 +00:00
v8-ci-autoroll-builder
27eeb711a3
Update V8 DEPS.
...
Rolling v8/third_party/icu: 45f655f..407b393
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I66c8e7e5cb96dbaa4a2e80d0eaace3dfd1624c79
Reviewed-on: https://chromium-review.googlesource.com/c/1341454
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57589}
2018-11-18 03:46:57 +00:00
v8-ci-autoroll-builder
076ea0b9c9
Update V8 DEPS.
...
Rolling v8/build: e983b53..1caa03d
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e69406d..b81a9c7
Rolling v8/third_party/depot_tools: 8ada4d5..c6ffd7a
Rolling v8/tools/clang: b19f15a..1d879ce
Rolling v8/tools/swarming_client: f78187a..7f463e6
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: Idd64c2a6be6f1664a19e84376d2d19d0fc68dbc6
Reviewed-on: https://chromium-review.googlesource.com/c/1341128
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57588}
2018-11-17 03:29:23 +00:00
Mathias Bynens
eb93a84632
Roll Test262
...
This roll should cover the last batch of upstream $DONOTEVALUATE
updates.
TBR=gsathya@chromium.org
Bug: v8:7834, v8:8467
Change-Id: Ia1c6e8fa2fd7fd020c5499b3825a8c1e6c14db47
Reviewed-on: https://chromium-review.googlesource.com/c/1338348
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57587}
2018-11-17 03:04:01 +00:00
v8-ci-autoroll-builder
c0281e928d
Update V8 DEPS.
...
Rolling v8/build: ccf9ff5..e983b53
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8a6451c..e69406d
Rolling v8/third_party/depot_tools: f66e551..8ada4d5
Rolling v8/tools/clang: fa8094f..b19f15a
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: Id7245fc90eee541a03b16d30b337db4afb07bc7f
Reviewed-on: https://chromium-review.googlesource.com/c/1339239
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57561}
2018-11-16 09:33:55 +00:00
Mathias Bynens
837efe703f
Roll Test262
...
Bug: v8:7834
Change-Id: I1986c55cb884acfce11f779a23d303cd126c43d7
Reviewed-on: https://chromium-review.googlesource.com/c/1336471
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57553}
2018-11-15 16:44:41 +00:00
v8-ci-autoroll-builder
12d99b8b88
Update V8 DEPS.
...
Rolling v8/build: 6600235..ccf9ff5
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6b8b30c..8a6451c
Rolling v8/third_party/depot_tools: ef71a5f..f66e551
Rolling v8/tools/luci-go:infra/tools/luci/isolate/${platform}: https://chrome-infra-packages.appspot.com/infra/tools/luci/isolate/${platform}/+log/git_rev..git_rev
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: Id6ee2891245ec1ce147c83ba1f9715646bb15c56
Reviewed-on: https://chromium-review.googlesource.com/c/1336783
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57520}
2018-11-15 07:54:38 +00:00
Sergiy Byelozyorov
fa306d4372
Update V8 DEPS.
...
Rolling v8/build: 8af70c5..6600235
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0cf6ee7..6b8b30c
Rolling v8/third_party/depot_tools: 332c9ff..ef71a5f
Rolling v8/third_party/googletest/src: 2e68926..879ac09
Rolling v8/tools/luci-go:infra/tools/luci/isolate/${platform}: https://chrome-infra-packages.appspot.com/infra/tools/luci/isolate/${platform}/+log/git_rev..git_rev
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I0cbffcb71b49e1d54e2aedb19f6dab65448586a0
Reviewed-on: https://chromium-review.googlesource.com/c/1336187
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57517}
2018-11-14 20:08:33 +00:00
v8-ci-autoroll-builder
47c642e5e9
Update V8 DEPS.
...
Rolling v8/build: 81ffd00..8af70c5
Rolling v8/third_party/android_tools: https://chromium.googlesource.com/android_tools/+log/130499e..6fecaa5
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f2c3502..0cf6ee7
Rolling v8/third_party/depot_tools: ddbeac1..332c9ff
Rolling v8/tools/clang: 31f2d26..fa8094f
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: Ic70fa8509b5fc87f37f30b2081a92807518b4fe2
Reviewed-on: https://chromium-review.googlesource.com/c/1332869
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57453}
2018-11-13 03:40:59 +00:00
v8-ci-autoroll-builder
77b53a8f86
Update V8 DEPS.
...
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5d50916..f2c3502
Rolling v8/third_party/depot_tools: af0ede1..ddbeac1
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: Ie5eb9348ac4bec24bdd4b7c42cc64199ef55b90d
Reviewed-on: https://chromium-review.googlesource.com/c/1330919
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57417}
2018-11-11 18:36:03 +00:00
v8-ci-autoroll-builder
28d2af161c
Update V8 DEPS.
...
Rolling v8/build: 3f61809..81ffd00
Rolling v8/third_party/depot_tools: 93cd73d..af0ede1
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I4d9b172f6657d33629a021475290869f743c5482
Reviewed-on: https://chromium-review.googlesource.com/c/1330911
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57415}
2018-11-10 03:54:37 +00:00
Michael Achenbach
ed618c3972
Update V8 DEPS.
...
Rolling v8/build: cae006c..3f61809
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1a1b38d..5d50916
Rolling v8/third_party/depot_tools: 75fa855..93cd73d
Rolling v8/third_party/icu: 834113a..45f655f
Rolling v8/tools/clang: 7798243..31f2d26
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
The ICU roll also fixes a test that now passes. The status file has been changed.
But: v8:8414
Change-Id: I82577bf6133176f2245b5562b71097fe3b222658
Reviewed-on: https://chromium-review.googlesource.com/c/1328003
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57376}
2018-11-09 08:22:41 +00:00
v8-ci-autoroll-builder
42dcc3ccc2
Update test262.
...
Rolling v8/test/test262/data: d9d9839..0475c12
TBR=adamk@chromium.org ,gsathya@chromium.org
Change-Id: I3d996306614cbf80a24c9dfc4f320ad551fd0b84
Reviewed-on: https://chromium-review.googlesource.com/c/1326365
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57356}
2018-11-08 14:39:02 +00:00
v8-ci-autoroll-builder
54ba9dee35
Update V8 DEPS.
...
Rolling v8/build: 9f8abf9..cae006c
Rolling v8/test/wasm-js/data: a56cf2e..5aaea96
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2e722b0..1a1b38d
Rolling v8/third_party/depot_tools: 6d6e0a8..75fa855
Rolling v8/third_party/fuchsia-sdk: 29de0c2..ac40df8
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: Ifcd163c5757f69ea900548da5e315c07a76e1cb8
Reviewed-on: https://chromium-review.googlesource.com/c/1325372
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57339}
2018-11-08 03:44:26 +00:00
Mathias Bynens
bd90821446
Roll Test262
...
The goal is to roll in my upstream patch [1] which speeds up some of the
slowest tests. The impact is especially noticeable on the builder named
“V8 Linux - arm64 - sim - debug”.
Before [2]:
08:57:047 test262/built-ins/RegExp/CharacterClassEscapes/character-class-non-digit-class-escape-flags-u *
08:56:265 test262/built-ins/RegExp/CharacterClassEscapes/character-class-non-word-class-escape-flags-u *
08:53:736 test262/built-ins/RegExp/CharacterClassEscapes/character-class-non-whitespace-class-escape-flags-u *
08:26:101 test262/built-ins/RegExp/CharacterClassEscapes/character-class-non-whitespace-class-escape-flags-u *
06:57:767 test262/built-ins/RegExp/CharacterClassEscapes/character-class-non-word-class-escape-flags-u *
05:04:746 test262/built-ins/RegExp/CharacterClassEscapes/character-class-non-digit-class-escape-flags-u *
01:46:609 test262/built-ins/Array/prototype/filter/15.4.4.20-9-c-ii-1 *
[…other unrelated tests…]
After [3]:
01:46:630 test262/built-ins/Array/prototype/filter/15.4.4.20-9-c-ii-1 *
[…other unrelated tests…]
That is, tests that previously took almost 9 minutes to run now don’t even
show up in the list of slowest tests anymore.
[1] https://github.com/tc39/test262/pull/1927
[2] https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8930575270954225344/+/steps/Test262_-_no_variants/0/logs/durations/0
[3] https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8930489323837575408/+/steps/Test262_-_no_variants/0/logs/durations/0
Bug: v8:7834
Change-Id: I1d0cea3b64223f7b0ec89c46235632855b8c7eee
Reviewed-on: https://chromium-review.googlesource.com/c/1323733
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57332}
2018-11-07 21:05:44 +00:00
v8-ci-autoroll-builder
9a9af77433
Update V8 DEPS.
...
Rolling v8/build: 47ccdba..9f8abf9
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9a5dbc6..2e722b0
Rolling v8/third_party/depot_tools: 459aaba..6d6e0a8
Rolling v8/third_party/icu: 42d5027..834113a
Rolling v8/tools/clang: b2235ed..7798243
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: Ibcbc016a94cf4e22180dc6b9b78f14fb42a6bacc
Reviewed-on: https://chromium-review.googlesource.com/c/1321896
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57305}
2018-11-07 03:47:38 +00:00
Junliang Yan
09b29b0962
s390x: ignore luci-go on the arch because it's missing
...
Bug: v8:8420
Change-Id: Ie3ca4cbee01a1b19c82630ec205915ff6a00b303
Reviewed-on: https://chromium-review.googlesource.com/c/1320449
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#57297}
2018-11-06 19:23:35 +00:00
v8-ci-autoroll-builder
6546405856
Update V8 DEPS.
...
Rolling v8/build: b5b1fdc..47ccdba
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/03ce64d..9a5dbc6
Rolling v8/third_party/depot_tools: 7e0b0c4..459aaba
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I24add833a4dee7301efa3f1ee2248351e3864074
Reviewed-on: https://chromium-review.googlesource.com/c/1319250
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57258}
2018-11-06 03:38:06 +00:00
v8-ci-autoroll-builder
5cd9436799
Update V8 DEPS.
...
Rolling v8/build: cd2c8fe..b5b1fdc
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8c035b3..03ce64d
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I5df515eea0c133826fcc1a78fb2453a2a8043c98
Reviewed-on: https://chromium-review.googlesource.com/c/1318093
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57255}
2018-11-05 23:31:22 +00:00
Frank Tang
3aa8267bb7
Roll Test262
...
Bug: v8:7834
Change-Id: Ib53448757bbaf785ff39ba0da6f54c91e449035b
Reviewed-on: https://chromium-review.googlesource.com/c/1314113
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57249}
2018-11-05 19:54:04 +00:00
v8-ci-autoroll-builder
eab36a246d
Update V8 DEPS.
...
Rolling v8/build: 5fafa7f..cd2c8fe
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I841cf4971c83f84dbe02d1ca771f503ca4856f82
Reviewed-on: https://chromium-review.googlesource.com/c/1316621
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57228}
2018-11-05 03:43:16 +00:00
v8-ci-autoroll-builder
5031c145e6
Update V8 DEPS.
...
Rolling v8/build: cf39c38..5fafa7f
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c02ed04..8c035b3
Rolling v8/third_party/depot_tools: a98da07..7e0b0c4
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I42ab117eb558e08ba1b5b9e56c288e6a5d3be66a
Reviewed-on: https://chromium-review.googlesource.com/c/1316613
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57224}
2018-11-04 03:27:56 +00:00
v8-ci-autoroll-builder
c803241db1
Update V8 DEPS.
...
Rolling v8/build: 6231c05..cf39c38
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/971689c..c02ed04
Rolling v8/third_party/depot_tools: fec80c4..a98da07
Rolling v8/tools/clang: 36daae0..b2235ed
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I27fbc4176c251e107b3793ebbb26cc5d298829b9
Reviewed-on: https://chromium-review.googlesource.com/c/1316611
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57223}
2018-11-03 03:35:34 +00:00
v8-ci-autoroll-builder
474a6d6364
Update V8 DEPS.
...
Rolling v8/build: 3e568c8..6231c05
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f929109..971689c
Rolling v8/third_party/depot_tools: 0db62fc..fec80c4
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: Iceb90cfe32d86cc6e45d0464cd726472b659d75e
Reviewed-on: https://chromium-review.googlesource.com/c/1314108
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57202}
2018-11-02 03:46:41 +00:00
v8-ci-autoroll-builder
2ef0aa662f
Update V8 DEPS.
...
Rolling v8/build: 277ad43..3e568c8
Rolling v8/test/wasm-js/data: c90bc96..a56cf2e
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5e1c1c2..f929109
Rolling v8/third_party/depot_tools: f170af4..0db62fc
Rolling v8/tools/clang: 3041f30..36daae0
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I57e0b3aa389b6a42d64134de607ee2e2267f04a4
Reviewed-on: https://chromium-review.googlesource.com/c/1312241
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57196}
2018-11-01 03:46:58 +00:00
Alexey Kozyatinskiy
ebd070ec2f
reland: inspector: move injected script source to native
...
- introduced ValueMirror interface, this interface contains methods to generate
different protocol entities,
- introduced DebugPropertyIterator, this iterator iterates through object properties
in the following order: exotic indices, enumerable strings, all other properties,
- removed all injected script infra, e.g. closure compiler,
R=dgozman@chromium.org
TBR=yangguo@chromium.org
Bug: chromium:595206
Change-Id: I030fdb3a80074ca6edd4749f86b39b590776ae6f
Reviewed-on: https://chromium-review.googlesource.com/c/1310056
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57181}
2018-10-31 17:47:58 +00:00
Michael Achenbach
c11c8b26cd
Update V8 DEPS.
...
Rolling v8/build: 49671d3..277ad43
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/36a23a7..5e1c1c2
Rolling v8/third_party/depot_tools: cb629a4..f170af4
Rolling v8/third_party/icu: b029971..42d5027
Rolling v8/third_party/instrumented_libraries: a90cbf3..a959e4f
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I951bed28ed3181406ceab213cee37c473a7c0c7f
Reviewed-on: https://chromium-review.googlesource.com/c/1309294
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57178}
2018-10-31 17:17:21 +00:00
Aleksey Kozyatinskiy
fc5c8d7f78
Revert "inspector: move injected script source to native"
...
This reverts commit 7e079c660b
.
Reason for revert: native implementation should be ready for navigation.
Original change's description:
> inspector: move injected script source to native
>
> - introduced ValueMirror interface, this interface contains methods to generate
> different protocol entities,
> - introduced DebugPropertyIterator, this iterator iterates through object properties
> in the following order: exotic indices, enumerable strings, all other properties,
> - removed all injected script infra, e.g. closure compiler,
>
> R=dgozman@chromium.org
> TBR=yangguo@chromium.org
>
> Bug: chromium:595206
> Change-Id: Idcfc04489ee52e015ad1d1d191c3474cc65e63f2
> Reviewed-on: https://chromium-review.googlesource.com/c/1308353
> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#57150}
TBR=dgozman@chromium.org ,yangguo@chromium.org,kozyatinskiy@chromium.org
Change-Id: I8c5c61f4cfe5a66cd33eadd02ab4acec539cc3bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:595206
Reviewed-on: https://chromium-review.googlesource.com/c/1310055
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57176}
2018-10-31 15:58:30 +00:00
Frank Tang
38e046df6e
Roll Test262
...
Bug: v8:7834
Change-Id: I2016b8d5e561546ec2f9b81d24c75bff0b950367
Reviewed-on: https://chromium-review.googlesource.com/c/1306896
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57151}
2018-10-30 23:42:52 +00:00
Alexey Kozyatinskiy
7e079c660b
inspector: move injected script source to native
...
- introduced ValueMirror interface, this interface contains methods to generate
different protocol entities,
- introduced DebugPropertyIterator, this iterator iterates through object properties
in the following order: exotic indices, enumerable strings, all other properties,
- removed all injected script infra, e.g. closure compiler,
R=dgozman@chromium.org
TBR=yangguo@chromium.org
Bug: chromium:595206
Change-Id: Idcfc04489ee52e015ad1d1d191c3474cc65e63f2
Reviewed-on: https://chromium-review.googlesource.com/c/1308353
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57150}
2018-10-30 21:30:55 +00:00
v8-ci-autoroll-builder
81ee4aa934
Update V8 DEPS.
...
Rolling v8/build: c55a0b9..49671d3
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/985e130..36a23a7
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I2aeb099485078312a09866964253ba87fa714447
Reviewed-on: https://chromium-review.googlesource.com/c/1306904
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57148}
2018-10-30 18:29:08 +00:00
Clemens Hammacher
192bee6bac
Revert "inspector: move injected script source to native"
...
This reverts commit 34686abe40
.
Reason for revert: Compile errors on several bots, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug%20builder/33299
Original change's description:
> inspector: move injected script source to native
>
> - introduced ValueMirror interface, this interface contains methods to generate
> different protocol entities,
> - introduced DebugPropertyIterator, this iterator iterates through object properties
> in the following order: exotic indices, enumerable strings, all other properties,
> - removed all injected script infra, e.g. closure compiler,
>
> R=dgozman@chromium.org
> TBR=yangguo@chromium.org
>
> Bug: chromium:595206
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I077c1879622aa0d9900d719b80d2ef5ba4221a22
> Reviewed-on: https://chromium-review.googlesource.com/c/1295550
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#57142}
TBR=dgozman@chromium.org ,yangguo@chromium.org,kozyatinskiy@chromium.org
Change-Id: I6e4ccaf1d6b151fbc0ffe4f26daa584433321c77
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:595206
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1307432
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57144}
2018-10-30 17:04:54 +00:00
Alexey Kozyatinskiy
34686abe40
inspector: move injected script source to native
...
- introduced ValueMirror interface, this interface contains methods to generate
different protocol entities,
- introduced DebugPropertyIterator, this iterator iterates through object properties
in the following order: exotic indices, enumerable strings, all other properties,
- removed all injected script infra, e.g. closure compiler,
R=dgozman@chromium.org
TBR=yangguo@chromium.org
Bug: chromium:595206
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I077c1879622aa0d9900d719b80d2ef5ba4221a22
Reviewed-on: https://chromium-review.googlesource.com/c/1295550
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57142}
2018-10-30 16:43:55 +00:00
v8-ci-autoroll-builder
61c6404e23
Update V8 DEPS.
...
Rolling v8/build: 425295f..c55a0b9
Rolling v8/third_party/depot_tools: 2b71832..cb629a4
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I10387d35ae298c7d20bc5eacfb70cff05ecd4052
Reviewed-on: https://chromium-review.googlesource.com/c/1304193
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57051}
2018-10-29 03:25:53 +00:00
v8-ci-autoroll-builder
e0b039e49d
Update V8 DEPS.
...
Rolling v8/build: 94314f9..425295f
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: If6f2893e829c4f03e52cd869fbb7f261a6aa53c2
Reviewed-on: https://chromium-review.googlesource.com/c/1303539
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57050}
2018-10-28 03:46:13 +00:00
v8-ci-autoroll-builder
5ba032b33d
Update V8 DEPS.
...
Rolling v8/build: df2e6ae..94314f9
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/687f318..985e130
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: Id21b9e29ba5f71ed92390e026e7bd74b9751959f
Reviewed-on: https://chromium-review.googlesource.com/c/1303536
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57049}
2018-10-27 03:31:31 +00:00
v8-ci-autoroll-builder
673955d9a2
Update V8 DEPS.
...
Rolling v8/build: 5a371bc..df2e6ae
Rolling v8/test/wasm-js/data: b0e7838..c90bc96
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ed6fe0f..687f318
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I7e0d61113455231c6fb40e229329b61c3de9b28c
Reviewed-on: https://chromium-review.googlesource.com/c/1300856
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#57011}
2018-10-26 03:46:57 +00:00
Sergiy Byelozyorov
919841a839
Use CIPD to checkout luci-go binaries
...
R=machenbach@chromium.org
Bug: chromium:865541
Change-Id: I98f21c278099bd2c90b4a1ff9b7dddb74d263e34
Reviewed-on: https://chromium-review.googlesource.com/c/1144923
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56975}
2018-10-25 09:25:34 +00:00
Michael Achenbach
9929a238ab
Update V8 DEPS.
...
Rolling v8/build: 6455acf..5a371bc
Rolling v8/test/wasm-js/data: 7e3c46a..b0e7838
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b026043..ed6fe0f
Rolling v8/third_party/depot_tools: 98f1e59..2b71832
Rolling v8/third_party/fuchsia-sdk: bac0433..29de0c2
Rolling v8/tools/clang: a245b95..3041f30
Rolling v8/tools/luci-go: 445d7c4..86c09e8
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: Ieb48aa2ff019267e3be8d3f70e60829d545d34c3
Reviewed-on: https://chromium-review.googlesource.com/c/1298391
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56971}
2018-10-25 07:28:05 +00:00
v8-ci-autoroll-builder
c20b0ded5f
Update V8 DEPS.
...
Rolling v8/build: bd2533d..6455acf
Rolling v8/third_party/icu: ccad447..b029971
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I4eec5e59be17ef15b3e4698c6ef6852e185dfc88
Reviewed-on: https://chromium-review.googlesource.com/c/1293073
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#56837}
2018-10-22 04:25:13 +00:00
v8-ci-autoroll-builder
23cc30051b
Update V8 DEPS.
...
Rolling v8/build: 8579f3d..bd2533d
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I46a9153202602b8df138a9e2aeebdc8ef65ce4fa
Reviewed-on: https://chromium-review.googlesource.com/c/1293069
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#56836}
2018-10-21 03:45:30 +00:00
v8-ci-autoroll-builder
694f6bd710
Update V8 DEPS.
...
Rolling v8/build: 0353cd5..8579f3d
Rolling v8/test/wasm-js/data: 64bf5c7..7e3c46a
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/237fb2a..b026043
Rolling v8/third_party/depot_tools: 93277a7..98f1e59
Rolling v8/tools/swarming_client: 486c9b5..f78187a
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I46c3e04ff35809c23d5646e5031abd5e5b9829e4
Reviewed-on: https://chromium-review.googlesource.com/c/1292682
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#56832}
2018-10-20 03:53:36 +00:00
v8-ci-autoroll-builder
a2e2520bed
Update V8 DEPS.
...
Rolling v8/build: 5839d1c..0353cd5
Rolling v8/test/wasm-js/data: cf67a47..64bf5c7
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5195651..237fb2a
Rolling v8/third_party/depot_tools: 08faab9..93277a7
Rolling v8/third_party/fuchsia-sdk: 6f8b55e..bac0433
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: I76b5ec2bbed7d63db1f496229a20567e3740b9eb
Reviewed-on: https://chromium-review.googlesource.com/c/1290115
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#56799}
2018-10-19 03:44:15 +00:00
Ben Smith
4347d0add1
Reland "[wasm] Add a new wasm-js testsuite to run js-api tests"
...
This is a reland of a12203c64b
Original change's description:
> [wasm] Add a new wasm-js testsuite to run js-api tests
>
> These changes were necessary to run with the new style of jsapi tests
> introduced in https://github.com/WebAssembly/spec/pull/883 .
>
> Change-Id: I4629dd48d595ed97ed0607dec9e7d9808c706a7e
> Reviewed-on: https://chromium-review.googlesource.com/c/1277724
> Commit-Queue: Ben Smith <binji@chromium.org>
> Reviewed-by: Andreas Haas <ahaas@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Reviewed-by: Mathias Bynens <mathias@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56745}
Change-Id: I25fcd95bfc1aee1d21da390359423e5dfed112a4
Reviewed-on: https://chromium-review.googlesource.com/c/1286952
Commit-Queue: Ben Smith <binji@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56791}
2018-10-18 20:18:55 +00:00
v8-ci-autoroll-builder
24e50f385e
Update V8 DEPS.
...
Rolling v8/build: 4ebebc9..5839d1c
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b273e0c..5195651
Rolling v8/third_party/fuchsia-sdk: 9647596..6f8b55e
TBR=machenbach@chromium.org ,hablich@chromium.org,sergiyb@chromium.org
Change-Id: Ib6c47e8fbe111eed904cc368adef9c1825d41801
Reviewed-on: https://chromium-review.googlesource.com/c/1288189
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56751}
2018-10-18 07:25:37 +00:00
Bill Budge
5c5dd02128
Revert "[wasm] Add a new wasm-js testsuite to run js-api tests"
...
This reverts commit a12203c64b
.
Reason for revert: Breaks isolate_tests
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20builder/36777
Original change's description:
> [wasm] Add a new wasm-js testsuite to run js-api tests
>
> These changes were necessary to run with the new style of jsapi tests
> introduced in https://github.com/WebAssembly/spec/pull/883 .
>
> Change-Id: I4629dd48d595ed97ed0607dec9e7d9808c706a7e
> Reviewed-on: https://chromium-review.googlesource.com/c/1277724
> Commit-Queue: Ben Smith <binji@chromium.org>
> Reviewed-by: Andreas Haas <ahaas@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Reviewed-by: Mathias Bynens <mathias@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56745}
TBR=binji@chromium.org ,machenbach@chromium.org,yangguo@chromium.org,ahaas@chromium.org,clemensh@chromium.org,mathias@chromium.org
Change-Id: I2edd0ca94cb5990322571879c81671fa835f3ecd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1286526
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56746}
2018-10-17 17:30:45 +00:00
Ben Smith
a12203c64b
[wasm] Add a new wasm-js testsuite to run js-api tests
...
These changes were necessary to run with the new style of jsapi tests
introduced in https://github.com/WebAssembly/spec/pull/883 .
Change-Id: I4629dd48d595ed97ed0607dec9e7d9808c706a7e
Reviewed-on: https://chromium-review.googlesource.com/c/1277724
Commit-Queue: Ben Smith <binji@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56745}
2018-10-17 17:07:53 +00:00