machenbach
b3000dda14
[test] Skip unsuitable tests for msan.
...
NOTRY=true
BUG=chromium:425187
LOG=n
TBR=Sven Panne, titzer
Review URL: https://codereview.chromium.org/1107323003
Cr-Commit-Position: refs/heads/master@{#28103}
2015-04-28 11:18:12 +00:00
yangguo
46b3582f48
Reland: Preprocess structured stack trace on GC to get rid of code reference.
...
BUG=v8:2340
LOG=N
Review URL: https://codereview.chromium.org/1109093002
Cr-Commit-Position: refs/heads/master@{#28102}
2015-04-28 11:12:56 +00:00
jkummerow
6270b797bc
Only try to unregister prototype users that are prototypes themselves
...
Because only such maps would have been registered in the first place.
This is a performance fix/followup to f6187fb3b5
/ r28076.
BUG=chromium:481785
LOG=n
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/1105063003
Cr-Commit-Position: refs/heads/master@{#28101}
2015-04-28 11:02:18 +00:00
ssid
0a1352a716
Extending v8::GetHeapStatistics to return total available size.
...
For dumping memory statistics about v8 heap, we need the total
available size of the heap. This CL adds extra field in HeapStatistics
to return the available size.
BUG=476013
LOG=Y
Review URL: https://codereview.chromium.org/1104123002
Cr-Commit-Position: refs/heads/master@{#28100}
2015-04-28 10:57:15 +00:00
dcarney
12350f16b8
[turbofan] Cleanup LiveRange a bit.
...
Review URL: https://codereview.chromium.org/1111563004
Cr-Commit-Position: refs/heads/master@{#28099}
2015-04-28 09:59:27 +00:00
jochen
1630253f93
Turn JSArrayBuffer::flags into a bit field
...
That way, we can access it more easily without all the smi magic
BUG=none
R=dcarney@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1112503002
Cr-Commit-Position: refs/heads/master@{#28098}
2015-04-28 09:40:07 +00:00
machenbach
4b95b9bb32
[test] Restrict msan to default variant.
...
NOTRY=true
BUG=chromium:425187
LOG=n
TBR=Sven Panne, titzer
Review URL: https://codereview.chromium.org/1110923002
Cr-Commit-Position: refs/heads/master@{#28097}
2015-04-28 09:05:11 +00:00
ofrobots
1f03256de3
fix assertion in Logger::CurrentTimeEvent with --prof
...
assertion did match the conditions under which this method gets called
(Runtime_DateCurrentTime). The bug got introduced as part of this change:
https://codereview.chromium.org/802333002
The assertion crash can be reproduced using:
% out/Debug/d8 --prof -e 'new Date();'
R=jkummerow@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1104303002
Cr-Commit-Position: refs/heads/master@{#28096}
2015-04-28 08:53:49 +00:00
yangguo
4d12e94801
Port CallSite methods to C++.
...
The goal is to port all of error stack trace formatting to C++.
We will do this bottom up, by first porting helper functions.
Eventually, CallSite methods will only be used when a custom
error stack trace formatter is defined via Error.prepareStackTrace.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/1060583008
Cr-Commit-Position: refs/heads/master@{#28095}
2015-04-28 08:52:47 +00:00
dcarney
3be656fb55
Reland: deprecate non-phantom weak callbacks
...
BUG=
Review URL: https://codereview.chromium.org/1103173002
Cr-Commit-Position: refs/heads/master@{#28094}
2015-04-28 08:31:24 +00:00
bmeurer
4486c47d9b
[clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations.
...
Currently only the Win64 bots report this warnings, which adds quite
some overhead to the development process. With this flag we also get
compiler warnings about implicit 64bit to 32bit truncations when
building with clang on Linux/x64 and Mac/x64.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/1111733002
Cr-Commit-Position: refs/heads/master@{#28093}
2015-04-28 06:53:41 +00:00
bmeurer
ef15f83bc3
[turbofan] Better fix for Win64 after r28066.
...
TBR=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/1107253003
Cr-Commit-Position: refs/heads/master@{#28092}
2015-04-28 05:09:01 +00:00
v8-autoroll
2613b7fb63
Update V8 DEPS.
...
Rolling v8/tools/clang to 5df4027be48d44a72ef035978746aac46184720e
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1105343002
Cr-Commit-Position: refs/heads/master@{#28091}
2015-04-28 03:27:32 +00:00
chunyang.dai
e31f5ec7eb
Disable two test cases for turbofan unsupported platform.
...
These two test cases "InlineCreateArrayLiteral" and "InlineCreateObjectLiteral" are
added in d1597b7d22
. They invokes Linkage::GetStubCallDescriptor
which is unimplemented for turbofan unsupported platform.
BUG=
Review URL: https://codereview.chromium.org/1095793007
Cr-Commit-Position: refs/heads/master@{#28090}
2015-04-27 17:02:27 +00:00
mbrandy
63d14580d8
PPC: Don't MISS if you read the hole from certain FastHoley arrays.
...
Port caeb9004f0
Original commit message:
If the array's map is the initial FastHoley array map, and the array prototype
chain is undisturbed and empty of elements, then keyed loads can convert the
load of a hole to undefined.
BUG=
R=dstence@us.ibm.com , michael_dawson@ca.ibm.com
Review URL: https://codereview.chromium.org/1110623002
Cr-Commit-Position: refs/heads/master@{#28089}
2015-04-27 17:01:17 +00:00
machenbach
3f27bb2188
Revert of Make it possible to hoist the neutering check for TA property accesses (patchset #1 id:1 of https://codereview.chromium.org/1107993002/ )
...
Reason for revert:
[Sheriff] Breaks benchmarks:
http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/3403
Original issue's description:
> Make it possible to hoist the neutering check for TA property accesses
>
> Also correctly set up the dependency between propoerty and elements
> accesses and the checks
>
> BUG=v8:3996
> R=hpayer@chromium.org
> LOG=n
>
> Committed: https://crrev.com/6a62e321381e1a212983804c4197068e842b240f
> Cr-Commit-Position: refs/heads/master@{#28087}
TBR=hpayer@chromium.org ,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996
Review URL: https://codereview.chromium.org/1108823003
Cr-Commit-Position: refs/heads/master@{#28088}
2015-04-27 16:56:08 +00:00
jochen
6a62e32138
Make it possible to hoist the neutering check for TA property accesses
...
Also correctly set up the dependency between propoerty and elements
accesses and the checks
BUG=v8:3996
R=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1107993002
Cr-Commit-Position: refs/heads/master@{#28087}
2015-04-27 16:17:51 +00:00
dslomov
919c54910f
Revert of Preprocess structured stack trace on GC to get rid of code reference. (patchset #5 id:80001 of https://codereview.chromium.org/1103843002/ )
...
Reason for revert:
Broke GCStress
Original issue's description:
> Preprocess structured stack trace on GC to get rid of code reference.
>
> R=verwaest@chromium.org
> BUG=v8:2340
> LOG=N
>
> Committed: https://crrev.com/462ffa1dfa0ab3a851ea0294470d1ed7ed12dd56
> Cr-Commit-Position: refs/heads/master@{#28085}
TBR=verwaest@chromium.org ,ulan@chromium.org,hpayer@chromium.org,yurys@chromium.org,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:2340
Review URL: https://codereview.chromium.org/1102383002
Cr-Commit-Position: refs/heads/master@{#28086}
2015-04-27 15:53:23 +00:00
yangguo
462ffa1dfa
Preprocess structured stack trace on GC to get rid of code reference.
...
R=verwaest@chromium.org
BUG=v8:2340
LOG=N
Review URL: https://codereview.chromium.org/1103843002
Cr-Commit-Position: refs/heads/master@{#28085}
2015-04-27 14:50:39 +00:00
dslomov
671ac25cf9
Use ExpressionClassifier for bindings.
...
Just a refactoring, real pattern parsing comes in a later CL.
R=rossberg@chromium.org ,marja@chromium.org
BUG=v8:811
LOG=N
Review URL: https://codereview.chromium.org/1066933005
Cr-Commit-Position: refs/heads/master@{#28084}
2015-04-27 14:35:18 +00:00
titzer
44350b3d49
Remove kOsrCompileFailed bailout.
...
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1105133002
Cr-Commit-Position: refs/heads/master@{#28083}
2015-04-27 14:24:28 +00:00
erikcorry
da66e720a3
Do more to avoid last-resort stop-the-world GC
...
BUG=chromium:481433
R=hpayer@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/1104113002
Cr-Commit-Position: refs/heads/master@{#28082}
2015-04-27 14:10:05 +00:00
dcarney
1d2be2af40
Reland: track global accesses to constant types
...
R=verwaest@chromium.org
BUG=468620
LOG=N
Review URL: https://codereview.chromium.org/1102543002
Cr-Commit-Position: refs/heads/master@{#28081}
2015-04-27 14:00:51 +00:00
ssid
0be81a43ea
Changing Size to SizeOfObjects in GetHeapSpaceStatistics api.
...
This CL changes GetHeapSpaceStatistics api to return SizeOfObjects()
instead of Size(). SizeOfObjects is the required field and is
consistent with GetHeapStatistics api.
BUG=476013
LOG=N
Review URL: https://codereview.chromium.org/1095393005
Cr-Commit-Position: refs/heads/master@{#28080}
2015-04-27 14:00:04 +00:00
machenbach
c5797f859a
Revert of deprecate non-phantom weak callbacks (patchset #1 id:1 of https://codereview.chromium.org/1103173002/ )
...
Reason for revert:
[Sheriff] Fails compilation on chromium android:
http://build.chromium.org/p/client.v8/builders/Android%20Builder/builds/4131
Is the chromium version our builder used maybe too old (it uses lkcr)? In that case please reland as soon as it's up-to-date.
Original issue's description:
> deprecate non-phantom weak callbacks
>
> BUG=
>
> Committed: https://crrev.com/39c31da2142ab0fca9dae279b9e59cd4951a1982
> Cr-Commit-Position: refs/heads/master@{#28077}
TBR=jochen@chromium.org ,dcarney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1104163002
Cr-Commit-Position: refs/heads/master@{#28079}
2015-04-27 13:30:19 +00:00
machenbach
db1674c532
Reland [test] Make msan work for v8 stand-alone. (patchset #1 id:1 of https://codereview.chromium.org/1104073002/ )
...
Reason for revert:
Reland after switching bot to ninja.
Original issue's description:
> Revert of [test] Make msan work for v8 stand-alone. (patchset #6 id:100001 of https://codereview.chromium.org/802583003/ )
>
> Reason for revert:
> Compile failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2047
>
> Original issue's description:
> > [test] Make msan work for v8 stand-alone.
> >
> > The msan configuration can be used in combination with
> > v8_use_snapshot=false.
> >
> > BUG=chromium:425187
> > LOG=n
> >
> > Committed: https://crrev.com/a65ef0d53fc28b0908f228938c6d84effa83c596
> > Cr-Commit-Position: refs/heads/master@{#28064}
>
> TBR=jochen@chromium.org ,earthdok@chromium.org,svenpanne@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:425187
>
> Committed: https://crrev.com/f69a48696ec3ec0ea1169a41b4c84fb36b059968
> Cr-Commit-Position: refs/heads/master@{#28068}
TBR=jochen@chromium.org ,earthdok@chromium.org,svenpanne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:425187
Review URL: https://codereview.chromium.org/1102323002
Cr-Commit-Position: refs/heads/master@{#28078}
2015-04-27 13:19:45 +00:00
dcarney
39c31da214
deprecate non-phantom weak callbacks
...
BUG=
Review URL: https://codereview.chromium.org/1103173002
Cr-Commit-Position: refs/heads/master@{#28077}
2015-04-27 13:06:18 +00:00
jkummerow
f6187fb3b5
Reland "Lazily register prototype users..."
...
...when handing out validity cells to handlers; because invalidating said cells is
the only time we'll need the user registrations.
Along the way, fix a corner case in WeakFixedArray, which can now be empty after
the recently introduced compaction support.
This reverts commit 968715c653
.
Original review: https://codereview.chromium.org/1104813004/
Review URL: https://codereview.chromium.org/1110513002
Cr-Commit-Position: refs/heads/master@{#28076}
2015-04-27 12:59:36 +00:00
dcarney
232b09825c
[turbofan] make register hinting explicit
...
- instead of committing operands early to resolve hints, hold the hint register data on the UsePosition
- allow hints to be rolled back efficiently as needed by GreedyAllocator
- some small drive by fixes
BUG=
Review URL: https://codereview.chromium.org/1103533002
Cr-Commit-Position: refs/heads/master@{#28075}
2015-04-27 12:46:24 +00:00
yangguo
77e37028c6
Wrap messages implementation in a function.
...
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/1106633002
Cr-Commit-Position: refs/heads/master@{#28074}
2015-04-27 12:33:34 +00:00
titzer
6e82fbfbaf
[turbofan] Reland: Optimize loads from the global object in JSTypeFeedbackSpecializer.
...
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1110503002
Cr-Commit-Position: refs/heads/master@{#28073}
2015-04-27 12:15:06 +00:00
wingo
9510a9c3ef
Eagerly declare eval scopes, even for sloppy scopes
...
R=mstarzinger@chromium.org
LOG=N
BUG=N
Review URL: https://codereview.chromium.org/1110473003
Cr-Commit-Position: refs/heads/master@{#28072}
2015-04-27 12:13:19 +00:00
yangguo
10b979e6aa
Debugger: clean up debug events.
...
The debug event BreakForCommand is now deprecated, as it cannot happen any longer.
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/1089893002
Cr-Commit-Position: refs/heads/master@{#28071}
2015-04-27 12:10:00 +00:00
hablich
8d8b742b9d
[release-tools] Return no hash if version is not available.
...
BUG=
Review URL: https://codereview.chromium.org/1105023002
Cr-Commit-Position: refs/heads/master@{#28070}
2015-04-27 11:32:05 +00:00
titzer
da1f8d6399
Disable test-run-jsexceptions for nosnap builds.
...
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1105043002
Cr-Commit-Position: refs/heads/master@{#28069}
2015-04-27 11:18:14 +00:00
machenbach
f69a48696e
Revert of [test] Make msan work for v8 stand-alone. (patchset #6 id:100001 of https://codereview.chromium.org/802583003/ )
...
Reason for revert:
Compile failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2047
Original issue's description:
> [test] Make msan work for v8 stand-alone.
>
> The msan configuration can be used in combination with
> v8_use_snapshot=false.
>
> BUG=chromium:425187
> LOG=n
>
> Committed: https://crrev.com/a65ef0d53fc28b0908f228938c6d84effa83c596
> Cr-Commit-Position: refs/heads/master@{#28064}
TBR=jochen@chromium.org ,earthdok@chromium.org,svenpanne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:425187
Review URL: https://codereview.chromium.org/1104073002
Cr-Commit-Position: refs/heads/master@{#28068}
2015-04-27 11:14:10 +00:00
Benedikt Meurer
8cb46cf02a
[turbofan] Fix win64 after r28066.
...
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1106963002
Cr-Commit-Position: refs/heads/master@{#28067}
2015-04-27 11:04:30 +00:00
Benedikt Meurer
2d827809e0
[turbofan] Add language mode to JSCallFunction operator.
...
Also do some drive-by-cleanup to the unittests.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/1107883002
Cr-Commit-Position: refs/heads/master@{#28066}
2015-04-27 10:44:30 +00:00
verwaest
a4b7d45c7b
Handlify ExecutableAccessorInfo::ClearSetter since it allocates.
...
BUG=chromium:478556
LOG=n
Review URL: https://codereview.chromium.org/1107853002
Cr-Commit-Position: refs/heads/master@{#28065}
2015-04-27 10:18:30 +00:00
machenbach
a65ef0d53f
[test] Make msan work for v8 stand-alone.
...
The msan configuration can be used in combination with
v8_use_snapshot=false.
BUG=chromium:425187
LOG=n
Review URL: https://codereview.chromium.org/802583003
Cr-Commit-Position: refs/heads/master@{#28064}
2015-04-27 10:13:58 +00:00
machenbach
fbf300802f
Revert of [turbofan] Optimize loads from the global object in JSTypeFeedbackSpecializer. (patchset #10 id:180001 of https://codereview.chromium.org/1063513003/ )
...
Reason for revert:
[sheriff] Breaks nosnap debug:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%201/builds/156
Original issue's description:
> [turbofan] Optimize loads from the global object in JSTypeFeedbackSpecializer.
>
> Uses lazy deoptimization and code dependencies to introduce loads
> from property cells and also to promote globals to constants.
>
> R=mstarzinger@chromium.org
> BUG=
>
> Committed: https://crrev.com/aae4a62d07e839455b1d0ad4fa512cc5d48a1a68
> Cr-Commit-Position: refs/heads/master@{#28057}
TBR=mstarzinger@chromium.org ,titzer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1084533003
Cr-Commit-Position: refs/heads/master@{#28063}
2015-04-27 10:07:08 +00:00
mstarzinger
d6e99a7f52
[turbofan] Introduce explicit JSCreateLiteral[Array|Object].
...
This uses explicit operators instead of intrinsic runtime calls to
create literals froms boilerplates. It allows for easier access of
static parameters and syncs it with other allocating operators.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/1104453006
Cr-Commit-Position: refs/heads/master@{#28062}
2015-04-27 09:57:22 +00:00
Benedikt Meurer
ecf499ef8e
[turbofan] Sanitize language mode for JSStoreProperty operator.
...
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/1109733002
Cr-Commit-Position: refs/heads/master@{#28061}
2015-04-27 09:33:38 +00:00
jochen
3383f6280e
Reland "Remove the weak list of views from array buffers"
...
Original description:
> Instead, views have to check their array buffer for whether
> it's neutered or not.
>
> BUG=v8:3996
> R=hpayer@chromium.org ,dslomov@chromium.org,verwaest@chromium.org
> LOG=n
BUG=v8:3996
R=hpayer@chromium.org ,dslomov@chromium.org,verwaest@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1107843002
Cr-Commit-Position: refs/heads/master@{#28060}
2015-04-27 09:27:53 +00:00
Benedikt Meurer
f13f949361
[turbofan] Sanitize language mode for javascript operators.
...
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/1084243005
Cr-Commit-Position: refs/heads/master@{#28059}
2015-04-27 09:12:43 +00:00
mstarzinger
a38f9dddd1
[turbofan] Use FastNewClosureStub if possible.
...
This introduces a JSCreateClosure operator which can be lowered by the
typed pipeline to the aforementioned stub. It also allows for further
optimizations of closure creation.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/1105513002
Cr-Commit-Position: refs/heads/master@{#28058}
2015-04-27 09:07:57 +00:00
titzer
aae4a62d07
[turbofan] Optimize loads from the global object in JSTypeFeedbackSpecializer.
...
Uses lazy deoptimization and code dependencies to introduce loads
from property cells and also to promote globals to constants.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1063513003
Cr-Commit-Position: refs/heads/master@{#28057}
2015-04-27 09:06:41 +00:00
mvstanton
caeb9004f0
Don't MISS if you read the hole from certain FastHoley arrays.
...
If the array's map is the initial FastHoley array map, and the array prototype
chain is undisturbed and empty of elements, then keyed loads can convert the
load of a hole to undefined.
BUG=
Review URL: https://codereview.chromium.org/1100083002
Cr-Commit-Position: refs/heads/master@{#28056}
2015-04-27 08:46:38 +00:00
jarin
ae0bc41635
Fix stack layout of full code arm64 for object literal.
...
BUG=
Review URL: https://codereview.chromium.org/1095203005
Cr-Commit-Position: refs/heads/master@{#28055}
2015-04-27 08:31:33 +00:00
mstarzinger
e81ee90018
[test] Limit "unittests" suite to default variant.
...
This changes the unittests suite to be run in only the default variant,
because unit tests are (and should be) written to be independent from
global flags.
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1067863007
Cr-Commit-Position: refs/heads/master@{#28054}
2015-04-27 08:19:55 +00:00