franziska.hinkelmann
8ed0454332
Emit better error message about writable properties
...
Section 8.10.5 9a specifies that a property descriptor cannot both have
accessors and specify the writability of the property. The previous
error message was misleading because it referred to writable rather
than specifying the writability (which includes writable: false).
BUG=v8:2536
LOG=N
Review URL: https://codereview.chromium.org/1399693003
Cr-Commit-Position: refs/heads/master@{#31273}
2015-10-14 19:22:27 +00:00
cbruni
3ac2973b29
Improving error messages when adding properties to non JSObject receiver in
...
strict mode.
LOG=N
BUG=chromium:423739
Review URL: https://codereview.chromium.org/1381083004
Cr-Commit-Position: refs/heads/master@{#31192}
2015-10-09 09:12:47 +00:00
bmeurer
7a7b692b30
[runtime] Replace %to_string_fun with %_ToString.
...
Introduce a new macro TO_STRING that maps to %_ToString and use that
instead of calling into any of the ToString/NonStringToString JavaScript
builtins. Also remove the TO_STRING_INLINE macro, which is basically
obsolete with %_ToString. We still have a few uses of ToString left (via
the utils export mechanism), where we need to investigate whether we
will tank badly if we replace them with TO_STRING as well.
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg
R=yangguo@chromium.org
BUG=v8:4307
LOG=n
Review URL: https://codereview.chromium.org/1323543002
Cr-Commit-Position: refs/heads/master@{#30895}
2015-09-23 21:46:49 +00:00
bbudge
bfde458271
Optimize ToString and NonStringToString.
...
Moves some uncommon type checking from ToString and
NonStringToString into DefaultString. This should
speed up string operations.
LOG=N
BUG=none
Review URL: https://codereview.chromium.org/1256323004
Cr-Commit-Position: refs/heads/master@{#29913}
2015-07-30 08:21:55 +00:00
bbudge
5d8c105428
SIMD.js: Update Float32x4 and tests to current spec.
...
LOG=N
BUG=v8:4124
Review URL: https://codereview.chromium.org/1239423004
Cr-Commit-Position: refs/heads/master@{#29781}
2015-07-22 03:14:06 +00:00
bbudge
6113058427
Expose SIMD.Float32x4 type to Javascript.
...
This CL exposes the constructor function, defines type related
information, and implements value type semantics.
It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero.
TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc
LOG=Y
BUG=v8:4124
Committed: https://crrev.com/e5ed3bee99807c502fa7d7a367ec401e16d3f773
Cr-Commit-Position: refs/heads/master@{#29689}
Review URL: https://codereview.chromium.org/1219943002
Cr-Commit-Position: refs/heads/master@{#29712}
2015-07-16 19:43:32 +00:00
hablich
40c38c5a5a
Revert of Expose SIMD.Float32x4 type to Javascript. (patchset #14 id:450001 of https://codereview.chromium.org/1219943002/ )
...
Reason for revert:
Seems to brake the latest roll into Chromium: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/59796/steps/compile%20%28with%20patch%29/logs/stdio
Original issue's description:
> Expose SIMD.Float32x4 type to Javascript.
> This CL exposes the constructor function, defines type related
> information, and implements value type semantics.
> It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero.
>
> TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc
>
> LOG=Y
> BUG=v8:4124
>
> Committed: https://crrev.com/e5ed3bee99807c502fa7d7a367ec401e16d3f773
> Cr-Commit-Position: refs/heads/master@{#29689}
TBR=rossberg@chromium.org ,littledan@chromium.org,martyn.capewell@arm.com,bbudge@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4124
Review URL: https://codereview.chromium.org/1241533004
Cr-Commit-Position: refs/heads/master@{#29701}
2015-07-16 12:36:11 +00:00
bbudge
e5ed3bee99
Expose SIMD.Float32x4 type to Javascript.
...
This CL exposes the constructor function, defines type related
information, and implements value type semantics.
It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero.
TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc
LOG=Y
BUG=v8:4124
Review URL: https://codereview.chromium.org/1219943002
Cr-Commit-Position: refs/heads/master@{#29689}
2015-07-15 19:17:06 +00:00
verwaest
d5335cba31
Avoid converting key to string for deleting of elements
...
Additionally rips out (now) unnecessary duplicate code in DefineArrayProperty.
BUG=
Review URL: https://codereview.chromium.org/1224523002
Cr-Commit-Position: refs/heads/master@{#29450}
2015-07-02 15:27:28 +00:00
yangguo
f3f0b2724b
Migrate error messages, part 11.
...
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/1140053002
Cr-Commit-Position: refs/heads/master@{#28423}
2015-05-15 13:32:26 +00:00
yangguo
0bbe787448
Migrate error messages, part 10.
...
R=mvstanton@chromium.org
Committed: https://crrev.com/8608e619afe2b4514b0577bfb73a153b1550d41f
Cr-Commit-Position: refs/heads/master@{#28357}
Review URL: https://codereview.chromium.org/1126043004
Cr-Commit-Position: refs/heads/master@{#28366}
2015-05-12 13:52:23 +00:00
yangguo
26cb29b891
Revert of Migrate error messages, part 10. (patchset #2 id:20001 of https://codereview.chromium.org/1126043004/ )
...
Reason for revert:
patch didn't apply correctly.
Original issue's description:
> Migrate error messages, part 10.
>
> R=mvstanton@chromium.org
>
> Committed: https://crrev.com/8608e619afe2b4514b0577bfb73a153b1550d41f
> Cr-Commit-Position: refs/heads/master@{#28357}
TBR=mvstanton@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1130073005
Cr-Commit-Position: refs/heads/master@{#28358}
2015-05-12 08:33:28 +00:00
yangguo
8608e619af
Migrate error messages, part 10.
...
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/1126043004
Cr-Commit-Position: refs/heads/master@{#28357}
2015-05-12 08:16:57 +00:00
yangguo
f8db4327ad
Migrate error messages, part 9.
...
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/1130783002
Cr-Commit-Position: refs/heads/master@{#28291}
2015-05-07 10:00:23 +00:00
yangguo
a5de69f4f8
Migrate error messages, part 8.
...
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/1118273004
Cr-Commit-Position: refs/heads/master@{#28250}
2015-05-06 07:52:05 +00:00
yangguo
a3ddb1bc42
Migrate error messages, part 7.
...
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/1122033002
Cr-Commit-Position: refs/heads/master@{#28216}
2015-05-05 07:57:36 +00:00
yangguo
ac50edfee0
Migrate error messages, part 6. (string.js and date.js)
...
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/1116953002
Cr-Commit-Position: refs/heads/master@{#28180}
2015-04-30 16:22:05 +00:00
yangguo
cadf96da90
Migrate error messages, part 5 (array.js and i18n.js).
...
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/1096243003
Cr-Commit-Position: refs/heads/master@{#28040}
2015-04-24 10:21:43 +00:00
machenbach
6911943e0b
Revert of Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #1 id:1 of https://codereview.chromium.org/1103473003/ )
...
Reason for revert:
This was probably an infrastructure problem caused by the mac ninja/goma switch.
Original issue's description:
> Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #7 id:140001 of https://codereview.chromium.org/1011823003/ )
>
> Reason for revert:
> [Sheriff] breaks mac gc stress:
> http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1029
>
> Original issue's description:
> > [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions)
> >
> > BUG=v8:3965, v8:3966
> > R=arv@chromium.org
> > LOG=N
> >
> > Committed: https://crrev.com/b09c048f693d280052ac63c7d6b3baf27b3bf271
> > Cr-Commit-Position: refs/heads/master@{#27985}
>
> TBR=arv@chromium.org ,caitpotter88@gmail.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:3965, v8:3966
TBR=arv@chromium.org ,caitpotter88@gmail.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3965, v8:3966
Review URL: https://codereview.chromium.org/1098243002
Cr-Commit-Position: refs/heads/master@{#27999}
2015-04-22 10:33:33 +00:00
machenbach
2b97a0e3bc
Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #7 id:140001 of https://codereview.chromium.org/1011823003/ )
...
Reason for revert:
[Sheriff] breaks mac gc stress:
http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1029
Original issue's description:
> [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions)
>
> BUG=v8:3965, v8:3966
> R=arv@chromium.org
> LOG=N
>
> Committed: https://crrev.com/b09c048f693d280052ac63c7d6b3baf27b3bf271
> Cr-Commit-Position: refs/heads/master@{#27985}
TBR=arv@chromium.org ,caitpotter88@gmail.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3965, v8:3966
Review URL: https://codereview.chromium.org/1103473003
Cr-Commit-Position: refs/heads/master@{#27990}
2015-04-22 07:57:49 +00:00
caitpotter88
b09c048f69
[es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions)
...
BUG=v8:3965, v8:3966
R=arv@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/1011823003
Cr-Commit-Position: refs/heads/master@{#27985}
2015-04-21 21:45:57 +00:00
yangguo
9b2fe70d93
Migrate error messages, part 4 (v8natives.js).
...
Goal is to reduce native context size.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/1099573002
Cr-Commit-Position: refs/heads/master@{#27953}
2015-04-21 09:03:09 +00:00
yangguo
5a9a0b20e7
Migrate error messages, part 3 (runtime.js).
...
Motivation for this is reducing the size of the native context.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/1089303003
Cr-Commit-Position: refs/heads/master@{#27917}
2015-04-17 13:27:28 +00:00
yangguo
ae2057e81a
Reland "Migrate error messages, part 2."
...
Review URL: https://codereview.chromium.org/1083083004
Cr-Commit-Position: refs/heads/master@{#27907}
2015-04-17 08:35:47 +00:00
machenbach
d881baaced
Revert of Migrate error messages, part 2. (patchset #1 id:1 of https://codereview.chromium.org/1086313003/ )
...
Reason for revert:
[Sheriff]: This changes layout test expectations e.g.
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Win/builds/2964
Original issue's description:
> Migrate error messages, part 2.
>
> Motivation for this is reducing the size of the native context.
>
> Committed: https://crrev.com/d3b788df0a4ccfedbe6e1df5e214cb6ba2792a65
> Cr-Commit-Position: refs/heads/master@{#27878}
TBR=mvstanton@chromium.org ,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1095573002
Cr-Commit-Position: refs/heads/master@{#27889}
2015-04-16 14:33:26 +00:00
yangguo
d3b788df0a
Migrate error messages, part 2.
...
Motivation for this is reducing the size of the native context.
Review URL: https://codereview.chromium.org/1086313003
Cr-Commit-Position: refs/heads/master@{#27878}
2015-04-16 11:34:47 +00:00