erikcorry
dc6907b3ed
Revert of Only record one in n line endings to save space. (patchset #4 id:60001 of https://codereview.chromium.org/1137683003/ )
...
Reason for revert:
Test failures https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/345/layout-test-results/results.html
Original issue's description:
> Only record one in n line endings to save space.
>
> R=yangguo@chromium.org
> BUG=
>
> Committed: https://crrev.com/b3d4bce593559276e68d3d7d9168f4351e4e5090
> Cr-Commit-Position: refs/heads/master@{#28837}
TBR=yangguo@chromium.org ,erik.corry@gmail.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1155683010
Cr-Commit-Position: refs/heads/master@{#28841}
2015-06-08 14:24:42 +00:00
erikcorry
b3d4bce593
Only record one in n line endings to save space.
...
R=yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1137683003
Cr-Commit-Position: refs/heads/master@{#28837}
2015-06-08 12:01:02 +00:00
kozyatinskiy
aca928b7ad
Reland [V8] Removed SourceLocationRestrict
...
This method uses in messages.js in GetSourceLine and GetPositionInLine. This methods uses in v8::Message API methods and there is no documentation about it.
Method looks obsolete.
One of the strange side effect is shown by attached issue.
BUG=chromium:468781
TBR=yangguo@chromium.org
LOG=Y
Review URL: https://codereview.chromium.org/1033973002
Cr-Commit-Position: refs/heads/master@{#27458}
2015-03-25 23:11:12 +00:00
machenbach
310d75218e
Revert of [V8] Removed SourceLocationRestrict (patchset #3 id:40001 of https://codereview.chromium.org/1022333004/ )
...
Reason for revert:
[Sheriff] This seems to change layout test expectations of some tests, e.g.:
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2317
Expectation example:
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64__dbg_/2317/layout-test-results/fast/events/window-onerror-11-pretty-diff.html
Please add a needsmanualrebaseline expectation to the tests affected by this change on the blink side first before relanding.
Original issue's description:
> [V8] Removed SourceLocationRestrict
>
> This method uses in messages.js in GetSourceLine and GetPositionInLine. This methods uses in v8::Message API methods and there is no documentation about it.
> Method looks obsolete.
> One of the strange side effect is shown by attached issue.
>
> BUG=chromium:468781
> R=yangguo@chromium.org
> LOG=Y
>
> Committed: https://crrev.com/b563ceac0f95551a128a1403cdbacc7aefcdabaf
> Cr-Commit-Position: refs/heads/master@{#27374}
TBR=yangguo@chromium.org ,kozyatinskiy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:468781
Review URL: https://codereview.chromium.org/1028413002
Cr-Commit-Position: refs/heads/master@{#27398}
2015-03-24 12:04:43 +00:00
kozyatinskiy
b563ceac0f
[V8] Removed SourceLocationRestrict
...
This method uses in messages.js in GetSourceLine and GetPositionInLine. This methods uses in v8::Message API methods and there is no documentation about it.
Method looks obsolete.
One of the strange side effect is shown by attached issue.
BUG=chromium:468781
R=yangguo@chromium.org
LOG=Y
Review URL: https://codereview.chromium.org/1022333004
Cr-Commit-Position: refs/heads/master@{#27374}
2015-03-23 16:33:19 +00:00
kozyatinskiy
ed8394f1e3
[V8] Added debug-sourceinfo.js with LF endings back
...
Readded after https://codereview.chromium.org/1029063002/ with correct line endings.
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/1032443002
Cr-Commit-Position: refs/heads/master@{#27370}
2015-03-23 14:51:03 +00:00
kozyatinskiy
ec9f0a5307
[V8] Removed debug-sourceinfo.js with CRLF line endings
...
We can't simple delete and add one file in one CL. This is necessary for replacing this test with version with LF line endings.
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/1029063002
Cr-Commit-Position: refs/heads/master@{#27368}
2015-03-23 14:31:40 +00:00
ager@chromium.org
e3fa53edef
Make sure that message reporting works when the builtin string and
...
array functions are overwritten.
Review URL: http://codereview.chromium.org/147142
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2269 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-06-25 10:27:36 +00:00
sgjesse@chromium.org
dc9670bcb4
Change locationFromPosition() and locationFromLine() to use a binary search to locate line numbers from position numbers. Modify test debug-sourceinfo.js to include more tests, including error conditions.
...
Patch by Matt Hanselman, see http://codereview.chromium.org/118371 .
BUG=213
TEST=test/mjsunit/debug-sourceinfo.js
Review URL: http://codereview.chromium.org/118425
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2125 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-06-09 07:03:21 +00:00
sgjesse@chromium.org
994ea00dfe
Changed a function in the internal debugger JavaScript to return the full source location instead of only the position.
...
Added an optional parameter to exclude/include the source line offset in source location.
Extended a message test to include a test with source offset.
Review URL: http://codereview.chromium.org/39342
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1461 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2009-03-09 17:59:25 +00:00
christian.plesner.hansen@gmail.com
089da79517
Quick fix for mjsunit/debug-sourceinfo failure
...
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@243 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-09-09 20:20:35 +00:00
christian.plesner.hansen@gmail.com
9bed566bdb
Changed copyright header from google inc. to v8 project authors.
...
Added presubmit step to check copyright.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-09-09 20:08:45 +00:00
mads.s.ager@gmail.com
6bda17f12b
Make test.py executable.
...
Changed eol-style on debug-sourceinfo.js since the test expects CRLF
endings.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@27 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-08-28 10:50:31 +00:00
christian.plesner.hansen
c42f5829a1
Included mjsunit JavaScript test suite and C++ unit tests.
...
In the shell sample don't print the result of executing a script, only
evaluating expressions.
Fixed issue when building samples on Windows using a shared V8
library. Added visibility option on Linux build which makes the
generated library 18% smaller.
Changed build system to accept multiple build modes in one build and
generate seperate objects, libraries and executables for each mode.
Removed deferred negation optimization (a * -b => -(a * b)) since this
visibly changes operand conversion order.
Improved parsing performance by introducing stack guard in preparsing.
Without a stack guard preparsing always bails out with stack overflow.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2008-08-22 13:33:59 +00:00