AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
20,247 Commits 1 Branch 0 Tags 839 MiB
e51e86f459
Commit Graph

108 Commits

Author SHA1 Message Date
jarin
4de4f74cf2 Avoid number range holes in bitset types. 
BUG=

Review URL: https://codereview.chromium.org/759013003

Cr-Commit-Position: refs/heads/master@{#25754}
 2014-12-10 16:39:10 +00:00
Jaroslav Sevcik
2d075e2298 Reland "[turbofan] Weakening of types must weaken ranges inside unions." 
This relands commit 4c1f4b796d.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/723023002

Cr-Commit-Position: refs/heads/master@{#25317}
 2014-11-13 09:02:14 +00:00
Jaroslav Sevcik
c513297f9f Revert "[turbofan] Weakening of types must weaken ranges inside unions." 
This reverts commit 4c1f4b796d.

TBR=rossberg@chromium.org

Review URL: https://codereview.chromium.org/722943003

Cr-Commit-Position: refs/heads/master@{#25312}
 2014-11-13 06:10:42 +00:00
Jaroslav Sevcik
4c1f4b796d [turbofan] Weakening of types must weaken ranges inside unions. 
BUG=
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/712623002

Cr-Commit-Position: refs/heads/master@{#25311}
 2014-11-13 05:31:47 +00:00
rossberg@chromium.org
0e16150d33 Better typing and type verification 
- Extend verifier to check types of JS and Simplified nodes.
- Untyped nodes now contain NULL as types, enforcing hard failure.
- Typer immediately installs itself as a decorator; remove explicit decorator installation.
- Decorator eagerly types all nodes that have typed inputs
  (subsumes typing of constant cache, removing its typing
  side-channel and various spurious dependencies on the typer).
- Cut down typer interface to prevent inconsistently typed graphs.
- Remove verification from start, since it caused too much trouble
  with semi-wellformed nodes.
- Fix a couple of bugs on the way that got uncovered.

To do: verifying machine operators. Also, various conditions in the
verifier are currently commented out, because they don't yet hold.

BUG=
R=jarin@chromium.org,titzer@chromium.org

Review URL: https://codereview.chromium.org/658543002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24626 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-15 11:38:04 +00:00
neis@chromium.org
93d0e79d6e Again reland "Refine expression typing, esp. by propagating range information." 
This relands commit 24552.

TBR=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/650513003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24615 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-15 08:21:46 +00:00
bmeurer@chromium.org
f574d93e51 Revert "Reland "Refine expression typing, esp. by propagating range information."" 
This reverts commit r24609 for breaking the
cctest/test-js-typed-lowering/Int32BitwiseBinops test.

TBR=rossberg@chromium.org,neis@chromium.org

Review URL: https://codereview.chromium.org/656003002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24614 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-15 03:50:13 +00:00
neis@chromium.org
a7eb593147 Reland "Refine expression typing, esp. by propagating range information." 
This relands commit 24552.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/653693002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24609 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-10-14 16:27:26 +00:00
neis@chromium.org
7045592947 Get rid of code duplication by computing int Lub using range Lub. 
R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/616563002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24320 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-30 10:34:54 +00:00
bmeurer@chromium.org
3eebdc3264 Replace OStream with std::ostream. 
Review URL: https://codereview.chromium.org/618643002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24319 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-30 10:29:32 +00:00
neis@chromium.org
bead5f6bb6 Add some tests about range types. 
Add missing tests for context types.
Rearrange some other tests.
Make printing of constant types more useful.
Give counter-examples for properties that no longer hold.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/602613002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24212 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-25 08:31:23 +00:00
neis@chromium.org
55ac3a3459 Move union length computation out of loops. 
R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/600713003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-25 08:02:12 +00:00
neis@chromium.org
6fd04d829e Redesign of the internal type system. 
Besides addressing a fundamental flaw, this significantly simplifies
several aspects of the system.  The downside is a loss of precision
and a loss of algebraic properties.

Range types are now fully implemented.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/558193003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24163 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-24 07:33:51 +00:00
rossberg@chromium.org
5d520f9ed1 Re-reland "Use unsigned type bitsets to limit undefined behaviour" 
Change: make bitset uint32_t, to avoid weird sign extension bugs on Win64.

BUG=
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/577563002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23978 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-16 12:58:43 +00:00
rossberg@chromium.org
2dbd871eb1 Re-revert "Use unsigned type bitsets to limit undefined behaviour" 
...and the various debug CLs.

R=machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/564413004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-15 15:49:24 +00:00
rossberg@chromium.org
21e0e00ae7 Reland "Use unsigned type bitsets to limit undefined behaviour" 
Temporary debug attempt; adds output to failing test in test-types.cc, otherwise unchanged.

Windows f

R=ulan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/567333002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23936 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-15 09:40:23 +00:00
ulan@chromium.org
c44a69d985 Revert r23916, r23917 for breaking 64-bit tests. 
"Use unsigned type bitsets to limit undefined behaviour".

TBR=rossberg@chromium.org

Review URL: https://codereview.chromium.org/563283003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23922 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-12 16:13:05 +00:00
rossberg@chromium.org
98dc857e2f Use unsigned type bitsets to limit undefined behaviour 
R=bmeurer@chromium.org, svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/555153003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23916 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-12 13:03:53 +00:00
yangguo@chromium.org
4e670fd05e Rename ascii to one-byte where applicable. 
R=dcarney@chromium.org, marja@chromium.org

Review URL: https://codereview.chromium.org/559913002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23840 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-09-10 12:38:12 +00:00
bmeurer@chromium.org
90c8932596 Replace our homegrown ARRAY_SIZE() with Chrome's arraysize(). 
Our own ARRAY_SIZE() was pretty bad at error checking. If you use
arrasize() in a wrong way, the compiler will issue an error instead of
silently doing the wrong thing. The previous ARRAY_SIZE() macro is still
available as ARRAYSIZE_UNSAFE() similar to Chrome.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/501323002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23389 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-26 09:19:24 +00:00
neis@chromium.org
c972e8e213 Extend some operations to range types. 
This is a reland of 22945, which failed to build on Windows due to
(some versions of?) Visual Studio lacking copysign().

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/448093002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22977 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-07 15:30:16 +00:00
neis@chromium.org
7692ec62dc Revert "Extend some operations to range types." 
This reverts commit 22945.  Turns out Visual Studio doesn't have copysign().

TBR=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/450473002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22946 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-06 17:43:55 +00:00
neis@chromium.org
86759140f0 Extend some operations to range types. 
This is a reland of 22934, which failed to build on Windows due to a missing include, and on ARM due to a name clash with some predefined constants.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/444023002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22945 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-06 17:23:47 +00:00
neis@chromium.org
19d07b2a9b Revert "Extend some operations to range types." 
This reverts 22934.

TBR=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/443123002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22936 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-06 14:09:21 +00:00
neis@chromium.org
a6ad240b91 Extend some operations to range types. 
R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/437393005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22934 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-06 13:51:38 +00:00
neis@chromium.org
a8729bdcf6 Fix a bug in type fuzzing and several handlification bugs elsewhere. 
R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/444883005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22926 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-06 12:41:37 +00:00
mstarzinger@chromium.org
df7057b3ce Add convenience method to print types for debugging. 
R=titzer@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/435403002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22908 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-06 09:26:49 +00:00
neis@chromium.org
63a170aaa7 Remove non-trivial subtyping between bitset and non-bitset types. 
R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/444503005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22903 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-06 08:28:01 +00:00
rossberg@chromium.org
cae6842a74 Undo some unintended changes from the Turbofan merge 
R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/435423002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22873 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-05 13:19:32 +00:00
neis@chromium.org
d04a2cbda5 Remove unnecesssary auxiliary definitions. 
R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/413983005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22860 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-05 11:27:26 +00:00
bmeurer@chromium.org
d07a2eb806 Rename ASSERT* to DCHECK*. 
This way we don't clash with the ASSERT* macros
defined by GoogleTest, and we are one step closer
to being able to replace our homegrown base/ with
base/ from Chrome.

R=jochen@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/430503007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-08-04 11:34:54 +00:00
danno@chromium.org
a1383e2250 Land the Fan (disabled) 
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/426233002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-07-30 13:54:45 +00:00
neis@chromium.org
61e1994f83 Minor clarifications and simplifications as well as additional checks. 
R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/417553003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22573 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-07-23 17:17:48 +00:00
neis@chromium.org
e999cf2857 Revert "Minor clarifications and simplifications as well as additional checks." 
This reverts commit d32eacbdea3fc0c119da06abe95b07a83c67aa48.

TBR=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/410083005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22569 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-07-23 15:39:08 +00:00
neis@chromium.org
6c67275fa0 Minor clarifications and simplifications as well as additional checks. 
R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/409743004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22568 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-07-23 15:30:34 +00:00
neis@chromium.org
6176dee6ea Add constructor for range types. 
R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/409543004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22535 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-07-22 17:33:22 +00:00
mstarzinger@chromium.org
2269da5287 Switch type of the-hole to be internal. 
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/381063002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22321 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-07-10 12:37:08 +00:00
svenpanne@chromium.org
d7934d1fbe Start using OStreams. 
Note that until everything is OStream-based, there are a few places
where we have to do some impedance matching. A few accessors had to be
const-corrected on the way.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/334763003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-07-03 07:18:30 +00:00
jochen@chromium.org
56a486c322 Use full include paths everywhere 
- this avoids using relative include paths which are forbidden by the style guide
- makes the code more readable since it's clear which header is meant
- allows for starting to use checkdeps

BUG=none
R=jkummerow@chromium.org, danno@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/304153016

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-06-03 08:12:43 +00:00
rossberg@chromium.org
7ac892c8bd Establish distributivity for type union & intersection 
This requires introducing proper bounds on all leaf types, so that intersection between bitsets and these types can be accurately represented. Extending a union also becomes more involved.

(On the upside, the modified union/intersect algorithm would now allow support for proper variance for function types.)

Not sure if it is worth landing this. Distributivity isn't really a crucial property for our use cases. It seems fine if intersection is slightly lossy.

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/251753005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21528 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-05-27 13:52:31 +00:00
rossberg@chromium.org
dbf7d8528c Various extensions to types 
R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/296213005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21494 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-05-26 13:10:52 +00:00
bmeurer@chromium.org
815781792d Treat FOREIGN_TYPE as internal. 
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/257523002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20920 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-04-24 07:16:10 +00:00
adamk@chromium.org
71750f7be8 Fix issue with Map/SetIterator and types 
BUG=v8:3281
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/246993003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20893 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-04-22 18:14:46 +00:00
bmeurer@chromium.org
779e87b87a Track up to 5 stable maps as field type. 
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/240813002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20831 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-04-17 08:22:22 +00:00
rossberg@chromium.org
926ec656de Implement structural function and array types 
Just wanted to add two constructors to a datatype, how ugly can it get?

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20809

Committed: https://code.google.com/p/v8/source/detail?r=20815

Review URL: https://codereview.chromium.org/228263005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20817 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-04-16 16:16:37 +00:00
rossberg@chromium.org
e3e81d85bb Revert "Implement structural function and array types" 
TBR=jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/237963016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20816 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-04-16 15:59:39 +00:00
rossberg@chromium.org
6782d9cea3 Implement structural function and array types 
Just wanted to add two constructors to a datatype, how ugly can it get?

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20809

Review URL: https://codereview.chromium.org/228263005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20815 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-04-16 15:42:22 +00:00
rossberg@chromium.org
a947aeb315 Revert "Implement structural function and array types" 
TBR=jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/240143003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20810 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-04-16 13:57:25 +00:00
rossberg@chromium.org
7de4c1c63f Implement structural function and array types 
Just wanted to add two constructors to a datatype, how ugly can it get?

R=bmeurer@chromium.org, jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/228263005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20809 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-04-16 13:44:26 +00:00
rossberg@chromium.org
7b7f787e3b Re-reland "More tests for Union & Intersect" 
R=jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/237143002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2014-04-14 15:35:36 +00:00