verwaest
2ea4f01f70
Introduce LookupIterator::PropertyOrElement which converts name to index if possible.
...
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/1178893002
Cr-Commit-Position: refs/heads/master@{#29004}
2015-06-12 16:30:18 +00:00
chunyang.dai
8c57b2e16d
X87: Disable the test case for X87 since ea2cb139d
.
...
The strong-object-set-proto test cases will throw one expected exception
and the exception message should include the source position in the JS
file. But crankshaft compiler does not generate the source position for
it when creating the flow graph by default. The source position information
is always zero. So it failed when comparing with the reference file.
If we use crankshaft compiler on IA32 platform to run this test case, it
has the same failure.
we will open these test case for x87 once turbofan for X87 is enabled.
BUG=
Review URL: https://codereview.chromium.org/1179763003
Cr-Commit-Position: refs/heads/master@{#29003}
2015-06-12 15:22:44 +00:00
verwaest
fa3e6c0850
Introduce DefineOwnPropertyIgnoreAttributes and make it call SetPropertyWithInterceptor.
...
Otherwise using Object.defineProperty with window.localStorage will not actually store the value into the database but on the object itself.
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/1180073002
Cr-Commit-Position: refs/heads/master@{#29002}
2015-06-12 14:14:12 +00:00
machenbach
6a10931820
[test] More debugging output in test runner.
...
Also use again the taskkill method, recently removed in
https://codereview.chromium.org/1156133006/
BUG=chromium:485932
LOG=n
TBR=jkummerow@chromium.org
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1177903005
Cr-Commit-Position: refs/heads/master@{#29001}
2015-06-12 13:43:57 +00:00
verwaest
a066202b17
Reland of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/ )
...
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/1180943002
Cr-Commit-Position: refs/heads/master@{#29000}
2015-06-12 12:39:44 +00:00
ishell
4cc4bc591c
Map::TryUpdate() must be in sync with Map::Update().
...
This CL fixes elements kind transitions handling in Map::TryUpdate().
BUG=v8:4121
LOG=Y
Review URL: https://codereview.chromium.org/1181163002
Cr-Commit-Position: refs/heads/master@{#28999}
2015-06-12 12:36:40 +00:00
wingo
103fcfaa40
Add script context with context-allocated "const this"
...
This is a reapplication of https://codereview.chromium.org/1173333004 .
R=rossberg@chromium.org
LOG=N
BUG=498811
Review URL: https://codereview.chromium.org/1178903003
Cr-Commit-Position: refs/heads/master@{#28998}
2015-06-12 12:34:24 +00:00
bmeurer
c487aba74c
[turbofan] Use appropriate type for NodeId.
...
Up until now we used int32_t for NodeId, but that was not ideal because
negative values are invalid for NodeId and we use it as an array index
for example in the NodeMarker class, where C++ compilers on x64 have to
generate code that does proper sign extension for the indices, which is
completely unnecessary.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/1178403004
Cr-Commit-Position: refs/heads/master@{#28997}
2015-06-12 12:03:19 +00:00
wingo
7063ed2de6
Revert of Add script context with context-allocated "const this" (patchset #2 id:20001 of https://codereview.chromium.org/1173333004/ )
...
Reason for revert:
nosnap failure
Original issue's description:
> Add script context with context-allocated "const this"
>
> This is a reapplication of https://codereview.chromium.org/1179893002/ .
>
> R=rossberg@chromium.org ,mstarzinger@chromium.org
> LOG=N
> BUG=498811
>
> Committed: https://crrev.com/cfc764f4050edc74aef92daa4c39ccc113893968
> Cr-Commit-Position: refs/heads/master@{#28994}
TBR=mstarzinger@chromium.org ,rossberg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=498811
Review URL: https://codereview.chromium.org/1177903004
Cr-Commit-Position: refs/heads/master@{#28996}
2015-06-12 11:53:11 +00:00
dusan.milosavljevic
a5b0a3e298
MIPS64: Fix memory allocation when code range is used for LO space only.
...
Allocation must respect requested reserve size, not requested commit area size.
Additionally fix check failures in debug mode for mips64.
After CL: https://codereview.chromium.org/1147503002/
memory for large code objects is allocated from code range,
memory for regular code objects is allocated normally.
TEST=cctest/test-spaces/MemoryChunk
BUG=
Review URL: https://codereview.chromium.org/1172333002
Cr-Commit-Position: refs/heads/master@{#28995}
2015-06-12 11:42:15 +00:00
wingo
cfc764f405
Add script context with context-allocated "const this"
...
This is a reapplication of https://codereview.chromium.org/1179893002/ .
R=rossberg@chromium.org ,mstarzinger@chromium.org
LOG=N
BUG=498811
Review URL: https://codereview.chromium.org/1173333004
Cr-Commit-Position: refs/heads/master@{#28994}
2015-06-12 11:11:28 +00:00
bmeurer
b5b00cc031
[turbofan] Move RawMachineAssembler to unittests.
...
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/1177353003
Cr-Commit-Position: refs/heads/master@{#28993}
2015-06-12 10:33:19 +00:00
machenbach
32e6455c1a
Revert of Add script context with context-allocated "const this" (patchset #7 id:120001 of https://codereview.chromium.org/1179893002/ )
...
Reason for revert:
[Sheriff] Breaks gc mole:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/2435
Original issue's description:
> Add script context with context-allocated "const this"
>
> R=rossberg@chromium.org
> LOG=N
> BUG=498811
>
> Committed: https://crrev.com/fa32d461c16a053cc6d48d3fb326016bc2765765
> Cr-Commit-Position: refs/heads/master@{#28988}
TBR=rossberg@chromium.org ,mstarzinger@chromium.org,wingo@igalia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=498811
Review URL: https://codereview.chromium.org/1180043004
Cr-Commit-Position: refs/heads/master@{#28992}
2015-06-12 10:07:34 +00:00
yangguo
74534bb8be
Revert of MIPS64: Enable shorten-64-to-32 warning. (patchset #12 id:240001 of https://codereview.chromium.org/1133163005/ )
...
Reason for revert:
Compile failure: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Mac64%20-%20debug/builds/3070/steps/compile/logs/stdio
Original issue's description:
> MIPS64: Enable shorten-64-to-32 warning.
>
> Port cdc43bc5fd
>
> Original commit message:
> Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings
> that arise.
>
> BUG=
>
> Committed: https://crrev.com/9af578a7c83b58a0ce25345998d9287cbf2030cb
> Cr-Commit-Position: refs/heads/master@{#28990}
TBR=danno@chromium.org ,martyn.capewell@arm.com,paul.lind@imgtec.com,akos.palfi@imgtec.com,dusan.milosavljevic@imgtec.com,jkummerow@chromium.org,machenbach@chromium.org,svenpanne@chromium.org,balazs.kilvady@imgtec.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1182493007
Cr-Commit-Position: refs/heads/master@{#28991}
2015-06-12 09:58:34 +00:00
balazs.kilvady
9af578a7c8
MIPS64: Enable shorten-64-to-32 warning.
...
Port cdc43bc5fd
Original commit message:
Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings
that arise.
BUG=
Review URL: https://codereview.chromium.org/1133163005
Cr-Commit-Position: refs/heads/master@{#28990}
2015-06-12 09:40:06 +00:00
yangguo
dd96c47a81
External snapshot: allow empty snapshot for external snapshot.
...
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/1180043003
Cr-Commit-Position: refs/heads/master@{#28989}
2015-06-12 09:37:11 +00:00
wingo
fa32d461c1
Add script context with context-allocated "const this"
...
R=rossberg@chromium.org
LOG=N
BUG=498811
Review URL: https://codereview.chromium.org/1179893002
Cr-Commit-Position: refs/heads/master@{#28988}
2015-06-12 09:35:57 +00:00
jochen
89b9a2cfb3
Reland "Keep track of array buffers in new space separately"
...
Original review https://codereview.chromium.org/1133773002/
BUG=v8:3996
TBR=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1177083003
Cr-Commit-Position: refs/heads/master@{#28987}
2015-06-12 09:34:54 +00:00
Michael Achenbach
c9368b2e77
Whitespace change to test infra clean-ups.
...
Cr-Commit-Position: refs/heads/master@{#28986}
2015-06-12 09:25:47 +00:00
jochen
21bca71c6d
Update PrintStack signature in gdbinit
...
BUG=none
R=yangguo@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1179053004
Cr-Commit-Position: refs/heads/master@{#28985}
2015-06-12 08:35:50 +00:00
jochen
b935e44c79
Add support for walking stack frames from hydrogen stubs
...
R=yangguo@chromium.org
BUG=none
LOG=n
Review URL: https://codereview.chromium.org/1184493003
Cr-Commit-Position: refs/heads/master@{#28984}
2015-06-12 08:28:00 +00:00
Benedikt Meurer
bd3edf37e1
[turbofan] Inline hot functions for NodeMarkerBase.
...
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/1184693002 .
Cr-Commit-Position: refs/heads/master@{#28983}
2015-06-12 08:05:16 +00:00
Michael Achenbach
068008e985
Whitespace change to test infra clean-ups.
...
Cr-Commit-Position: refs/heads/master@{#28982}
2015-06-12 07:20:19 +00:00
machenbach
f2747ed9b4
Revert of [es6] Bound function names (patchset #1 id:1 of https://codereview.chromium.org/1182513002/ )
...
Reason for revert:
[Sheriff] Speculative revert for changing layout tests:
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/379/layout-test-results/results.html
Exact blame assignment is not possible as our blink bots were in a bad state for a few builds.
Original issue's description:
> [es6] Bound function names
>
> https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function.prototype.bind
>
> Bound functions should have a name based on the function that was
> bound.
>
> BUG=N
> LOG=N
> R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/4e2a673881c55a13124dd62f2d05c8d9fe233cd3
> Cr-Commit-Position: refs/heads/master@{#28968}
TBR=adamk@chromium.org ,arv@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=N
Review URL: https://codereview.chromium.org/1186463002
Cr-Commit-Position: refs/heads/master@{#28981}
2015-06-12 06:49:45 +00:00
bmeurer
888b4ecab4
[turbofan] Use RootIndexMap to speed up IsMaterializableFromRoot predicate.
...
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/1181123002
Cr-Commit-Position: refs/heads/master@{#28980}
2015-06-12 06:31:08 +00:00
bmeurer
64ba57ce61
Revert of Keep track of array buffers in new space separately (patchset #4 id:60001 of https://codereview.chromium.org/1133773002/ )
...
Reason for revert:
GC stress unhappy
Original issue's description:
> Keep track of array buffers in new space separately
>
> BUG=v8:3996
> R=hpayer@chromium.org
> LOG=n
>
> Committed: https://crrev.com/506397d0a4241c19f5fab890e49e22d1d9b28bdc
> Cr-Commit-Position: refs/heads/master@{#28978}
TBR=hpayer@chromium.org ,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996
Review URL: https://codereview.chromium.org/1178403003
Cr-Commit-Position: refs/heads/master@{#28979}
2015-06-12 06:29:20 +00:00
jochen
506397d0a4
Keep track of array buffers in new space separately
...
BUG=v8:3996
R=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1133773002
Cr-Commit-Position: refs/heads/master@{#28978}
2015-06-12 05:35:35 +00:00
jacob.bramley
065b2374aa
Reland [arm64][turbofan]: Handle any immediate shift.
...
With this patch, we can generate simple immediate-shift instructions for
immediates outside the range "0 <= imm < width". Several related
instruction selectors have also been updated accordingly.
Example of generated code:
---- Before --- ---- After ----
movz w0, #33 lsr w0, w1, #1
lsr w0, w1, w0
BUG=
Review URL: https://codereview.chromium.org/1179893003
Cr-Commit-Position: refs/heads/master@{#28977}
2015-06-12 05:03:18 +00:00
martyn.capewell
b702cd97d4
[turbofan] Prefer add/shift over madd on ARM64
...
Before selecting multiply-accumulate for a multiplication with add operation,
check that the multiply can't be reduced to add-with-shift. This prevents
simple multiplications by 3, 5, etc turning into register moves and madd
instructions.
Review URL: https://codereview.chromium.org/1180863002
Cr-Commit-Position: refs/heads/master@{#28976}
2015-06-12 05:01:07 +00:00
mstarzinger
063079976c
[turbofan] Fix throwing conversion inserted by JSTypedLowering.
...
This fixes the graph wiring of implicit JSToNumber nodes inserted by
JSTypedLowering, to be correctly hooked into a surrounding exceptional
continuation.
R=bmeurer@chromium.org
TEST=mjsunit/compiler/try-binop,test262
Review URL: https://codereview.chromium.org/1178153004
Cr-Commit-Position: refs/heads/master@{#28975}
2015-06-12 04:42:14 +00:00
v8-autoroll
6d8c7958e1
Update V8 DEPS.
...
Rolling v8/tools/clang to 8b3ed2cb2e2512fa1074043cea3ada1143b80f26
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/1179113002
Cr-Commit-Position: refs/heads/master@{#28974}
2015-06-12 03:27:22 +00:00
verwaest
7b5264475c
Use LookupIterator in GetOldValue
...
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/1178123003
Cr-Commit-Position: refs/heads/master@{#28973}
2015-06-11 23:02:43 +00:00
dehrenberg
cbf9137707
Add ToObject call in Array.prototype.sort
...
The spec says ToObject is called on the receiver, and this is
observable if you call sort on a primitive. This patch trivially
adds the call and a test.
BUG=v8:4125
R=adamk
LOG=Y
Review URL: https://codereview.chromium.org/1178193004
Cr-Commit-Position: refs/heads/master@{#28972}
2015-06-11 21:43:21 +00:00
arv
5f72593d16
[es6] Make sure we call add property when adding a new property
...
When setting a property using `super.prop = val` we need to use
add property if we are adding a new property and not set property.
BUG=493566
LOG=N
R=verwaest@chromium.org , dslomov@chromium.org
Review URL: https://codereview.chromium.org/1161073002
Cr-Commit-Position: refs/heads/master@{#28971}
2015-06-11 21:24:41 +00:00
Toon Verwaest
dd90d2d4da
Remove ASSERT, this method can handle ExternalArrays just fine.
...
BUG=v8:4137
LOG=n
R=arv@chromium.org
Review URL: https://codereview.chromium.org/1179983002 .
Cr-Commit-Position: refs/heads/master@{#28970}
2015-06-11 20:46:46 +00:00
dehrenberg
b23c328f53
In Array.of and Array.from, fall back to DefineOwnProperty
...
%AddElement is not intended for objects which are not arrays, and
its behavior may go away with future refactorings. This patch gets
rid of it if the receiver of from or of is not the intrinsic Array
object.
Array.of and Array.from previously papered over failures in calling
[[DefineOwnProperty]] when setting array elements. This patch
makes them lead to exceptions, and adds tests to assert that
the appropriate exceptions are thrown.
BUG=v8:4168
R=adamk
CC=rossberg,verwaest
LOG=Y
Review URL: https://codereview.chromium.org/1181623003
Cr-Commit-Position: refs/heads/master@{#28969}
2015-06-11 20:41:04 +00:00
arv
4e2a673881
[es6] Bound function names
...
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function.prototype.bind
Bound functions should have a name based on the function that was
bound.
BUG=N
LOG=N
R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1182513002
Cr-Commit-Position: refs/heads/master@{#28968}
2015-06-11 20:36:45 +00:00
verwaest
848b620beb
Reland of Use the LookupIterator in SetAccessor (patchset #1 id:1 of https://codereview.chromium.org/1175323004/ )
...
Reason: Didn't break anything
Original issue's description:
> Revert of Use the LookupIterator in SetAccessor (patchset #2 id:20001 of https://codereview.chromium.org/1178673003/ )
>
> Reason for revert:
> Blocks reverting of https://codereview.chromium.org/1175973002
>
> Original issue's description:
> > Use the LookupIterator in SetAccessor
> >
> > BUG=v8:4137
> > LOG=n
> >
> > Committed: https://crrev.com/f93276bfe093f576595c5dcac69cf8f9163915d9
> > Cr-Commit-Position: refs/heads/master@{#28955}
>
> TBR=jkummerow@chromium.org ,verwaest@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:4137
>
> Committed: https://crrev.com/11dbd29de57b290ee8dac2a782a53f879beb416f
> Cr-Commit-Position: refs/heads/master@{#28956}
TBR=jkummerow@chromium.org ,ishell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4137
Review URL: https://codereview.chromium.org/1181813002
Cr-Commit-Position: refs/heads/master@{#28967}
2015-06-11 20:20:57 +00:00
verwaest
360e020408
Revert of Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #1 id:1 of https://codereview.chromium.org/1179933002/ )
...
Reason for revert:
Reland, this didn't break anything.
Original issue's description:
> Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #2 id:40001 of https://codereview.chromium.org/1175973002/ )
>
> Reason for revert:
> It broke webkit_unit_tests
>
> Original issue's description:
> > Remove GetAttributes from the mix to avoid another virtual dispatch.
> >
> > BUG=chromium:495949,v8:4137
> > LOG=n
> >
> > Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175
> > Cr-Commit-Position: refs/heads/master@{#28953}
>
> TBR=verwaest@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:495949,v8:4137
>
> Committed: https://crrev.com/ae639d2ad646237e2f413259a0f116845ef96440
> Cr-Commit-Position: refs/heads/master@{#28958}
TBR=ishell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:495949,v8:4137
Review URL: https://codereview.chromium.org/1182603002
Cr-Commit-Position: refs/heads/master@{#28966}
2015-06-11 20:17:36 +00:00
Toon Verwaest
91de375868
Restore ExecutableAccessorInfoHandling for now
...
BUG=v8:4137
LOG=n
R=ishell@chromium.org
Review URL: https://codereview.chromium.org/1173283004 .
Cr-Commit-Position: refs/heads/master@{#28965}
2015-06-11 20:15:02 +00:00
mtrofin
32f4bd659d
Decompiler improvements.
...
The main motivation is simplifying profiling activities:
1) Use hex instead of decimal for offsets, just like perf does. This
affects --print-opt-code
2) When printing block information, indicate loop information: if
block is header, where the end is; if block is in a loop, where the
loop starts. This affects --code-comments.
Using --print-opt-code --code-comments, and cross-referencing with data
obtained from perf, one may now find the block a hotspot belongs to
without needing to do hex2dec/dec2hex conversions. Once found, loop info
is available locally, on the block.
BUG=
Review URL: https://codereview.chromium.org/1177123002
Cr-Commit-Position: refs/heads/master@{#28964}
2015-06-11 20:10:40 +00:00
verwaest
83abd09597
Use LookupIterator for elements in the observed part of DefineAccessor
...
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/1177103003
Cr-Commit-Position: refs/heads/master@{#28963}
2015-06-11 20:09:27 +00:00
verwaest
2cdfd4daa9
Use LookupIterator for elements in GetAccessor
...
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/1178083002
Cr-Commit-Position: refs/heads/master@{#28962}
2015-06-11 20:08:22 +00:00
arv
37e268732d
Bound functions should also have configurable length
...
BUG=v8:4116
LOG=N
R=adamk@chromium.org
Review URL: https://codereview.chromium.org/1180873002
Cr-Commit-Position: refs/heads/master@{#28961}
2015-06-11 20:07:15 +00:00
dstence
7d65a62f5c
PPC: smi test optimization
...
R=mbrandy@us.ibm.com , michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/1177263002
Cr-Commit-Position: refs/heads/master@{#28960}
2015-06-11 20:06:10 +00:00
Toon Verwaest
6a8315229f
Reconfigure on the right holder, which might be a hidden object.
...
BUG=v8:4137
LOG=n
R=ishell@chromium.org
Review URL: https://codereview.chromium.org/1178953003 .
Cr-Commit-Position: refs/heads/master@{#28959}
2015-06-11 18:52:08 +00:00
ishell
ae639d2ad6
Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #2 id:40001 of https://codereview.chromium.org/1175973002/ )
...
Reason for revert:
It broke webkit_unit_tests
Original issue's description:
> Remove GetAttributes from the mix to avoid another virtual dispatch.
>
> BUG=chromium:495949,v8:4137
> LOG=n
>
> Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175
> Cr-Commit-Position: refs/heads/master@{#28953}
TBR=verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:495949,v8:4137
Review URL: https://codereview.chromium.org/1179933002
Cr-Commit-Position: refs/heads/master@{#28958}
2015-06-11 17:25:34 +00:00
ishell
62d65a347f
Revert of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/ )
...
Reason for revert:
Blocks revert of https://codereview.chromium.org/1175973002
Original issue's description:
> Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant.
>
> @yangguo: please look at the debugger part of the CL.
> @ishell: please look at the rest.
>
> Additionally:
> - Ensure the LookupIterator for named properties does not accidentally get indexes in.
> - Fix the return value for typed array assignments to be the incoming value.
>
> BUG=v8:4137
> LOG=n
>
> Committed: https://crrev.com/15aa811f8fe2708a757c3b53ca89db736aa8b222
> Cr-Commit-Position: refs/heads/master@{#28954}
TBR=yangguo@chromium.org ,verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4137
Review URL: https://codereview.chromium.org/1181733002
Cr-Commit-Position: refs/heads/master@{#28957}
2015-06-11 17:21:19 +00:00
ishell
11dbd29de5
Revert of Use the LookupIterator in SetAccessor (patchset #2 id:20001 of https://codereview.chromium.org/1178673003/ )
...
Reason for revert:
Blocks reverting of https://codereview.chromium.org/1175973002
Original issue's description:
> Use the LookupIterator in SetAccessor
>
> BUG=v8:4137
> LOG=n
>
> Committed: https://crrev.com/f93276bfe093f576595c5dcac69cf8f9163915d9
> Cr-Commit-Position: refs/heads/master@{#28955}
TBR=jkummerow@chromium.org ,verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4137
Review URL: https://codereview.chromium.org/1175323004
Cr-Commit-Position: refs/heads/master@{#28956}
2015-06-11 17:20:05 +00:00
verwaest
f93276bfe0
Use the LookupIterator in SetAccessor
...
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/1178673003
Cr-Commit-Position: refs/heads/master@{#28955}
2015-06-11 17:04:00 +00:00