AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
13,088 Commits 1 Branch 0 Tags 839 MiB
f41f6c2b41
Commit Graph

13088 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
bmeurer@chromium.org
125d3390a3 Improve detection of C++11 features. 
Also improve detection of V8_INFINITY while we're at it.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23323003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16254 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-21 10:43:50 +00:00
yangguo@chromium.org
09668ec3f6 Use CheckUsesForFlag to check flag in uses list 
BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/22862009

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16253 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-21 08:28:59 +00:00
plind44@gmail.com
4c113989a1 MIPS: Fix bug that prevents JALR to JAL optimizations. 
TEST=

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/23072023

Patch from Dusan Milosavljevic <Dusan.Milosavljevic@rt-rk.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16252 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 22:10:20 +00:00
palfia@homejinni.com
5d718d96b9 MIPS: Remove platform-specific dead code for KeyedStores 
Port r16227 (02df4098)

BUG=

Review URL: https://codereview.chromium.org/22815014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16251 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 18:07:22 +00:00
jkummerow@chromium.org
dea98eee53 Fix a bug in Div when all uses are truncating 
Refine the related test cases to cover truncating cases

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/22964004

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16249 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 13:57:01 +00:00
dslomov@chromium.org
02fdc4114f Promote ArrayBuffer, DataView and typed arrays to non-experimental. 
The primary reason for this change is to bake these guys into the
snapshot.

Flag definitions (--harmony-typed-arrays, --harmony-array-buffer) are
still there so that Blink does not complain, but they are noop and
default to true.

R=mstarzinger@chromium.org
BUG=270527

Committed: https://code.google.com/p/v8/source/detail?r=16137

Committed: https://code.google.com/p/v8/source/detail?r=16228

Review URL: https://codereview.chromium.org/22390008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16248 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 13:55:52 +00:00
yangguo@chromium.org
9b8c71ea6d Add warning to cctest when running multiple tests in sequence. 
R=mstarzinger@chromium.org
BUG=v8:2848

Review URL: https://codereview.chromium.org/23067008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16247 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 13:20:40 +00:00
olivf@chromium.org
383a167279 Add X87 implementations for Integer32ToDouble, DoubleToI, DoubleToSmi 
Additionally refactor the X87Stack tracking

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/20781007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16246 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 13:01:54 +00:00
dslomov@chromium.org
1bff3fd516 Replace OS::MemCopy with memcpy in typed array initialization. 
This is an attempt to fix a weird perf regression on MacOS X 10.6 bot.
Perf regression is not reproducible on MacOS X 10.8.
This difference in memory-copying routines is the only reasonable
difference in the algorithm. We should try and see.

R=bmeurer@chromium.org
BUG=270642

Review URL: https://codereview.chromium.org/23330005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16245 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 11:14:56 +00:00
bmeurer@chromium.org
c2c6b2813d Reland "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them.". 
- Use V8_FINAL and V8_OVERRIDE in Ast classes.
- Use V8_FINAL and V8_OVERRIDE in Lithium mips backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium arm backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium x64 backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium ia32 backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium classes.
- Use V8_FINAL and V8_OVERRIDE in Hydrogen classes.

TBR=dslomov@chromium.org

Review URL: https://codereview.chromium.org/22796020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16244 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 11:10:24 +00:00
bmeurer@chromium.org
60e7d4b1e3 Revert "Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them." 
This reverts commit r16232 for breaking the
tools/gen-postmortem-metadata.py script. Will reland without the
objects.{cc,h} changes.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23143007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16243 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 10:52:23 +00:00
yangguo@chromium.org
479935bc62 Remove access-check-failed callback after test. 
BUG=v8:2848
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/22802013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 10:46:02 +00:00
bmeurer@chromium.org
1a560b1a5e Visual Studio 2012 and later support the C++11 final keyword. 
TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23128007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16241 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 09:37:21 +00:00
mstarzinger@chromium.org
8a1abf6279 Consistently use CompilationInfo::AbortOptimization. 
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/22832002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16240 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 08:53:34 +00:00
jochen@chromium.org
943d5cc27a Move i18n break iterator C++ code to runtime 
BUG=v8:2745
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/22764007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16239 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 08:46:36 +00:00
bmeurer@chromium.org
f86f275f65 Add (mostly Chromium-compatible) V8_OS_* defines to v8.gyp. 
R=jkummerow@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23283010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16238 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 08:29:21 +00:00
jochen@chromium.org
bd30d3aa54 Fix null handle deref in InternalDateFormat 
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/22927014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16237 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 08:17:43 +00:00
bmeurer@chromium.org
c3778ade30 Fix non-Xcode build on Mac with clang. 
TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/22793008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16236 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 08:14:19 +00:00
jkummerow@chromium.org
31691477b7 Avoid -O3 in nacl as it does not play well with -W. 
Also cleans up some uninitialized data I saw while investigating
the problem.

R=jkummerow@chromium.org, machenbach@chromium.org

Review URL: https://codereview.chromium.org/23119004

Patch from Ken Mixter <kmixter@google.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16235 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 08:12:19 +00:00
jochen@chromium.org
800f9f7d35 Don't use Persistent in runtime 
R=dcarney@chromium.org, mstarzinger@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/22432009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16234 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 08:07:52 +00:00
jochen@chromium.org
76a820a91e During bootstrapping, the script's name is not necessarily set. 
So check whether the name is actually set before printing it when
throwing an exception.

BUG=none
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23283011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16233 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 08:06:48 +00:00
bmeurer@chromium.org
9929a9cd12 Use V8_FINAL and V8_OVERRIDE in various places, fixing bugs revealed by them. 
- Use V8_FINAL and V8_OVERRIDE in objects.
- Use V8_FINAL and V8_OVERRIDE in Ast classes.
- Use V8_FINAL and V8_OVERRIDE in Lithium mips backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium arm backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium x64 backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium ia32 backend.
- Use V8_FINAL and V8_OVERRIDE in Lithium classes.
- Use V8_FINAL and V8_OVERRIDE in Hydrogen classes.

R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/23064017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16232 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 07:27:06 +00:00
bmeurer@chromium.org
cb4eb5b3e1 Add V8_FINAL and V8_OVERRIDE macros for C++11 final/override. 
TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/22914019

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16231 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 06:51:58 +00:00
bmeurer@chromium.org
c44ccc2d79 Revert "Add FINAL and OVERRIDE macros for C++11 final/override." 
This reverts commit r16222 for not using V8_ prefix.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23301006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16230 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 06:39:04 +00:00
dslomov@chromium.org
80ec7fab15 Revert "Promote ArrayBuffer, DataView and typed arrays to non-experimental." 
This reverts commit r16137 for breaking Windows build.
TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/22985011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16229 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 01:37:09 +00:00
dslomov@chromium.org
62505a3901 Promote ArrayBuffer, DataView and typed arrays to non-experimental. 
The primary reason for this change is to bake these guys into the
snapshot.

Flag definitions (--harmony-typed-arrays, --harmony-array-buffer) are
still there so that Blink does not complain, but they are noop and
default to true.

R=mstarzinger@chromium.org
BUG=270527

Committed: https://code.google.com/p/v8/source/detail?r=16137

Review URL: https://codereview.chromium.org/22390008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16228 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-20 00:48:25 +00:00
danno@chromium.org
ca9a3c71a1 Remove platform-specific dead code for KeyedStores 
R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22745003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16227 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-19 22:12:46 +00:00
mstarzinger@chromium.org
bbf9018c0f Fix invalid out-of-bounds store in MacroAssembler::Allocate. 
This fixes an out-of-bounds store in inlined allocations when double
alignment and pretenuring into old-data-space have been requested.

R=hpayer@chromium.org, jkummerow@chromium.org, plind44@gmail.com
BUG=chromium:263515

Review URL: https://codereview.chromium.org/23242006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16224 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-19 17:46:43 +00:00
palfia@homejinni.com
8bb2b9307f MIPS: Remove wrong restriction in GenerateDeoptJumpTable. 
* This Abort condition does not apply to MIPS, since the
  assembler can also emit long Branches automatically, when
  it is needed.

TEST=mjsunit/math-floor-of-div,benchmarks/octane/gbemu,benchmarks/octane/mandreel

BUG=

Review URL: https://codereview.chromium.org/23020018

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16223 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-19 16:02:50 +00:00
bmeurer@chromium.org
254482e4a3 Add FINAL and OVERRIDE macros for C++11 final/override. 
We also use new the constant naming scheme for Yield::Kind values to avoid
clash with the FINAL macro.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23098004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-19 14:46:35 +00:00
bmeurer@chromium.org
a04490517a ARM: Fix register misuse bug in Allocate(). 
The bug is triggered if flags contains DOUBLE_ALIGNMENT and the
object_size is not an ARM immediate value. In this case, the code
for DOUBLE_ALIGNMENT uses the scratch2 register, which is aliased
to obj_size_reg containing the object_size.

Instead of pre-loading the object_size, which is difficult since
we are out of registers here, we simply generate a non-empty
sequence of add instructions for the addition of the constant
object_size (carefully handling possible overflow in each step).

Also turn static ASSERT into STATIC_ASSERT in Allocate().

BUG=v8:2851
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23323002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16221 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-19 13:37:57 +00:00
mstarzinger@chromium.org
665a6d8a94 Prevent empty handle dereference in Runtime_InternalNumberFormat. 
R=jochen@chromium.org
BUG=chromium:275467

Review URL: https://codereview.chromium.org/22859025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16220 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-19 13:03:58 +00:00
verwaest@chromium.org
20ca26f494 Improve generalization / migration tracing. 
R=yangguo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23047002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16219 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-19 12:32:50 +00:00
mstarzinger@chromium.org
94fb05f823 Temporary workaround for GC stress builder. 
R=hpayer@chromium.org, hpayer@google.com
TEST=cctest/test-debug/ScriptCollectedEventContext --gc-interval=500

Review URL: https://codereview.chromium.org/22987004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16216 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-19 11:10:08 +00:00
mstarzinger@chromium.org
d52f489c79 Clarify side effects of HTransitionElementsKind. 
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/22796011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16215 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-19 10:55:51 +00:00
rossberg@chromium.org
17046dbe14 Prepare push to trunk. Now working on version 3.21.1. 
R=jkummerow@chromium.org
BUG=

Review URL: https://codereview.chromium.org/22856005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16212 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-19 09:34:18 +00:00
bmeurer@chromium.org
8fa088b273 Drop broken and unnecessary RequiredInputRepresentation() in HMathFloorOfDiv. 
R=titzer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16190

Review URL: https://codereview.chromium.org/23190002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16211 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-19 07:25:25 +00:00
mstarzinger@chromium.org
c5c6c23a23 Handlify Accessors::FunctionSetPrototype method. 
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/23280004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16210 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-16 21:27:11 +00:00
mstarzinger@chromium.org
3fa964bf53 Remove check for empty handle for CodeGenerator::MakeCodeEpilogue. 
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/22840002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16209 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-16 19:52:29 +00:00
verwaest@chromium.org
d81af53131 Store copied value rather than the original double. 
R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23262002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16208 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-16 15:43:42 +00:00
mstarzinger@chromium.org
3e4fbd0e85 Mark HStringCompareAndBranch as potentially causing GCs. 
This also adds a %SetAllocationTimout runtime function which helps to
write regression tests that need to trigger a GC at a certain point in
program execution.

R=hpayer@chromium.org
BUG=chromium:274438
TEST=mjsunit/regress/regress-crbug-274438

Review URL: https://codereview.chromium.org/22933006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16205 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-16 15:10:07 +00:00
jochen@chromium.org
aabfd6d610 Revert "make Intl non-enumerable" 
This reverts commit 327355efe28995f5d91aadb54c71ea1d292c8428.

TBR=svenpanne@chromium.org,dcarney@chromium.org

Review URL: https://codereview.chromium.org/22893026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-16 14:10:08 +00:00
danno@chromium.org
d5762717d6 Fix bug in test-code-stubs-x64 which meant not all registers were being checked. 
Also change test-code-stubs-ia32 to use the same style as x64.

BUG=
R=danno@chromium.org

Review URL: https://codereview.chromium.org/22865006

Patch from Ross McIlroy <mcilroy@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16203 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-16 11:29:54 +00:00
palfia@homejinni.com
aaeca64dd6 MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only allow changing hole to nan if all uses allow undefined as nan. 
Port r16183 (1858bc57)

BUG=

Review URL: https://codereview.chromium.org/23130006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-14 23:07:48 +00:00
danno@chromium.org
48ff27831c Prepare push to trunk. Now working on version 3.21.0 
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/22870007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16197 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-14 17:10:14 +00:00
danno@chromium.org
6bcca144a9 Fix GC Mole warning 
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/22815005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16196 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-14 17:03:19 +00:00
danno@chromium.org
6cd9ae7bc1 Fix src/version.cc number to be consistent with next trunk push 
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23000010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-14 17:00:16 +00:00
verwaest@chromium.org
928b07f558 Fix no-sse2 part 2. 
R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23154004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-14 16:58:14 +00:00
danno@chromium.org
7aa3fedaab Fix Crankshafted CompareNil of constant values 
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/23198002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16193 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-14 16:13:58 +00:00
verwaest@chromium.org
ea14c000bc Fix CmpHoleAndBranch on no-sse2 
R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22810005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16192 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
 2013-08-14 15:50:23 +00:00