Andrey Lushnikov
257f9494a6
Reland of Inspector: Runtime.callFunctionOn to accept executionContextId
...
This patch:
- teaches Runtime.callFunctionOn to accept executionContextId instead of
objectId.
- adds the optional objectGroup parameter to the Runtime.callFunctionOn.
R=kozy
TBR=pfeldman
BUG=chromium:760367
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I024654860f23a9e79fb57865ba5bd472692ea526
Reviewed-on: https://chromium-review.googlesource.com/641921
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47725}
2017-08-31 02:23:06 +00:00
Michael Achenbach
d2af19f2da
Revert "Inspector: Runtime.callFunctionOn to accept executionContextId"
...
This reverts commit de839c5671
.
Reason for revert: Breaks chromium compilation, e.g.:
https://build.chromium.org/p/client.v8.fyi/builders/Linux%20Debug%20Builder/builds/6010
Original change's description:
> Inspector: Runtime.callFunctionOn to accept executionContextId
>
> This patch:
> - teaches Runtime.callFunctionOn to accept executionContextId instead of
> objectId.
> - adds the optional objectGroup parameter to the Runtime.callFunctionOn.
>
> R=kozy
>
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Ia29ee37f37a1e8cbe2d9f15ae75e841534ecf727
> Reviewed-on: https://chromium-review.googlesource.com/639751
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#47659}
TBR=lushnikov@chromium.org ,pfeldman@chromium.org,kozyatinskiy@chromium.org
Change-Id: I2586a6accde6c1f79d628b8999d90222b5714dc1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/640590
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47661}
2017-08-29 06:37:57 +00:00
Andrey Lushnikov
de839c5671
Inspector: Runtime.callFunctionOn to accept executionContextId
...
This patch:
- teaches Runtime.callFunctionOn to accept executionContextId instead of
objectId.
- adds the optional objectGroup parameter to the Runtime.callFunctionOn.
R=kozy
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia29ee37f37a1e8cbe2d9f15ae75e841534ecf727
Reviewed-on: https://chromium-review.googlesource.com/639751
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47659}
2017-08-29 04:22:45 +00:00
Andrey Lushnikov
109e8b98f5
Inspector: support simple objects for Runtime.callFunctionOn arguments
...
This patch adds objects support for Runtime.callFunctionOn arguments.
R=kozy
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9e9ad000482aa556f10a632b89c2f91fdc21ff1e
Reviewed-on: https://chromium-review.googlesource.com/636353
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47624}
2017-08-25 23:59:11 +00:00
Andrey Lushnikov
7bf549a44b
Inspector: re-write the test to be modern
...
This patch re-writes the call-function-on-async.js test according
to the new style.
R=kozy
Change-Id: I0541d336fe2bba3197170b0cc22c70e96d8543aa
Reviewed-on: https://chromium-review.googlesource.com/636691
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47621}
2017-08-25 23:01:22 +00:00
Alexey Kozyatinskiy
6ceee53698
[inspector] aligned Runtime.evaluate(awaitPromise: true) with await semantic
...
This one allows us to support custom promises implementation.
With awaitPromise flag Runtime.evaluate awaits
Promise.resolve(<expression result>).
This also allows to await for any non-Promise value, similar to await
expression, which is more convenient for most protocol users.
R=dgozman@chromium.org
Bug: chromium:755104
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iee798b33b6fb7de7d393372e164c0481d1bbf7eb
Reviewed-on: https://chromium-review.googlesource.com/614308
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47354}
2017-08-15 01:35:29 +00:00
dgozman
7bbea08f66
[inspector] Refactor protocol-test.js
...
This refactoring makes it easier to write advanced tests and
gives full control over what's happening to the test code.
It also forces description for every test.
BUG=none
Review-Url: https://codereview.chromium.org/2891213002
Cr-Commit-Position: refs/heads/master@{#45412}
2017-05-19 00:35:45 +00:00
kozyatinskiy
9c385f0405
[inspector] added reconnect method for tests
...
This method enables test of agent::restore methods.
Bonus: forbid setCustomObjectFormatterEnabled on disabled agent.
BUG=none
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2713023004
Cr-Commit-Position: refs/heads/master@{#43502}
2017-02-28 20:22:24 +00:00
kozyatinskiy
6808ec1f83
[inspector] introduced Script::TYPE_INSPECTOR
...
Inspector uses this type for all internal scripts, e.g. injected-script-source.js. Scripts with new type are not reported by remote debugging protocol, frames from them are ignored.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=none
R=yangguo@chromium.org ,dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2499273003
Cr-Commit-Position: refs/heads/master@{#41056}
2016-11-17 04:39:47 +00:00
kozyatinskiy
24beac30ee
[inspector] Make InspectorTest.sendCommand* private
...
Introduce Protocol.Domain.method(args) and Protocol.Domain.onEventName() instead.
Renamed InspectorTest.evaluateInPage -> InspectorTest.addScript.
Improved InspectorTest.logMessage.
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Review-Url: https://codereview.chromium.org/2390733002
Cr-Commit-Position: refs/heads/master@{#39942}
2016-10-03 23:33:07 +00:00
kozyatinskiy
270db7903a
[inspector] added inspector test runner [part 5]
...
- added most part of inspector tests that depends only on JavaScript domains.
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Committed: https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79
Review-Url: https://codereview.chromium.org/2369753004
Cr-Original-Commit-Position: refs/heads/master@{#39897}
Cr-Commit-Position: refs/heads/master@{#39931}
2016-10-02 21:23:03 +00:00
machenbach
ee0d69910b
Revert "[inspector] added inspector test runner [part 3-5]"
...
Revert "[inspector] added inspector test runner [part 3]"
This reverts commit f3f9f4448d
.
Revert "[inspector] added inspector test runner [part 4]"
This reverts commit 4a5f5d0991
.
Revert "[inspector] added inspector test runner [part 5]"
This reverts commit 9ddbdab195
.
Reverting this in order to revert parts 1-2 which block the roll:
https://codereview.chromium.org/2379053003/
BUG=chromium:635948
TBR=kozyatinskiy@chromium.org ,
NOTRY=true
Review-Url: https://codereview.chromium.org/2379303002
Cr-Commit-Position: refs/heads/master@{#39908}
2016-09-30 09:25:31 +00:00
kozyatinskiy
9ddbdab195
[inspector] added inspector test runner [part 5]
...
- added most part of inspector tests that depends only on JavaScript domains.
BUG=chromium:635948
R=dgozman@chromium.org ,alph@chromium.org
Review-Url: https://codereview.chromium.org/2369753004
Cr-Commit-Position: refs/heads/master@{#39897}
2016-09-30 04:50:17 +00:00