machenbach@chromium.org
45681c688d
Remove old branch logic from push scripts.
...
The old temporary branch is not needed anymore. All scripts create a different branch after creating the temporary branch.
This also fixes logging subprocesses and logs a warning to track down script failures due to wrong branches.
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/266083003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21147 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-05-05 15:16:26 +00:00
machenbach@chromium.org
0516f641cd
Let releases script retrieve information about chromium branches.
...
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/238443005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20972 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-25 11:33:19 +00:00
machenbach@chromium.org
8cab750a81
Let revision script add commit dates.
...
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/238983002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20763 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-15 12:00:53 +00:00
machenbach@chromium.org
0182a0f16a
Make V8 releases script add useful links.
...
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/227303005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20713 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-14 10:32:00 +00:00
machenbach@chromium.org
f1c2b7007d
Fix chromium ranges output in v8 releases script.
...
Add space after commas for auto line break in spreadsheets.
Add default empty strings to avoid undefined values in spreadsheets.
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/233343002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20671 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-11 07:40:48 +00:00
machenbach@chromium.org
fd8a2a7f7a
Add V8 releases script.
...
This script retrieves the history of all V8 branches and trunk revisions and their corresponding Chromium revisions.
TEST=tools/push-to-trunk/releases.py -c <chrome path> --csv test.csv
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/227583002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20629 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-09 14:30:02 +00:00
machenbach@chromium.org
c9d8b90f1b
Automatically determine current V8 sheriff in chromium-roll script.
...
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/225283007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20576 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-08 12:07:49 +00:00
machenbach@chromium.org
4b222fb69e
Make auto-roll script also roll patched trunk revisions.
...
This will allow the auto-roll bot to roll the last trunk patches, e.g. "Version 3.4.5.1 ...".
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/223863003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20497 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-04 07:23:45 +00:00
machenbach@chromium.org
48b8a545c4
Fix bug entry and quotation marks in merge-to-branch.
...
This fixes usage of quotation marks inside titles of merged patches.
This also fixes aggregation of empty or "none" BUG entries.
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/223463003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20483 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-03 13:01:22 +00:00
machenbach@chromium.org
5f3c8a11fa
Add merged patches to commit title in merge-to-branch.
...
This makes it easier to grep for patches in title in the revision history.
This also removes the redundant information into which branch was merged, as this can be derived from the version number in the title now.
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/223753002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20482 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-03 12:57:33 +00:00
machenbach@chromium.org
18308b389c
Add version number to commit message in merge-to-branch.
...
This is a step towards automatically rolling arbitrary trunk revisions into Chromium.
This also deprecates the bash scripts as they now start to divert.
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/223093003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20465 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-03 09:42:18 +00:00
machenbach@chromium.org
eba6cb49c1
Fix auto-roll configuration.
...
TBR=jarin@chromium.org
BUG=
Review URL: https://codereview.chromium.org/221833003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20425 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-02 07:13:17 +00:00
machenbach@chromium.org
bde7527a07
Add execution permission to auto-roll script.
...
TBR=jarin@chromium.org
BUG=
Review URL: https://codereview.chromium.org/220203010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20424 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-02 07:04:53 +00:00
machenbach@chromium.org
0b246776ec
Implement auto-roll script.
...
This script will (1) check if there is an active roll on rietveld (2) check if there is a trunk revision ready to be rolled and (3) call the chromium_roll script, creating a roll CL. The script will be called regularly through a cron job.
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/212983003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20422 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-04-02 06:59:25 +00:00
machenbach@chromium.org
8311e24c2d
Change auto-roll to auto-push for automatic trunk pushes.
...
The current script is only performing automatic pushes to trunk. This prepares for adding an auto-roll script that actually rolls to Chromium.
This also removes the v8-status updates, which are no longer necessary due to not touching bleeding edge any more.
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/196173018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20205 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-24 15:52:31 +00:00
machenbach@chromium.org
db8196ae63
Fix options for calling push-to-trunk script.
...
BUG=
TBR=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/209833002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-24 08:03:15 +00:00
machenbach@chromium.org
04a418c550
Let auto-roll push the lkgr.
...
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/205703004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20168 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-21 15:04:54 +00:00
machenbach@chromium.org
e134d32ff0
Split of rolling Chromium from push-to-trunk.
...
This moves rolling Chromium into a new script with its own tests.
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/199733012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20159 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-21 12:15:25 +00:00
machenbach@chromium.org
b12ff51378
Allow to push arbitrary revisions when pushing to trunk.
...
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/206133004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20132 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-20 15:44:30 +00:00
machenbach@chromium.org
d7d4452e1c
Deprecate prepare push commit when pushing to trunk.
...
- This also deprecates using version.cc on bleeding edge.
- The deprecated push-to-trunk.sh is deleted.
- The script now commits bleeding edge HEAD by default. Committing different revisions will be added in a follow up CL.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/203753010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20101 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-20 09:23:44 +00:00
machenbach@chromium.org
44e3cfc651
Retrieve current version from trunk branch in push-to-trunk.
...
- This moves retrieving and incrementing the version before creating the change log
- Before the prepare push commit will be deprecated (follow up CL), the script deals with 3 build levels. X: the current build level on the last trunk push. X + 1: the build level for this trunk push. X + 2: the build level of the new version file on bleeding edge (to be deprecated).
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/203773013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-19 13:10:41 +00:00
machenbach@chromium.org
23b0228614
Directly modify version file on trunk branch in push-to-trunk.
...
- This also shifts the push revision by one to prepare for the deprecation of the prepare push commit
- The version increment is still based on the bleeding_edge version.cc. This will be changed in a follow up CL.
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/200763013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20054 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-19 10:46:24 +00:00
machenbach@chromium.org
c06c9f8e1e
Deprecate ChangeLog on bleeding_edge.
...
- This adds a sentinel to the ChangeLog on bleeding edge.
- Modifying the ChangeLog file directly when pushing to trunk is now no longer possible. If further modifications to the ChangeLog in manual push-to-trunk mode are required (e.g. after the prepare push LGTM), the change log entry temp file must be edited.
- Functionality that is no longer needed is removed.
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/199893005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20029 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-18 12:46:48 +00:00
machenbach@chromium.org
a868a74cfc
Fix branch for resetting change log in push-to-trunk.
...
The patch is applied to ChangeLog with the "--index" option, which already updates the index of the file. For resetting the ChangeLog to the trunk revision, the trunk branch needs to be stated explicitly in the checkout, otherwise it checks out the already patched HEAD.
TEST=tools/push-to-trunk/script_test.py
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/199993005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19996 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-17 13:52:33 +00:00
machenbach@chromium.org
fac6b67b2c
Fix maintaining change log in push-to-trunk.
...
Applying the patch on ChangeLog causes local changes. To reset the ChangeLog to its original state, the "-f" option is required.
TBR=jarin@chromium.org
Review URL: https://codereview.chromium.org/201633002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19963 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-17 08:51:27 +00:00
machenbach@chromium.org
acc2997b52
Reland "Maintain change log file directly on trunk branch in push-to-trunk."
...
This uses the following approach to modify the trunk change log:
- Calculate the new change log entries
- Apply changes to the bleeding edge change log (this will be removed in a follow up CL)
- Apply the diff between BE and trunk to trunk (this includes the diff of the change log)
- Reset the change log to the version on trunk
- Reapply the new change log entries
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/196473012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19953 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-15 13:06:08 +00:00
machenbach@chromium.org
f7fea5dd92
Revert "Maintain change log file directly on trunk branch in push-to-trunk." and related changes.
...
This reverts r19876, r19902 and r19903. The changes made git diff' in push-to-trunk unusable.
TBR=jarin@chromium.org
Review URL: https://codereview.chromium.org/197313005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19905 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-13 15:48:24 +00:00
machenbach@chromium.org
fa4625c1a4
Maintain change log file directly on trunk branch in push-to-trunk.
...
This is another step for deprecating the change log file on bleeding edge.
BUG=
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/196283014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19902 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-13 15:12:18 +00:00
machenbach@chromium.org
078ecbb9c3
Add file exclusion to trunk patch creation in push-to-trunk.
...
This is another step towards getting rid of the bleeding edge change log file. Now it can be omitted in a follow up CL.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/197023004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19876 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-13 07:57:07 +00:00
machenbach@chromium.org
8bcd43b8cf
Refactoring: Use explicit mock expectations for testing push and merge scripts.
...
- Up to now, mock expectations were simple lists of arguments + return value
- These expectations are now modeled explicitly including the name of the mock (e.g. git or readline)
- The optional test callback function is now explicitly named
- This will allow merging all mock expectation types (e.g. git and readline) into a single list per test case (follow up CL)
TEST=tools/push-to-trunk/script_test.py
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/197313002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19853 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-12 14:39:04 +00:00
machenbach@chromium.org
7c778096b1
Suppress error handling for test coverage in push and merge scripts.
...
- This adds a suppression of lines concerning error handling for the test coverage analysis
- Fixes also calling push-to-trunk from auto-roll
TEST=tools/push-to-trunk/script_test.py
TBR=ulan@chromium.org
Review URL: https://codereview.chromium.org/196883003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19838 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-12 10:45:23 +00:00
machenbach@chromium.org
11b6daec84
Don't use a temp file for changelog in push-to-trunk.
...
This is part of getting rid of the ChangeLog on bleeding_edge and directly modifying it on trunk.
BUG=
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/195183003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19832 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-12 07:39:56 +00:00
machenbach@chromium.org
bc21f42563
Refactoring: Make script dependencies more object-oriented in push and merge scripts.
...
- Connect the top-level scripts via inheritance and remove top-level functions
- Options and option processing can be extended from base to subclass script
This CL is split off from https://codereview.chromium.org/173983002/
BUG=
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/185263003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19664 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-04 23:27:27 +00:00
machenbach@chromium.org
73bb6c6bd7
Add coverage analysis to push and merge script tests.
...
The coverage analysis must live in an extra file in order to analyze the scripts when being imported.
TEST=tools/push-to-trunk/script_test.py
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/183923013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19640 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-03-03 20:17:03 +00:00
machenbach@chromium.org
5acdc942f6
Refactoring: Long option names in push and merge scripts.
...
This CL is split off from https://codereview.chromium.org/173983002/
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/180873010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19632 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-28 21:49:51 +00:00
commit-bot@chromium.org
56060812f6
Fix line distance in push and merge scripts.
...
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19628 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-28 19:45:28 +00:00
machenbach@chromium.org
f09b3db78c
Fix patch creation in merge-to-branch script.
...
Patch white space got stripped, which lead to failures when applying the patch.
- Refine test to reveal the problem
- Create a separate method for retrieving the patch that doesn't strip white space
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/181603002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19566 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-26 16:12:32 +00:00
machenbach@chromium.org
2e01427c3d
Refactoring: Deprecate optparse in push and merge scripts.
...
- Deprecate optparse with argparse
- The tests include now options parsing by default: each test specifies the command-line args to parse rather than the options directly
This CL is split off from https://codereview.chromium.org/173983002/
TBR=ulan@chromium.org
Review URL: https://codereview.chromium.org/181583002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19565 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-26 15:13:31 +00:00
machenbach@chromium.org
01cf2f8eda
Refactoring: Extract low-level git from push and merge scripts.
...
- This adds a python layer on top of the low-level git calls to control parameter passing and return values.
- This also fixes a bug in FindLastTrunkPush that only shows up in manual mode when the last push versions are iterated.
- The order of some parameters changed in some git calls in the tests to be uniform.
BUG=
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/171423013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19515 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-20 16:39:41 +00:00
machenbach@chromium.org
672bc20af8
Fix options in push-to-trunk script.
...
BUG=
TBR=ulan@chromium.org
Review URL: https://codereview.chromium.org/173533002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19501 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-20 08:06:11 +00:00
machenbach@chromium.org
7a4f18caa6
Refactoring: Extract git checks in push and merge scripts.
...
This extracts the pattern "if call git fails: raise exception", which is spread all over the place. Now all calls to git are required to return gracefully and give a uniform exception message if they don't.
BUG=
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/166903012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19494 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-19 14:56:19 +00:00
machenbach@chromium.org
fb0fb8e0cc
Retrieve bleeding edge push revision from trunk commit message.
...
This is part of moving towards an lkgr-push script and prepares the deprecation of the prepare push commit.
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/169843002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19482 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-19 13:40:30 +00:00
machenbach@chromium.org
a56d0da623
Refactor persisting state in push and merge scripts.
...
- The backed state dict is now persisted and restored in the step template as a json file
- All explicit persist/restore calls are removed
- Added testing an unexpected script failure + restart with state recovery to the merge-to-branch test
- This CL is not changing external behavior of the scripts
BUG=
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/170583002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19478 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-19 11:56:48 +00:00
machenbach@chromium.org
77c278b94d
Fix merge-to-branch options.
...
BUG=
TBR=ulan@chromium.org
Review URL: https://codereview.chromium.org/170443003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19453 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-18 14:17:08 +00:00
machenbach@chromium.org
0f2c040c79
Fix merge-to-branch python port.
...
This fixes a forgotten parameter when calling the script's toplevel method and adds the same usage message as in the bash script.
BUG=
TBR=ulan@chromium.org
Review URL: https://codereview.chromium.org/164373015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19450 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-18 14:05:59 +00:00
machenbach@chromium.org
f15c700378
Fix merge-to-branch imports.
...
BUG=
TBR=ulan@chromium.org
Review URL: https://codereview.chromium.org/170513002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19448 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-18 13:51:46 +00:00
machenbach@chromium.org
6af4512ba7
Make merge-to-branch python port executable
...
BUG=
TBR=ulan@chromium.org
Review URL: https://codereview.chromium.org/170493002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19446 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-18 13:47:56 +00:00
machenbach@chromium.org
c2cd2083a3
Add merge-to-branch python port.
...
- To ease a line-by-line review, the script is intentionally close to the former bash version
- Disambiguate the existing "-r" option for reviewer in the other scripts
- The options design will be refactored in a follow up CL
TEST=python -m unittest test_scripts.ScriptTest.testMergeToBranch
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/163183004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19443 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-18 13:09:14 +00:00
machenbach@chromium.org
e81eacfa74
Enable specification of author email in push-to-trunk.
...
If not specified, depot tools tend to ask for an email on the command line once in a while, which makes the automated script hang.
BUG=
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/158733002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19223 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-02-10 12:48:36 +00:00
machenbach@chromium.org
15ecc108cb
Show v8 bleeding edge revision in trunk and Chromium commit message.
...
This allows to map from a V8 Chromium roll to the bleeding_edge revision used for the roll.
This CL also improves some test code:
- Don't loose assertion exceptions in mocked git on retry.
- Remove an unused method
BUG=337167
LOG=n
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/139993006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18778 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2014-01-23 13:44:52 +00:00