14c5b0ae67
Scopes in V8 are used to guarantee one or more properties during its lifetimes. If a scope is not named e.g MyClassScope(args) instead of MyClassScope scope(args) it will get created and automatically destroyed and therefore, being useless as a scope. This CL would produce a compiling warning when that happens to ward off this developer error. Follow-up to ccrev.com/2552415 in which it was introduced and implemented for Guard classes. Change-Id: Ifa0fb89cc3d9bdcdee0fd8150a2618af5ef45cbf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2555001 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#71425}
54 lines
1.3 KiB
C++
54 lines
1.3 KiB
C++
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_TEST_COMMON_WASM_FLAG_UTILS_H
|
|
#define V8_TEST_COMMON_WASM_FLAG_UTILS_H
|
|
|
|
#include "src/wasm/wasm-features.h"
|
|
#include "test/common/flag-utils.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
#define EXPERIMENTAL_FLAG_SCOPE(flag) FLAG_SCOPE(experimental_wasm_##flag)
|
|
|
|
namespace wasm {
|
|
|
|
class V8_NODISCARD WasmFeatureScope {
|
|
public:
|
|
explicit WasmFeatureScope(WasmFeatures* features, WasmFeature feature,
|
|
bool val = true)
|
|
: prev_(features->contains(feature)),
|
|
feature_(feature),
|
|
features_(features) {
|
|
set(val);
|
|
}
|
|
~WasmFeatureScope() { set(prev_); }
|
|
|
|
private:
|
|
void set(bool val) {
|
|
if (val) {
|
|
features_->Add(feature_);
|
|
} else {
|
|
features_->Remove(feature_);
|
|
}
|
|
}
|
|
|
|
bool const prev_;
|
|
WasmFeature const feature_;
|
|
WasmFeatures* const features_;
|
|
};
|
|
|
|
#define WASM_FEATURE_SCOPE(feat) \
|
|
WasmFeatureScope feat##_scope(&this->enabled_features_, kFeature_##feat)
|
|
|
|
#define WASM_FEATURE_SCOPE_VAL(feat, val) \
|
|
WasmFeatureScope feat##_scope(&this->enabled_features_, kFeature_##feat, val)
|
|
|
|
} // namespace wasm
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_TEST_COMMON_WASM_FLAG_UTILS_H
|