ec06bb6ce5
This is a reland of d1b27019d3
Fixes include:
Adding missing file to bazel build
Forward-declaring classing before friend-classing them to fix win/gcc
Add missing v8-isolate.h include for vtune builds
Original change's description:
> [include] Split out v8.h
>
> This moves every single class/function out of include/v8.h into a
> separate header in include/, which v8.h then includes so that
> externally nothing appears to have changed.
>
> Every include of v8.h from inside v8 has been changed to a more
> fine-grained include.
>
> Previously inline functions defined at the bottom of v8.h would call
> private non-inline functions in the V8 class. Since that class is now
> in v8-initialization.h and is rarely included (as that would create
> dependency cycles), this is not possible and so those methods have been
> moved out of the V8 class into the namespace v8::api_internal.
>
> None of the previous files in include/ now #include v8.h, which means
> if embedders were relying on this transitive dependency then it will
> give compile failures.
>
> v8-inspector.h does depend on v8-scripts.h for the time being to ensure
> that Chrome continue to compile but that change will be reverted once
> those transitive #includes in chrome are changed to include it directly.
>
> Full design:
> https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
>
> Bug: v8:11965
> Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76424}
Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
Bug: v8:11965
Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76460}
83 lines
2.8 KiB
C++
83 lines
2.8 KiB
C++
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "test/inspector/utils.h"
|
|
|
|
#include <vector>
|
|
|
|
#include "include/v8-inspector.h"
|
|
#include "include/v8-primitive.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
std::vector<uint8_t> ToBytes(v8::Isolate* isolate, v8::Local<v8::String> str) {
|
|
std::vector<uint8_t> buffer(str->Length());
|
|
str->WriteOneByte(isolate, buffer.data(), 0, str->Length());
|
|
return buffer;
|
|
}
|
|
|
|
v8::Local<v8::String> ToV8String(v8::Isolate* isolate, const char* str) {
|
|
return v8::String::NewFromUtf8(isolate, str).ToLocalChecked();
|
|
}
|
|
|
|
v8::Local<v8::String> ToV8String(v8::Isolate* isolate,
|
|
const std::vector<uint8_t>& bytes) {
|
|
return v8::String::NewFromOneByte(isolate, bytes.data(),
|
|
v8::NewStringType::kNormal,
|
|
static_cast<int>(bytes.size()))
|
|
.ToLocalChecked();
|
|
}
|
|
|
|
v8::Local<v8::String> ToV8String(v8::Isolate* isolate,
|
|
const std::string& buffer) {
|
|
int length = static_cast<int>(buffer.size());
|
|
return v8::String::NewFromUtf8(isolate, buffer.data(),
|
|
v8::NewStringType::kNormal, length)
|
|
.ToLocalChecked();
|
|
}
|
|
|
|
v8::Local<v8::String> ToV8String(v8::Isolate* isolate,
|
|
const std::vector<uint16_t>& buffer) {
|
|
int length = static_cast<int>(buffer.size());
|
|
return v8::String::NewFromTwoByte(isolate, buffer.data(),
|
|
v8::NewStringType::kNormal, length)
|
|
.ToLocalChecked();
|
|
}
|
|
|
|
v8::Local<v8::String> ToV8String(v8::Isolate* isolate,
|
|
const v8_inspector::StringView& string) {
|
|
if (string.is8Bit()) {
|
|
return v8::String::NewFromOneByte(isolate, string.characters8(),
|
|
v8::NewStringType::kNormal,
|
|
static_cast<int>(string.length()))
|
|
.ToLocalChecked();
|
|
}
|
|
return v8::String::NewFromTwoByte(isolate, string.characters16(),
|
|
v8::NewStringType::kNormal,
|
|
static_cast<int>(string.length()))
|
|
.ToLocalChecked();
|
|
}
|
|
|
|
std::vector<uint16_t> ToVector(v8::Isolate* isolate,
|
|
v8::Local<v8::String> str) {
|
|
std::vector<uint16_t> buffer(str->Length());
|
|
str->Write(isolate, buffer.data(), 0, str->Length());
|
|
return buffer;
|
|
}
|
|
|
|
std::vector<uint16_t> ToVector(const v8_inspector::StringView& string) {
|
|
std::vector<uint16_t> buffer(string.length());
|
|
for (size_t i = 0; i < string.length(); i++) {
|
|
if (string.is8Bit())
|
|
buffer[i] = string.characters8()[i];
|
|
else
|
|
buffer[i] = string.characters16()[i];
|
|
}
|
|
return buffer;
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|