21cbc91443
This makes sure that the coercion of global import values to numbers remains non-observable to JavaScript. It allows instantiation failures to fall back to JavaScript proper without accidentally causing some side-effect to happen twice. Also coercions might invalidate previous checks done during linking or throw exceptions. R=clemensh@chromium.org TEST=mjsunit/regress/regress-6431 BUG=v8:6431 Change-Id: Ibe2f7a336bc0fb25532d526746ecc802e04bbd5c Reviewed-on: https://chromium-review.googlesource.com/512544 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46051}
81 lines
3.1 KiB
JavaScript
81 lines
3.1 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --validate-asm
|
|
|
|
function MODULE_TEMPLATE(stdlib, foreign, buffer) {
|
|
"use asm";
|
|
var fround = stdlib.Math.fround;
|
|
IMPORT;
|
|
function f(int, flt, dbl) {
|
|
int = int | 0;
|
|
flt = fround(flt);
|
|
dbl = +dbl;
|
|
return EXPRESSION;
|
|
}
|
|
return { f:f };
|
|
}
|
|
|
|
var throws = {};
|
|
var test_count = 0;
|
|
const stdlib = this;
|
|
const buffer = new ArrayBuffer(1024);
|
|
function p(x) { return x * x; }
|
|
|
|
function assertThrowsOrEquals(result, fun) {
|
|
if (result === throws) {
|
|
assertThrows(fun, TypeError);
|
|
} else {
|
|
assertEquals(result, fun(1, 2.3, 4.2));
|
|
}
|
|
}
|
|
|
|
function RunAsmJsTest(asm_source, imports, result, valid) {
|
|
var nonasm_source = asm_source.replace(new RegExp("use asm"), "");
|
|
|
|
var js_module = eval("(" + nonasm_source + ")")
|
|
var js_instance = js_module(stdlib, imports, buffer);
|
|
assertThrowsOrEquals(result, js_instance.f);
|
|
|
|
var asm_module = eval("(" + asm_source + ")");
|
|
var asm_instance = asm_module(stdlib, imports, buffer);
|
|
assertEquals(valid, %IsAsmWasmCode(asm_module));
|
|
assertThrowsOrEquals(result, asm_instance.f);
|
|
}
|
|
|
|
function Run(imp, exp, imports, result, valid) {
|
|
var name = "test" + (++test_count);
|
|
var src = MODULE_TEMPLATE.toString();
|
|
src = src.replace("IMPORT", imp);
|
|
src = src.replace("EXPRESSION", exp);
|
|
src = src.replace("MODULE_TEMPLATE", name);
|
|
RunAsmJsTest(src, imports, result, valid);
|
|
}
|
|
|
|
// Imports of values from foreign.
|
|
Run("var x = foreign.x | 0", "(x + int) | 0", {x:12}, 13, true);
|
|
Run("var x = foreign.x | 0", "(x = int) | 0", {x:12}, 1, true);
|
|
Run("var x = foreign.x | 0", "+(x + dbl)", {x:12}, 16.2, false);
|
|
Run("var x = +foreign.x", "+(x + dbl)", {x:1.2}, 5.4, true);
|
|
Run("var x = +foreign.x", "+(x = dbl)", {x:1.2}, 4.2, true);
|
|
Run("var x = +foreign.x", "(x + int) | 0", {x:1.2}, 2, false);
|
|
Run("const x = foreign.x | 0", "(x + int) | 0", {x:12}, 13, true);
|
|
Run("const x = foreign.x | 0", "(x = int) | 0", {x:12}, throws, false);
|
|
Run("const x = foreign.x | 0", "+(x + dbl)", {x:12}, 16.2, false);
|
|
Run("const x = +foreign.x", "+(x + dbl)", {x:1.2}, 5.4, true);
|
|
Run("const x = +foreign.x", "+(x = dbl)", {x:1.2}, throws, false);
|
|
Run("const x = +foreign.x", "(x + int) | 0", {x:1.2}, 2, false);
|
|
|
|
// Imports of functions and values from stdlib and foreign.
|
|
Run("var x = foreign.x", "x(dbl) | 0", { x:p }, 17, true);
|
|
Run("var x = foreign.x", "(x = fround, x(dbl)) | 0", { x:p }, 4, false);
|
|
Run("var x = stdlib.Math.E", "(x = 3.1415, 1) | 0", {}, 1, false);
|
|
Run("var x = stdlib.Math.imul", "(x = fround, 1) | 0", {}, 1, false);
|
|
|
|
// Imports missing or causing side-effects during lookup.
|
|
Run("var x = +foreign.x", "+x", { no_x_present:0 }, NaN, true);
|
|
Run("var x = +foreign.x", "+x", { get x() { return 23 } }, 23, false);
|
|
Run("var x = +foreign.x", "+x", new Proxy({ x:42 }, {}), 42, false);
|
|
Run("var x = +foreign.x", "+x", { x : { valueOf : () => 65 } }, 65, false);
|