63f9ee1645
This fixes the signature of "Math.min" and "Math.max" for integer values from "(int, int...) -> signed" to "(signed, signed..) -> signed" which properly distinguishes signed from unsigned values now. This is in sync with the spec errata (and ECMAScript semantics). R=clemensh@chromium.org TEST=mjsunit/regress/regress-6838-1 BUG=v8:6838 Change-Id: Id72836513dd86e93472a22cf1ac2e2d382ed4f23 Reviewed-on: https://chromium-review.googlesource.com/681357 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48139}
79 lines
2.2 KiB
JavaScript
79 lines
2.2 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
function Module(stdlib) {
|
|
"use asm";
|
|
|
|
var max = stdlib.Math.max;
|
|
var fround = stdlib.Math.fround;
|
|
|
|
// f: double, double -> double
|
|
function f(a, b) {
|
|
a = +a; b = +b;
|
|
return +max(a, b);
|
|
}
|
|
|
|
// g: signed, signed -> signed
|
|
function g(a, b) {
|
|
a = a | 0; b = b | 0;
|
|
return max(a >> 0, b >> 0) | 0;
|
|
}
|
|
|
|
// h: float, float -> float
|
|
function h(a, b) {
|
|
a = fround(a); b = fround(b);
|
|
return fround(max(a, b));
|
|
}
|
|
|
|
return { f: f, g: g, h: h };
|
|
}
|
|
|
|
var m = Module({ Math: Math });
|
|
var f = m.f;
|
|
var g = m.g;
|
|
var h = m.h;
|
|
|
|
assertTrue(isNaN(f(0, NaN)));
|
|
assertFalse(isFinite(f(0, Infinity)));
|
|
assertTrue(isFinite(f(0, -Infinity)));
|
|
|
|
assertTrue(Object.is(+0, f(-0, +0)));
|
|
assertTrue(Object.is(+0, f(+0, -0)));
|
|
|
|
assertEquals(0.1, f( 0, 0.1));
|
|
assertEquals(0.5, f( 0.1, 0.5));
|
|
assertEquals(0.5, f( 0.5, -0.1));
|
|
assertEquals(-0.1, f(-0.1, -0.5));
|
|
assertEquals(1, f(-0.5, 1));
|
|
assertEquals(1.1, f( 1, 1.1));
|
|
assertEquals(1.1, f( 1.1, -1));
|
|
assertEquals(-1, f(-1, -1.1));
|
|
assertEquals(0, f(-1.1, 0));
|
|
|
|
assertEquals( 1, g( 0, 1));
|
|
assertEquals( 5, g( 1, 5));
|
|
assertEquals( 5, g( 5, -1));
|
|
assertEquals(-1, g(-1, -5));
|
|
assertEquals( 1, g(-5, 1));
|
|
assertEquals( 1, g( 1, -1));
|
|
assertEquals( 0, g(-1, 0));
|
|
|
|
assertEquals(Math.fround(0.1), h( 0, 0.1));
|
|
assertEquals(Math.fround(0.5), h( 0.1, 0.5));
|
|
assertEquals(Math.fround(0.5), h( 0.5, -0.1));
|
|
assertEquals(Math.fround(-0.1), h(-0.1, -0.5));
|
|
assertEquals(Math.fround(1), h(-0.5, 1));
|
|
assertEquals(Math.fround(1.1), h( 1, 1.1));
|
|
assertEquals(Math.fround(1.1), h( 1.1, -1));
|
|
assertEquals(Math.fround(-1), h(-1, -1.1));
|
|
assertEquals(Math.fround(0), h(-1.1, 0));
|
|
|
|
assertEquals(1, g(0, Number.MIN_SAFE_INTEGER));
|
|
assertEquals(0, g(0, Number.MAX_SAFE_INTEGER));
|
|
|
|
assertEquals(Number.MAX_VALUE, f(Number.MIN_VALUE, Number.MAX_VALUE));
|
|
assertEquals(Number.MAX_VALUE, f(Number.MAX_VALUE, Number.MIN_VALUE));
|
|
assertEquals(Number.POSITIVE_INFINITY, f(Number.POSITIVE_INFINITY, 0));
|
|
assertEquals(0, f(Number.NEGATIVE_INFINITY, 0));
|