b53f4d8247
This CL avoids unnecessary heap allocation for BigInt64 array store/load by - setting the output representation of a load to word64, and - propagating word64 truncation to the source of a store. This CL introduces a simplified operator SpeculativeToBigInt which is applied to the source of a store to a BigInt64 array to deopt on a non-bigint input. Bug: v8:9407 Change-Id: I48ce13761bc4cf742d5b18cec4476dc9ad131414 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4101011 Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Qifan Pan <panq@google.com> Cr-Commit-Position: refs/heads/main@{#84908}
72 lines
2.4 KiB
JavaScript
72 lines
2.4 KiB
JavaScript
// Copyright 2022 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --turbofan --no-always-turbofan
|
|
|
|
const bi = 18446744073709551615n; // 2n ** 64n - 1n
|
|
|
|
function storeAndLoad(x) {
|
|
let buffer = new ArrayBuffer(16);
|
|
let biArray = new BigInt64Array(buffer);
|
|
biArray[0] = bi;
|
|
biArray[1] = x;
|
|
return biArray[0] + biArray[1];
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(storeAndLoad);
|
|
assertEquals(-1n, storeAndLoad(0n));
|
|
assertEquals(41n, storeAndLoad(2n ** 64n + 42n));
|
|
assertEquals(0n, storeAndLoad(-bi));
|
|
assertEquals(-2n, storeAndLoad(bi));
|
|
%OptimizeFunctionOnNextCall(storeAndLoad);
|
|
assertEquals(-1n, storeAndLoad(0n));
|
|
assertEquals(41n, storeAndLoad(2n ** 64n + 42n));
|
|
assertEquals(0n, storeAndLoad(-bi));
|
|
assertEquals(-2n, storeAndLoad(bi));
|
|
assertOptimized(storeAndLoad);
|
|
|
|
assertEquals(-1n, storeAndLoad(false));
|
|
if (%Is64Bit()) {
|
|
assertUnoptimized(storeAndLoad);
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(storeAndLoad);
|
|
assertEquals(-1n, storeAndLoad(0n));
|
|
%OptimizeFunctionOnNextCall(storeAndLoad);
|
|
assertEquals(0n, storeAndLoad(true));
|
|
// TODO(panq): Uncomment the assertion once the deopt loop is eliminated.
|
|
// assertOptimized(storeAndLoad);
|
|
|
|
function storeAndLoadUnsigned(x) {
|
|
let buffer = new ArrayBuffer(16);
|
|
let biArray = new BigUint64Array(buffer);
|
|
biArray[0] = bi;
|
|
biArray[1] = x;
|
|
return biArray[0] + biArray[1];
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(storeAndLoadUnsigned);
|
|
assertEquals(bi, storeAndLoadUnsigned(0n));
|
|
assertEquals(bi + 42n, storeAndLoadUnsigned(2n ** 64n + 42n));
|
|
assertEquals(bi + 1n, storeAndLoadUnsigned(-bi));
|
|
assertEquals(bi * 2n, storeAndLoadUnsigned(bi));
|
|
%OptimizeFunctionOnNextCall(storeAndLoadUnsigned);
|
|
assertEquals(bi, storeAndLoadUnsigned(0n));
|
|
assertEquals(bi + 42n, storeAndLoadUnsigned(2n ** 64n + 42n));
|
|
assertEquals(bi + 1n, storeAndLoadUnsigned(-bi));
|
|
assertEquals(bi * 2n, storeAndLoadUnsigned(bi));
|
|
assertOptimized(storeAndLoadUnsigned);
|
|
|
|
assertEquals(bi, storeAndLoadUnsigned(false));
|
|
if (%Is64Bit()) {
|
|
assertUnoptimized(storeAndLoadUnsigned);
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(storeAndLoadUnsigned);
|
|
assertEquals(bi, storeAndLoadUnsigned(0n));
|
|
%OptimizeFunctionOnNextCall(storeAndLoadUnsigned);
|
|
assertEquals(bi + 1n, storeAndLoadUnsigned(true));
|
|
// TODO(panq): Uncomment the assertion once the deopt loop is eliminated.
|
|
// assertOptimized(storeAndLoadUnsigned);
|