c0fd89c3c0
This is a reland of819c3ae2f8Original change's description: > Reland "Reland "Improve error messages for property access on null/undefined"" > > This is a reland of8b18c5e6a5> > Original change's description: > > Reland "Improve error messages for property access on null/undefined" > > > > This is a reland of24c626c1f7> > > > Original change's description: > > > Improve error messages for property access on null/undefined > > > > > > Only print the property name when accessing null/undefined if we can > > > convert it to a string without causing side effects. > > > If we can't, omit the property name in the error message. > > > This should avoid confusion when the key is an object with toString(). > > > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object > > > Object]' anymore, which was misleading since the property accessed would > > > be 'a', but we can't evaluate the key without side effects. > > > > > > Bug: v8:11365 > > > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211 > > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#75250} > > > > Bug: v8:11365 > > Change-Id: Ie2312337f4f1915faa31528a728d90833d80dbd1 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979599 > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#75571} > > Bug: v8:11365 > Change-Id: I90360641ecd870bd93247aa6d91dfb0ad049cfb8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008219 > Auto-Submit: Patrick Thier <pthier@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75604} Bug: v8:11365 Change-Id: I002b537144f328ccbbdcd655e26e5dc87c49c6f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3013935 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#75645}
133 lines
8.1 KiB
Plaintext
133 lines
8.1 KiB
Plaintext
# Copyright 2013 the V8 project authors. All rights reserved.
|
|
# Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions
|
|
# are met:
|
|
# 1. Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# 2. Redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in the
|
|
# documentation and/or other materials provided with the distribution.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
|
|
# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
|
|
# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
|
|
# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
|
|
# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
|
|
# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
|
|
# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
|
|
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
Tests that the peephole CompareEq optimization for the case where one side is predicted final object and the other side is predicted either final object or other (i.e. null or undefined) doesn't assert when both sides are also proven final object.
|
|
|
|
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
|
|
|
|
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS foo({f:42}, null) threw exception TypeError: Cannot read properties of null (reading 'f').
|
|
PASS foo(o, o) is [42, 42, true]
|
|
PASS successfullyParsed is true
|
|
|
|
TEST COMPLETE
|
|
|