81aa89592b
Known-pointer decompression used to be distinct from any-tagged-value decompression, since the latter used to detect Smis and decompress them with sign extension. However, we got rid of this distinction when we introduced Smi-corrupting loads (allowing the top 32-bits of uncompressed Smis to be undefined), which means that the TaggedPointer and TaggedAny decompression is now identical. We can remove a bunch of duplicate code by removing this distinction. Change-Id: Id66671497d63ed885f9e537494c011317dfd4788 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4221398 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#85647}
71 lines
2.2 KiB
C++
71 lines
2.2 KiB
C++
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Don't bother initializing global cage base value, compute it from any
|
|
// on heap address instead.
|
|
#define V8_COMPRESS_POINTERS_DONT_USE_GLOBAL_BASE
|
|
#include "debug-helper-internal.h"
|
|
#include "src/common/ptr-compr-inl.h"
|
|
#include "torque-generated/class-debug-readers.h"
|
|
|
|
namespace i = v8::internal;
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace debug_helper_internal {
|
|
|
|
bool IsPointerCompressed(uintptr_t address) {
|
|
#if COMPRESS_POINTERS_BOOL
|
|
return address < i::kPtrComprCageReservationSize;
|
|
#else
|
|
return false;
|
|
#endif
|
|
}
|
|
|
|
uintptr_t EnsureDecompressed(uintptr_t address,
|
|
uintptr_t any_uncompressed_ptr) {
|
|
if (!COMPRESS_POINTERS_BOOL || !IsPointerCompressed(address)) return address;
|
|
// TODO(v8:11880): ExternalCodeCompressionScheme might be needed here for
|
|
// decompressing Code pointers from external code space.
|
|
return i::V8HeapCompressionScheme::DecompressTagged(
|
|
any_uncompressed_ptr, static_cast<i::Tagged_t>(address));
|
|
}
|
|
|
|
d::PropertyKind GetArrayKind(d::MemoryAccessResult mem_result) {
|
|
d::PropertyKind indexed_field_kind{};
|
|
switch (mem_result) {
|
|
case d::MemoryAccessResult::kOk:
|
|
indexed_field_kind = d::PropertyKind::kArrayOfKnownSize;
|
|
break;
|
|
case d::MemoryAccessResult::kAddressNotValid:
|
|
indexed_field_kind =
|
|
d::PropertyKind::kArrayOfUnknownSizeDueToInvalidMemory;
|
|
break;
|
|
default:
|
|
indexed_field_kind =
|
|
d::PropertyKind::kArrayOfUnknownSizeDueToValidButInaccessibleMemory;
|
|
break;
|
|
}
|
|
return indexed_field_kind;
|
|
}
|
|
|
|
std::vector<std::unique_ptr<ObjectProperty>> TqObject::GetProperties(
|
|
d::MemoryAccessor accessor) const {
|
|
return std::vector<std::unique_ptr<ObjectProperty>>();
|
|
}
|
|
|
|
const char* TqObject::GetName() const { return "v8::internal::Object"; }
|
|
|
|
void TqObject::Visit(TqObjectVisitor* visitor) const {
|
|
visitor->VisitObject(this);
|
|
}
|
|
|
|
bool TqObject::IsSuperclassOf(const TqObject* other) const {
|
|
return GetName() != other->GetName();
|
|
}
|
|
|
|
} // namespace debug_helper_internal
|
|
} // namespace internal
|
|
} // namespace v8
|