2b133ebc9e
This prepares work for speeding up gcmole infrastructure by adding more checks and testing. - Add a presubmit check that verifies gcmole directives in gn files. - Simplify gcmole directives in gn files. Drop all but the architecture property as the others were unused. Simplify regular expressions. - Fix some gcmole directives (fly by - only on untested architectures). - Add a python test for the changed function in gcmole.py. There's no other testing yet and this starts somewhere. The test simulates real BUILD.gn files via checked-in test data. Bug: v8:12660 Change-Id: I9ca3152b2c3b806de5d4509c152283b36294950d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4020268 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Alexander Schulze <alexschulze@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#84239}
33 lines
832 B
Python
33 lines
832 B
Python
# Copyright 2022 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
USE_PYTHON3 = True
|
|
|
|
|
|
def _RunTests(input_api, output_api):
|
|
return input_api.RunTests(
|
|
input_api.canned_checks.GetUnitTestsInDirectory(
|
|
input_api,
|
|
output_api,
|
|
'.',
|
|
files_to_check=[r'.+_test\.py$'],
|
|
run_on_python2=False))
|
|
|
|
|
|
def _CommonChecks(input_api, output_api):
|
|
"""Checks common to both upload and commit."""
|
|
checks = [
|
|
_RunTests,
|
|
]
|
|
|
|
return sum([check(input_api, output_api) for check in checks], [])
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
return _CommonChecks(input_api, output_api)
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
return _CommonChecks(input_api, output_api)
|