2a20b228ef
This does: - Move gcmole runs to bots with matching arch. - Update mb_configs to enable gcmole on the bots that run it. - Add a GN target that extracts some compiler flags from a ninja file of one of V8's other targets. - Use the extracted flags in the gcmole script and remove other hard-coded arch-specific flags. This is done for DEFINES and includes for now. Other compiler flags are still a TODO. Bug: v8:9287 Change-Id: Icba9ce59e0bfffd138d9207b1c2ad64d42bf6a91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4055629 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Alexander Schulze <alexschulze@chromium.org> Cr-Commit-Position: refs/heads/main@{#85341}
60 lines
1.6 KiB
Python
60 lines
1.6 KiB
Python
# Copyright 2023 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
"""Calculate arguments for the gcmole plugin based on flags passed to the
|
|
compiler for a typical target in V8.
|
|
"""
|
|
|
|
from pathlib import Path
|
|
|
|
import os
|
|
import re
|
|
import sys
|
|
|
|
DEFINES_RE = re.compile(r'^defines = (.*)$', re.M)
|
|
INCLUDES_RE = re.compile(r'^include_dirs = (.*)$', re.M)
|
|
|
|
BASE_DIR = Path(__file__).resolve().parents[2].absolute()
|
|
|
|
# This script is always called relative to the build directory root
|
|
# by ninja.
|
|
BUILD_DIR_ABS = Path.cwd()
|
|
BUILD_DIR_REL = BUILD_DIR_ABS.relative_to(BASE_DIR)
|
|
|
|
|
|
def search_flags(regexp, ninja_config):
|
|
match = regexp.search(ninja_config)
|
|
assert match
|
|
result = match.group(1)
|
|
assert result
|
|
return result
|
|
|
|
|
|
def main():
|
|
assert BUILD_DIR_ABS.exists()
|
|
|
|
ninja_file = BUILD_DIR_ABS / 'obj' / 'v8_base_without_compiler.ninja'
|
|
assert ninja_file.exists()
|
|
|
|
with ninja_file.open() as f:
|
|
ninja_config = f.read()
|
|
|
|
defines = search_flags(DEFINES_RE, ninja_config)
|
|
includes = search_flags(INCLUDES_RE, ninja_config)
|
|
|
|
# Include flags are relative to the build root. Make them relative to the
|
|
# base directory for gcmole.
|
|
# E.g. BUILD_DIR_REL = out/build and -I../../include gives -Iinclude.
|
|
include_flags = []
|
|
for flag in includes.strip().split():
|
|
prefix, suffix = flag[:2], flag[2:]
|
|
assert prefix == '-I'
|
|
include_flags.append(prefix + os.path.normpath(BUILD_DIR_REL / suffix))
|
|
|
|
with open('v8_gcmole.args', 'w') as f:
|
|
f.write(' '.join([defines] + include_flags))
|
|
|
|
|
|
if __name__ == '__main__':
|
|
main()
|