3ea1ad234c
This CL implements TypedArray.p.sort in Torque. The Torque version works basically the same as the existing JS builtin: When no comparison function is provided, the C++ fast path builtin is used. Otherwise a quicksort written in Torque is used, with a InsertionSort fallback for smaller arrays. The JS quicksort implementation also containes a more elaborate third pivot calculation for larger arrays. This is currently not done. Reported benchmark results are only for those, where a custom comparison function is provided. The numbers for the C++ path stayed the same. Benchmark Current (JS) Torque Speedup IntTypes 83.9 263.7 3.1 BigIntTypes 32.1 54.6 1.7 FloatTypes 99.3 138.7 1.4 R=danno@chromium.org, jgruber@chromium.org Bug: v8:7382 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I7abe7ceff525bab24f302d2f06b5961cca770d24 Reviewed-on: https://chromium-review.googlesource.com/1021691 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by: Daniel Clifford <danno@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52776} |
||
---|---|---|
.. | ||
bootstrap.sh | ||
BUILD.gn | ||
gccause.lua | ||
gcmole-tools.tar.gz.sha1 | ||
gcmole.cc | ||
gcmole.lua | ||
Makefile | ||
parallel.py | ||
README | ||
run-gcmole.py |
DESCRIPTION ------------------------------------------------------------------- gcmole is a simple static analysis tool used to find possible evaluation order dependent GC-unsafe places in the V8 codebase. For example the following code is GC-unsafe: Handle<Object> Foo(); // Assume Foo can trigger a GC. void Bar(Object*, Object*); Handle<Object> baz; baz->Qux(*Foo()); // (a) Bar(*Foo(), *baz); // (b) Both in cases (a) and (b) compiler is free to evaluate call arguments (that includes receiver) in any order. That means it can dereference baz before calling to Foo and save a raw pointer to a heap object in the register or on the stack. PREREQUISITES ----------------------------------------------------------------- 1) Install Lua 5.1 2) Get LLVM 2.9 and Clang 2.9 sources and build them. Follow the instructions on http://clang.llvm.org/get_started.html. Make sure to pass --enable-optimized to configure to get Release build instead of a Debug one. 3) Build gcmole Clang plugin (libgcmole.so) In the tools/gcmole execute the following command: LLVM_SRC_ROOT=<path-to-llvm-source-root> make USING GCMOLE ------------------------------------------------------------------ gcmole consists of driver script written in Lua and Clang plugin that does C++ AST processing. Plugin (libgcmole.so) is expected to be in the same folder as driver (gcmole.lua). To start analysis cd into the root of v8 checkout and execute the following command: CLANG_BIN=<path-to-clang-bin-folder> lua tools/gcmole/gcmole.lua [<arch>] where arch should be one of architectures supported by V8 (arm, ia32, x64). Analysis will be performed in 2 stages: - on the first stage driver will parse all files and build a global callgraph approximation to find all functions that might potentially cause GC, list of this functions will be written into gcsuspects file. - on the second stage driver will parse all files again and will locate all callsites that might be GC-unsafe based on the list of functions causing GC. Such places are marked with a "Possible problem with evaluation order." warning. Messages "Failed to resolve v8::internal::Object" are benign and can be ignored. If any errors were found driver exits with non-zero status.